- 21 Feb, 2019 40 commits
-
-
Eric Stevenson authored
These were pulled in because trichrome uses monochrome templates. Since Trichrome still shares the same native library logic with monochrome it makes sense to continue using monochrome templates, but using a variable |is_trichrome| to differentiate trichrome from monochrome. This CL removes Java deps, some Java resource deps, and webview's locale pak files from TrichromeChrome.apk. Validated CL changes by: * Building the 3 trichrome apks and their downstream variants * Installing/launching TrichromeChrome.apk * Manually inspecting the .build_config and "unzip -l" changes | old (c)| new (c)| diff (c)| total| 24.8 MiB| 23.6 MiB| -1.2 MiB| dex| 6.8 MiB| 6.4 MiB| -392.1 KiB| arsc| 4.9 MiB| 4.8 MiB| -101.8 KiB| xml| 344.9 KiB| 344.9 KiB| -6 B| res| 912.3 KiB| 908.2 KiB| -4.1 KiB| native| 254.6 KiB| 254.6 KiB| +0 B| asset| 11.1 MiB| 10.4 MiB| -698.0 KiB| misc| 145.3 KiB| 142.4 KiB| -2.9 KiB| Bug: 932253 Change-Id: Iedb427aa5ec05ad3bc905ac61b23f615349d579e Reviewed-on: https://chromium-review.googlesource.com/c/1481019 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#634385}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 514c84e0. With Chromium commits locally applied on WPT: 14c11107 "Implement `Sec-CH-Lang`" df760ab0 "Don't skip past auto-height flexboxes in quirks mode." cd40220a "Fix as=fetch preload where preload is used before response arrives" 1d89521e "[LayoutNG] Force relayout when constraint spaces change." c326c82a "Surface dtlsTransport via state-surfacer" 98e7141b "Fix 2_tracks, 3_tracks wpt/webvtt tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I462cc03771c9186999d480e8e4e98d4acff89631 Reviewed-on: https://chromium-review.googlesource.com/c/1481586Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634384}
-
Daniel Bratell authored
In some build experiments, the compiler emitted an object assignment of StdStringCanonOutput which did not link because the operator= was not exported from the url.dll in component builds. This makes the class explicitly not copyable and removes the copy to avoid that kind of (hard to debug) problems. Change-Id: I92988b5799e4229d1fb0379f9897727c1bac20de Reviewed-on: https://chromium-review.googlesource.com/c/1477602Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#634383}
-
Henrique Ferreiro authored
Replace uses of ScrollSnapAlign from third_party/blink/renderer/platform/scroll_snap_data.h with the unwrapped type from cc/input/scroll_snap_data.h. This is part of a series of CLs to remove platform/scroll. Bug: 922111 Change-Id: If90f64169884a54f6ee29545a157a03e23db8900 Reviewed-on: https://chromium-review.googlesource.com/c/1480514 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#634382}
-
Ayman Almadhoun authored
This change introduces the skeleton for the BottomTabGrid compoenent, exposing the functionality through BottomTabGridCoordinator. As of now, there are no consumers of this component. BUG=930895 Change-Id: I2ccdff5bb905ae53169114a8dff074727dd348ad Reviewed-on: https://chromium-review.googlesource.com/c/1478185 Auto-Submit: Ayman Almadhoun <ayman@chromium.org> Commit-Queue: Ayman Almadhoun <ayman@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#634381}
-
Becca Hughes authored
Enable ducking for flash based videos. BUG=931892 Change-Id: I68ee115d6a5938a86ca624b2cfa5295b9d95e43b Reviewed-on: https://chromium-review.googlesource.com/c/1481588Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#634380}
-
Giovanni Ortuño Urquidi authored
Refactors testing APIs so that tests can control when the setAdapterState callback is called and when the adapter changed event is fired. Changes current test to make sure the toggle is disabled when the adapter is changing states and adds a new test to make sure the toggle changes states when the adapter changes states on its own. Bug: 908288 Change-Id: I17e6f3d36e00746f03fdb537683597ca0d1048f5 Reviewed-on: https://chromium-review.googlesource.com/c/1475681Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#634379}
-
Dale Curtis authored
Looks like the old one was replaced with a new Blink.* one but the histogram suffixes weren't updated, so you can't view these on the dashboard. Noticed this while looking at binary size changes for Android. BUG=none TEST=none Change-Id: I26f59313f93434b0aaf374f4472d073fabd184de Reviewed-on: https://chromium-review.googlesource.com/c/1481735 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#634378}
-
Eric Orth authored
Updated the resolve implementation in mojo_host_resolver_impl.cc to use the newer HostResolver::CreateRequest() API. Updated the mojo API to no longer use a serialized version of the deprecated RequestInfo struct. As this mojo API is only used by one special-purpose caller (HostResolverMojo), reduced parameters down to just those parameters (hostname and an operation enum) used by that one caller. Also reduced the output of the mojo API down to just an array of IPAddress as that is all that is used by the one caller. Bug: 922699 Change-Id: Idec52470363981a34c8741a2012cb6eab218ffdb Reviewed-on: https://chromium-review.googlesource.com/c/1446780 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Auto-Submit: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#634377}
-
Jinsuk Kim authored
TabParentIntent encapsulates an Intent object with its triggering logic for bring up the activity a tab was opened from. Bug: 925242 Change-Id: Ib33e9f77744696b9026408c388e6e38b1345029b Reviewed-on: https://chromium-review.googlesource.com/c/1472270 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#634376}
-
Sylvain Defresne authored
Update the implementation of IOSPaymentInstrumentFinder to use JSONReader::Read instead of JSONReader::ReadDeprecated. Bug: 925165 Change-Id: I2b9a55055175574027088f45aba9ff1f9ef2cae5 Reviewed-on: https://chromium-review.googlesource.com/c/1477681Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#634375}
-
Henrique Ferreiro authored
Replace uses of ScrollSnapType from third_party/blink/renderer/platform/scroll_snap_data.h with the unwrapped type from cc/input/scroll_snap_data.h. This is part of a series of CLs to remove platform/scroll. Bug: 922111 Change-Id: Ib6dba63c8fbcf3f2d3c75d5543997b30eb9301d5 Reviewed-on: https://chromium-review.googlesource.com/c/1481330 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
-
Saman Sami authored
Instead of requiring both parent and child sequence numbers of the activated surface to be larger in order to drop the dependency, only require that one is larger. Bug: 934305 Change-Id: I00866d3da44a5ca73777f51f2cd79c6037d6acd9 Reviewed-on: https://chromium-review.googlesource.com/c/1481066Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#634373}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fee9be7a..43b5c7b0 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If7d32caf0f1c654ecbe05d871ff0a55c4303c86f Reviewed-on: https://chromium-review.googlesource.com/c/1481743Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634372}
-
Becca Hughes authored
If a force duck session abandons audio focus then we should stop ducking it. It should not have the custom behaviour. BUG=931892 Change-Id: Ib6f1198e05179b5bede8cf23414729be0e4b286b Reviewed-on: https://chromium-review.googlesource.com/c/1481587Reviewed-by:
-
John Chen authored
To help testing projects like WPT, archive ChromeDriver binary to https://commondatastorage.googleapis.com/chromium-browser-snapshots/index.html Bug: chromedriver:2656 Change-Id: I4dcb9810e18ccd9bbd2ff120c36f76db411f2177 Reviewed-on: https://chromium-review.googlesource.com/c/1481720 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#634370}
-
Kristi Park authored
This reverts commit 4eb465c4. Reason for revert: Probably source of browser_test failures, https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29%2832%29/56684 Original change's description: > Measure main frame bytes and main frame ad bytes per-page > > Measure the amount of bytes directly loaded in the main frame by the > page. Record separately the total number of ad bytes loaded in the main > frame. Main frame ad bytes per page are currently recorded in > PageLoad.Clients.Ads.Resource.Bytes.TopLevelAds, but this only accounts > for network bytes. > > Rather than adding more counters to AdsPLMO, main frame data will > be stored in a separate FrameData object to reduce repetition. It > makes sense at this point to also refactor all page bytes counts to > a frame data object. This will help compartmentalize the two classes. > This change should be a no-op to existing metrics. > > Bug: 919122 > Change-Id: I83839cea1d01e375bb8d2a088be69d0911119966 > Reviewed-on: https://chromium-review.googlesource.com/c/1478091 > Commit-Queue: John Delaney <johnidel@chromium.org> > Reviewed-by: Charlie Harrison <csharrison@chromium.org> > Cr-Commit-Position: refs/heads/master@{#634320} TBR=csharrison@chromium.org,johnidel@chromium.org Change-Id: Ib058a9389771e2723827073d0d81d84ab04f029e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 919122,934461 Reviewed-on: https://chromium-review.googlesource.com/c/1481902Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#634369}
-
Jazz Xu authored
Bug: 909963 Change-Id: I5c443e1cd33d9ff88136904de9695b3aa12a58f6 Reviewed-on: https://chromium-review.googlesource.com/c/1481620Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#634368}
-
Raul Tambre authored
Bug: 879657 Change-Id: Iefd2f8c923d08b6d0a25ba4aa4fad3f2716ea574 Reviewed-on: https://chromium-review.googlesource.com/c/1481323Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Raul Tambre <raul@tambre.ee> Cr-Commit-Position: refs/heads/master@{#634367}
-
Alex Ilin authored
AutocompleteActionPredictor database can grow infinitely during a single browsing session. The memlog bot reports that the database can reach up to 20M in size. This CL limits the maximum number of rows that the database can contain. Whenever a newly added element makes the database exceed this limit, one element with the lowest confidence score is removed. Extra rows are also removed when the database is read from a disk. Bug: 854665 Change-Id: Ic6faf8c135c83c0a873b4eef1760c035c385594e Reviewed-on: https://chromium-review.googlesource.com/c/1480461 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#634366}
-
Justin Cohen authored
Bug: 934294 Change-Id: I34eac982df5e4ce23a7e748debe9b118cd88afb4 Reviewed-on: https://chromium-review.googlesource.com/c/1481491 Commit-Queue: Justin Cohen <justincohen@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#634365}
-
Henrique Ferreiro authored
Replace uses of SnapSelectionStragegy from third_party/blink/renderer/platform/scroll_snap_data.h with the unwrapped type from cc/input/scroll_snap_data.h. This is part of a series of CLs to remove platform/scroll. Bug: 922111 Change-Id: Icb63605c2f4aeabf486b7080220b45afc23faa30 Reviewed-on: https://chromium-review.googlesource.com/c/1479967Reviewed-by:
-
Eric Roman authored
Bug: 932907 Change-Id: I452a014dad0fdc002d4cd96c8f21f7c2ce11a553 Reviewed-on: https://chromium-review.googlesource.com/c/1480551 Auto-Submit: Eric Roman <eroman@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/0eee33250ebb..3fc635ac4a7f git log 0eee33250ebb..3fc635ac4a7f --date=short --no-merges --format='%ad %ae %s' 2019-02-21 bclayton@google.com GLES: Fix race in Renderer destruction Created with: gclient setdep -r src/third_party/swiftshader@3fc635ac4a7f The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/124288179 TBR=swiftshader-team+autoroll@chromium.org Change-Id: I6f217308e01522f9e5582b72d8231e485b8681cc Reviewed-on: https://chromium-review.googlesource.com/c/1480988Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634362}
-
Ryan Sturm authored
Optimization guide is used for all profiles on chromeOS, so browser tests should check the per-profile state rather than a histogram that spans multiple profiles. Bug: 932913 Change-Id: I2a8aa5e3c70ad59b8924f83173454fccc6bc27fa Reviewed-on: https://chromium-review.googlesource.com/c/1477879 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#634361}
-
Fredrik Söderquist authored
f6e075c5 removed the only real usage of this flag. Remove the flag and clean up. Also avoids setting SetCompositingReasonsChanged when the flag changes. Bug: 812166 Change-Id: Id4d204db83117feafeb92baa765988952cdb7af3 Reviewed-on: https://chromium-review.googlesource.com/c/1480004 Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#634360}
-
Ian Prest authored
1. Added `BrowserAccessibilityManagerWin::FireUiaAccessibilityEvent`. -- New function, modelled on `FireWinAccessibilityEvent`. -- Both functions now examine the experimental UIA flag. 2. Fire the `UIA_AutomationFocusChangedEventId` event when appropriate. 3. Refactored the test "pass" logic in `DumpAccessibilityTestBase` to run a test pass for each tree-formatter factory method that is returned by `AccessibilityEventRecorder::GetTestPasses`. -- This allows each platform to run a different set of test passes. 4. Added a third pass for tests on Windows to test UIA. -- They look for files with the "-expected-win-uia.txt" suffix. -- This allows us to provide expected results for UIA events separately from MSAA events. 5. All existing Windows/MSAA tests that had `EVENT_OBJECT_FOCUS` events were enabled for the new UIA pass. -- We'll enable the remaining tests as more UIA events are added. 6. Since you can't simultaneously listen to both MSAA and UIA events, a new event-recorder `AccessibilityEventRecorderUia` was needed to record UIA events. -- Heavily based on existing class `AccessibilityEventRecorderWin`. Bug: 928949 Change-Id: Ic4fde227c8f5674a915c0d30eb05151f3250a704 Reviewed-on: https://chromium-review.googlesource.com/c/1474976 Commit-Queue: Ian Prest <iapres@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#634359}
-
Daniel Murphy authored
This allows scopes to be used in the DeleteDatabase call, and cleans up some code in the IndexedDBDatabase class. The last part of the codebase that doesn't have locks before being used is the IndexedDBBackingStore::Initialize call. Since this happens on the opening of the database, this can probably use just the raw database + a WriteBatch. Bug: 862456 Change-Id: I89c79ec89a4450e21f1ee700b007ec867b3a4f48 Reviewed-on: https://chromium-review.googlesource.com/c/1478391 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#634358}
-
Benjamin Shaya authored
Bug: 124534506 Test: cplay Change-Id: I512e2b6d2f43d56c13d0dcf1dcf5d63778156135 Reviewed-on: https://chromium-review.googlesource.com/c/1479303 Commit-Queue: Benjamin Shaya <bshaya@chromium.org> Auto-Submit: Benjamin Shaya <bshaya@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#634357}
-
Dmitry Gozman authored
This CL introduces DidStartNavigation and ReadyToCommitNavigation to replace DidStartProvisionalLoad. The focus here is to split two entirely different signals and stop passing fake DocumentLoader to DidStartProvisionalLoad. Unfortunately, this leaves us in an intermediate state, but addressing all the issues at once is pretty hard and will be easier after some other cleanups land. 1. For browser-initiated navigation, when it comes to the renderer, we immediately commit. The old flow: DidStartProvisionalLoad -> DidCommitProvisionalLoad. The new flow: DidStartNavigation -> ReadyToCommitNavigation -> DidCommitProvisionalLoad. 2. For renderer-initiated navigation, we issue a request from the renderer process to the browser process to begin navgation, and then follow up with commit coming from the browser to the renderer. The old flow: DidStartProvisionalLoad (with a fake DocumentLoader) -> browser process does something -> DidStartProvisionalLoad (with a real DocumentLoader) -> DidCommitProvisionalLoad. The new flow: DidStartNavigation -> browser process does something -> ReadyToCommitNavigation -> DidCommitProvisionalLoad. See https://docs.google.com/document/d/1eCcUmWMUkIeCgieIxFA_T7UkML-V3mzwT2yu26Q-PX4/view for motivation. This also corresponds to the step 14 from the doc linked in the bug. TBR=nyquist@chromium.org Bug: 855189 Change-Id: I830c5317bf7f58db35589488efb2cb1b47c50b8a Reviewed-on: https://chromium-review.googlesource.com/c/1427442 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#634356}
-
Roberto Carrillo authored
This change passes the LLVM_PROFILE_FILE var from the test_runner environment down to the environment inside the VM where actual test is run. The location is set to /tmp inside the VM, where the test can write to, and passed to the test runner for extracting the data out into the results directory (which should be included in the isolated output IIUC) R=liaoyuke,stgao,jbudorick BUG=934059 Change-Id: Id85f54120355176925cc39ce52947fcfe83c2e62 Reviewed-on: https://chromium-review.googlesource.com/c/1480552 Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Shuotao Gao <stgao@chromium.org> Cr-Commit-Position: refs/heads/master@{#634355}
-
Alex Clarke authored
Previously this API behaved differently depending on whether mock time was used or not. If mock time was used, it only returned false if there where no pending tasks at all. If mock time wasn't used it returned false if there where no tasks to run now. This is confusing so we replaced it with MainThreadHasPendingTask which checks if there are any tasks to run now. We also fix a problem with ~TestBrowserThreadBundle which was flaking if CHECK(!MainThreadHasPendingTask()) if a delay expired between the last RunUntilIdle() and it. TBR=mfoltz@chromium.org, rouslan@chromium.org, bajones@chromium.org, bnc@chromium.org Bug: 925315 Change-Id: I664615b43882f94126309e1355f5045305bd02c1 Reviewed-on: https://chromium-review.googlesource.com/c/1454363 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#634354}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/04097a34d39e..a5230e24c600 git log 04097a34d39e..a5230e24c600 --date=short --no-merges --format='%ad %ae %s' 2019-02-21 rycsmith@google.com Select/deselect and isIndexSelected for Comboboxes and Listboxes. 2019-02-21 thestig@chromium.org Add more checks to ValidateDecoderPipeline(). 2019-02-21 thestig@chromium.org Validate filters in CPDF_DIBBase::LoadColorInfo(). Created with: gclient setdep -r src/third_party/pdfium@a5230e24c600 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:b/124253371 TBR=dsinclair@chromium.org Change-Id: Ib6f2df8e0b91b2b439b7dee279fceca4731eb255 Reviewed-on: https://chromium-review.googlesource.com/c/1480983Reviewed-by:
-
Devlin Cronin authored
Since URLPattern::Contains() now properly checks schemes, checking whether an extension had the <all_urls> permission through the permissions API began failing if the extension didn't have file access. This is because the permissions API, for contains(), unpacked the permissions as if the extension had file access. This then meant that checking against active permissions would indicate the extension didn't have permission if it didn't have file access. Fix this by instead always parsing file:-scheme patterns (always including URLPattern::SCHEME_FILE as a valid scheme), but removing it from the valid schemes for <all_urls> patterns if the extension doesn't have file access. For patterns that explicitly specify the file:-scheme, populate them in a new group of |restricted_file_scheme_patterns|. This also lets us trivially fix an oddity in the permissions.request() function, where requesting a file:-scheme pattern would fail with the message "Invalid value for origin pattern file:///Invalid scheme.: *" if the extension didn't have file access. Add unit tests for the API behavior as well as the changes to permissions_api_helpers. Bug: 931816, 932703 Change-Id: I891d7aae5042cdb58d24fd7ef2d19f919a893228 Reviewed-on: https://chromium-review.googlesource.com/c/1475805 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#634352}
-
Sergey Ulanov authored
The following tests will run on all fuchsia FYI bots: blink_common_unittests, blink_heap_unittests, blink_platform_unittests Bug: 821951 Change-Id: Ife49c41157727230bb9e0378957b6df75323fe03 Reviewed-on: https://chromium-review.googlesource.com/c/1444703Reviewed-by:
-
Jia authored
Bug: 931149 Change-Id: I2b5007ad211eeb785091662257f34fa1ce89f44f Reviewed-on: https://chromium-review.googlesource.com/c/1480307Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#634350}
-
Oystein Eftevaag authored
The large buffer size is causing flakiness on memory_top10_mobile webview perf bots, and should no longer be necessary given other recent improvements like always adding trace metadata at the end of the trace R=eseckler@chromium.org,ssid@chromium.org,perezju@chromium.org Bug: 929802,929793 Change-Id: I71f8421bacce1f1d785f8553f8d8e0d54db3d4ee Reviewed-on: https://chromium-review.googlesource.com/c/1481612Reviewed-by:
ssid <ssid@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#634349}
-
Natalie Chouinard authored
This internals page is used to surface debugging information useful to developers of the NTP Interest Feed. The first set of properties being added here display whether the new Interest Feed is enabled, some user classifier information (type of user, frequency of usage), and provide the ability to easily clear the current user classification. https://screenshot.googleplex.com/FY6F7zhx0ur Bug: 913126 Change-Id: I6cebc1b3f217677bd184ed7eba7f68793cd26091 Reviewed-on: https://chromium-review.googlesource.com/c/1478174Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#634348}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bb774460bda0..689da99593bd Created with: gclient setdep -r src-internal@689da99593bd The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:790088,chromium:790095,chromium:790105,chromium:790115 TBR=mmoss@chromium.org Change-Id: Iaeba6681c45298e785b83dcbf88c8b8813a93e91 Reviewed-on: https://chromium-review.googlesource.com/c/1480986Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634347}
-
Brian Sheedy authored
This reverts commit c9078153. Reason for revert: Cause of https://crbug.com/934351 Original change's description: > Hide URL from lookalike URL warning interstitial. > > This CL adds support for hiding of URLs in the omnibox by security > interstitials so as to enable it for the lookalike URL interstitial. > > Bug: 927924 > Change-Id: I2a7c7311480d6626d2ef27572e326c0a473dc20b > Reviewed-on: https://chromium-review.googlesource.com/c/1478358 > Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> > Reviewed-by: Michael Wasserman <msw@chromium.org> > Reviewed-by: Carlos IL <carlosil@chromium.org> > Cr-Commit-Position: refs/heads/master@{#634067} TBR=msw@chromium.org,carlosil@chromium.org,jdeblasio@chromium.org Change-Id: Ibe82a239db4be9f799187dff4b1d321461cb784e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 927924 Reviewed-on: https://chromium-review.googlesource.com/c/1480718Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#634346}
-
