- 13 Nov, 2019 40 commits
-
-
Zhiheng Li authored
Bug: internal b/143071435 Test: tested on AndroidThings device Change-Id: I4b93f9ed7c39dbfa1e669c285515234f2acc241d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902075Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Commit-Queue: Zhiheng(Vincent) Li <vincentli@google.com> Auto-Submit: Zhiheng(Vincent) Li <vincentli@google.com> Cr-Commit-Position: refs/heads/master@{#714835}
-
Liquan (Max) Gu authored
Added comments: * Comment why the ref over the weak-ref is chosen for WebContents. * Comment why using an abbreviation. Bug: 999196 Change-Id: I94eddbed050e131865869ac09521fa7275d48619 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912912Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#714834}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/e46010f01da9..0865050e54e9 git log e46010f01da9..0865050e54e9 --date=short --no-merges --format='%ad %ae %s' 2019-11-12 rharrison@google.com Split spvc shader generation into initialize and compile phases (#882) 2019-11-12 9856269+sarahM0@users.noreply.github.com opName - opStruct (#880) Created with: gclient setdep -r src/third_party/shaderc/src@0865050e54e9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com Bug: None Change-Id: I62159dec827ab3d973b07f92d2f2230a5315c02d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912928Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714833}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cea09e02b1a6..a4e6d1590f29 Created with: gclient setdep -r src-internal@a4e6d1590f29 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None Change-Id: I21bd3e5b70f712d0083a9712ad46599d5a74392e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912930Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714832}
-
Noel Gordon authored
Replace computer and shared SVG icons with viewBox="0 0 20 20" version from UX, and optimize them using SVGOMG. Bug: 992819, 1002393 Change-Id: I3f2d7625cb1d72e42a540e6da93a21bf186a819d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913779Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#714831}
-
Wei Lee authored
The corresponding CL on ARC side is: http://ag/9684171 Bug: b/144062362 Test: Tested with an enterprise account and policy which blocks CCA and CCA will not show up as an option when forwarding camera intent. Change-Id: Ie27c899f044d7e72cd58439510adbb4af6b7775e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903238 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#714830}
-
Manu Cornet authored
When going to tablet mode ShelfWidget/ShelfConfig gets updated before the AppListController gets to notify observers that AppList will be visible. This means ShelfWidget will update thinking that the AppList is not visible, when it actually is. To fix this race, check whether the AppList *should* be visible at ShelfConfig::is_in_app(). Change-Id: I7d82b6ca5bd8933146dad75c0c1edb3257e41a67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903595 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#714829}
-
Paul Dyson authored
Bug: 991433 Change-Id: Ifdb323f64cb9dddc59e95ba673a5cadbf7869cb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910822 Commit-Queue: Paul Dyson <pdyson@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#714828}
-
Alexander Timin authored
Ensure that "extended experimental supported feature set" allows all pages regardless of features used by this page. This will break pages, so this should never be enabled for users, but it's useful for local testing and debugging without having to build Chrome or pass command-line flags, which is difficult on Android. TBR=arthursonzogni@chromium.org Change-Id: If0fd2c5f848211f60a33ee550c4fe27decc3acaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912701Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#714827}
-
Julie Jeongeun Kim authored
It converts remote_cocoa::mojom::StubInterface from application.mojom to new Mojo types using PendingAssociatedReceiver, AssociatedReceiver, PendingAssociatedRemote, and AssociatedRemote. Bug: 955171 Change-Id: I8ab0dcc86445e14dc6ab966e1b2729fbe714931b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893609Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#714826}
-
Alexey Baskakov authored
Fix WebAppSyncBridge::ApplySyncChangesToRegistrar: Do not call SyncInstallDelegate methods if app sets are empty. Add WebAppSyncBridge unit tests for ApplySyncChanges method. These tests is a promised follow up for this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1830494 This code is disabled by default behind kDesktopPWAsWithoutExtensions and kDesktopPWAsUSS base features. In next CL: Add WebAppSyncBridge::CommitUpdate unit tests (UpdateSync). Change-Id: If5b20b3ef8490397a4e024e3237b0456e06667ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910985 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#714825}
-
Justin Gallagher authored
Command line flags, field trials, and feature flags must be initialized before BrowserTaskEnvironment to avoid a potential race condition, where the browser is reading from the trial state at the same time that it is being written to. This isn't done in SearchProviderTest, which causes potential races in two tests: SearchProviderTest.CommandLineOverrides SearchProviderTest.SendsWarmUpRequestOnFocus To resolve, a new class SearchProviderFeatureTestComponent was created to handle field trial state. It's initialized before the BrowserTaskEnvironment member. BrowserTaskEnvironment is responsible for spinning up the thread pool, so everything before that point is synchronous. That's adding a thread which is reading the field trial state, causing the race. C++ initializes it's member variables in order of declaration, so adding the FeatureTestComponent before BrowserTaskEnvironment ensures that the command line and field tests are set before any other threads are added. This change is heavily based on mpearson's prior fix, which was reverted. http://crrev.com/c/1263562 Bug: 891959 Change-Id: I5590579ad9aef73d2d055dec5712dfd5dc567ce9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902786 Commit-Queue: Justin Gallagher <jugallag@microsoft.com> Reviewed-by:Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#714824}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7980e5ea3e34..a1a26deab50b git log 7980e5ea3e34..a1a26deab50b --date=short --no-merges --format='%ad %ae %s' 2019-11-12 primiano@google.com trace_processor: don't use cxxabi for demangling on windows 2019-11-12 eseckler@google.com Merge "trace_processor: make stringpool not commit by default" 2019-11-12 skyostil@google.com TrackEvent: Check that category names are well formed 2019-11-12 treehugger-gerrit@google.com Merge "trace_processor: Implementing "demangle" SQL function" 2019-11-12 oysteine@google.com Update EXPORT_JSON to output stack samples in a matching format to the legacy viewer 2019-11-12 lalitm@google.com Merge "trace_processor: rework best index logic again" 2019-11-12 fmayer@google.com Merge "Disable AllGraphs test." 2019-11-12 lalitm@google.com Merge "trace_processor: remove kId flag" 2019-11-12 fmayer@google.com Merge "Only run HeapGraphWalker::AllGraphs on standalone builds." 2019-11-12 fmayer@google.com Merge "Mention UI for recording profiles." 2019-11-12 treehugger-gerrit@google.com Merge "Add new assertion to HeapGraphWalkerTest::AllGraphs" 2019-11-12 treehugger-gerrit@google.com Merge "ftrace probe: fix padding size calculation being off by 4 bytes" 2019-11-11 fmayer@google.com Merge "Do not count roots as unique_retained." 2019-11-11 rsavitski@google.com Merge "compact_sched: remove "unstable" notices" 2019-11-11 rsavitski@google.com Merge "compact sched_waking: event decoding in trace_processor" 2019-11-11 rsavitski@google.com Merge "compact sched_waking: writer (traced_probes)" Created with: gclient setdep -r src/third_party/perfetto@a1a26deab50b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:132678367 Change-Id: Ia42b7f5a4aefc6996ff8618ff553a5702f262c28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913760Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0bbd6ee7bb63..2a11883d0071 git log 0bbd6ee7bb63..2a11883d0071 --date=short --no-merges --format='%ad %ae %s' 2019-11-13 fancl@chromium.org Fix fetching config from luci-config 2019-11-13 fancl@chromium.org Fix handling invalid requests in /subscriptions/match Created with: gclient setdep -r src/third_party/catapult@2a11883d0071 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=nuskos@google.com Bug: chromium:953181,chromium:953181 Change-Id: Ibb61ed9962cb8e7cf1d8a0d84127abb53279b3ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913799Reviewed-by:
-
Bailey Berro authored
This change begins to address an issue where context was unclear for screen readers when a dialog opens. Previously, when a dialog had a field set as 'autofocus', ChromeVox would read the name and contents of the field followed by "dialog". With this change, all dialogs properly read title of dialog + "dialog" before reading the name and contents of the autofocused field. With this change, we end up with a slightly different issue where some information about the title/ first field of a dialog is read twice for example "Add Printer, Dialog, Name, dit text, Name, edit text, Add Printer, Dialog" Screen recordings: Before: https://www.loom.com/share/c3c71f84457d457b8bcf9a8cc973cc43 After: https://www.loom.com/share/24c4a8dd5ef54063a94bc94af48246ed Bug: 1015673 Change-Id: Ic79006ea3cf94c0695f140c1cdff9efdb65bc28b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906254Reviewed-by:
Jordy Greenblatt <jordynass@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#714821}
-
Daniel Rubery authored
This CL adds a few variants on the MDB and CRT extension to download_file_types.asciipb, so that they have reasonable failure behavior in the event Safe Browsing is unavailable. Fixed: 1022257, 1022265, 1022732, 1022737, 1022316 Change-Id: I01cd8f79c6ac7b061acdcdf95533e80406074f26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911283 Auto-Submit: Daniel Rubery <drubery@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#714820}
-
Joe DeBlasio authored
This CL adds two new safety tip statii: kBadReputationIgnored and kLookalikeIgnored. These states correspond to when the user has previously ignored a warning on that page, but the page would otherwise trigger a Safety Tip. This CL also updates every default case of SafetyTipStatus to be kUnknown instead of kNone. This means that kNone definitively means "safety tip status was checked, and found to be none" instead of a generic unknown state. These changes have no user-visible impact, but before this change, several distinct cases were conflated into kNone in metrics. TBR: cthomp@chromium.org Bug: 1022017 Change-Id: I51c81dab94b438abc13e62b837d4ec55be41e5a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901631 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#714819}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: I2f5e0f4a3e6b3f530c8ff9a287656f0067ec6bb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912892Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714818}
-
Dana Fried authored
Visibility change on animation start resulted in alpha overlay not painting until next animation frame, resulting in the underlying text (representing the new title and domain) showing through at 100% opacity. Now the overlay always draws but possibly at zero opacity, avoiding the issue. The text is still cleared when the card reaches its destination so we don't incur the overhead of laying out the text. Change-Id: Id1e0587874f7e91dad4efdf0fd31f2ac23860ceb Bug: 1023956 Fixes: 1023956 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910681 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Auto-Submit: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#714817}
-
Pavel Yatsuk authored
The test verifies Identity Disc visibility based on navigation location (NTP vs. other locations), sign-in, and sync state. To enable testing I updated the logic to retrieve ProfileSyncService reference instead of using cached reference. I also updated FakeProfileSyncService to allow controlling sync state from test. R=twellington@chromium.org Change-Id: I8fcc672acd0b0a5e7c46e951e4222e7c9cbb8c7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904080Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#714816}
-
Ken Rockot authored
This is a stripped down incarnation of Service Manager's BinderMap type. Unlike that type, there is no intent here to support the complexity of variadic binder arguments since such use cases are generally now limited to the Content layer or above. This is a straightforward mapping of interface name to callback + task runner. At first this will at least be used by Blink and various Content child process types to expose interfaces to the browser through a common path in ChildThreadImpl. Bug: 977637 Change-Id: I7aa7cf40995b1898090202bd4e4377285c776421 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905047 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f47c2ab889d9..d4002a733dc6 git log f47c2ab889d9..d4002a733dc6 --date=short --no-merges --format='%ad %ae %s' 2019-11-12 mbonadei@webrtc.org RTC_EXPORT missing symbols for Chromium's component build. Created with: gclient setdep -r src/third_party/webrtc@d4002a733dc6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I4d2c9014d7d0f19816c3ad6c3cfcfd20444e3000 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913706Reviewed-by:
-
David Grogan authored
FlexibleBoxAlgorithm reads margins from LayoutBox. We weren't positioning items with margins correctly in FlexNG before this patch. Bug: 845235 Change-Id: I4d05fd6107f0140d69c6aee3f56d78dc430862c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913707Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#714813}
-
Maggie Cai authored
Implement delete app from preferred apps for an |app_id| and |intent_filter|. BUG=853604 Change-Id: Ibc1060304765813bcde50f80d1a00a0d10fee880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910823Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#714812}
-
rbpotter authored
Add a new cr-splitter Polymer element and use this to replace cr.ui.Splitter in the bookmarks page. cr.ui.splitter depends on cr.ui.define(), which will not be migrated to Polymer 3. Also generate Polymer 3 versions of the new cr-splitter and its tests. Fixed: 1023002 Change-Id: Ie8360353c1e67fa5fc8d2fcf3d09002621d71ba4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910701 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#714811}
-
Daniel Hosseinian authored
Implement the PdfPrinterHandlerGetCapabilityTest class to allow for the initialization of a PdfPrinterHandler object. The handler allows for the simulation of Web UI messages that make calls to the handler. Change-Id: I2e1cfa033b524400687658c19117cfc24ecc16ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907772Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#714810}
-
Julian Watson authored
Bug: 1017511 Change-Id: Ibe74895517bc1d14792b18d2e12b62958fde541d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905029 Commit-Queue: Julian Watson <juwa@google.com> Auto-Submit: Julian Watson <juwa@google.com> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#714809}
-
Jeevan Shikaram authored
This CL shows a no permissions label for ARC apps when the app does not request any permissions in their manifest. Bug: 1020777 Change-Id: Ieb80ff7661204b8fa85804fa5b52ed7ac3d1b2d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896493 Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#714808}
-
Hirokazu Honda authored
A VideoFrame mapped by the VaapiDmabufVideoFrameMapper holds a VAImage created from the source VideoFrame. The VA surface associated the source video frame should not be released until the mapped video frame is destroyed, so we bind a reference to the source video frame to the mapped video frame's destructor. Bug: 1020776 Test: VD test on atlas Change-Id: Ia0b01b4bcb3e4312c0c2e91f8ad8c8beae20f393 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911342 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#714807}
-
Julie Jeongeun Kim authored
This CL cleans up old mojo types for mojom::ExternalBeginFrameController using AssociatedRemote, PendingAssociatedReceiver, and AssociatedReceiver. Bug: 955171 Change-Id: I1c8c2669f9f18420db0d6960d662598708d93248 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897376Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#714806}
-
David Benjamin authored
Now that we have SSL_used_hello_retry_request, include it in SSLHandshakeDetails as it affects the RTT count of the handshake. Bug: none Change-Id: I6dbbf787b773d5ab0c7182ead25f715fbaab6b1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903951Reviewed-by:
Matt Mueller <mattm@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#714805}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8296d47e. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" 88d98fda "Add more scroll to text WPTs" faa1edfe "update WPT tests to eliminate CSSPseudoElement from animations" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I7200506aeae1c5832d80bb72322041eb2c4096be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913109Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714804}
-
Kelvin Jiang authored
This CL adds the OnRuleMatchedDebug event for DNR. This event is emitted every time a DNR rule is matched if the extension is unpacked and is listening to the event. Emitting this event for allow rules will be implemented in a follow-up. Bug: 1017934 Change-Id: I2a4d450c01eb19e5090b1c8cb2d6e1a0b984ed7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880176Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#714803}
-
Hirokazu Honda authored
An encoder driver may expect extra data size between planes in an input buffer. We currently don't use width and height adjusted by the driver, but a large-enough width and height computed from the buffer size in bytes. Therefore, a VEA client is asked to allocate a larger width/height buffer in the case. A backend for graphics buffer allocation (e.g. minigbm) is able to allocate a buffer that has extra data properly from width and height adjusted by the encoder driver. A client using a backend like minigbm wrongly allocates a buffer unexpected by the encoder driver due to a large width and height requested by VEA. ARC++ encoder hits this issue. This CL resolves the issue by requesting width and height adjusted by the encoder driver if native_input_mode, that is, a client will feed a buffer allocated by a backend like minigbm. Bug: b:144135251 Test: ARC++ encoder on kukui Change-Id: I5bfbd0169bbff2ad3801a4561d546fbfe290902d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906864Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#714802}
-
Jan Wilken Dörrie authored
This is a reland of 84fcf8bb Original change's description: > Reland "[base] Introduce base::CheckedContiguousRange" > > This is a reland of 83ced150 > > Original change's description: > > [base] Introduce base::CheckedContiguousRange > > > > This change introduces base::CheckedContiguousRange, which similarly to > > base::span is a light-weight wrapper around a contiguous container > > performing bound CHECKs. > > > > However, in contrast to base::span this class keeps a pointer to the > > underlying container, and thus is able to respond to changes to data() > > and size(), which base::span can't do. > > > > Furthermore, this change provides a constexpr overload of base::data() > > for std::array and fixes a bug in CheckedContiguousIterator::operator-=. > > > > Bug: 990059 > > > > Change-Id: I3fef91c7ef7874bf495ac2ab6dbaf3a8b02dab35 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893858 > > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > > Reviewed-by: Chris Palmer <palmer@chromium.org> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#712120} > > Bug: 990059 > Change-Id: If7cfd16ca526930643e9fac7567f58ba9ef60b1f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893069 > Reviewed-by: Chris Palmer <palmer@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#712493} Bug: 990059 Change-Id: I728ab7d229d931919f928b4786a19c8ca46920f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906352 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#714801}
-
Mitsuru Oshima authored
It sometimes draws bad wallpaper image. Temporarily disable while investigating the cause. (could be an issue on gpu/driver, and in that case it will stay) Bug: 1020500 Test: manually tested on minnie Change-Id: I141f04eda13ce2c1280102b9fccdb2933c3456b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912833Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#714800}
-
Hirokazu Honda authored
VideoFrameMapper assumes a given VideoFrame on Map() is not nullptr. This causes a test crash if the VideoFrame is nullptr. We shall handle the case as error rather than crash. Bug: 1020776 Test: VD test on atlas Change-Id: Ifa49a405cf33e16f2df0e5e5079e7df253a5bb1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911062Reviewed-by:
-
Tim Song authored
The collapse state of the status area should be updated when the shelf state or bounds change or when a tray item is shown or hidden. Note that the actual calculation for which trays should be hidden or visible is unimplemented and will be finished in a future CL. TEST=unit test BUG=982511 Change-Id: Ie4a46be7d03435bf8927062af0c7726f5cc090a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904165 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#714798}
-
Joel Hockey authored
Currently we hardcode crostini terminal to use the builtin crosh location, whereas crosh can dynamically allow nassh and nassh-dev apps to be used instead. With some expected changes coming in crrev.com/c/1905039 to have crosh use chrome://terminal, and other changes to gzip content, it is useful to have terminal use the same URL that is used for crosh. Bug: 1023866 Change-Id: I7784b42171c73592acdd99d20ade6367c2afa3de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913283Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#714797}
-
Hirokazu Honda authored
Bug: 1020776 Test: VD test on atlas --output_frames Change-Id: I3ab7dc8342fd55cfa18d5125d0a8065ad4fa94bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910983 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
-
