- 04 Mar, 2020 40 commits
-
-
Alan Cutter authored
Bug: 1007786 Change-Id: I674710a2fd92a669c636ab190337483825bac6c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076222 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#746669}
-
Eric Willigers authored
GetAppIdForTab now supports web apps, in addition to bookmark apps and Chrome platform apps. AppServiceAppWindowWebAppBrowserTest is now parameterized by web_app::ProviderType. Bug: 1048055 Change-Id: I2fc9f656f88634d6b0c2f03a2531ea7914452797 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078377Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#746668}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/eedab7912f7c..779e58d10e2f Created with: gclient setdep -r src-internal@779e58d10e2f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ie0890ec326eb07a1a407d0dc07fe976fecf6fed8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086186Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746667}
-
Giovanni Ortuño Urquidi authored
Flakes started again around: https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/81647 TBR=avi@chromium.org Bug: 985255 Change-Id: I1827cb12df13a490c8de00ae753c223d17c62f89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086458Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#746666}
-
Alex Danilo authored
With the flag enabled, and upcoming change the DOM structure of the breadcrumb, this test can't work in files-ng. Bug: 1035691 Change-Id: I3a78f7d82bc5f117fd3dfeab6b925c7284e41b0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086379Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#746665}
-
Koji Ishii authored
This patch fixes an use-of-uninitialized-value accidentally introduced in r746511 <crrev.com/c/2079775>. |is_hanging_| is initialized and should be used only for |NGPhysicalLineBoxFragment|. The CL passes |is_hanging_| as an argument for this purpose, but the function mistakenly uses it in the super class, instead of using the one passed by the argument. Bug: 982194 Change-Id: I3b33595fa0305f92408914b9ac77d15fbccb9d27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086456Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#746664}
-
Tal Pressman authored
Bug: 1049056 Change-Id: I52a862b6d5999203cff4ad92b9d1d63eff811ae4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078518Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Tal Pressman <talp@chromium.org> Cr-Commit-Position: refs/heads/master@{#746663}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/970291c5e024..40dd59329abe git log 970291c5e024..40dd59329abe --date=short --first-parent --format='%ad %ae %s' 2020-03-04 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@40dd59329abe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0a2ed4fc9363ad1d073d0280b95d7f5515367b75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086183Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746662}
-
Yuki Shiino authored
'Dictionary' type is obsolete and deprecated. The new bindings generator won't support it. The existing use cases (in *.idl) have been removed by peria@, except only for MediaTrackConstraintSet dictionary that contains Dictionary type. Removes web tests that depend on 'Dictionary' type. This is the last use case that is directly visible from IDL interface bindings. (MediaTrackConstraintSet dictionary yet contains Dictionary type, but it's not directly visible from IDL interface bindings.) Bug: 839389 Change-Id: Iec4f1112a0c17a7931aaf49ef4c2780ca564474e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084773Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#746661}
-
Mathew King authored
On the Drallion stylus when the errse button is pressed the digitizer will send an BTN_TOOL_RUBBER event before a BTN_TOUCH event and then a BTN_TOOL_PEN. This sequence should be considered an POINTER_TYPE_ERASER and not a POINTER_TYPE_PEN. Bug: b:139781900 Change-Id: I268ef0d72e25fa374832ed529a4b54559bc0f805 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076530Reviewed-by:
Sean O'Brien <seobrien@chromium.org> Commit-Queue: Mathew King <mathewk@chromium.org> Cr-Commit-Position: refs/heads/master@{#746660}
-
Kent Tamura authored
This CL relands crrev.com/c/2074840. A part of it was landed as crrev.com/746315, and this CL is the remaining. > HTMLOptionElement's InsertedInto() and RemovedFrom() called > MenuListSelectType::UpdateTextStyleAndContent(), which updates a Text > node in a UA shadow tree. It triggered a DCHECK failure about > IsSlotAssignmentRecalcForbidden(). We should not update the DOM tree > in these functions. > > This CL moves the logic of the InsertedInto() and the RemovedFrom() to > HTMLSelectElement::ChildrenChanged() and |HTMLOptGroupElement:: > ChildrenChanged()|. > > As for kAllChildrenRemoved such as |select.innerHTML=''|, > ChildrenChanged() had no ways to know removed nodes. This CL adds > ChildrenChangedAllChildrenRemovedNeedsList flag, and ContainerNode > provides a list of removed nodes if the flag is true. > > This CL also updates comments on Node::InsertedInto(), > Node::RemovedFrom(), and ContainerNode::ChildrenChanged(). Bug: 1056094 Change-Id: Icef4c9f180333a5b39d38b1950f9c5c2660c66c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086451Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#746659}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: Ia9d9b134b9f1fb09a466e1a3c6ccce8a2968910f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086555Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746658}
-
Giovanni Ortuño Urquidi authored
List of failed builders: Builder: Mac10.12 Tests https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests First failing build: https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests/b8886807550037870064 TBR=bokan@chromium.org Bug: 1058244 Change-Id: I2a44c2e90c866785d49320114fed6fd1eec485da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086356Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#746657}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/40d8cb5fc0ae..806369810527 git log 40d8cb5fc0ae..806369810527 --date=short --first-parent --format='%ad %ae %s' 2020-03-04 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 0380a339..b7f5172d (746487:746590) Created with: gclient setdep -r src/third_party/webrtc@806369810527 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I65a0445db64d011497cf1798f7aa6c79c900bf1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086181Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746656}
-
Eric Willigers authored
We previously had separate code paths for bookmark apps and web apps. Change-Id: I054a5d82634f851f3573e9510775260a006965e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079774Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#746655}
-
Sean Harrison authored
Bug: 1032584 Change-Id: Iede0e4630357ae5e4ccb653e7925a8beb808f20d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002616 Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#746654}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fe6f75240a8c..ec2a6ce2706a git log fe6f75240a8c..ec2a6ce2706a --date=short --first-parent --format='%ad %ae %s' 2020-03-03 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@ec2a6ce2706a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ieced2c3b72be8e8ff607c3ba145b7509232dee4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086179Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746653}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/05f974d7..18eac1a4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I61106dd2413678c4a4224997dc5466a51b009fa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086158Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746652}
-
Akihiro Ota authored
Due to changes in relative file paths, ChromeVox doesn't correctly display images in the panel. Fix the relative file paths so they get rendered correctly. Also ensures the options button in the panel opens the options page. Change-Id: I74f6e36086458f458b6725b8b5fad0ef08d5d99d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086291 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#746651}
-
Khushal authored
The Xiaomi Mibox 4 device doesn't support anything more than 1. Internally SurfaceTexture also uses 1 here so update the ImageReader implementation to use the same. R=dalecurtis@chromium.org, liberato@chromium.org Bug: 1051705 Change-Id: I8fb1e88fbca9b1d0acb932cb4e1ac851a7c05762 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086313 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#746650}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a54af923929b..20ed48e8e963 git log a54af923929b..20ed48e8e963 --date=short --first-parent --format='%ad %ae %s' 2020-03-04 rmistry@google.com Create flutter checkouts from scratch Created with: gclient setdep -r src/third_party/skia@20ed48e8e963 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: herb@google.com Change-Id: I96c3285d6c74ecb7ade759749d0828337f6035b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086178Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746649}
-
Kei Nakashima authored
Implemented RemoveFirst, pop_back, AppendOrMoveToLast, PrependOrMoveToFi rst and InsertBefore to NewLinkedHashSet. Also, added tests for those fu nctions. Added DCHECK for checking if each node in a vector is used. Change-Id: I9da2dd77db203f68b9d4312890cbc748c594d004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081726 Commit-Queue: Kei Nakashima <keinakashima@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#746648}
-
Luciano Pacheco authored
Change icons for files without thumbnails to show the file's icon as thumbnail. See crbug.com/992822#c14 for some screenshots. Change generic icons SVG to have fill color --google-grey-700 to use them background-image instead of -webkit-mask-image to simplify the CSS logic to overwrite the generic icon to specific icons. For specific icons we want to use their SVG color, which isn't possible when using -webkit-mask-image. Force the grey color for ".detail-icon" to have icons used as -webkit-mask-image have the correct color. This in turn requires to force the blue color for ".detail-checkmark" because this element is child of ".detail-icon" causing it to inherit the color. Change the JS logic to add CSS classes to make easier to style: 1. Initialize the ".img-container" with CSS class "no-thumbnail". 2. Remove "no-thumbnail" class once a thumbnail is loaded. 3. For FilesNg don't add the ".shield" div at all. 4. For FilesNg don't add the 2 divs ".checkmark.active" and ".checkmark.inactive". Instead add ".detail-checkmark" in the same place it adds for folders, which is the same as File List. 5. Change setGenericThumbnail_() (for FilesNg) to set the attribute "generic-thumbnail" as the mime type icon instead of media type, media type is limited to: image, video, audio, raw, documents, etc, which is too coarse to be able to customize icon per mime type/file type. This is the same logic used for the File List and the smaller icon near the file name. Bug: 992822 Change-Id: Idf4cd25381bf5a12767c4bc970f73f2e418dad7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082660 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#746647}
-
Kazuki Takise authored
We adjust PIP initial bounds in exo as Android isn't aware of some Chrome OS System UI We should apply this logic only to the PIP initial bounds. Otherwise, the obsolete bounds might be applied incorrectly for display rotation, PIP fling, etc. Whether it's entering PIP or not can be checked by whether the snap fraction is set or not as the snap fraction is set when the initial bounds is actually applied to the window in ClientControlledState. BUG=b:149889040 BUG=b:149875362 TEST=Manually confirmed PIP fling and screen rotation put PIP to the correct position. Change-Id: I0f988b1ed6467c6d7a005bb1b0abc6e220277c5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081650 Commit-Queue: Kazuki Takise <takise@chromium.org> Auto-Submit: Kazuki Takise <takise@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#746646}
-
Evan Stade authored
Before this patch, when the history stack was empty and the user pressed the system back button, the tab would be closed (usually --- depending on how the tab was opened). The beforeunload handler, if any, would be skipped, even though navigating in a different manner *would* trigger beforeunload. In comparison, desktop Chrome does run beforeunload when closing a tab (via the tab close button, for example). So this discrepancy seems unintended. This fix *only* affects system back and not other ways of closing tabs. So, for example, closing from the tab switcher UI will still immediately close, but offer an undo notification bar. This should not have any effect if a page does not have a beforeunload handler (or the handler is not active due to the lack of a user gesture), except that closing will be asynchronous. The same sequence happens in TabModelImpl, as TabModel#closeTab is called with the same arguments by way of TabWebContentsDelegateAndroid#closeContents. Bug: 1055540 Change-Id: Ie9e45692b920db54fd3d00f06466edee01771d47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071491 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#746645}
-
Xing Liu authored
NavigationEntryTest.NavigationEntryContentUri is failing on Android builders. This CL disables it. TBR=arthursonzogni@chromium.org Bug: 1050906 Change-Id: Ie43860ae550b11662087e7f1ffee5ebca85d1827 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086265Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#746644}
-
Kaustubha Govind authored
Improve DNS configuration checking to handle additional cases where we must defer to platform DNS, such as checking for DNS proxies and VPN configurations, and an additional policy that could be used to configure NRPT rules. Bug: 1052139 Change-Id: I4884f76b576964e976114169113259e28fc78801 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055761Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Kaustubha Govind <kaustubhag@chromium.org> Cr-Commit-Position: refs/heads/master@{#746643}
-
Nnamdi Theodore Johnson-Kanu authored
This CL moves chromeOS strings for settings Date/Time page from settings_strings.grdp to os_settings_strings.grdp. It continues the process of moving all chromeOS specific strings. Bug: 967883 Change-Id: Ie0f1edeea54b8399f205ca2facc0b8b2c2f5d55e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069968 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#746642}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7f746ebe3585..eedab7912f7c Created with: gclient setdep -r src-internal@eedab7912f7c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ia376e7d402a090b1ddb1d346eb6b9868bf83610f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086175Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746641}
-
Daniel Rubery authored
This CL replaces AdvancedProtectionDeepScanningEnabled with a new policy AdvancedProtectionEnhancedSecurityAllowed. This new policy is meant to cover all Advanced Protection security features in Chrome, rather than covering each on a case-by-case basis. Note that deep scanning of downloads for Advanced Protection users didn't launch in M81, so this new policy will be covering the feature from launch. Bug: 1056358 Change-Id: I9e262009e4dd48d73a28ca4c8f0e104202bb9817 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079301 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#746640}
-
Yusuf Sengul authored
Bug: 1055977 Change-Id: I1756855b25371b9bbf0da02a63cb1c754790f697 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086256 Commit-Queue: Yusuf Sengul <yusufsn@google.com> Reviewed-by:
Rakesh Soma <rakeshsoma@google.com> Cr-Commit-Position: refs/heads/master@{#746639}
-
Evan Stade authored
If we wanted to support fractional scales well we'd need to switch to using some smaller unit, such as milliseconds, but that doesn't seem to be the purpose of scaleTimeout (the example given in the documentation is scale == 20), and it would require touching many files. Bug: none Change-Id: I97b625d10b3be5ddbd305694ab78714a43677f08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084717Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#746638}
-
Pavel Feldman authored
This allows associating navigation events with the input, the way it was supposed to be at the first place. By default, inspector events are coalesced and only flushed upon either protocol command ack or blink task end. It is essential to not compromise runtime performance. It is also essential to push notify in-time for selected navigations and we already did that for many events, just not the navigation ones. Fixing this. Change-Id: I0b765bd634b3c03b64249150734e1368327b5b0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083562 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#746637}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 127 histograms that show frequent access in the past 90 days. These are the 90% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2020-08-30. Change-Id: Ibe0539b849ff6de9bd7eb7ae75bef38afd2c27c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085232 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#746636}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/90019cea5ec9..54bd00057324 git log 90019cea5ec9..54bd00057324 --date=short --first-parent --format='%ad %ae %s' 2020-03-03 cnorthrop@google.com Capture/Replay: Add Query Object support to mid-execution capture 2020-03-03 cnorthrop@google.com Capture/Replay: Update getTexImage for depth/stencil and 3D Created with: gclient setdep -r src/third_party/angle@54bd00057324 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: ianelliott@google.com Change-Id: Iab597fe1f4bc37bc413e3ba63c14835669332d97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086113Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746635}
-
Tibor Goldschwendt authored
This includes adding title navigation to the customize dialog to switch between collections and images. NOTE: This does not embed actual images. Will do this in a follow up CL. Bug: 1032328 Change-Id: I3f9931aca673590dcd05dd4e4fa6dcf046aee3f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076554 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#746634}
-
Brian Osman authored
Bug: chromium:1045995 Change-Id: If8d5873d355c12587bc231091145b0312726b667 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085293Reviewed-by:
Mike Klein <mtklein@google.com> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Brian Osman <brianosman@google.com> Cr-Commit-Position: refs/heads/master@{#746633}
-
Lukasz Anforowicz authored
Fixed: 1054974 Change-Id: Ica1b44284e99f9b56f49bcbb602bfd0cdb6de648 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081263Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#746632}
-
Dan Harrington authored
StreamModel ingests DataOperations and provides the set of content to be rendered by the UI. Also supports ephemeral changes which can be undone later. We'll add some additional features to this class soon, as it is only a subset of what we need. Bug: 1044139 Change-Id: I1b8d6c6196c9102c0cd6696033b3083ccf350c47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083433 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#746631}
-
Robert Liao authored
This test helps ensure that color values do not change when the Color Provider feature is enabled. BUG=1057754 TBR=sky@chromium.org ui/base Feature Addition for the Color Provider. Change-Id: Ifd115ee7d4b6f73e337e5e74269d521960de7250 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086191 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#746630}
-