GitLab

base/string16.h was moved into base namespace in r191198 by Brett.

BUG=None
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/15759009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203079 0039d316-1c4b-4281-b951-d872f2087c98

This creates a separate SynchronousCompositorImpl class that is owned
by the RenderWidget. This will be needed for hooking up the root layer
scroll offset delegate.

BUG=None

Review URL: https://chromiumcodereview.appspot.com/15875009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203078 0039d316-1c4b-4281-b951-d872f2087c98

BUG=239392,9096213

Review URL: https://chromiumcodereview.appspot.com/15871003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203077 0039d316-1c4b-4281-b951-d872f2087c98

Currently preview panel is transparent and does not affect the size of other
components. Thus this CL just removed call for onResize.

This CL also removes unused function requestResize.

BUG=238867
TEST=manually

Review URL: https://chromiumcodereview.appspot.com/15675007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203076 0039d316-1c4b-4281-b951-d872f2087c98

ResourceMetadata::GetResourceEntryById no longer returns FilePath.
FileSystemInterface::GetResourceEntryById no longer returns FilePath.
Remove GetFilePath related code from FakeFileSystem.

BUG=244135
TEST=unit_tests
R=satorux@chromium.org

Review URL: https://codereview.chromium.org/16107004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203075 0039d316-1c4b-4281-b951-d872f2087c98

Allow specifying proxy scripts using file:, data:, and ftp: URLs.  This addresses a regression from r198915.

BUG=243974

Review URL: https://chromiumcodereview.appspot.com/15665006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203074 0039d316-1c4b-4281-b951-d872f2087c98

Android can have tabs without any web contents. Tab association logic
assumes that all tabs have web contents. This prevents Android from
cleanly doing session reassociation. This change adds a
SyncedTabDelegate which does not depend on existence of web contents.
It also ensures that SessionID for a tab does not change when web
contents get attached to the tab.

BUG=139670, 125549

Review URL: https://chromiumcodereview.appspot.com/15499005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203071 0039d316-1c4b-4281-b951-d872f2087c98

webstore_private_api returns "already_installed" when an install request specifies an extension id that is either already installed or is in the process of installing.

BUG=222735

Review URL: https://chromiumcodereview.appspot.com/15292011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203070 0039d316-1c4b-4281-b951-d872f2087c98

buffer_pool_lock_ is not needed on the UI thread for this test, but if the
camera started and stopped without an OnFrameInfo, then it's possible that
the buffer_pool_ was never created.

BUG=231723

Review URL: https://chromiumcodereview.appspot.com/15070008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203069 0039d316-1c4b-4281-b951-d872f2087c98

This is generally not applicable to autofill as we either filter out incomplete
profiles or there's no associated phone number (in the case of credit cards).

BUG=180149
R=estade@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15892013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203068 0039d316-1c4b-4281-b951-d872f2087c98

This timeout was long to work around a problem that has been resolved
elsewhere.
I'm also changing the histogram name to match the condensed format
that is now preferred. In addition I've added a new boolean histogram
to indicate if the data was ready or not.

BUG=244939
BUG=242726

TEST=None

Review URL: https://chromiumcodereview.appspot.com/16189009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203065 0039d316-1c4b-4281-b951-d872f2087c98

BUG=164227
TEST=No

Review URL: https://chromiumcodereview.appspot.com/16171008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203064 0039d316-1c4b-4281-b951-d872f2087c98

Remove the overenthusiastic DCHECK from PictureLayerImpl to make sure
that every tile that intersects the visible content rect also has a
distance to the viewport of zero.  Because the projection of the
viewport is done more precisely than the enclosing rect for the visible
content rect, it may be possible for a tile to be outside the viewport
but inside the visible content rect.

Therefore, the current DCHECKS are bogus.  Instead, skip these tiles
because they're not truly required for activation.

R=reveman@chromium.org
BUG=243437

Review URL: https://chromiumcodereview.appspot.com/16160005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203063 0039d316-1c4b-4281-b951-d872f2087c98

R=mgaba@chromium.org
BUG=244897
TEST=none

Review URL: https://chromiumcodereview.appspot.com/16114010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203062 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203056 0039d316-1c4b-4281-b951-d872f2087c98

This CL alters SpellcheckMessageFilter to check for NULL spellcheck service when
it periodically receives a list of document markers from the renderer.

BUG=244521

Review URL: https://chromiumcodereview.appspot.com/16075005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203054 0039d316-1c4b-4281-b951-d872f2087c98

Example (new on top, old on bottom): http://imgur.com/a/vx7pW

BUG=99426

Review URL: https://chromiumcodereview.appspot.com/16019014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203052 0039d316-1c4b-4281-b951-d872f2087c98

The bugs fixed are:
- programs required for -o2 weren't checked for when using -o2
but were checked for lower -o levels.
- if no savings could be found the results printed at the end
were confusing and the script had a divide by zero error.

BUG=None

Review URL: https://chromiumcodereview.appspot.com/15970004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203051 0039d316-1c4b-4281-b951-d872f2087c98

This removes third_party/IconFamily from Chrome, which creates
questionable results when adding icon sizes < 128px. Since OSX 10.5, OSX
hasn't used indexed icons or alpha masks when a 32-bit icon is available
(see notes in OSServices.framework/IconStorage.h).

BUG=241304
TEST=Create an app shim and inspect Resources/app.icns using OSX Preview
-- ensure the icons are correct.
TBR=darin@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15650005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203050 0039d316-1c4b-4281-b951-d872f2087c98

Fix some style nits while there.

TEST=Robot Unicorn Attack.
BUG=

Review URL: https://chromiumcodereview.appspot.com/15990006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203049 0039d316-1c4b-4281-b951-d872f2087c98

BUG=242227
TEST=unittest

Review URL: https://chromiumcodereview.appspot.com/15862014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203048 0039d316-1c4b-4281-b951-d872f2087c98

These headers have moved from Source/Platform/chromium/public to
public/platform. This CL updates content's references to the old location to
point to the new location. After this CL lands, I'll remove the forwarding
headers that are letting these references still work.

TBR=jamesr@chromium.org
BUG=239545

Review URL: https://chromiumcodereview.appspot.com/15822010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203047 0039d316-1c4b-4281-b951-d872f2087c98

This fixes the heapchecker+components release build.

BUG=241938

Review URL: https://chromiumcodereview.appspot.com/15797009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203046 0039d316-1c4b-4281-b951-d872f2087c98

It makes the test more self-contained.

This patch converts only the tests not involving file deletion feed,
which is not supported yet in FakeDriveService.

BUG=244316

Review URL: https://chromiumcodereview.appspot.com/15741023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203045 0039d316-1c4b-4281-b951-d872f2087c98

Add per-dialog UseNewStyleForThisDialog() style control.
(by default this returns the static UseNewStyle() control)
Update DialogDelegate to respect this per-dialog control.

Have TaskManagerView always use the old style; cleanup.
See before/after pics at http://crbug.com/245000#c1

Do DialogClientView background init in ViewHierarchyChanged.
(check the dialog delegate instance for styling control)

BUG=245000,166075
TEST=The task manager always uses the old dialog style.
R=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15731007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203044 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=mtomasz@chromium.org, hirono@chromium.org

Review URL: https://codereview.chromium.org/16216006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203043 0039d316-1c4b-4281-b951-d872f2087c98

The ui::CompositorTestSupport class existed to initialize WebKit since
ui::Compositor depends on cc which used to depend on WebKit being initialized
to function properly.  cc no longer has this requirement, so this class is
unnecessary.

R=piman, sky

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202787

Review URL: https://chromiumcodereview.appspot.com/14744016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203042 0039d316-1c4b-4281-b951-d872f2087c98

This adds a task graph interface to the worker pool and
implements a simple queue instance of this interface for
use by the tile manager.

The task graph interface can be used describe more
complicated task dependencies in the future and
provides the immediate benefit of seamlessly being
able to cancel and re-prioritize tasks.

BUG=178974,244642
TEST=cc_unittests --gtest_filter=WorkerPoolTest.Dependencies

Review URL: https://chromiumcodereview.appspot.com/14689004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203041 0039d316-1c4b-4281-b951-d872f2087c98

FileSystem::GetFileByResourceId was converting resource ID to file path and then calling EnsureFileDownloaded.
Rename EnsureFileDownloaded to EnsureFileDownloadedByPath and add an additional version EnsureFlieDownloadedByResourceID
to avoid the unnecessary conversion from resource ID to file path.

BUG=244135
TEST=unit_tests
R=satorux@chromium.org

Review URL: https://codereview.chromium.org/16190003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203040 0039d316-1c4b-4281-b951-d872f2087c98

that the Blink roll is sticking.

BUG=238484
R=abarth@chromium.org, thestig@chromium.org

Review URL: https://codereview.chromium.org/16153008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203039 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/15624003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203038 0039d316-1c4b-4281-b951-d872f2087c98

Previously, the DOMActionType was being sent from the renderer to the browser ActivityLog as a string. It was then being turned into an enum. I've now moved it to its own proper field, and it's being marshaled across the renderer/browser boundary as an int that matches an enum instead of as a string.

R=mpcomplete@chromium.org
BUG=229703

Review URL: https://chromiumcodereview.appspot.com/15520002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203037 0039d316-1c4b-4281-b951-d872f2087c98

BUG=242261

Review URL: https://chromiumcodereview.appspot.com/15359007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203036 0039d316-1c4b-4281-b951-d872f2087c98

Don't allow the the page to call setValue() if the omnibox doesn't have focus.
This breaks the "clearing out gray text" usecase (when the user clicks on
the suggestion corresponding to a gray-text completion), but we aren't
worried about it because we are aiming for a launch without any gray text.
We'll re-enable setValue() in the general case when we handle it properly.

Also disable the focus() API to prevent a trivial workaround (where the page
focuses the omnibox and then calls setValue).

BUG=229193

Review URL: https://chromiumcodereview.appspot.com/15001020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203035 0039d316-1c4b-4281-b951-d872f2087c98

Unreviewed gardening.

TBR=tomhudson@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/16123010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203031 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203030 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit 4c237453.

As with the previous two rolls, this broke WebViewInteractiveTest.PopupPositioningMoved on the Mac.

TBR=tomhudson@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/15731010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203029 0039d316-1c4b-4281-b951-d872f2087c98

> Make the copy of GURL in src/url buildable as a component build. (try 2)
> 
> BUG=229660
> TBR=brettw
> 
> Review URL: https://chromiumcodereview.appspot.com/15805003

TBR=thestig@chromium.org

Review URL: https://codereview.chromium.org/15848009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203027 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/15772012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203026 0039d316-1c4b-4281-b951-d872f2087c98

BUG=229660
TBR=brettw

Review URL: https://chromiumcodereview.appspot.com/15805003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203025 0039d316-1c4b-4281-b951-d872f2087c98