GitLab

Use the new multi-line elision in RenderText to manage/display
a dictionary definition answer-in-suggest, which can
span multiple lines.

BUG=591803

Review-Url: https://codereview.chromium.org/2009673005
Cr-Commit-Position: refs/heads/master@{#397198}

This is required to run the browser_tests on swarming.

BUG=614745,582622
TEST=This fixes failing browser_tests.

Review-Url: https://codereview.chromium.org/2028133002
Cr-Commit-Position: refs/heads/master@{#397197}

BUG=

Review-Url: https://codereview.chromium.org/2024033003
Cr-Commit-Position: refs/heads/master@{#397196}

BUG=611802
TBR=tsepez@chromium.org, piman@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2027223002
Cr-Commit-Position: refs/heads/master@{#397195}

The lcd text is only updated at commit time. We should compute whether
or not to use_lcd_text on demand rather than updating it every frame.

BUG=581842
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2026033002
Cr-Commit-Position: refs/heads/master@{#397194}

BUG=611802
TBR=ben@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2027203002
Cr-Commit-Position: refs/heads/master@{#397193}

While here, also fix a bug in which the rectangle in which the filter is
assumed to be visible was also mapped through the filter, and update unit
tests accordingly.

BUG=600821
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2015343002
Cr-Commit-Position: refs/heads/master@{#397192}

This CL adds a layout test that getSettings actually returns
frame rate. This required wiring up support for letting the
fake video source in blink_test_runner call its callbacks.

BUG=543997

Review-Url: https://codereview.chromium.org/2023203002
Cr-Commit-Position: refs/heads/master@{#397191}

BUG=616509
R=dfalcantara

Review-Url: https://codereview.chromium.org/2024293005
Cr-Commit-Position: refs/heads/master@{#397190}

When DEPOT_TOOLS_WIN_TOOLCHAIN=0 it is assumed that the developer has a
local install of Visual Studio, and therefore the CRT DLLs don't need to
be copied to the output directory in order to run binaries. However,
when creating packages for running elsewhere (isolates or the
mini_installer) those DLLs are needed. In order to avoid special cases
elsewhere this change copies them to the output directories when 'gn gen'
or 'gn args' runs.

This change also makes the newly copied files writable so that they can
easily be deleted. For backwards compatibility it also makes the files
writable before deleting them. This avoids a problem with pgort140.dll
which can end up read-only and thus impossible to copy over or delete
without first removing the read-only flag.

This change also removes the need for create_installer_archive.py to
copy CRT DLLs, which should avoid bugs with over-copying of these DLLs.
This change also updates that script to say that ucrtbase*.dll is
required.

BUG=611934,585556, 610336

Review-Url: https://codereview.chromium.org/2021353003
Cr-Commit-Position: refs/heads/master@{#397189}

This CL attempts to fix the flakiness observed on DrMemory bots by running
the current message loop until idle after resuming the sequence socket data.

R=mef@chromium.org

BUG=604611

Review-Url: https://codereview.chromium.org/2011183002
Cr-Commit-Position: refs/heads/master@{#397188}

BUG=540847

Review-Url: https://codereview.chromium.org/2027883002
Cr-Commit-Position: refs/heads/master@{#397187}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/cc555cc2..e7978efc

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2024293004
Cr-Commit-Position: refs/heads/master@{#397186}

Restore the LayoutUnit::epsilon tolerance in LineWidth::fitsOnLine calls
to avoid unnecessary breaks at element boundaries due to precision loss.

R=szager@chromium.org
BUG=613118
TEST=fast/text/sub-pixel/button-span-wrap.html

Review-Url: https://codereview.chromium.org/2026073002
Cr-Commit-Position: refs/heads/master@{#397185}

Allow headless clients to provide custom protocol handlers. This lets
the clients override how URL requests are fulfilled for different
schemes types.

Design doc: https://docs.google.com/document/d/1m4CCZGJWOJdHY5MVwQqY3sT-5kBoz7NqmGvIb6-l3fM/edit#bookmark=id.5bqp8w95liri

BUG=546953

Review-Url: https://codereview.chromium.org/2024973002
Cr-Commit-Position: refs/heads/master@{#397184}

https://chromium.googlesource.com/skia.git/+log/e3fa811657ec..4a603fc591dc

$ git log e3fa81165..4a603fc59 --date=short --no-merges --format='%ad %ae %s'
2016-06-01 msarett Revert of Create SkColorSpaceXform to handle color conversions (patchset #10 id:260001 of https://codereview.chromium.org/1952063002/ )
2016-06-01 kulshin Implement support for rendering color emoji on Windows
2016-06-01 msarett Create SkColorSpaceXform to handle color conversions
2016-06-01 scroggo Make SkPngCodec decode progressively.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=herb@google.com

Review-Url: https://codereview.chromium.org/2029023003
Cr-Commit-Position: refs/heads/master@{#397183}

ImageCapture mojo command servicing in the Browser
needs to jump several threads (UI --> IO --> Device(s)).
On ToT, each possible error condition in this chain is
treated more or less individually, which is ugly, (especially
as I'm adding capability retrieval/settings in // CLs).

This CL proposes ScopedResultCallback, which is a
move-only type wrapping a Mojo |callback_| _and_ an
associated |error_callback_|, which is a callback provided
to signal to Blink-side that something went wrong. Using
and passing this callback along the callstack allows for:
- removing the boolean return value
- not having to run the callback by hand:  If and when
 the methods/functions receiving this ScopedCallback
 don't Run() it nor pass it explicitly, it would be
 tantamount to "rejecting" it.

For reference, the callstack follows a sequence:
ImageCaptureImpl --> VideoCaptureManager --> VideoCaptureDevice (implementation).

BUG=518807

Review-Url: https://codereview.chromium.org/2005753006
Cr-Commit-Position: refs/heads/master@{#397182}

Review-Url: https://codereview.chromium.org/2007273003
Cr-Commit-Position: refs/heads/master@{#397181}

This fixes a DCHECK during TileManagerPerfTests. LTHI::ResetTreesForTesting
destroys the pending tree, so if it doesn't also destroy
the pending tree duration timer, the next call to CreatePendingTree
will fail the DCHECK that the timer doesn't already exist.

BUG=607818
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2027803003
Cr-Commit-Position: refs/heads/master@{#397180}

For multiprocess only. Test is flaky.

BUG=616505
TBR=sgurun

Review-Url: https://codereview.chromium.org/2027243002
Cr-Commit-Position: refs/heads/master@{#397179}

Only multiprocess. Test is flaky.

BUG=616501
TBR=sgurun

Review-Url: https://codereview.chromium.org/2028023003
Cr-Commit-Position: refs/heads/master@{#397178}

BUG=chromedriver:1390

Review-Url: https://codereview.chromium.org/2023303002
Cr-Commit-Position: refs/heads/master@{#397177}

The browser compositor now waits until IOSurfaces are no longer in use by the
Window Server before returning them.

BUG=608026

Review-Url: https://codereview.chromium.org/2020183003
Cr-Commit-Position: refs/heads/master@{#397176}

Certain methods, especially for protobufs, can be moved to common in
data_reduction_proxy_utils.

BUG=

Review-Url: https://codereview.chromium.org/2025443002
Cr-Commit-Position: refs/heads/master@{#397175}

This should reduce binary size quite a bit, without less security.
We currently use different -fstack-protector flags on different platforms,
and I think -fstack-protector-strong is where we eventually want all platforms
to be.  Chrome OS has been using that flag for a long time already.  Linux
will use it eventually (see bug linked to in the comment I'm adding here.)
clang-cl is very likely going to hook up /GS to -fstack-protector-strong.

BUG=none

Review-Url: https://codereview.chromium.org/2029633002
Cr-Commit-Position: refs/heads/master@{#397174}

BUG=616265
TEST=none
R=jamescook@chromium.org
TBR=reveman@chromium.org

Review-Url: https://codereview.chromium.org/2030593002
Cr-Commit-Position: refs/heads/master@{#397173}

BUG=613787

Review-Url: https://codereview.chromium.org/2026063002
Cr-Commit-Position: refs/heads/master@{#397172}

* Dynamic DSF change is not supported/tested on linux. Jus make sure that it uses the same scale unless restarted.

BUG=615353
R=thomasanderson@chromium.org

Review-Url: https://codereview.chromium.org/2022383002
Cr-Commit-Position: refs/heads/master@{#397171}

We didn't end up needing to roll it back. Take the flag out starting M52.

BUG=none

Review-Url: https://codereview.chromium.org/2022373002
Cr-Commit-Position: refs/heads/master@{#397170}

Reland of Use valid log callback for audio modem's audio recorder. (patchset #1 id:1 of https://codereview.chromium.org/2028083002/ )

Reason for revert:
The revert failed to fix the bot that was failing, so relanding.

Original issue's description:
> Revert of Use valid log callback for audio modem's audio recorder. (patchset #1 id:1 of https://codereview.chromium.org/2028023002/ )
>
> Reason for revert:
> Temporarily reverting this, as the revert is required to revert https://codereview.chromium.org/2022023002/ which is suspect of causing bot failures.
>
> Will reland if the reverts don't work.
>
> Original issue's description:
> > Use valid log callback for audio modem's audio recorder.
> >
> > This fixes a crash.
> >
> > Also change dchecks to checks to catch early. In the unit test we use a mock stream, and there's obviously no (debug built) integration test for this.
> >
> > BUG=616083
> > TBR=tommi@chromium.org, xiyuan@chromium.org
> >
> > Committed: https://crrev.com/9d6c6d9e13e8c263cf0a16c33eb39065ebb5a6eb
> > Cr-Commit-Position: refs/heads/master@{#397127}
>
> TBR=tommi@chromium.org,xiyuan@chromium.org,grunell@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=616083
>
> Committed: https://crrev.com/81395dce584e055f2ec5b126d366f19869865e29
> Cr-Commit-Position: refs/heads/master@{#397144}

TBR=tommi@chromium.org,xiyuan@chromium.org,grunell@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=616083

Review-Url: https://codereview.chromium.org/2023323002
Cr-Commit-Position: refs/heads/master@{#397169}

Allows compression via gzip for rarely used .pak resources. These resources
will only be uncompressed into memory upon request of the resource. We are
compressing all "internals" pages, with a savings of 472KB.

TBR=sdefresne
BUG=609219
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/1968993002
Cr-Commit-Position: refs/heads/master@{#397168}

We construct a new request to represent a redirect, but never set its priority.
This fixes that.

BUG=613165

Review-Url: https://codereview.chromium.org/1994173002
Cr-Commit-Position: refs/heads/master@{#397167}

Reland of land: Forward output glitch information from stream WebRTC log (patchset #1 id:1 of https://codereview.chromium.org/2028053002/ )

Reason for revert:
The WebRTC Linux Tests bot is still broken after the revert, so relanding.

Original issue's description:
> Revert of Reland: Forward output glitch information from stream WebRTC log (patchset #3 id:60001 of https://codereview.chromium.org/2022023002/ )
>
> Reason for revert:
> This is a speculative revert, as this CL is suspect of breaking the WebRTC Linux Tester bot.
>
> See: https://build.chromium.org/p/chromium.webrtc/builders/Linux%20Tester/builds/17602
>
> If the revert doesn't work, I'll reland.
>
> Original issue's description:
> > Forward output glitch information from stream WebRTC log
> >
> > * A callback is added as input parameter on AudioManager create stream functions.
> > * OnLogMessage() function is added to the AudioLog interface.
> > * The AudioOutputDispatcherImpl gives AudioLog::OnLogMessage() as callback when creating an output stream.
> > * AudioInputController gives AudioInputController::LogMessage() (new function) as callback when creating an input stream. In this function, the message is passed to AudioInputRendererHost::OnLog().
> > * In both input and output cases, the message is then passed to the WebRTC log.
> > * The Mac input and output streams inform about OS glitches via the callback.
> >
> > This relands https://codereview.chromium.org/1864483002
> >
> > BUG=610967
> > TBR=slan@chromium.org,sievers@chromium.org,xiyuan@chromium.org (for unchanged files from original CL)
> >
> > Committed: https://crrev.com/ee6953c1c54a56cd277074e6945ae251e6e1240d
> > Cr-Commit-Position: refs/heads/master@{#396818}
>
> TBR=tommi@chromium.org,slan@chromium.org,sievers@chromium.org,xiyuan@chromium.org,grunell@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=610967
> NOPRESUBMIT=true
>
> Committed: https://crrev.com/7f28c7f2bd207ab104cb26877da069f634e63872
> Cr-Commit-Position: refs/heads/master@{#397145}

TBR=tommi@chromium.org,slan@chromium.org,sievers@chromium.org,xiyuan@chromium.org,grunell@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=610967

Review-Url: https://codereview.chromium.org/2021403003
Cr-Commit-Position: refs/heads/master@{#397166}

BUG=603217

Review-Url: https://codereview.chromium.org/2028113002
Cr-Commit-Position: refs/heads/master@{#397165}

If the curve for setValueCurveAtTime is too short (length less than
2), an exception must be thrown.

BUG=615477
TEST=audioparam-setValueCurve-exceptions.html updated

Review-Url: https://codereview.chromium.org/2020753002
Cr-Commit-Position: refs/heads/master@{#397164}

It is superseded by SourceLocation now.

BUG=613882

Review-Url: https://codereview.chromium.org/2016123002
Cr-Commit-Position: refs/heads/master@{#397163}

BUG=596039
TBR=pkasting

Review-Url: https://codereview.chromium.org/2032463004
Cr-Commit-Position: refs/heads/master@{#397162}

setValueCurveAtTime() should copy the curve data so that modifications
of the original array don't change what setValueCurveAtTime would
produce.

See description of value parameter at http://webaudio.github.io/web-audio-api/#widl-AudioParam-setValueCurveAtTime-AudioParam-Float32Array-values-double-startTime-double-duration

BUG=582980
TEST=audioparam-setValueCurve-copy.html

Review-Url: https://codereview.chromium.org/2016563002
Cr-Commit-Position: refs/heads/master@{#397161}

ImportedStyleSheetClient is currently a part class of StyleRuleImport, but
this change makes it GarbageCollected as a preparation to make
StyleSheetResourceClient GarbageCollectedMixin.

BUG=587663

Review-Url: https://codereview.chromium.org/1996293002
Cr-Commit-Position: refs/heads/master@{#397160}

Only exclude ones that have top/left/right/bottom set to a non-zero value.

BUG=604996

Review-Url: https://codereview.chromium.org/2002623003
Cr-Commit-Position: refs/heads/master@{#397159}