- 09 Aug, 2019 6 commits
-
-
James Cook authored
UX wants the icon back in OS Settings. This is a partial revert of: https://chromium-review.googlesource.com/c/chromium/src/+/1709783 Screenshot: http://screen/ygVfqu1eVb7 Note that this is currently the device account icon. A follow-up CL will change the Chrome C++ code to send the primary GAIA account icon, which could be different. Bug: 990528 Test: added to browser_tests Change-Id: I983846c517763d64e5cf2830deb9334865d7a17a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745590 Commit-Queue: James Cook <jamescook@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#685412}
-
Kenichi Ishibashi authored
We won't maintain on-the-main-thread script fetch anymore. Bug: 967272 Change-Id: I4731b5f8988da1a959ea74971c6f68f766275e92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745666 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#685411}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Icbfb599fb8e6336035ab0fae673923e67176f2ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745591Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#685410}
-
Danyao Wang authored
Finch config CL: https://critique.corp.google.com/#review/262012910 Bug: 991381 Change-Id: Ie2da3a72a7f00c0f9de194b57d03cc7373ecd58b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1740506 Commit-Queue: Steven Holte <holte@chromium.org> Auto-Submit: Danyao Wang <danyao@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#685409}
-
Aaron Colwell authored
This combines the origin and URL checks to remove some duplicate and unnecessary checks. This will also make it easier to update the URL checks to handle non-standard URLs in a follow-up CL. - Inlines CanCommitURL() at the beginning and end of CanCommitOrigin() and removes redundant checks. - Rename CanCommitOrigin() to CanCommitOriginAndUrl() - Move kDisableWebSecurity check to the top of the function so it skips URL checks as well. This is the only functional change. Bug: 991607 Change-Id: Id8b9f52b594994c1a4c1c38a709ba3e4c0daffc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742836 Commit-Queue: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#685408}
-
yuanzhi authored
Bug: TEST-851 Change-Id: I7646f3902793811b81ad2a6c4b3807603536c603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737726Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Yuan Zhi <yuanzhi@google.com> Cr-Commit-Position: refs/heads/master@{#685407}
-
- 08 Aug, 2019 34 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium cb6e9a3c. With Chromium commits locally applied on WPT: 329c91e5 "Attempt to make test more stable" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: pwnall@chromium.org, jsbell@chromium.org: external/wpt/cookie-store NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I0f6fd9c6c14d4975c0c616bbd8886d9b37ae3c23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745266Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#685406}
-
Rakib M. Hasan authored
We are attempting to standardize the expectations format. A new format has been created. Now we have to make all the test/benchmark runners use the new format. This CL will make the src/perf benchmarks use the new format of expectations. The script used to translate the old expectations format into the new format can be found at the following link, https://paste.googleplex.com/5236354608791552 The design document for the expectations format change can be found at go/change-telemetry-benchmarks-expectations-format. Bug: chromium:973936 Bug: chromium:992199 Change-Id: I83b0090958fe50517be6540d241be3e29c0925b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737991Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#685405}
-
Tommy Steimel authored
This CL modifies the MediaNotificationListView to be a ScrollView so that the Global Media Controls dialog becomes scrollable when there are too many sessions to fit comfortably. Bug: 991370 Change-Id: Id5e9b92e455e4298dfcb7fd409b096f348bff232 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745389Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#685404}
-
Toby Huang authored
R=agawronska Bug: None Change-Id: Ic6ab4fd47ffbe272252a350e133d383d386a911e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723301 Commit-Queue: Toby Huang <tobyhuang@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#685403}
-
James Cook authored
Split settings is moving the "Change account image" functionality to OS settings. UX wants the item in browser settings not to be clickable anymore. See bug. Screenshot of non-clickable row: http://screen/1nrWpZxXMBb Bug: 990528 Test: added to browser_tests CrSettingsPeoplePageTest.All Change-Id: I83a9c04f5c8a792a88375bef25cddb090ec4ec3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745267Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#685402}
-
Caroline Rising authored
Bug: 959933 Change-Id: I1793b705f647e8e32fedec1b592c59ea840876f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745130Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#685401}
-
Wei Li authored
Simplify the bubble showing procedure through browser view by 1) move profile checking logic into Hats service; 2) move anchor view handling logic into Hats bubble class. BUG=979530 Change-Id: I6962f3904d575671f592ca0926edd214fe748c2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742511Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#685400}
-
Clark DuVall authored
Bug: 934317 Change-Id: I054b539a39752582d6e44f1ac416bbc24be7c470 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742371Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#685399}
-
Lily Chen authored
Calls to SetCookieWithOptionsAsync are replaced with the two-step process of first making a CanonicalCookie via CanonicalCookie::Create, then passing that to SetCanonicalCookieAsync. At this point, there is only one non-test usage remaining, and that call site already has a CanonicalCookie, so might as well just call SetCanonicalCookieAsync there, and remove the entry point and its implementations. This does slightly change behavior, due to consolidation of all cookie-line parsing logic into CanonicalCookie::Create. In particular, the iOS CookieStore used to do its own cookie-line parsing in SetCookieWithOptionsAsync. That used to differ from CanonicalCookie::Create in whether trailing dots in URLs/domains were preserved (and possibly some other subtle differences?). This updates the relevant CookieStore unittests to reflect this change in cookie creation behavior. (Based on morlovich's https://crrev.com/c/1464131) Bug: 989098 Change-Id: Ibbe2fb0a950af07e5df6811f6372a9dd8c88b5f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739491 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#685398}
-
Karan Bhatia authored
Reduce the work that's done while evaluating the query transform of a rule. This is done by indexing escaped values for the query key value pairs. Also, sort and remove duplicates before indexing the query keys to be removed. BUG=983685 Change-Id: Ia6e72832253025c4a43b5852e00a7a064d3fcd6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742887 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#685397}
-
Caitlin Fischer authored
Change-Id: If334d98e17657d81cb4241df3ebe25415be6514a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736700 Auto-Submit: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#685396}
-
Anna Malova authored
Java AwQuotaManagerBridge is now owned by Java AwBrowserContext. Bug: 963875 Change-Id: I517b1d17f17f6bda9ce93de09baa4861a74bc179 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742171Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Anna Malova <amalova@chromium.org> Cr-Commit-Position: refs/heads/master@{#685395}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0756495a26fb..65b41192b9a7 git log 0756495a26fb..65b41192b9a7 --date=short --no-merges --format='%ad %ae %s' 2019-08-08 primiano@google.com Merge "Client library: Allow recursive acquire of data source lock" Created with: gclient setdep -r src/third_party/perfetto@65b41192b9a7 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: Ic326138e7014ac5c6df1758401ff20fb18575675 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744967Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#685394}
-
Kyle Milka authored
Bug: 937570 Change-Id: I069370a8574797c133c5660106b6cc74132b4cd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744927 Commit-Queue: Kyle Milka <kmilka@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Auto-Submit: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#685393}
-
ssid authored
BUG=989384 Change-Id: I899ff40c615f3fd5312199408f9aa93c32372530 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745128 Commit-Queue: ssid <ssid@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Auto-Submit: ssid <ssid@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#685392}
-
Daniel Cheng authored
This CHECK is intended to catch when an IPC race around process shutdown that leads to inconsistent state between the browser and the renderer. Without the CHECK, there are likely instances where the bug is latent but never triggered, so adding an explicit CHECK() likely increases the number of overall crashes. Due to how Android WebView crashes are attributed, and the fact that Android seems to encounter this IPC race more, disable this CHECK() there for now despite the fact that it doesn't actually fix anything... Bug: 974173 Change-Id: I19bbbe0a0fdaffdc30cfdfbc1cf300d0de12839c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1740332Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#685391}
-
Sami Kyostila authored
*** Note: There is no behavior change from this patch. *** The PostTask APIs will shortly be changed to require all tasks to explicitly specify their thread affinity, i.e., whether the task should run on the thread pool or a specific named thread such as a BrowserThread. This patch updates all call sites with thread affinity annotation. We also remove the "WithTraits" suffix to make the call sites more readable. Before: // Thread pool task. base::PostTaskWithTraits(FROM_HERE, {...}, ...); // UI thread task. base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...); After: // Thread pool task. base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...); // UI thread task. base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...); This patch was semi-automatically prepared with these steps: 1. Patch in https://crrev.com/c/1635827 to make thread affinity a build-time requirement. 2. Run an initial pass with a clang rewriter: https://chromium-review.googlesource.com/c/chromium/src/+/1635623 3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \ uniq > errors.txt 4. while read line; do f=$(echo $line | cut -d: -f 1) r=$(echo $line | cut -d: -f 2) c=$(echo $line | cut -d: -f 3) sed -i "${r}s/./&base::ThreadPool(),/$c" $f done < errors.txt 5. GOTO 3 until build succeeds. 6. Remove the "WithTraits" suffix from task API call sites: $ tools/git/mffr.py -i <(cat <<EOF [ ["PostTaskWithTraits", "PostTask"], ["PostDelayedTaskWithTraits", "PostDelayedTask"], ["PostTaskWithTraitsAndReply", "PostTaskAndReply"], ["CreateTaskRunnerWithTraits", "CreateTaskRunner"], ["CreateSequencedTaskRunnerWithTraits", "CreateSequencedTaskRunner"], ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"], ["CreateSingleThreadTaskRunnerWithTraits", "CreateSingleThreadTaskRunner"], ["CreateCOMSTATaskRunnerWithTraits", "CreateCOMSTATaskRunner"] ] EOF ) This CL was uploaded by git cl split. R=carlosil@chromium.org Bug: 968047 Change-Id: I7004c79f585e1e040609c3830c5a80286402f705 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739812 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#685390}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8b062b2de99f..c1692cd34cc0 Created with: gclient setdep -r src-internal@c1692cd34cc0 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: I3526fbf4e55ec74a1f3aac04ef51bcb107b23e7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744966Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#685389}
-
Mike Jackson authored
Update the list of devices for Microsoft Edge. This includes: - Adding Microsoft Edge for all supported platforms - Clarified which ones are based upon EdgeHTML vs Chromium - Ensured that appVersion and Chromium version are patched similar to Chrome. Change-Id: I59c5287799c6e9bd6950c76323a867c012951323 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709693Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: Mike Jackson <mjackson@microsoft.com> Cr-Commit-Position: refs/heads/master@{#685388}
-
Daniel Cheng authored
Currently VectorBuffer allows the access of buffer[size]. This is because callers are using buffer[size] to get buffer.end(). In order to avoid this, use CheckedRandomAccessIterators in VectorBuffer. This required creating iterator versions for the DestructRange and MoveRange functions. CheckedIterator's behavior now depends on the enable_checked_iterators buildflag: when true, CheckedIterator will CHECK on spatial safety violations; when false, CheckedIterator will merely DCHECK. This is temporary, so that binary size regressions on Android can be studied and explained: the eventual goal is to enable this universally and remove the buildflag. BUG=chromium:817982 Change-Id: I2037bdb542c4442011fc9ebffdc50e50ccfafa7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674746Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#685387}
-
Joe DeBlasio authored
This CL adds a directory for upcoming reputation warnings and the safety tip experiment. Otherwise, this CL contains nothing interesting. Bug: 981177 Change-Id: Ic5a4bfc7ce5f95ccdf04e8a9604aa6fe094b2411 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688332Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#685386}
-
Vlad Tsyrklevich authored
Enable the GWP-ASan unit tests on Android and wire-in GWP-ASan in to the crash handler and browser (for now it's still disabled by default and not wired in to webview.) Bug: 973167 Change-Id: I705bc3fcd4469c90099d91b9b2ae16f2a9c93fab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733567 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#685385}
-
Joe DeBlasio authored
This CL switches the protobuf used for component updater to pass patterns rather than raw URLs. This allows safety_tips to remain consistent with the SB-style pattern matching. It also moves the playbook for component updates to g3. Change-Id: I9da231882cdb68fddd1d0b582006ed60e97fbe8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743247Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#685384}
-
Charlene Yan authored
Since HoverButton was changed to no longer inherit from MenuButton, the behavior has to be readded back into the controller. Bug: 991877 Change-Id: I7d0987eb1b30423753560feee2d8a42bb6d71cc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745289Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#685383}
-
Collin Baker authored
This also fixes accessibility tree errors uncovered when running the new test. Bug: 989174 Change-Id: If362f808260fdcaaa4a0b64a6573ed6f3bc9d471 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744674 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#685382}
-
Scott Little authored
virtual/disable-blink-gen-property-trees/animations/stability/animation-iteration-event-destroy-renderer.html is flaky on linux, so marking it as such. See bug for more info. https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20ASAN/2822 TBR=ericwilligers@chromium.org Bug: 992148 Change-Id: I803958493d9330e3a3383e74e1cae0621aeb5475 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745026Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#685381}
-
Sergey Ulanov authored
Now all Fuchsia owners will be scenic ozone platform OWNERS. Change-Id: I8377878a56785602b600bfdcd40e894c9a37415c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744947Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#685380}
-
Adam Langley authored
WebAuthn contains the “appid” extension that allows WebAuthn to obtain assertions for credentials that were registered using the old U2F API. However, prior to this, there was no way when doing a WebAuthn registration to exclude authenticators based on a U2F credential. An “appidExclude” extension has now been added to WebAuthn to resolve this and this change implements support for it. [1] https://w3c.github.io/webauthn/#sctn-appid-extension [2] https://w3c.github.io/webauthn/#sctn-appid-exclude-extension Change-Id: I2eb1d6d0a574bc4d8cab95540de031329403581f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728724Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#685379}
-
Oksana Zhuravlova authored
This change converts document-scoped FileSystemManager client in blink to use BrowserInterfaceBrokerProxy as a use case of a callback dispatched on the IO thread. Bug: 936482 Change-Id: I3afba1264396bb9b916efb75c6594797ad581407 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709723 Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#685378}
-
Devon O'Brien authored
Adding documentation to ev-to-page-info.md in src/docs/security/ to describe EV certificate UI changes in Chrome 77. Bug: 992132 Change-Id: I1c614e0d7f66d6719f511740f18a5754561c9a35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742810 Commit-Queue: Devon O'Brien <asymmetric@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#685377}
-
Juan Antonio Navarro Perez authored
Prevent issues like crbug.com/985712 happening again. Bug: 990472 Bug: 985712 Change-Id: I6cfa17ec39076f17b6a3bf35b0430f778c05d5ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736896Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Auto-Submit: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#685376}
-
Rouslan Solomakhin authored
Before this patch, the address editor on desktop would not require the full name. However, Payment Request shipping addresses cannot be empty, which is checked in several other places in the code. So the saved address would immediately have a "Name required" error next to it in the address selection screen. In addition, desktop address editor placed the country selector between the name and the rest of the address fields, whereas Android placed the country on top, which makes sense, since changing the country can change all fields, including the position of the name field. This patch makes the name always required in the address editor on desktop and places the country selector on top. Bug: 992081 Change-Id: I028c296289e4635c9c5c12dc10c59102d321fa30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743094Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#685375}
-
Scott Little authored
These tests have been flaking for a long time now, crashing with segfaults occasionally on the linux-chromeos-rel bot for at least a week now: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel?limit=200 See the bug for more details. TBR=antrim@chromium.org Bug: 992022 Change-Id: I9074436363e6bbef0dfa838274a1343e9e333f84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745288Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#685374}
-
Reid Kleckner authored
https://chromium.googlesource.com/chromium/deps/nasm.git/+log/f564874f4..21eb59531 $ git log f564874f4..21eb59531 --date=short --no-merges --format='%ad %ae %s' 2019-08-06 rnk@chromium.org Revert "Skip compiling ilog2.c on Windows where 'inline' uses C++ semantics" 2019-08-06 rnk@google.com Fix extern_inline for MSVC and clang-cl 2019-08-01 rnk@google.com Skip compiling ilog2.c on Windows where 'inline' uses C++ semantics Created with: roll-dep src/third_party/nasm R=dalecurtis@chromium.org, davidben@chromium.org Bug: 989745 Change-Id: I26c19bce9bb4148154168732f2862cb0c7817686 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744200Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#685373}
-