GitLab

If the quick answer consent view is discarded 3 times, we no longer show it
and start showing the quick answers.
This was previously not tested.

Bug: b/169362551
Tests: ash_unittests --gtest_filter="QuickAnswers*"
Change-Id: I7352b45a724980ac169e0d250f06e7b46a7c2440
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436316Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Yue Li <updowndota@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812296}

Bug: 1132076
Change-Id: Ic40b79a2068b60aa8baaab23109a85ac52edc6a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438851Reviewed-by: Carlos IL <carlosil@chromium.org>
Commit-Queue: Xinghui Lu <xinghuilu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812295}

This fixes the signing failures like:
remoting-me2me-host-mac/PrivilegedHelperTools/ChromeRemoteDesktopHost.app/Contents/MacOS//remoting_me2me_host_service: is already signed

BUG=1117247

Change-Id: I184bc8f6c0c0f4476cd174db0a5a693c03fca271
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438206
Commit-Queue: Jamie Walch <jamiewalch@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Auto-Submit: Michael Moss <mmoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812294}

When FadeImageView changes images, update the image size.
This will prevent distorted images when HTML renders.

Bug: 1128721
Change-Id: I3144c4489fd667c3287cd24dbb069e748e7e8613
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436861
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Matthew Mourgos <mmourgos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812293}

QrCodeShareActivity was removed in
https://chromium-review.googlesource.com/c/chromium/src/+/1848370, but
the Manifest entry was not cleaned up.

Bug: 1022172
Change-Id: I51b235728deafa2d884c7174449ef91d715e4c49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438884Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812292}

This is a test only, no behavior change.

Fixed: 750631
Change-Id: Ia51278bd0a1420d9821b52716b2ace238c6ad7f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434744Reviewed-by: Manuel Rego <rego@igalia.com>
Commit-Queue: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812291}

While the tabstrip is not visible, TabStripRegionView has zero width.
If any model change happens while the tabstrip is not visible, the
tabstrip calculates the ideal bounds for tabs based on this
available width. The bug was that the tabstrip was ignoring the first
layout after being restored to visibility because it believed that its
cached layout was still up-to-date.

I.e. this was the timeline:
Layout() at width and available width 1340.
Enter fullscreen. Available width is now -78.
Insert a tab. Ideal bounds are as small as possible to fit -78 width.
Exit fullscreen. Available width is now 1340.
Layout() at width and available width 1340.
Layout() is ignored because there's been no change in width or
available width, when in fact the ideal bounds are stale.

This wasn't happening pre-suspect change because it was calling Layout()
while TabStripRegionView's width was zero (since it called Layout() to
calculate the available width for calculating ideal bounds), so the
first layout after the size was normal again went through.

The fix I went with was to update |last_available_width_| whenever
ideal bounds are calculated. This more correctly reflects the
current calculated layout's dependency on available width.

Bug: 1132832
Change-Id: I5487a99bceb7267cab1e00e2163ba86e2a93b0ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438774
Commit-Queue: Taylor Bergquist <tbergquist@chromium.org>
Reviewed-by: Charlene Yan <cyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812290}

This CL removes the functionality for sending a CSD ping when an
interstitial was previously shown on the page. This is the minimal CL
to do so, and is intended to be merged.

Future CLs will clean up useless code introduced by this CL.

Bug: 1132060
Change-Id: I9f3e163268254cf79eee60b30b2d3da025293abc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429809Reviewed-by: Bettina Dea <bdea@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812289}

The API is still needed in the content level for some conversions,
but blink now no longer needs to call into the content layer to
do these conversions.

BUG=1097816

Change-Id: I004e218a2145db26ff0ec15a35e82376dadd7740
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432186
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812288}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9418e43a9c9d..36477e478d39

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jianli@google.com,xidachen@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1128771,chromium:1133700
Tbr: jianli@google.com,xidachen@google.com
Change-Id: I530fb434931e9d08bd23761d2a750310229a3ae4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441328Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#812287}

This CL updates TabSearchButtonBrowserTest to assert that the tab
search button is not present in an incognito browser.

Bug: 1099917
Change-Id: Ib2bc7c3142521f12613c7721d2b891efb0beb030
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438985Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812286}

This enables LoggingTest.FuchsiaSystemLogging to pass when run with
run_test_component.

Bug: 1132146
Test: fx shell run_test_component fuchsia-pkg://fuchsia.com/base_unittests#meta/base_unittests.cmx
Change-Id: I77a69bc925593c127efbe2e66af1c637d9269197
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433108
Commit-Queue: David Dorwin <ddorwin@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812285}

For ephemeral tab previews within reader mode, the Chrome Component is
created before BottomSheetController is ready.

Bug: 1132772
Change-Id: I30f02d29c2130c9245da8b09cbd7101ea6f4a151
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435926Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812284}

Treat especially dependencies on classes that are in multiple build
targets as "dubious" since only one target will need to be added.
That is a really rare case (I know of only MainDex and CheckDiscard).

Bug: 1133017
Change-Id: Ifce84a6e0c8448f55547d52600b54e84ebb9f50c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436755
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812283}

OnboardingUiTracker implementation that uses the
|kHasCompletedOnboardingBefore| pref to determine whether the
Onboarding UI should be shown. This class invokes
|show_multidevice_setup_dialog_callback| when the user proceeds with
the onboarding flow if Better Together is disabled. If Better Together
is enabled, but PhoneHub is disabled, this class enables the PhoneHub
feature via the MultiDeviceSetupClient instead.

Bug: 1106937
Change-Id: I9453754edf3a51a4056bfce16a7cf8c9c409d7b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437732
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812282}

Bug: 1132721
Change-Id: I72c36069395bba886fe9f7baefbe742ddb980402
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436777Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812281}

This CL:
- Adds handling for absolute paths for --android-deps-dir parameter
- Adds warning if the passed-in path does not contain build.gradle
file

BUG=1132330

Change-Id: I244b8ee41c9371a85a2ddb63de843e1002e99408
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438879
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812280}

This CL replaces the Sticky Activation check for enumeration with a page
visibility check. The attack vector that the sticky activation check was
intended to mitigate is background access to the API.

However, this prevents an intended use-case of the API: e.g. navigating
to a link to open a document will require user activation before content
is show if this API is necessary to render on-screen.

Using a Page Visibility change instead mitigates the same attack vector
while enabling the navigation use-case.

A manual test will be added in a subsequent CL.

Bug: 1043306
Change-Id: Ieb12341f78bceec94907fb577f3c969ae839abdd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439496Reviewed-by: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Martin Barbella <mbarbella@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Olivier Yiptong <oyiptong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812279}

This value does not change over the lifetime of a session, and does not
need to be communicated with the same frequency as other VRDisplayInfo
attributes. Sending it once at the start of a session better matches how
the value is used in practice.

Bug: 1017477
Change-Id: I09e1507418c6dfbab3d19b0d909b6f4753a6d4c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438452
Commit-Queue: Brandon Jones <bajones@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812278}

New histograms include:
- HoldingSpace.TimeFromFirstAvailabilityToFirstEntry (units = ms)
- HoldingSpace.TimeFromFirstEntryToFirstPin (units = ms)

Bug: 1131266
Change-Id: Ida50fa29150b0bbf1f52fb09022bc9f7399bce7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435800Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#812277}

This patch moves Open Screen unittests from the linux-fieldtrial-rel bot
to the main Mac OS X and Linux bots.

Bug: 1025244
Change-Id: I88d0f8e2863da75d808129c134fcb690145b0932
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432762Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Jordan Bayles <jophba@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812276}

This adds (basic) support for adding features to nested complex
selectors.

Bug: 568705
Change-Id: I1f0512ac148bc1f5810787e68777b2d14bd94089
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435225
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812275}

Creates a helper class that gets the metadata needed to return
a vector of the latest visited BrowserTabMetadata to the caller.

Creates a fake version that can be used for unit tests of
callers to this class.

Note the class requires a FaviconService to be passed in the ctor.

Bug: 1106937
Change-Id: Ibe669cc337190025c59d536f36450c054731e14f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424513
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812274}

The spec requires that requests be aborted on addAll() failure:

https://w3c.github.io/ServiceWorker/#cache-addAll

See the sections that say "Terminate all the ongoing fetches
initiated by requests with the aborted flag set."  Note, there
appear to be a few places where this text is missing as noted in:

https://github.com/w3c/ServiceWorker/issues/1543

Currently there is no way to reliably observe that this abort takes
place in a WPT test.  The AbortSignal is not updated for internal
abort decisions and the information is not propagated to the signal
on a service worker FetchEvent.request.  Therefore this test only adds
a simple unit test to verify the related AbortController was triggered.

Bug: 1130781
Change-Id: I0e0498741a6d387147a2ef0ea9d31feaa805dee8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429308Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812273}

This reverts commit 9a224d53.

Reason for revert: causing a crash of HoldingSpaceUiBrowserTest.OpenItem on linux-chromeos-chrome

BUG=1133808

Original change's description:
> Miscellaneous holding space fixes.
>
> Fix pin toggle bounds in HoldingSpaceItemScreenshotView:
> The bounds of the pin toggle button were being stretched to match the
> full height of its parent container.
>
> Fix context menu bounds:
> Context menu should be below the associated view (when space allows).
>
> Fix long press gesture:
> When long pressing, the pressed view should become the selection just
> prior to showing the context menu.
>
> Fix crash in HoldingSpaceTrayBubble:
> If closing bubble due to ESC, bubble widget should only be closed if it
> exists and hasn't already been marked closed.
>
> Fix drag behavior:
> The holding space bubble should be closed during drag events.
>
> Bug: 1131262, 1131267, 1129981
> Change-Id: I5a1f0536ae6badeed841e0a6106e9c423cbf3781
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436671
> Reviewed-by: Ahmed Mehfooz <amehfooz@chromium.org>
> Commit-Queue: David Black <dmblack@google.com>
> Cr-Commit-Position: refs/heads/master@{#812064}

TBR=dmblack@google.com,amehfooz@chromium.org

Change-Id: I1a1321e8ad5a5c3dc9d7371a62908d06f4d8bdf4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1131262
Bug: 1131267
Bug: 1129981
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441320Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812272}

https://chromium.googlesource.com/angle/angle.git/+log/fa082bb58ba7..e1d1b8b30e95

2020-09-30 jmadill@chromium.org Fix info collection on Android without Vulkan.
2020-09-30 jmadill@chromium.org Additional perf test cleanup & functionality.
2020-09-30 courtneygo@google.com Vulkan: Check that its okay to add commands
2020-09-30 syoussefi@chromium.org Vulkan: Constants for unpacked D/S attachment indices

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: chromium:1133459
Tbr: jonahr@google.com
Change-Id: I7a2e522bbef1a7e5a982ad364fe2bf29721fcbb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441027Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#812271}

This reverts commit 7c25668c.

Reason for revert:

Caused test error for https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/20645

Original change's description:
> Reland "Rewrite scroll interruption tests into browser tests"
>
> After we finish the scroll unification, the scrolls happens mainly on
> the compositor thread, and the scroll code in the main thread will be
> removed. eventSender sends the scroll events to main thread, so it
> would not work after the scroll unification. We rewrite below tests
> fast/scroll-behavior/main-frame-interrupted-scroll.html,
> fast/scroll-behavior/overflow-interrupted-scroll.html and
> fast/scroll-behavior/subframe-interrupted-scroll.html into browser tests
> because we cannot guarantee that the scroll arrives before the animation
> completes.
>
> TBR=bokan@chromium.org
>
> Bug: 1047176
> Change-Id: I59bb34a98326892380d748a2a4691ea4664cad26
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438652
> Reviewed-by: Lan Wei <lanwei@chromium.org>
> Commit-Queue: Lan Wei <lanwei@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#811936}

TBR=bokan@chromium.org,lanwei@chromium.org

Change-Id: If1db54aa0562084ed90124f9b5e4597e37647378
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1047176
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441293Reviewed-by: Jian Li <jianli@chromium.org>
Commit-Queue: Jian Li <jianli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812270}

This comprises:
* Making <ntp-most-visited> 3px shorter so that modules move up a tad.
* Remove top margin of first module if there is no promo.
* Making modules a tad narrower so that they match the search box
  including their border.
* Increasing the module title font size.
* Tweak shopping module image background color.

Fixed: 1130032
Change-Id: I10c4b7a9932af106e906e20907bfcc938d2f733e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439519
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812269}

This is a reland of 7927c8a6

TBR=calamity@chromium.org,steimel@chromium.org

Original change's description:
> Use JS modules for the NTP module
>
> Uses JS modules for the NTP module and updates
> closure so it can resolve chrome://kaleidoscope.
>
> Change-Id: I985b20a7faca215bd5194a4a21c790d5a4ff0262
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435441
> Reviewed-by: calamity <calamity@chromium.org>
> Reviewed-by: Tommy Steimel <steimel@chromium.org>
> Commit-Queue: Becca Hughes <beccahughes@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#811807}

Change-Id: I348d2116dc851394804866642a24da48d25e3edf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441109Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812268}

Has been commented out for a while, which means the test passes.

TBR=bsheedy

Bug: 679696
Change-Id: I39601b7d83535dcb91a9fa24fc61e43cb5f75f8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441269Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812267}

Reduces runtime from 6106ms to 1320ms

Bug: 989569
Change-Id: I468ce8f180d218e5cdbae1c3327cd13750a15949
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439343
Commit-Queue: benjamin joyce <bjoyce@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812266}

Client Side Detection models are based on a combination of a DOM model
and a vision-based model. The most recent DOM model was found to be
faulty, so we need to rollout new combined models. This CL updates
the fieldtrial_testing_config to be in sync with the config changes.

Change-Id: Id50dc55a52c927567dd97d76715098fd7c53de6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437007
Auto-Submit: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812265}

1. Encapsulated the test logic of checking click action of
TableViewInfoButtonItem.
2. Added EG test to save password settings UI.
3. Added the accessibility IDs of save password switch item and managed
item to constants file.

Bug: 1131052
Change-Id: Ice93cde0f2db4917d66293188faa063e16869e08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436690
Commit-Queue: Tina Wang <tinazwang@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812264}

TBR=bling-team@google.com

Change-Id: I69df1a68450c5099c2d3e061bc904b5d825320f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441279Reviewed-by: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#812263}

Bug: 973801
Change-Id: I96fcf532f33e80b246475a2ba8a806d5019a33b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438199Reviewed-by: Asanka Herath <asanka@chromium.org>
Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
Commit-Queue: Dylan Cutler <dylancutler@google.com>
Cr-Commit-Position: refs/heads/master@{#812262}

They were necessary to prevent crashes at one point, but other
refactoring appear to have rendered them unnecessary, and they can cause
createDocument/createHTMLDocument to incorrectly return null when they
are called on an implementation object from a detached document.

Bug: 1128911
Test: dom/nodes/DOMImplementation-createHTMLDocument-with-saved-implementation.html
Change-Id: Ia37201a15db195f24e6d3988ee9dddd1d15806c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432850
Commit-Queue: Nate Chapin <japhet@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812261}

Adds support for modal-type dialogs to BubbleDialogModelHost.

Functional changes to the dialog are:

* Adding an associated label to the window-name textfield.
* Focusing and selecting all text in the window-name textfield.

Bug: 1096586,1106422
Change-Id: Iacf39997897041493d622a9840032ca46c76e8fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438581
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812260}

This CL:
* Removes CaptivePortal.DetectionResultSincePortal which no longer seems
  to accurately reflect its intended results.
* Adds NetworkPortalDetector.Result and
  NetworkPortalDetector.NetworkType to report Chrome portal detection
  results (so that they can be compared with Shill results).
* Removes some complex code to reduce log spam that shouldn't be
  happening (and if it is we should know about it).

Bug: 1132475
Change-Id: I961cd9f6dafe70f209c6db09a982bfea8d102b11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432852Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Matthew Mourgos <mmourgos@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812259}

This function can be called when the "malware" tag is present on a scan
request since POTENTIALLY_UNWANTED and UNCOMMON don't exempt from a
deep malware scan. This also makes the function tolerant of all results
which means the UX won't block since the callback will always run.

Bug: 1132981
Change-Id: Ie8836f73ccbcf7af103560d3b9d5291b0709a4f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436416
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812258}

Patch ae49e297, "Add tracing to
ClassifyNavigation to make debugging easier." introduced the following
code:

struct TracingCategory {
  static constexpr const char kNavigation[] = "navigation";
};

This looks fine at first glance, but has one subtle problem that the
author of the code might not have been aware of. In C++14 (which is
currently used by chomium) a static constexpr member variable (unlike
other global constexpr variables) has an external linkage. This is not
really intuitive and is probably why it was fixed in C++17, where such
static constexpr member is inline.

The interesting part is this subtle difference in linking semantics
breaks component builds when using GOLD linker instead of LLD.

  obj/content/browser/browser/navigation_controller_impl.o(.debug_addr+0x858):
  error: undefined reference to 'content::TracingCategory::kNavigation'

To fix this lets just convert TracingCategory from struct into a
namespace. This way it should be inlined no matter which version of the
C++ standard the compiler is instructed to adhere to.

Ref: https://en.cppreference.com/w/cpp/language/constexpr

Change-Id: Ibf0471eaf20805cc7af8236386aa7c5318d26f4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436824
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812257}