- 23 Nov, 2018 40 commits
-
-
Mustaq Ahmed authored
Also marks one currently untestable test. Bug: 906791 Change-Id: I17fd03f16e93244be80f9572db8c43e8e0b95678 Reviewed-on: https://chromium-review.googlesource.com/c/1347092 Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#610651}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/afef11dc26bd..dfbb007cffb6 Created with: gclient setdep -r src-internal@dfbb007cffb6 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I7833ac596269b2efa28ef047a29adc95e1436666 Reviewed-on: https://chromium-review.googlesource.com/c/1349439Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610650}
-
Mounir Lamouri authored
It's flaky on all platforms and is starting to flake on the leak bot. Bug: 891155 Change-Id: I1aa21d9232bc88e02cc8c17d08c0ee17dc08434e TBR: mlamouri@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1349453Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#610649}
-
Stephane Zermatten authored
Before this change, PromptAction only supported normal chips. This change adds support for displaying choice as scripts in buttons with highlights. The way this is done reproduces exactly the way buttons are configured for scripts, sharing the same logic and code. The idea is that it would help keep the two consistent. Bug: 806868 Change-Id: I82b3a49b1339e4aecd1c3dffabb826022fbac1e6 Reviewed-on: https://chromium-review.googlesource.com/c/1348050 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#610648}
-
Dave Tapuska authored
Use wtf_size_t as opposed to size_t BUG=879657 Change-Id: If00143969f0c18bbfb54b6b602e5b915e756dd3b Reviewed-on: https://chromium-review.googlesource.com/c/1349750Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#610647}
-
Dan Elphick authored
Value::ToObject(Isolate*) is deprecated because it doesn't force the user to check whether a result was actually returned. This changes MessageChannel::Create to use the Context version and calls FromMaybe on the result. This will return an empty Local if ToObject throws which would happen if its input was undefined or null (https://tc39.github.io/ecma262/#sec-toobject). Bug: v8:7279, v8:8238 Change-Id: I51c48350d1c50507d2dff6ef5c5a97cf2b03ddb5 Reviewed-on: https://chromium-review.googlesource.com/c/1344100 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#610646}
-
Sami Kyostila authored
This story is also failing on Windows. It was previously disabled on Mac. NOTRY=True TBR=charliea@chromium.org Bug: 903417 Change-Id: I23d63c76f313dd18413d7d112a5fbfd44546ffc2 Reviewed-on: https://chromium-review.googlesource.com/c/1349326Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#610645}
-
Marc Treib authored
Consents have been moved to their own data type and thus have their own Sync bridge. Bug: 905639 Change-Id: Idf4a9ee11b74eac38f158a0135a4a1998f04fe2a Reviewed-on: https://chromium-review.googlesource.com/c/1349649Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#610644}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1a5db00d4018..46505d3c656f git log 1a5db00d4018..46505d3c656f --date=short --no-merges --format='%ad %ae %s' 2018-11-23 fmayer@google.com Merge "profiling: Add convenience script to profile." Created with: gclient setdep -r src/third_party/perfetto@46505d3c656f The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I37f20422725425d102463599455c7c7ad900ac66 Reviewed-on: https://chromium-review.googlesource.com/c/1349632Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610643}
-
Mugdha Lakhani authored
Move the creation of ResponseReadyProperty to the contructor of BackgroundFetchRecord. This helps us simplify responseReady(). We can simply return the promise of the created ResponseReadyProperty every time it's called. Bug: 875201 Change-Id: Idfb97864ebbe57b770cad76d215f08177eda8175 Reviewed-on: https://chromium-review.googlesource.com/c/1349712Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#610642}
-
Tim Volodine authored
Currently flaky on KitKat phone tester bot. BUG=908118 TBR=twellington@chromium.org,eseckler@chromium.org NOTRY=true Change-Id: Id8a76dafef89d1f2098e1e9a0ebe8fd1b78c8b86 Reviewed-on: https://chromium-review.googlesource.com/c/1349654 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#610641}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/01b0845a..500be6dd Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic0a123adfab356f6344725f4cd22050e15e34eea Reviewed-on: https://chromium-review.googlesource.com/c/1349671Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610640}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f8d95114b66d..afef11dc26bd Created with: gclient setdep -r src-internal@afef11dc26bd The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I8f20a2e4ae31493f98e7fa1cd3fee6c73579b6c0 Reviewed-on: https://chromium-review.googlesource.com/c/1349631Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610639}
-
Peng Huang authored
Bug: 906688 Change-Id: If53d2ad9420440a5b9cb214b2c23fd64168187b9 Reviewed-on: https://chromium-review.googlesource.com/c/1348862Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#610638}
-
David Jean authored
Bug: 907082,907001 Change-Id: I30d4a9f0a1463f3b500cefc255b4335bde790b37 Reviewed-on: https://chromium-review.googlesource.com/c/1348109Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#610637}
-
Dave Tapuska authored
This avoids a possible truncation warning. BUG=879657 Change-Id: I533c053523c8ade81bb54b55071d4d509e834cbb Reviewed-on: https://chromium-review.googlesource.com/c/1348970Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#610636}
-
Boris Yusupov authored
to allow to migrate variations from master preferences to Local State Change-Id: I25cca8a8265e2fae57d5d0a13b053e577a9bba11 Bug: 907434 Change-Id: I25cca8a8265e2fae57d5d0a13b053e577a9bba11 Reviewed-on: https://chromium-review.googlesource.com/c/1344097 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#610635}
-
Ross McIlroy authored
BUG=v8:7290,v8:8238 Change-Id: I826a5cba05bb6c5f322ddde79eecd2f64a942045 Reviewed-on: https://chromium-review.googlesource.com/c/1349261 Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#610634}
-
Dan Elphick authored
Since all uses are preceded by IsInt32 checks, it's safe to convert all these uses to As<v8::Int32> casts. Bug: v8:7279, v8:8238 Change-Id: I6fadc29adf85294afaa4f7980353ab43add75771 Reviewed-on: https://chromium-review.googlesource.com/c/1349228Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#610633}
-
Boris Sazonov authored
This CL adds isOperationInProgress and runAfterOperationInProgress methods to SigninManager and uses these methods in SigninHelper.validateAccounts. SigninHelper has been causing many test failures recently because it attempts to start resign-in before previous sign-out is finished. Tests for isOperationInProgress and runAfterOperationInProgress will be added in subsequent CLs, as they require significant amount of changes around SigninManager (it's not quite testable at the moment). Bug: 903657, 903658, 906188, 906193, 906788 Change-Id: I216e16874adef6a050df4796eab4eb55ddf6fa6c Reviewed-on: https://chromium-review.googlesource.com/c/1345069Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#610632}
-
henrika authored
The GetMixFormat method retrieves a format descriptor that is in the form of a WAVEFORMATEXTENSIBLE structure instead of a standalone WAVEFORMATEX structure. The method outputs a pointer to the WAVEFORMATEX structure that is embedded at the start of this WAVEFORMATEXTENSIBLE structure. Note that, crbug/803056 indicates that some devices can return a format where only the WAVEFORMATEX parts is initialized and we must be able to account for that. This CL improves usage of WAVEFORMATEX/WAVEFORMATEXTENSIBLE by introducing a wrapper structure called WaveFormatWrapper. The idea is to avoid assuming that the underlying structure is extended when it actually isn't even if a WAVEFORMATEXTENSIBLE is used. Also stops using WAVEFORMATPCMEX in the utility to avoid assuming PCM format. Bug: 803056, 905969 Change-Id: I6a9fe3e23b3537df81f9d4ed610c12935668a253 Reviewed-on: https://chromium-review.googlesource.com/c/1335560 Commit-Queue: Henrik Andreasson <henrika@chromium.org> Reviewed-by:
Henrik Grunell <grunell@chromium.org> Reviewed-by:
Oskar Sundbom <ossu@chromium.org> Cr-Commit-Position: refs/heads/master@{#610631}
-
Tibor Goldschwendt authored
Update Play Core to fix a bug where SplitInstallManager.getInstalledModules would return an empty set if no module was installed as a true split. This CL is a precursor for adding the installed feature modules to crash reports. Bug: 873719 Change-Id: Ibd1715e01e504860f2124a9b9abaca027306a563 Reviewed-on: https://chromium-review.googlesource.com/c/1349009Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#610630}
-
Javier Ernesto Flores Robles authored
Running git log will reveal that Olivier has committed more than 40 CLs this folders and given that he has been a committer for more than 6 months. He meets all the criteria. Change-Id: I090289fa27abee24fcf9e46c916cb4287e15048a Reviewed-on: https://chromium-review.googlesource.com/c/1348091Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#610629}
-
Jeremy Roman authored
Bug: 736037 Change-Id: I86fec7e292751bcd7dd4a0091704a8cc79dcacc8 Reviewed-on: https://chromium-review.googlesource.com/c/1348832Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#610628}
-
Ross McIlroy authored
Also replace deprecated uses of arraysize with base::size(array). BUG=v8:7290,v8:8238 Change-Id: I1ea89bcc0162e8ac1f530be979511171d53c5467 Reviewed-on: https://chromium-review.googlesource.com/c/1349321 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#610627}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/246e02474676..1a5db00d4018 git log 246e02474676..1a5db00d4018 --date=short --no-merges --format='%ad %ae %s' 2018-11-23 fmayer@google.com Merge "profiling: Dump all on receipt of USR1 signal." Created with: gclient setdep -r src/third_party/perfetto@1a5db00d4018 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I085ebe91be19612acbea50f5f121acb8173f9ff6 Reviewed-on: https://chromium-review.googlesource.com/c/1349436Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610626}
-
Andrew Grieve authored
Bug: 906803 Change-Id: I5a9c315008a6908e2bb3aef7ac9726e20b6c1cfc Reviewed-on: https://chromium-review.googlesource.com/c/1349672Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#610625}
-
Mathias Carlen authored
Propagate the cookie experiment bool to the initial request parameters by setting it explicitly in the parameters map. This will allow the backend to make informed decisions for previously seen sites where we may not have a clean slate. Note: This parameter only gets set when the cookie experiment is enabled. Note 2: This patch introduces a different pattern to set parameters not actually provided by callers. Bug: 806868 Change-Id: Ibe7b19ad8bda2636e531884b89928d3a9cebb0f1 Reviewed-on: https://chromium-review.googlesource.com/c/1349226Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#610624}
-
Mathias Carlen authored
Bug: 806868 Change-Id: I17f1e150ed5cf5d14124086717364c7ac7c5d21a Reviewed-on: https://chromium-review.googlesource.com/c/1349319Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#610623}
-
Michael Lippautz authored
Change-Id: Id380da541c8ed38ca1c07df6c53f7fddd2fc9b82 Reviewed-on: https://chromium-review.googlesource.com/c/1349312Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#610622}
-
sebsg authored
This will be used to record whether a user has opted in to seeing their Google Account cards in the Autofill dropdown. The dictionary should not contain info about accounts that are not opted in. Bug: 907929 Change-Id: Icc663b228792c58b00c02b204249fba9f557481b Reviewed-on: https://chromium-review.googlesource.com/c/1348792Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#610621}
-
Jeremy Roman authored
Bug: 736037 Change-Id: I4c0bf2d3d374fbd659c7c70383e68c8102ef80f3 Reviewed-on: https://chromium-review.googlesource.com/c/1349494Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#610620}
-
Dan Elphick authored
Also rebaselines the tests to match. Bug: v8:7279, v8:8238 Change-Id: I4ba0aa32c5048a4a7e7a86ebf7481f048c13c95c Reviewed-on: https://chromium-review.googlesource.com/c/1349225Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#610619}
-
Sami Kyostila authored
The following perf tests are often timing out on Android: - JSONPerfTest.StressTest - ObserverListPerfTest/1.NotifyPerformance - ScheduleWorkTest.* This patch disables them on Android until they are be investigated. TBR=gab@chromium.org Bug: 906686 Change-Id: Iad78d71e1b3293a75834b06a2b7b4b13b7ac5e75 Reviewed-on: https://chromium-review.googlesource.com/c/1349711Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#610618}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c7c809224d90..f8d95114b66d Created with: gclient setdep -r src-internal@f8d95114b66d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I61b503b4d48b2841007cb07fefeadd8960c31802 Reviewed-on: https://chromium-review.googlesource.com/c/1349435Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610617}
-
Chromium WPT Sync authored
Using wpt-import in Chromium b5906a4d. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: guidou@chromium.org: external/wpt/mediacapture-streams NOAUTOREVERT=true TBR=markdittmer No-Export: true Change-Id: If546c1f899ae3bef760513114c7811080594ab98 Reviewed-on: https://chromium-review.googlesource.com/c/1349493 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610616}
-
Dave Tapuska authored
While not possible the compiler still generates errors without casts. BUG=879657 Change-Id: I1975197135c8ab2bd0723360180d851b8be17e93 Reviewed-on: https://chromium-review.googlesource.com/c/1348954Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#610615}
-
Nicolás Peña Moreno authored
This reverts commit 9703d737. Reason for revert: compile failure https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Builder/42183 Original change's description: > Disable failing zipFileOpenDownloadsEncryptedCancelPassphrase. > > linux-chromeos-rel currently fails this test. > > TBR=amistry@chromium.org > > Bug: 908071 > Change-Id: Iff70ff9c3cc4eb455b48f4effaa3befc441d52b4 > Reviewed-on: https://chromium-review.googlesource.com/c/1349345 > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > Commit-Queue: Rune Lillesveen <futhark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610609} TBR=amistry@chromium.org,futhark@chromium.org Change-Id: Id22fd9c845a0656c16b939930a6ea37474eaec8a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 908071 Reviewed-on: https://chromium-review.googlesource.com/c/1349497Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#610614}
-
Nicolás Peña Moreno authored
This reverts commit 0850df10. Reason for revert: the culprit CL was reverted, no longer needed. Original change's description: > EventTiming: mark event-timing-onloadthenobserve.html as flaky on Mac > > Bug: 907948 > TBR=tdresser@chromium.org > > Change-Id: I53d328b935ab235e441f555e625aa97fac1b9ea4 > Reviewed-on: https://chromium-review.googlesource.com/c/1349033 > Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> > Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610519} TBR=tdresser@chromium.org,npm@chromium.org Change-Id: Ib20b5fd4bf0cf147518967ede801d9092e7a7112 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 907948 Reviewed-on: https://chromium-review.googlesource.com/c/1349496Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#610613}
-
Gauthier Ambard authored
This CL adds EG test for testing the Switch to Open Tab feature. The covered test cases are: - Check that it is possible to switch to an open tab, - Check that if you switch tab, your previous tab isn't closed, - Check that the incognito tabs aren't taken into account in non-incognito and vice-versa, - Check that the current page doesn't have the switch button. Bug: 908010 Change-Id: I9434ef8cf2b41b55ab59f70aec48aea282d2401e Reviewed-on: https://chromium-review.googlesource.com/c/1349331Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#610612}
-