- 07 Sep, 2019 28 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/bd6c633b6e72..0dbf1e37194c git log bd6c633b6e72..0dbf1e37194c --date=short --no-merges --format='%ad %ae %s' 2019-09-06 rmhasan@google.com [Telemetry] Add system condition tags frozen set to typ expectations module Created with: gclient setdep -r src/third_party/catapult@0dbf1e37194c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sadrul@google.com Bug: chromium:999335 Change-Id: Ib3f65be7c663783c62bf14c6e7fcf71f2209f1ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789979Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694513}
-
Cici Ruan authored
Currently, the AutotestPrivateTakeScreenshotFunction returns the primary screenshot. To get the screenshot of external displays, it adds another api AutotestPrivateTakeScreenshotForDisplayFunction. It helps take the screenshot of specific display. Bug: b/134981068 Test: Call the api to see if it gets the screenshot as needed. Change-Id: Ic46637b0828aa76a068c6b52358082a6323b4548 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779177 Commit-Queue: Cici Ruan <cuicuiruan@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Auto-Submit: Cici Ruan <cuicuiruan@google.com> Cr-Commit-Position: refs/heads/master@{#694512}
-
Rachel Wong authored
This change adds three metrics: 1. The position index of the launched item. 2. The number of item types included in each impression set. (Diversity) 3. Whether or not an item was clicked. (CTR) Bug: 999912 Change-Id: I0a725c141f353f4fb89cd04110cf9731d01f96fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781124Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#694511}
-
Miyoung Shin authored
This CL converts MediaSessionServiceRequest in content to the new Mojo types. Bug: 955171 Change-Id: Iafc4e62a19235d6bf70cca084ae0769d7c1e441c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782459Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#694510}
-
Xing Liu authored
The display flow in ScheduledNotificationManager is now asychronous, so the glue layer must track all DisplayNotification calls and its result, and do things after all display flows are done. This CL adds a DisplayCallback which replaces Delegate. Bug: 998980 Change-Id: I88201232d882a4292bbf729c5906ab5644ab154e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787563 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#694509}
-
Nate Fischer authored
No change to sample rate - this still samples at 2% for all channels. This changes the logic for computing when a client is in-sample, in a way which generalizes better to arbitrary sample rates. This also supports varying sample rate by channel, although the stable and beta/dev/canary rates are still currently the same. The eventual goal is to change the sample rate for beta/dev/canary to 99%, for consistency with Chrome. Bug: 969803 Test: Start up WebView hundreds of times, log if in sample group, judge if numbers are OK Change-Id: Ia68124434cea768f5e2a59ca88d3121f0829a48b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742770 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#694508}
-
Johannes Henkel authored
Bug: 1001678 Change-Id: Iba6f8db30dfdaa84e77c6e005bfa131d6bc7704a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789976 Auto-Submit: Johannes Henkel <johannes@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#694507}
-
Miyoung Shin authored
This CL converts MediaStreamTrackMetricsHost{Ptr, Request} in content to the new Mojo types. Bug: 955171 Change-Id: Ica78f4ad4b2f804392cace05492d56ed4a36f7c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783684Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#694506}
-
Xianzhu Wang authored
Bug: 994361 Change-Id: I04957f751b340f7c0775b6022ef2ca782ed32e4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787569 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#694505}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/65c12be8d1d3..ca5820a7d61c Created with: gclient setdep -r src-internal@ca5820a7d61c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I2d29b39ec0ac8280cff218e0f002e43029310ced Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790261Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694504}
-
Jérôme Lebel authored
Removing IdentityDisc feature flag. Bug: 1001073 Change-Id: I9ab7c1e7867bc51583fb287d94dd94c20acf25a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786647 Commit-Queue: Peter Lee <pkl@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#694503}
-
Xianzhu Wang authored
The previous calculation was: local_offset = hit_test_location - accumulated_offset - inner_editor->PhysicalLocation(); which was correct when the inner editor was the top element in the shadow dom or its PhysicalLocation included all offset from the text control. In a search input box, there are extra levels of layout objects between the text control and the inner editor. We need to exclude all offsets from the text control to the inner editor when calculating the local offset. Bug: 1000657 Change-Id: If1053ceffe556c2ca5be4639b21e669465c93b0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789983 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#694502}
-
Lei Zhang authored
It is just as easy to give the code within those namespaces unique names. This is more consistent with the naming scheme elsewhere in chrome/. e.g. ChromeAppsAPIProvider and ChromeContentClient. Change-Id: I0f79aaf1bb00f61fb6599dfabb9ddf1f5ff4ad23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790276Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#694501}
-
Tommy Steimel authored
Bug: 940049 Change-Id: Ib90a9eb315e19308c6d2b171d2ff7d57777cc84d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789784 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#694500}
-
Shimi Zhang authored
This is a followup of http://crrev/c/1685837. See more at https://docs.google.com/document/d/1Jwfbzbe8ozaoilhqj5mAPYbYGpgZCen_XAAAdwmyP1E/edit Bug: 955171 Change-Id: Iaa528bed1f3909a60f1c5db5bd01bf575ecd2cd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787168 Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#694499}
-
Nico Weber authored
Bug: 961769 Change-Id: I15c6a610aba1d90d976183be8053cf3829e16423 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789425 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#694498}
-
Milad Farazmand authored
Recent CLs on V8 have been starting to use c++14 features, such as this: https://chromium-review.googlesource.com/c/v8/v8/+/1786284 Having the hard coded "gnu++11" flag causes the compilation to fail on AIX. Change-Id: Iffd74e3aed00711c8c344ea278b9533079f52ffa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789965Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#694497}
-
Maksim Sisov authored
As long as the conformance tests[1,2,3,4] on AMD drivers with Mesa >= 19 now pass, disable the workaround for newer drivers. [1] https://www.khronos.org/registry/webgl/sdk/tests/conformance/canvas/draw-webgl-to-canvas-test.html [2] https://www.khronos.org/registry/webgl/sdk/tests/conformance/canvas/draw-static-webgl-to-multiple-canvas-test.html [3] https://www.khronos.org/registry/webgl/sdk/tests/conformance/rendering/draw-webgl-to-canvas-2d-repeatedly.html [4] https://www.khronos.org/registry/webgl/sdk/tests/conformance/textures/misc/tex-image-webgl.html Bug: 1000113 Change-Id: I3ea93121eaa1f363fe11c742158ef8bd3e0a953c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787615 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#694496}
-
Lambros Lambrou authored
This updates do_signing.sh for the new signing requirements in MacOS 10.15. This CL: * Passes --timestamp to the signing commands. * Signs the final DMG image. * Refactors the commands to avoid duplication in the keystore/no-keystore cases. Bug: 999402 Change-Id: I128a7e087f1d5019ae344b5c7e4ad041e500452b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790735 Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Gary Kacmarcik <garykac@chromium.org> Auto-Submit: Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Cr-Commit-Position: refs/heads/master@{#694495}
-
Sammie Quon authored
If there is odd number of windows, then closing the last window will leave a large gap. Fix this by shifting |scroll_offset_| before positioning windows. Long press used to be required for swipe to close. It can now be closed without a long press, just a vertical scroll is enough. Did one TODO and removed two obsolete ones. Test: manual, added tests Bug: 978112 Change-Id: I9d491ea232e2133fa28f86f299a0a69fbf971017 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788220 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#694494}
-
Yuchen Liu authored
This is a reland of 9035a391 Original change's description: > [Fuchsia][EME] Audio decryptor > > Implement FuchsiaDecryptor (audio part) with StreamProcessor. > > This CL also copies logic from FuchsiaVideoDecoder into > StreamProcessorHelper and SysmemBufferPool. > > StreamProcessorHelper is a wrapper for StreamProcessor. > > BufferPool is a wrapper of BufferCollection. > > Caller is expected to create and own input/output BufferPool in its own > class and interact with StreamProcessorHelper by buffer index. > > The new classes will be shared between FuchsiaVideoDecoder and > FuchsiaDecryptor in the future. > > component successfully. > > Bug: 966191 > Test: Shaka player demo "Dig the Uke", log shows connecting to fuchsia > Change-Id: Ia0bd63e9ff39eaf4b6f477ac542fcbefe9c86e46 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764179 > Reviewed-by: Xiaohan Wang <xhwang@chromium.org> > Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> > Commit-Queue: Yuchen Liu <yucliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#694024} Bug: 966191 Change-Id: I2ffbe2ca2835de16468f3babcd3419e92c7677da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789835 Auto-Submit: Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#694493}
-
Rafael Cintron authored
CL accomplished the following things: * Allows creation of GLImage3D with a texture and no swap chain * Rework WebGPUDecoderImpl::CreateDefault device to pick an adapter that is compatible with the rest of Chromium. * Eliminate SharedImageFactory::d3d_backing_factory_ in favor of using interop_backing_factory_ and gate swap chain creation on return value of IsSwapChainSupported instead of presence of d3d_backing_factory_ * Add SharedImageRepresentationDawnD3D that manages the Dawn texture and destroys it on EndAccess * Refactors SharedImageBackingD3D to be created from either a swap chain or d3d11_texture and optional shared handle. Bug: 999732 Change-Id: Icfea4601d06b84e036d5ab6d6a8dee805add80e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777075 Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#694492}
-
Dan Harrington authored
Change-Id: I80ee27bb1933a38a6a27c338b853a6acec0e51bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669757 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dmitry Titov <dimich@chromium.org> Cr-Commit-Position: refs/heads/master@{#694491}
-
Ahmed Mehfooz authored
Remove RTL handling in toolbar_ink_drop_util since it's taken care of by inkdrops. Fix inkdrop highlight flip to use GetLocalBounds instead of GetContentsBounds. Bug: 1001417 Change-Id: I93c3cbe9badd9fa0f22b833e1634392e43998ebe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790407Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#694490}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/19f3c21a61d3..bd6c633b6e72 git log 19f3c21a61d3..bd6c633b6e72 --date=short --no-merges --format='%ad %ae %s' 2019-09-06 rmhasan@google.com [Telemetry] Return user friendly names for Android OS version names Created with: gclient setdep -r src/third_party/catapult@bd6c633b6e72 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sadrul@google.com Bug: chromium:999335 Change-Id: I3800d5c5f5482c6e397b5c7271ebd72d143d05e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789834Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694489}
-
Mike Wittman authored
Android will use signal-based stack copying so only needs to implement the ThreadDelegate interface, not SuspendableThreadDelegate. No functional change is intended. TBR=gab@chromium.org Bug: 988579 Change-Id: I618fff36911860fafcb06e8cf88b28d37f51c6c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762840 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#694488}
-
Jarryd authored
Bug: 897276 Change-Id: Ic79a581dde8b49c9c4194c1f24a2a0989d19bb81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1701955 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#694487}
-
Jordan Taylor authored
The fix will explicitly pass in any required params instead of relying on a partially updated member variable. Bug: 994850 Change-Id: I1f27866105c939ccaf6584828c3ba25e5dc12b8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780910 Commit-Queue: Jordan Taylor <jortaylo@microsoft.com> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#694486}
-
- 06 Sep, 2019 12 commits
-
-
Sergey Ulanov authored
GPU process is leaking memory when Vulkan is enabled. Disable Vulkan temporarily until that issue is resolved. Bug: 1001296 Change-Id: I4f4bd55b0a1cf5690b8bcfee8dccce5babb1de58 TBR: wez@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790411Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#694485}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c30f1a936d84..08b68dba6a8d git log c30f1a936d84..08b68dba6a8d --date=short --no-merges --format='%ad %ae %s' 2019-09-06 cblume@chromium.org Add blocklist command line parameter 2019-09-06 egdaniel@google.com Revert "Add support for direct use of vulkan primary command buffer in render pass." Created with: gclient setdep -r src/third_party/skia@08b68dba6a8d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jlavrova@google.com Bug: chromium:842296 Change-Id: I3abb6030a4c1797662dbe97f1718f3e3e4bd60c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789837Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694484}
-
yilkal authored
This CL adds SupervisedUserIframeFilter feature flag. Bug: 850328 Change-Id: I5e06f250d7a5024412d28b5878cb3db0397705ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771950 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#694483}
-
Dominic Mazzoni authored
Bug: 654768 Change-Id: I3af203c48310587a6b4ff05226275cac89f6e575 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783437Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#694482}
-
Rune Lillesveen authored
StyleForElement doesn't create ancestor computed styles as necessary to do inheritance correctly. Noticed the listed TEST would trigger a sanity DCHECK in StyleForElement() for another CL. Without this change we would inherit styles from initial styles instead of the parent element. TEST=accessibility/name-calc-visibility.html TEST=inspector-protocol/accessibility/accessibility-nameSources-visiblity.js Change-Id: Icd6d669b0ff04f97fcdd637530f56619e8b1f3f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789233Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#694481}
-
Mike Wittman authored
Moves the thread delegate functions that only apply to signal-based stack copying into a top-level interface. This will allow the signal-based copying to depend on only the functions that it requires. No functional change is intended. TBR=gab@chromium.org Bug: 988579 Change-Id: I8a60b69779aec748bccdd9cb3bb672c23d849879 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762950 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#694480}
-
Alex Leung authored
This reverts commit c10518d1. Reason for revert: Previously CL was only reverted due to a merge conflict. Change-Id: I0c3ac6584a65b89d6a6516b1e8a2b6cd34f170d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783241Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Alex Leung <alexleung@google.com> Auto-Submit: Alex Leung <alexleung@google.com> Cr-Commit-Position: refs/heads/master@{#694479}
-
Yun Liu authored
chrome_public_smoke_test: all Android versions chrome_modern_public_smoke_test: L, M monochrome_public_smoke_test: N, O, P Bug: 970083 Change-Id: Ibd646b0d94a6e7dfa21274cb2bce687ecdceb5e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785092Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Andrew Luo <aluo@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Yun Liu <yliuyliu@google.com> Cr-Commit-Position: refs/heads/master@{#694478}
-
Caleb Rouleau authored
R=perezju@chromium.org TBR=perezju@chromium.org Bug: 1000426 Change-Id: I2df03c431ce523a7407eadfbf22f890d80efa297 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789479 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#694477}
-
Dale Curtis authored
As noted in 69e8f306 we need to preroll in all cases prior to kHaveFutureData. That patch only partially restored the correct behavior though. It fixed IsPrerollAttemptNeeded(), but did not fix the early-out code which is run upon preroll attempt. BUG=986021 Change-Id: I1129b45c7294a6f55bfe59a74094fe7cf5c39649 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790095 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#694476}
-
John Rummell authored
As writing the file is done asynchronously, when the test doesn't wait for the write to complete but closes the file immediately, it is possible that the write succeeds. So updating the test to check that the result of reading the reopened file is either the original contents or the updated contents (i.e. the file was not corrupted). As the test succeeded locally before this change, tried with the file parameters to EXPECT_FILE_READ_EITHER() in both orders. Bug: 999421 Test: Updated test succeeds Change-Id: I7c9a3d948b3a93ccc878b28d1fd4f5bed5e1015c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787590Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#694475}
-
Yue Zhang authored
Currently, the drag-and-drop IPH animation uses startOffset to specify the timeline for animation. However, there is a Android bug that startOffset won't work for AnimatedVectorDrawable in some versions. This CL replaces startOffset usage with a workaround. Bug: 1001666 Change-Id: I4e7eb5c433105bcf745c8d2b871eb73a4e04d9cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789832Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#694474}
-