- 22 Mar, 2018 40 commits
-
-
yoshiki iguchi authored
If the notification view is invalid state, FindVisibleNotificationById may returns null and it caused the crash. This CL fixes it. Bug: 824039 Test: None Change-Id: I0ebc0ddd0cd77c9af235bef07a92fe635135e96c Reviewed-on: https://chromium-review.googlesource.com/974665Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#545020}
-
Mitsuru Oshima authored
Done by mass-rename.sh BUG=735078 TEST=None Change-Id: I2d111218065a991817534f4cc4a3f3d974f2c8c1 Reviewed-on: https://chromium-review.googlesource.com/967049 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#545019}
-
Yuhong Sha authored
The specification for DOMTokenList's replace() method which would make it return a boolean. Indicating true if a token was replaced, and false otherwise. Bug: 820988 Signed-off-by:
Yuhong Sha <yuhong.sha@samsung.com> Change-Id: I8e500a74a2504e13522c4e85b17d441cd2d4299f Reviewed-on: https://chromium-review.googlesource.com/965683Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#545018}
-
Marc Treib authored
GoogleURLTracker registers itself as a NetworkChangeObserver at the NetworkChangeNotifier singleton, and unregisters itself again in Shutdown(). In non-test code, GoogleURLTracker is a KeyedService and so its Shutdown() gets called at the proper time automatically. But in unit tests that instantiate it directly, we have to explicitly call Shutdown(), otherwise we leave behind a dangling pointer. Bug: 823858 Change-Id: Idc215823ad81c983c8693c04688eccce40f9f26c Reviewed-on: https://chromium-review.googlesource.com/973603Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#545017}
-
Jan Wilken Doerrie authored
This change fixes GattServicesDiscovered on Windows to only be called once all services, characteristics and descriptors are discovered. Furthermore it removes the deprecated GattDiscoveryCompleteForService notification. Bug: 507419, 821766 Change-Id: I234409cb159a022e0443b8c2d2a4b1c90fac9b15 Reviewed-on: https://chromium-review.googlesource.com/850357Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Conley Owens <cco3@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#545016}
-
Gauthier Ambard authored
This CL adds a switch used to change the positions of the toolbars buttons, allowing to test different layouts. The 3 layouts possible are: - Navigation controls in the bottom and nothing in top toolbar (default) - Navigation controls in the bottom and share button in the top toolbar - Navigation controls in the top toolbar and bookmark/share in the bottom toolbar Those layout will mainly change the visibility of the different buttons. Also the second forward button is added to the toolbar views. Bug: 824175 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I8e76b081038fb444bdac8f9e823dc023b4b9e883 Reviewed-on: https://chromium-review.googlesource.com/973609 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#545015}
-
Nick Carter authored
Three refactorings are done, as follows: 1. Loader's "loader_" member becomes "threadable_loader_" Rationale: This aims to reduce confusion between the Loader type, its "loader_" member, the ThreadableLoader type, and the SRIVerifier::loader_ member, which are all used in this same cpp file. 2. Loader's "request_" member becomes "fetch_request_data_". Rationale: to reduce confusion with the |request| local variable that's used in FetchManager::Loader::PerformHTTPFetch(). PerformHTTPFetch() references both |request| and |request_| extensively, resulting in code that is very hard to follow, since they have different types. 3. Add a using-decl for network::mojom::FetchRequestMode. Rationale: this typename is used more than twenty times times in this file; a using-decl cuts down on the noise. Bug: Change-Id: I077f30fb08aebe8fe3e5f8911a2eb6df614df9cc Reviewed-on: https://chromium-review.googlesource.com/731620Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#545014}
-
tzik authored
Change-Id: If9fec539c2fc140d755033a1ed5dbaff141230d4 Reviewed-on: https://chromium-review.googlesource.com/974725Reviewed-by:
-
Olivier Robin authored
The current autofill implementation uses the name field for two usages - it is used as a hint to infer the type of the field - it is used as a technical pointer to the field that will be used to fill the field later. This has multiple consequences: - if multiple fields have the same name, there is a collision when autofilling, - if a field name is empty, there is no way to set its value using autofill, - any workaround on these issues may have consequences on the type of field deduction. On the other hand, form_field_data has an id field that is not used on iOS. This CL splits the name field in two The name will be used to deduce the field type in the form. The name of the field is (in order of priority) - the name attribute if present, - the id of the element if present. Otherwise, the name field is empty. This restores the behavior of the name field before https://chromium-review.googlesource.com/751241 This can be extended using other attributes known to carry information on content as suggested in crbug.com/791578. The identifier will be used as a unique identifier of the field and is the key to set the field value. The identifier is (in order of priority) - the id of the element if present. - the name attribute if present and in a form, - the index of the control element in the form if the element is in a form - an XPath query pointing to the element consisting in the closest ancestor with an ID, then the index of the element with the same tag name. This identifier *cannot* be empty. The JS API does not provide a way to retrieve an element knowing its identifier. Retrieving it requires to loop through the potential matches and check the identifier. Bug: Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ieaa196d8fb9a55d7c446ffbfe39a3ea6699c9acf Reviewed-on: https://chromium-review.googlesource.com/814434Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#545012}
-
https://pdfium.googlesource.com/pdfium.git/+log/19a33e4ece99..0f494c86440d $ git log 19a33e4ec..0f494c864 --date=short --no-merges --format='%ad %ae %s' 2018-03-22 thestig Roll DEPS for buildtools to 3748a2a9 2018-03-22 thestig Roll DEPS for build to 4b1fc75d 2018-03-22 thestig Remove testing/{gmock,gtest}/dummy. 2018-03-22 thestig Update gtest and gmock to 1.8.x. 2018-03-22 thestig Add testing/{gmock,gtest}/dummy. Created with: roll-dep src/third_party/pdfium BUG=chromium:823586,chromium:823586 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I23df90f832e9981f4c07702dabdb325b155055f4 Reviewed-on: https://chromium-review.googlesource.com/974901 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#545011}
-
Gyuyoung Kim authored
Embedded devices have limited storage capacity generally. So current maximum disk cache size(250MB) can make their storage fully used in the embedded devices. For the embedder, it would be good if we give the power them to set the maximum disk cache size through the command line. Bug: 824619 Change-Id: Ib4fae34934eadf23f1165907b5c547fff205b827 Reviewed-on: https://chromium-review.googlesource.com/974804Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> Cr-Commit-Position: refs/heads/master@{#545010}
-
https://skia.googlesource.com/skia.git/+log/f5720cc4d1dd..4259797efdf3 $ git log f5720cc4d..4259797ef --date=short --no-merges --format='%ad %ae %s' 2018-03-22 update-docs Update markdown files Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: I5d5854743c09f0bce07b0f3b6d0e0cee4278e05d Reviewed-on: https://chromium-review.googlesource.com/974902 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#545009}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9f531298e1a3..869a2857a4f3 $ git log 9f531298e..869a2857a --date=short --no-merges --format='%ad %ae %s' 2018-03-22 thestig Revert "Add debugging info when gclient deletes an old DEPS entry." Created with: roll-dep src/third_party/depot_tools BUG=chromium:823586 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ief0ad99707d16924e86b7b1f475310fc71bd7b82 Reviewed-on: https://chromium-review.googlesource.com/974897Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#545008}
-
Henrik Grunell authored
This reverts commit 13dc6be4. Reason for revert: Broke official Chrome builder. Original change's description: > Remove localhost from Hangouts services extension manifest. > > Bug: 819406 > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: I9ec4028146c3a561f847a649848c5c16dde6e2a8 > Reviewed-on: https://chromium-review.googlesource.com/951684 > Reviewed-by: Patrik Höglund <phoglund@chromium.org> > Commit-Queue: Henrik Grunell <grunell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#544656} TBR=grunell@chromium.org,phoglund@chromium.org,jansson@chromium.org Change-Id: Id11dbe77e63a4ca73badce8efe959f601ccf4306 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 819406, 824632 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/974382Reviewed-by:
Henrik Grunell <grunell@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#545007}
-
https://chromium.googlesource.com/angle/angle.git/+log/3395c8b96333..8b92c53b8a8c $ git log 3395c8b96..8b92c53b8 --date=short --no-merges --format='%ad %ae %s' 2018-03-22 jmadill Skip EnableQueryExtensions test on Win/AMD/GL. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: Ie4d5ac12678842c41765eb3ff5585a4cf43adeaa Reviewed-on: https://chromium-review.googlesource.com/974890Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#545006}
-
Rudy Xie authored
This client is needed by downstream (Mountain) repo. Bug: b/75308868 Change-Id: I06829202017f8244db7787ff0cb3f09b01662032 Reviewed-on: https://chromium-review.googlesource.com/972224Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
-
Gauthier Ambard authored
This CL adds the metrics for the new tools menu actions. Bug: 804770 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ic39f8043906b7c5db2cd6ed390a6afbcf5f5037c Reviewed-on: https://chromium-review.googlesource.com/973601Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#545004}
-
Tom Anderson authored
BUG=787020 TBR=thestig,dpranke CC=drott Change-Id: I794aab43f62f9c56f00a8c4d9d3959f1a8f36e85 Reviewed-on: https://chromium-review.googlesource.com/973560 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#545003}
-
Michael Lippautz authored
Bug: chromium:757440 Change-Id: I3b691a2ac8ca9d10a5540fe7385f2278cdef94ec Reviewed-on: https://chromium-review.googlesource.com/973169 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#545002}
-
Kent Tamura authored
- Rename DataLogF() to DeprecatedDataLogF(). - Remove commented-out code in Heap.cpp - Prevent us from adding new dependencies on DataLog.h This CL has no behavior changes. Bug: 720442 Change-Id: I188ef5a69f3426b8b49eea508e50f68fa744f7a0 Reviewed-on: https://chromium-review.googlesource.com/974807 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#545001}
-
Qiang Xu authored
changes: For contacts that don't have profile photo set, the image info passed to chrome is null. This CL handles this case. We should provide appropriate default images for this case on Chrome side. Android side change: ag/3774689. Bug: 818902 Test: manual test Change-Id: I03ebe42d8c8930b25c50a3968a9c7c89477f6a76 Reviewed-on: https://chromium-review.googlesource.com/973552Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
-
Lei Zhang authored
Change-Id: I09440837fddc4ed6a7163b6adcd08ee7ef13634a Reviewed-on: https://chromium-review.googlesource.com/973915Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#544999}
-
oka@chromium.org authored
Bug: 805369 Test: Fix failed test and `git cl try` Change-Id: If77f7d2502cb17891d82914928c031f62d4e5f94 Reviewed-on: https://chromium-review.googlesource.com/954163Reviewed-by:
Blake O'Hare <blakeo@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Keigo Oka <oka@chromium.org> Cr-Commit-Position: refs/heads/master@{#544998}
-
Koji Ishii authored
Following bot results are included. 4316 4317 4318 4320 4321 4322 1 lines were removed and 1 lines were deflaked by consecutive results since 4288. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I53b86a1df9840baa0c0b1a50199d60047d09c469 Reviewed-on: https://chromium-review.googlesource.com/973422 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#544997}
-
Joe Downing authored
This change moves the KeyboardLock API methods to a 'keyboard' namespace on the Navigator object. We are doing this work now as there has been a request for additional keyboard functionality that would also be placed on the new keyboard object and we wanted to move the KeyboardLock methods there for consistency before we launch. KeyboardLock API Spec is here: https://w3c.github.io/keyboard-lock/#API Old calling pattern: Navigator.keyboardLock(); Navigator.keyboardUnlock(); New calling pattern: Navigator.keyboard.lock(); Navigator.keyboard.unlock(); Note: The main logic in the KeyboardLock.cpp class and tests is the same as it was, however the file changed enough that git does not recognize it as a file move. BUG=680809 Change-Id: I234b2ab12d5ecd44c894ed5103863fd96fd548d4 Reviewed-on: https://chromium-review.googlesource.com/969656Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Reviewed-by:
-
Kent Tamura authored
as well as third_party/WebKit because we'll move third_party/WebKit/{Source,common,public} to third_party/blink soon. Bug: 622551 Change-Id: Ib916a70651318dadc333416d8ca49927bceba1cb Reviewed-on: https://chromium-review.googlesource.com/952946Reviewed-by: -
Yoshifumi Inoue authored
This patch moves paragraph granularity related tests from "VisibleUnitsTest.cpp" to "VisibleUnitsParagraphTest.cpp" for ease of maintenance. Change-Id: I5bd49913a6407e2bcc74bda0a96aff3c7d066386 Reviewed-on: https://chromium-review.googlesource.com/970381Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#544994}
-
Yafei Duan authored
In this CL: - Removed unused methods from ArchiveManager. - Reporting more storage stats from ArchiveManager, for multiple archive directories. - Fixed multiple tests related. There will be a followup change based on this one for reporting storage related UMAs from OfflinePageModelTaskified. Bug: NONE Change-Id: I8f9d2837b4c47a1f88fd380c86f63d0f5340c6e0 Reviewed-on: https://chromium-review.googlesource.com/967561 Commit-Queue: Yafei Duan <romax@chromium.org> Reviewed-by:
Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#544993}
-
https://skia.googlesource.com/skia.git/+log/4d4b3aaa20e1..f5720cc4d1dd $ git log 4d4b3aaa2..f5720cc4d --date=short --no-merges --format='%ad %ae %s' 2018-03-22 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 8574357f1..3395c8b96 (5 commits) 2018-03-21 mtklein back to individual flags for :hsw 2018-03-20 benjaminwagner Remove some MSVC 32-bit Perf/Test jobs. 2018-03-21 ynovikov update_meta_config: Use new LUCI optional GPU Android trybot 2018-03-21 borenet [infra] Use new LUCI Mac trybot 2018-03-21 caryclark limit discrete path effect iterations 2018-03-21 joe Add Node as a bot asset. Created with: roll-dep src/third_party/skia BUG=chromium:731979,chromium:824467 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: Ie69305f18965af2a4aa09b0c4dd129e83e72f70c Reviewed-on: https://chromium-review.googlesource.com/974757Reviewed-by:
-
Kent Tamura authored
It is a list of exceptional rules, and contains some Source/ paths. Bug: 578345 Change-Id: I17e65d35c4809b9c91217db086e1af10d82dea54 Reviewed-on: https://chromium-review.googlesource.com/974605 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#544991}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 863a31fc. With Chromium commits locally applied on WPT: 1c4a06ae "Make Range::intersectsNode() to follow the spec" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/14334 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-request TBR=robertma No-Export: true Change-Id: If30ad24bb4212460dde70e1bca739f51308f0797 Reviewed-on: https://chromium-review.googlesource.com/974799 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#544990}
-
Kent Tamura authored
Bug: 578345 Change-Id: Ic323ea326224eedfe84d1c9902fcaccaae853d9e Reviewed-on: https://chromium-review.googlesource.com/974803Reviewed-by:
-
Tetsui Ohkubo authored
According to UX spec, UnifiedSystemTray supports collapsed state. This CL * Adds SetExpanded to FeaturePodButton. If false, it hides labels. * Adds SetExpanded to FeaturePodsContainerView. If false, it uses layout that places all the buttons horizontally. Buttons exceed the limit will be hidden in the collapsed state. To support this behavior, FeaturePodButton::SetExpandedByContainer is also added. * Adds SetExpanded to UnifiedSystemTrayView and puts all sliders to |sliders_container_|, so that it can be easily hidden when collapsed. * Adds FeaturePodsContainerViewTest unit tests. Screencast: http://go/scrcast/NTk3Mzg1NzQwMzkyODU3NnxhZTNmMDI2ZS1kNA UnifiedSystemTray design doc: go/cros-qs-restyling TEST=FeaturePodsContainerViewTest BUG=819942 Change-Id: Ic7b7bcf56f1405b9eb0babab8f041f5a83d361f2 Reviewed-on: https://chromium-review.googlesource.com/964031Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#544988}
-
Xiaohan Wang authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8bf5a724397c..a1ec7e112c5e $ git log 8bf5a7243..a1ec7e112 --date=short --no-merges --format='%ad %ae %s' 2018-03-21 xhwang chrome-sdk: Remove Widevine CDM adapter 2018-03-17 pberny atlas: Add master builder configuration Created with: roll-dep src/third_party/chromite TBR=achuith@chromium.org,vapier@chromium.org BUG=772160,823986 Change-Id: I12d8487657339b574b5285c6598a84e14fa4afed Reviewed-on: https://chromium-review.googlesource.com/974798Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#544987}
-
Kent Tamura authored
- Jinja template files have .tmpl extension now. - Remove should_skip_with_warning() We have no files match to _SKIPPED_FILES_WITH_WARNING. - Remove non-existent files from _SKIPPED_FILES_WITHOUT_WARNING. Change-Id: I5e7e11bc806cd4da3ad46aa1981e34ae5286c944 Reviewed-on: https://chromium-review.googlesource.com/974722Reviewed-by:
-
Jamie Madill authored
It seems new drivers have a regression with 3D textures. Bug: angleproject:2424 No-try: True Tbr: kbr@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Id1a94b1b95206551f6fd504043cf2fe0b48bbb56 Reviewed-on: https://chromium-review.googlesource.com/974459Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#544985}
-
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ca08cc1b0773..6ad0221d7539 $ git log ca08cc1b0..6ad0221d7 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src-internal The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: If701aa0d0e8e10f1e66804928ed57423f233643b Reviewed-on: https://chromium-review.googlesource.com/974711Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#544984}
-
Hiroki Nakagawa authored
This CL supports ES Modules on DedicatedWorker behind the ModuleDedicatedWorker flag and adds WPT tests. With the flag, you can specify 'type' option on the constructor of DedicatedWorker (i.e., new Worker) to start a dedicated worker as a module script. On DedicatedWorkerGlobalScope, static import is available, but dynamic import() hasn't been implemented yet. Bug: 680046 Change-Id: I3aca350228ec07be7884c7a2eb8cd351e7fd6b6e Reviewed-on: https://chromium-review.googlesource.com/967908 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#544983}
-
Jeremy Roman authored
bit_cast is more correct (memcpy, unlike use of inactive union members, is blessed by the standard), and besides, all uses are in WTF, which can use base. Change-Id: Ia9ac40c692db72d9339934e33e4c4ffbe7443bef Reviewed-on: https://chromium-review.googlesource.com/974318 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
-
tzik authored
This CL changes the ownership of base::Clock and base::TickClock from injectee-owned to injecter-owned. Before this CL, these instances are owned by the owner of the injectee or one of the injectees themselves. That makes the ownership handling complex. After this CL, the injectee of clocks never own the clock. Instead, injecters owns a clock for testing, and a shared clock is used on the production code. Bug: 789079 Change-Id: Ibd4de27bb774c8e00a9dc24e720452245b20c8da Reviewed-on: https://chromium-review.googlesource.com/956325 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Bartosz Fabianowski <bartfab@chromium.org> Cr-Commit-Position: refs/heads/master@{#544981}
-
