- 19 Aug, 2020 40 commits
-
-
Zhenyao Mo authored
On Windows, if we call swap chain's Present1 with damage rect info, even the damage rect info indicates full damage, the chance of Chrome's back buffer being promoted into an overlays are much lower. If we want to consistently Chrome's BGRA back buffer to an overlay, we have to always call Present which doesn't take damage rect info, indicating full damage. I measured some common use case, and their percentage of frames being promoted to overlays are as below: - Google Meet (5 person, 2x2): 97.8% - wikipedia: 80.5% - a story sharing site: 77.2% - gmail (reading a few emails and then compose one): 61.3% - Google speadsheet: 78.2% - Google photos: 95.5% If we promote a frame to overlay, then we save an extra copy (DWM doesn't need to copy chrome's back buffer into OS's back buffer). If we fail to promote a frame to overlay and it's partial damage, now we use full damage, so at worst we do an extra copy. So as far as we promote more than 50% frames to overlays, there is performance gains. For use cases where performance is critical, like Google Meet, or when we scroll, we get almost 100% promotion, so we get maximum performance gain. Besides, always use full damage simplifies logic quite a bit. The UMA "GPU.DirectComposition.CompositionMode.MainBuffer" will show us if this is a good decision by collecting overlay promotion percentage from the wild. BUG=1117185 TEST=manual R=sunnyps@chromium.org Change-Id: I12d927f472652f17e146debc83e40d9f40a1b950 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363771 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#799862}
-
Daniel Libby authored
With cc-based directly composited images, we previously made a decision to not directly composite images if raster scale and aspect ratio resulted in filling in tiles that end up truncated when scaled back up in the display compositor, based on the shared quad state transform. However, because we don't apply directly composited images in cases where we used to, we can end up using more tile memory. The example page from bug 1111621 has over a hundred 1572 x 861 size image layers, but the image is only 16x16. If we don't directly composite, we run into the upper limits of allowed tile memory, and tiles start disappearing (are dropped) on re-draw. Unfortunately, as raster scale can only be expressed as a single scaler value, there no way to have tile size match the intrinsic image size when the aspect ratio of the layer and image are different (the previous approach was able to do this by encoding x and y scales in the layer transform - however, our detection of directly composited images happens later in the pipeline at a time where we cannot alter the structure of the transform property tree). This change removes the restriction (and the associated DCHECK validating it) when the raster scale is less than 0.1, in favor of applying directly composited images to save memory, over the minor changes in rendering that may result. The difference in rendering is that the last row/column of scaled pixels will only be partially filled, and those pixels will be stretched and clipped at the layer bounds. Bug: 1111621 Change-Id: I15b83a9f33df72f40ece087ade3e82a513aa596e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355831Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#799861}
-
Yu Han authored
Prior to this CL, dark mode tests were coded one by one manually. However, there are already a number of tests that test the appearance of form controls. So we should leverage the existing tests to verify form controls dark mode. This CL adds fast/forms/color-scheme to the dark mode virtual TestSuite. The directory has a good coverage for all form controls. To do so requires modifying existing tests to include the <meta name="color-scheme" content="light dark"> so that they support both light and dark mode. In addition, I went through all the rebaselined expected images and mark the ones that doesn't match dark mode spec in the TestExpectation file, along with a bug number. The failed rebaseline images are not include in this CL. The CL also removes the duplicated tests in the dark-color-scheme directory that have been already tested in the fast/form/color-scheme directory. In the follow on CL, I'll work through these failed cases. Bug: 929098 Change-Id: Ic4e6c30c51051a7e5e009c733da9bbe3c6c98c32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353091Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Yu Han <yuzhehan@chromium.org> Cr-Commit-Position: refs/heads/master@{#799860}
-
Karandeep Bhatia authored
Platform app resources should never load in a tab. However currently, it's possible for browser initiated navigations to bypass that restriction on redirects. Fix that by adding an explicit check in ExtensionNavigationThrottle to ensure that navigations to platform app resources only succeed in certain cases. Also, add a regression test. BUG=1110551 Change-Id: If11f7f1f9649c8a3f7960cd51d18ef902ac272d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347086 Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#799859}
-
Jianhui Dai authored
Set default bitrate according to video resolution Change-Id: I0f00af6b8900af71c27701c7f91c393f63d36b82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347399Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#799858}
-
Marijn Kruisselbrink authored
Renames self.getOriginPrivateDirector() to navigator.storage.getDirectory(), following the changes in https://github.com/WICG/native-file-system/pull/217. Change-Id: Ie993c24b56ffdf369bb87ed03eb786f458e50ad5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363567 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Auto-Submit: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#799857}
-
Anastasia Helfinstein authored
Switch Access has been experiencing performance issues on moderate to large webpages. A large portion of this is due to the inefficiencies of its traversal of the automation tree, recalculating the same values sometimes hundreds of times for nodes deep in the tree. This change utilizes techniques from dynamic programming to persist intermediate values for continued use, reducing the asymptotic worst- case run time from exponential in the depth of the node to linear in the number of nodes in the subtree. AX-Relnotes: n/a. Bug: 1109970 Change-Id: I61368292f2e731245e4f733c2883b86293d8a74c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360340Reviewed-by:
Abigail Klein <abigailbklein@google.com> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#799856}
-
Harkiran Bolaria authored
Add callback to handle specialized behavior when tasks are posted. To be filled with IPC tracking for cached frames in a subsequent Cl. Bug: 1110344 Change-Id: I7a053747082782a0c2f6c44a7b77aeb6f9694d96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316781 Commit-Queue: Harkiran Bolaria <hbolaria@google.com> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#799855}
-
Eric Lawrence authored
Previously, the loader would unconditionally clear the request's Content-Type header upon any redirect. This would cause the value to be lost upon reloading a page that loaded through a HTTP/307 or HTTP/308 redirect that preserved the POST body. Bug: 860546 Change-Id: Id5af5b03a997b8fa185af7ad3245cec5952b3b92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363661Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Cr-Commit-Position: refs/heads/master@{#799854}
-
Justin DeWitt authored
Bug: 1119485 Change-Id: Ic85c4ae86c8bdc287e724f3bf403a7942aa1c337 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364023Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#799853}
-
Nela Kaczmarek authored
This change covers the implementation of AffiliationService, the AffiliationFetcherDelegate interface implementation and unit tests. It prefetches data with a help of AffiliationFetcher and provides an API to get change password urls for requested origin. This change includes only preparing data for prefetch without processing the response. Bug: 1108279 Change-Id: I3f47a3b1f7c0b99726b4107d484387a77b1345b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332604 Commit-Queue: Nela Kaczmarek <nelakaczmarek@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#799852}
-
Renato Silva authored
PIN auto submit is only available on Chrome OS and the feature should be in the chromeos namespace. Bug: 1075994 Change-Id: Idd199abb2baf6ac88d10762e22735fe42d46e656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362965 Commit-Queue: Renato Silva <rrsilva@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#799851}
-
Lei Zhang authored
Remove deprecated macro usage and use explicit deletions instead. Also remove some unnecessary includes for base/macros.h. Bug: 1010217 Change-Id: I8d1e4d03e93933262f184b7802de4ef1b94ab1e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363630Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#799850}
-
Leonid Baraz authored
Bug: b:153364303 Change-Id: Idb13d9993a6301cda0ca7514a7c0fc457c7e90a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364060Reviewed-by:
Zach Trudo <zatrudo@google.com> Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#799849}
-
Dylan Cutler authored
Bug: 973801 Change-Id: Ie2de8e36520d28ea0063ab6c54695786eb1de5c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353028 Commit-Queue: Dylan Cutler <dylancutler@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#799848}
-
Brian Malcolm authored
This is intended to replace the NativePrintersBulkWhitelist policy. The old policy will still be used in the absence of the new one for at least a few releases of Chrome. BUG=chromium:1098047 Change-Id: Ib863ff1f2244dcd832826883c0dfa7f167865908 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342049 Commit-Queue: Brian Malcolm <bmalcolm@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#799847}
-
Yicheng Li authored
If the submitted password looks like PIN, try authenticate the user with PIN. On failure, submit the password as normal password. This fallback to password auth is because the user may type the PIN into the password textfield (though admittedly this is a less valid use case). This behavior is consistent with ScreenLocker. Bug: b:156258540 Change-Id: I23bf097a35c6458e8f341ae105679d6d42a83c59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364756Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yicheng Li <yichengli@chromium.org> Cr-Commit-Position: refs/heads/master@{#799846}
-
Tomasz Wiszkowski authored
This change allows Search-Ready Omnibox to be shown on SRP effectively removing the need to manually clear the Omnibox field ahead of typing in new search query. Bug: 1118222 Change-Id: Ie36029b38ed54bb63de1db66eef9457dec6d86ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364048 Commit-Queue: Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#799845}
-
Evan Stade authored
Bug: 738196 Change-Id: Ibc6ab965ba80cbc76f7e89230da7c20bf7dc9392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364957Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#799844}
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. Bug: 1110266 Change-Id: I5aedb1ceaad41242f4a51d450704027dcb0c046e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352022 Commit-Queue: Sean McAllister <smcallis@google.com> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#799843}
-
Michael Bai authored
Record the task delay to see how often the short delay is triggered. Bug: 1114819 Change-Id: Ia1368fd354dea1af196b6f5ff14f7d073b73da9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363557 Commit-Queue: Tao Bai <michaelbai@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#799842}
-
Evan Stade authored
Bug: 1057100 Change-Id: I57cff2406fa4d11420dbbb3e450dc189f5dd97a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364740 Commit-Queue: Evan Stade <estade@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by:
-
Yi Chou authored
Add ordinal value in the mojom would increase the compatibility between different builds. Change-Id: I88c455f092035ffd0d9b6164e83babf39957fb61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319088Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Commit-Queue: joe Chou <yich@google.com> Cr-Commit-Position: refs/heads/master@{#799840}
-
Chong Gu authored
Adds ~5 mins of runtime and bot time per build. Bug: 1058255 Change-Id: If3bea9834a4c2894fe333d57b19dba68451f8d4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364061 Auto-Submit: Chong Gu <chonggu@google.com> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#799839}
-
chromium-internal-autoroll authored
Release_Notes:http://go/help_app-x20/relnotes/Nightly/help_app_nightly_202008190800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/2mC2HAs3wr9lkv-fO7paccSOBACAv2EXtzFGg-sY7ukC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/162466284,b/163420424 Tbr: help-app@grotations.appspotmail.com Change-Id: Ifded1470451b18602cb561f452fa5368a2037899 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362979Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799838}
-
James Hawkins authored
This reverts commit e2c7dc67. This relands the below change after fixes to the underlying components to support unoptimized builds. cr_components/network: Convert NetworkListItem to Polymer 3. Also convert the types in NetworkListTypes as well since they are trivial and NetworkListItem depends on them. Bug: 1045266 Test: NetworkNetworkListItem* Change-Id: Ic607a49efa874fde2bf18459dc9a351db6fd49f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364815Reviewed-by:
-
Xiaocheng Hu authored
This follows from a discussion that 'advance-override' more accurately summarizes what the descriptor does. Bug: 1098355 Change-Id: Ib497288f9e824ee33adb77b2e1b76e8aed709f42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363857 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#799836}
-
Juan Mojica authored
Bug: 1092713 Change-Id: I8e0d7c2d18dcaac7ab930452c57907f1c31ab449 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363393 Commit-Queue: Juan Mojica <juanmojica@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
-
John Lee authored
Bug: 1117652 Change-Id: If097acd73096be0b1b36e94088361a9715f53936 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360344 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#799834}
-
Xing Liu authored
This CL removes metric "GoogleUpdate.Notification.LaunchEvent". Bug: 1084148 Change-Id: I95d3eb2f42fb77219d4cbcdf6a593545f7d15026 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363647Reviewed-by:
Hesen Zhang <hesen@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#799833}
-
David Roger authored
Bug: 1063856 Change-Id: Icbfc8643e34c358421d6cf200269726ff2dc4537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364616 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#799832}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/53effa99e255..9b259fd1b84c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC alexmos@google.com,mcnee@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1085419,chromium:1103274,chromium:1111893,chromium:1116656,chromium:1118189 Tbr: alexmos@google.com,mcnee@google.com Change-Id: I8035267520474439deabbc3dade009f4d3ed2930 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364576Reviewed-by:
-
Steven Bennetts authored
There is an edge case where the netmask can be undefined, causing an exception which breaks the UI. This handles that edge case. Bug: 1091567 Change-Id: I40eb7e8b57670fd9582a28fa5723ac221cdf550c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364002 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#799830}
-
Elly Fong-Jones authored
This method is only implemented on the base class, which always returns false. Delete the method, its implementation, a wrapper around it in DesktopWindowTreeHostWin, and the only call to it in HWNDMessageHandler. Open question: is WidgetDelegate::HandleWorkAreaChanged() now dead? It can only be called in HWNDMessageHandler::OnSettingChange() when GetParent(hwnd()), but under what circumstances is that true? Bug: None Change-Id: Ib00d0b67597ded401c624786b54051bdf2373769 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364212Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#799829}
-
Anatoliy Potapchuk authored
Change-Id: I51abb949970bd03810144b033dcc8bb7a51c18b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363753 Auto-Submit: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#799828}
-
Raymond Toy authored
Add a CHECK before we break out of the loop in ComputeIndices. This has never happened in my testing, so this is just a guess. If we do get crashes, perhaps we can get better information about what's happening. This is important because if we do exit the loop early, we're not telling ComputeOutput about it and the read indices may not be set up correctly for that. Also, update frames_processed to tell ComputeOutput how many values were computed so ComputeOutput doesn't compute more outputs than needed. I think letting this bake for a week or so will be enough to gather enough information if this is the case. Bug: 1116104 Change-Id: Id0ab1d3ca801196fc49b878349f469cbd4f6e11a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358815Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#799827}
-
Anupam Snigdha authored
Added a new method to initialize a mocked version of TSFBridge when |InitializeInputMethodForTesting| is called from test code. This change also adds a call in the views unittest base to initialize the |MockTSFBridge| by calling |InitializeInputMethodForTesting| and enables some disabled tests. Bug: 968222 Change-Id: Ib25dcefd53a2b6e11ea6dfa713efe37052b24be6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364034Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#799826}
-
Charlene Yan authored
The height of the TabStrip was being incorrectly set when Tab Scrolling was turned on leading to an invisible tabstrip. height() is 0, potentially because TabStrip does it's own layout? Bug: 1093529 Change-Id: I45745b8d3ff0cdbcaf1b5ba99e2e16bc2c23c69d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364698Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#799825}
-
Aleks Totic authored
LayoutNGCaptions can be created in both Legacy and NG tables. Only Legacy tables require AddCaption/RemoveCaption calls. Bug: 958381 Change-Id: I43131f66b794dc43bea41d6b39fdf66eac72aa86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363556 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#799824}
-
Dana Fried authored
Requested by PM to be symmetric with "Add to new group" menu. Bug: 1117460 Change-Id: I4c1047e076b889cd122e18da74187324419ed391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363394Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#799823}
-
