- 16 May, 2020 16 commits
-
-
Donn Denman authored
Adds support for displaying Related Searches using the existing Contextual Search UX. The main differences are: 1) Tap does not select anything when Related Searches is enabled. 2) Clicks in the Overlay don't promote to a new tab when they are only one level deep but do promote to a separate tab after that. When Related Searches are enabled the Long-press triggering is automatically enabled so a Long-press resolves normally but a Tap generates a Related Search without any selection. The treatment of the selection is gated by the Feature with a non-empty selection unless the Feature is active (allowing an insertion point). All significant functional changes are behind the RelatedSearches Feature flag. Functions that have been changed to accommodate this Feature have tests: Context allows an insertion-point and the SearchRequest allows non-Google URLs when the Feature is active. Also removed some unused code. BUG=1062737 Change-Id: I4b8f133398890c214d26e968c2ede6a1ba08618a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200437 Commit-Queue: Donn Denman <donnd@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#769510}
-
Anastasia Helfinstein authored
Generalize some helper functions within Switch Access tests, and clean up tests. AX-Relnotes: n/a. Bug: None Change-Id: I7c0ced18e600a8a641a959d8e958a724045b47a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203403 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#769509}
-
Karandeep Bhatia authored
Improve CompositeMatcher interface to allow overwriting and erasing RulesetMatchers. This helps simplify client code. This has no behavior change. BUG=754526 Change-Id: I1e59bae5e06e3a3f123221f41619fa5d4e00dc0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203224 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#769508}
-
Joe DeBlasio authored
This CL makes some small changes to allow the top 500 list to be less than 500 domains long. This allows us to remove domains that should no longer be in the list without having to regenerate the whole thing. This CL also incidentally fixes a bug wherein some domains were treated as top-500 domains even though they weren't. This CL keeps some statically-defined variables that are defined in a generated .cc file as having 500 entries, even though they actually have fewer than that. This prevents us from having to regenerate the header file as well, but eventually that's the right answer. I'm hoping we can merge this CL to M84, which necessitates simplicity and safety over elegance. Bug: 1083489,1083487 Change-Id: I45a5425cd4a8c4a9135d6f723b08d628f164f7df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204554 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#769507}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/31d722dc6723..21bceb888974 git log 31d722dc6723..21bceb888974 --date=short --first-parent --format='%ad %ae %s' 2020-05-15 thestig@chromium.org Use std::extent to figure out the size of member arrays. 2020-05-15 tsepez@chromium.org Convert pdfium::MakeUnique<> to std::make_unique<> in fpdfsdk Created with: gclient setdep -r src/third_party/pdfium@21bceb888974 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: Ieb8dce4526b5f59d81accc6fe0f02681597a730d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204916Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#769506}
-
Behnood Momenzadeh authored
This CL removes the now-superfluous EV_SECURE security state, as Chrome no longer treats EV certificates different than DV certificates in browser UI. Refer to https://crbug.com/1006943 for more information. Bug: 1006943 Change-Id: I330f5005fc07f18fc9edabd5a904bb136f577256 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2191191Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Behnood Momenzadeh <behnoodm@google.com> Cr-Commit-Position: refs/heads/master@{#769505}
-
Sean Topping authored
Bug: None Test: CQ Change-Id: I218520ae263aa2f597a6ac81703087ec5ad9c8f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204847 Commit-Queue: Sean Topping <seantopping@chromium.org> Commit-Queue: Junbo Ke <juke@chromium.org> Auto-Submit: Sean Topping <seantopping@chromium.org> Reviewed-by:
Junbo Ke <juke@chromium.org> Cr-Commit-Position: refs/heads/master@{#769504}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/212eb74a..bc1bf875 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1d941c3f95b3af68d790bdfaae5d305461b72be2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203985Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#769503}
-
Bettina authored
The test for Safe Browsing Extended Reporting was updated in the settings page but was not updated for Safe Browsing interstitial page. Bug: 1082286 Change-Id: Ide3912121b45152d343991e9b0b67e278815025d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204630Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#769502}
-
David Bertoni authored
ActivityLogApiTest.TriggerEvent is very long and can time out on slower builds. I've removed some unnecessary console.log output, which fixed the issue on most builds. However, it still times out occasionally on Debug or ASan configurations, so I've left it disabled on those. This test should be split into multiple tests so it can be enabled on all builds. Bug: 299393 Change-Id: Ie958b8699aee2fe72f4914cc971f9fd5c972800d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197509Reviewed-by:
Archana Simha <archanasimha@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#769501}
-
David Schinazi authored
https://quiche.googlesource.com/quiche.git/+log/f6ba532e3e4f..8963f6066333 $ git log f6ba532e3..8963f6066 --date=short --no-merges --format='%ad %ae %s' 2020-05-15 dschinazi Refactor QuicDispatcher connection ID replacement 2020-05-15 fayang In quic, check quicconnection::shouldgeneratepacket for every crypto packet. protected by gfe2_reloadable_flag_quic_fix_checking_should_generate_packet. 2020-05-15 fayang In quic, notify stream id manager stream close after connection disconnected. protected by gfe2_reloadable_flag_quic_notify_stream_id_manager_when_disconnected. 2020-05-15 dschinazi Fix AckNotifierWithPacketLossAndBlockedSocket 2020-05-15 fayang In quic, return from quiccryptostream::writependingcryptoretransmission after partial writes. protected by gfe2_reloadable_flag_quic_fix_write_pending_crypto_retransmission. 2020-05-15 dschinazi Deflake AckNotifierWithPacketLossAndBlockedSocket 2020-05-14 fayang In quic, update crypto_retransmit_count for ietf quic. stats only, not protected. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I5456c3c73cb707c4b26ecc3899c3d9ecd86c1d9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204691 Commit-Queue: David Schinazi <dschinazi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Auto-Submit: David Schinazi <dschinazi@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#769500}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/bb0779674b54..7776e78f011c git log bb0779674b54..7776e78f011c --date=short --first-parent --format='%ad %ae %s' 2020-05-15 John.Emau@microsoft.com [console] make context selector subtitle contrast WCAG compliant 2020-05-15 John.Emau@microsoft.com [issues] Affected sources styling Created with: gclient setdep -r src/third_party/devtools-frontend/src@7776e78f011c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1070376 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia2e2d26b24a11650d67249e5e9ed016c8295a767 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204735Reviewed-by:
-
Anastasia Helfinstein authored
This is a reland of 2b4e41b5 Original change's description: > [Switch Access] Add back button focus ring > > The Switch Access UI specification (see bug) indicates that the back > button should have a perfectly round focus ring exactly around the back > button. The general accessibility focus ring infrastructure is not set > up to be round, or to draw exactly adjacent to a UI element, so the > preferred approach is to modify the back button's appearance to include > the focus ring, when the node should be focused. > > AX-Relnotes: n/a > Bug: 973719 > Change-Id: I80aaa036d13192ce8b60fb2abaeb573a3f8ac5a1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181428 > Commit-Queue: Anastasia Helfinstein <anastasi@google.com> > Reviewed-by: Jenny Zhang <jennyz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#766483} Bug: 973719 Change-Id: I987127b9f05dbb87b700d85e364cca93d862c6de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196848Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#769498}
-
Nate Chapin authored
Currently, we only clear dom_window_ in the corner case where LocalDOMWindow will be reused with a new document. However, this isn't consistent with the spec, and we even have a special case for it: https://chromium.googlesource.com/chromium/src/+/ea568b335c1b01a41c47f50bbbe9738730beafce/third_party/blink/renderer/core/dom/document.cc#6752 This CL gives us the invariant that if a Document is detached, it will have both its frame_ and dom_window_ nullptr. In the case where the frame is detached, this means we now have a set of more consistent but still not very intuitive rules. We maintain the connection from the "owner" objects to the "owned" objects: LocalFrame->LocalDOMWindow->Document ...but sever the connections the other direction: LocalFrame</-LocalDOMWindow</-Document I have no idea how many places in our code depend on Document::domWindow() returning non-null after detach that aren't covered by tests, so this CL will probably cause at least a few crashes in the short term. Bug: 1080735, 1046898 Change-Id: Ic91eb87a459fe737326d4931859de3304de1b07c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199168 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#769497}
-
Kyle Horimoto authored
This CL uses the Hierarchy infrastructure added in [1] to register subpages and settings for each section. It also changes OsSettingsSection::RegisterHierarchy() to a pure virtual function so that all sections must implement this functionality. Additionally, this CL adds a test which verifies that metadata is registered for every subpage/setting. This ensures that as new content is added to the settings page, it must be registered to pass the CQ. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2203149 Bug: 1080892 Change-Id: Ia9736f3f841c1c61202e1fe59bdb3793f0874bf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204440Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#769496}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I8cfd50675a1e37c1e54e2a4489a30f9af07304c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204733Reviewed-by:
-
- 15 May, 2020 24 commits
-
-
Kenneth Russell authored
Failing on this configuration too. Tbr: shrekshao@google.com No-Try: True Bug: 1018028 Change-Id: I8e2c1d7c753e017e293f39adb3aeee81d2a9c63a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204936 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#769494}
-
Wei Li authored
Restructure the test case to own a widget when needed. In this way, the BookmarkBarView can transfer ownership to a widget. There is no need to use set_owned_by_client(). BUG=1044687 Change-Id: I9189dd97e9afe56ec4e5d4fb6f4c2eec10ecc828 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202422Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#769493}
-
wutao authored
This patch is a refactoring to move photo related code from ambient_controller to ambient_photo_controller to consolidate the photo logic. Bug: b/156767583 Test: new unittests: ShouldStartScreenUpdateSuccessfully Change-Id: I6790882dc8202d7fea78cfebe8edeca6e97e093e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2185437 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#769492}
-
Raphael Kubo da Costa authored
Make the tests in runGenericSensorTests() that use more than one sensor of the same type wait for the "reading" event to be delivered to all of them rather than just one before verifying all readings to prevent flakiness and incorrect usage. Bug: 731018, 1078172 Change-Id: I7a78d5a2d26b8d6f1074c93199e158ba8567b19b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204180 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#769491}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/380174f8642d..31d722dc6723 git log 380174f8642d..31d722dc6723 --date=short --first-parent --format='%ad %ae %s' 2020-05-15 tsepez@chromium.org Replace pdfium::MakeUnique<T> with std::make_unique<T> in fxjs 2020-05-15 thestig@chromium.org Replace ContainsKey() and ContainsValue() with Contains(). 2020-05-15 thestig@chromium.org Rename progressivedecoder* to progressive_decoder*. 2020-05-15 thestig@chromium.org Do IWYU for progressivedecoder.h. 2020-05-15 thestig@chromium.org Rename BmpModule to BmpDecoder. 2020-05-15 thestig@chromium.org Separate BmpModule from ModuleMgr and remove ModuleMgr. 2020-05-15 thestig@chromium.org Finish transition to C++14. Created with: gclient setdep -r src/third_party/pdfium@31d722dc6723 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I4d0a39c0b37900d8e597f6e4ce400e43274b2234 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204726Reviewed-by:
-
Thomas Lukaszewicz authored
This reverts commit 7bde7700. Reason for revert: Deterministic build failure on Win7 Tests bot for the following: WebAppUninstallDialogViewBrowserTest.TestWebAppUninstallDialogDelegateViewAccept Original change's description: > add test for web_app::WebAppUninstallDialogDelegateView > > This adds test for the flow of initiating uninstall and accept/cancel > the uninstall action. It also fixes a bug that the autoconfirm for testing is called > before the widget is instantiated by > |constrained_window::CreateBrowserModalDialogViews| > > Bug: 1073258 > Change-Id: Ifad3298f892be3e1e1875cb83e29cf87ce9f8b34 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198369 > Reviewed-by: Alan Cutter <alancutter@chromium.org> > Commit-Queue: Phillis Tang <phillis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#769406} TBR=alancutter@chromium.org,phillis@chromium.org Change-Id: I65c61881adfccb7fe7acf94f00cc0f43a4309219 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1073258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204933Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#769489}
-
Xing Liu authored
This CL adds the image preloading histogram to monitor the interaction to image fetcher service. Bug: 1068683 Change-Id: Ia1cd839e93f2fcb53efe6a6795c31402f4400964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199602 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#769488}
-
Stephen McGruer authored
These are symptomatic of crbug.com/1047818, but to stop the pain for sheriffs lets mark them timeout=long for now. TBR=lpz@chromium.org Bug: 1083267, 1079383 Change-Id: Ide65aee5e5935ddbe145e4a7e35080f3b42acecc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204634Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#769487}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f5f132355f29..9ff392c5e37c git log f5f132355f29..9ff392c5e37c --date=short --first-parent --format='%ad %ae %s' 2020-05-15 primiano@google.com Infra: allow curl to follow redirects Created with: gclient setdep -r src/third_party/perfetto@9ff392c5e37c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I6441d12171edd16783b3afb7b31b1b3bdee41224 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204720Reviewed-by:
-
Yusuke Sato authored
The tip will be moved to /etc/arcvm_dev.conf. BUG=None TEST=no real code change Change-Id: I8ce7bd9243ff253e61c6a377afd56e4db832589d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204681Reviewed-by:
Long Cheng <lgcheng@google.com> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#769485}
-
Xiaohan Wang authored
There are a lot of Renderer implementations that do not support encrypted stream. Make SetCdm() non-pure-virtual so that those renderers do not need to override it. Bug: 1082077 Change-Id: Idaf7d6b157665ea7b3fee0850e3618a2850c1850 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198642Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#769484}
-
Kyle Horimoto authored
This reverts commit bb4748c6. Reason for revert: Merging the landed CL to M-84, but we want to change the implementation of this code for master branch to adhere to best practices. See comments on original CL for context. Original change's description: > Update Add Accounts page for supervised user accounts. > > This cl updates the messaging in add accounts > settings page for supervised users for edu coexistence. > Supervised users are able to add only EDU school account as > a secondary account. > > The screenshot can be found here: > https://drive.google.com/file/d/1u4ATw_tuJfmXUeoU3tr0agJp6y1vgAl5/view?usp=sharing, > > Bug: 1082336 > Change-Id: Ic7026b4ce60a87b3e85329e282ec1c59f3d54a67 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204274 > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Reviewed-by: Aga Wronska <agawronska@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Commit-Queue: Yilkal Abe <yilkal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#769480} TBR=jamescook@chromium.org,khorimoto@chromium.org,agawronska@chromium.org,yilkal@chromium.org Change-Id: I52e02046911e8fca6dab510b7b3f76f3410e91bf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1082336 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204842Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#769483}
-
Thomas Lukaszewicz authored
This reverts commit 7ff9c2a4. Reason for revert: browser_tests on Intel GPU on Mac deterministically fail on the Mac10.12 Tests bot as a result of the following test case: PDFExtensionTest.PdfAccessibilityContextMenuAction Original change's description: > Supporting context menu on PDF via AT clients > > This CL adds support for invoking context menu on PDF via AT clients. To > show context menu for PDF plugin, the context menu action can be invoked > on respective EMBED node. This internally takes care of showing plugin > related context menu option(See ContextMenuController::ShowContextMenu() > for reference). > > Implemented PdfAXActionTarget::ShowContextMenu() that forwards the call > to RenderAccessibilityImpl::ShowPluginContextMenu() to find the EMBED > object in accessibility tree and invoke ShowContextMenu() on EMBED node. > > This CL also includes browser test to validate E2E scenario. > > Bug: 1023283 > Change-Id: I40f9f75ad526067384f1edc94e9d851d412b1c74 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2172854 > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: Ankit Kumar
🌪 ️ <ankk@microsoft.com> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Commit-Queue: Mansi Awasthi <maawas@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#769358} TBR=dmazzoni@chromium.org,thestig@chromium.org,jochen@chromium.org,mohitb@microsoft.com,maawas@microsoft.com,virens@microsoft.com,ankk@microsoft.com Change-Id: Ic747fbaf554228d37525bfe4a3181f42d3c5fbc6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1023283 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204841Reviewed-by: -
Matt Mueller authored
Bug: 1044698 Change-Id: Id0ca262ddb548e625f8e4d2031cac7761c813691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204276 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#769481}
-
yilkal authored
This cl updates the messaging in add accounts settings page for supervised users for edu coexistence. Supervised users are able to add only EDU school account as a secondary account. The screenshot can be found here: https://drive.google.com/file/d/1u4ATw_tuJfmXUeoU3tr0agJp6y1vgAl5/view?usp=sharing, Bug: 1082336 Change-Id: Ic7026b4ce60a87b3e85329e282ec1c59f3d54a67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204274Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#769480}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/36aca5228a1a..bb0779674b54 git log 36aca5228a1a..bb0779674b54 --date=short --first-parent --format='%ad %ae %s' 2020-05-15 janscheffler@chromium.org Add basic types from protocol to closure Created with: gclient setdep -r src/third_party/devtools-frontend/src@bb0779674b54 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I16d0a635bd8f2441a7e5a7f42f587a25d3ae3a1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204721Reviewed-by:
-
Xiaoling Bao authored
Bug: 1068797 Change-Id: I9dff77c500e3db9befa5cac646c7e2104172f51e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203236 Commit-Queue: Xiaoling Bao <xiaolingbao@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
S. Ganesh <ganesh@chromium.org> Cr-Commit-Position: refs/heads/master@{#769478}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/513322113905..da722adec9a9 git log 513322113905..da722adec9a9 --date=short --first-parent --format='%ad %ae %s' 2020-05-15 enga@chromium.org Run dawn_end2end_tests on all available system adapters 2020-05-15 enga@chromium.org Remove experimental Dawn DEPS CQ bots 2020-05-15 enga@chromium.org DawnTest: Gather adapters on environment creation for filtering backends Created with: gclient setdep -r src/third_party/dawn@da722adec9a9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I3abf7c40f3e6dc8cb22219e8e84bd10bc5215a70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204672Reviewed-by:
-
Thomas Lukaszewicz authored
This reverts commit a095318b. Reason for revert: Deterministic failure of the following unittests on the linux CFI bot. LibcastSocketServiceTest.OpenChannelIsConnected LibcastSocketServiceTest.ChannelAddAndRemove https://ci.chromium.org/p/chromium/builders/ci/Linux%20CFI/17219 Original change's description: > Use libcast CastSocket in CastSocketService > > This change makes CastSocketService use libcast's CastSocket to back all > the Cast channels it opens. This change is compatible with both the > extension and native MRPs. Although the API and state management are > slightly different between Chromium's existing CastSocket and libcast's, > this change should keep observable behavior very similar. > > Bug: 1050913 > Change-Id: Ic1ebf4194e8ae3818cd0d959a77c9b2b9726ede9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119207 > Commit-Queue: Brandon Tolsch <btolsch@chromium.org> > Reviewed-by: mark a. foltz <mfoltz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#769250} TBR=mfoltz@chromium.org,btolsch@chromium.org Change-Id: I6c1acdbd8f80980430a4ae12188c2c6eb946677b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1050913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204815Reviewed-by:
-
Carlos IL authored
Removes ShowingInterstitialPage from WebContents, and DidAttachInterstitialPage and DidDetachInterstitialPage from WebContentsObserver. Cleans up call sites. Bug: 1077074 TBR=sky@chromium.org Change-Id: Ia139d07d4ba7fd8ef8a2afff8981b049d61a5045 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147921 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Auto-Submit: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#769475}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3bfa3660853d..ec4698056847 Created with: gclient setdep -r src-internal@ec4698056847 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC gab@google.com,tluk@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: gab@google.com,tluk@google.com Change-Id: I57c4dee422e3eb4aedf3f9edcf4879edd2014b1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204658Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#769474}
-
Alexander Timin authored
Add a flag to enable capturing a trace file for layout tests, similar to how browser tests do this: run_web_tests.py --enable-tracing=CATEGORIES The implementation passed the following flags to the driver: --trace-startup --trace-startup-duration=0 --trace-startup-file R=robertma@chromium.org Change-Id: I2f145936f567986219928108eba89c8c60f734a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202807 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#769473}
-
Sophie Chang authored
Bug: 1083332 Change-Id: I903bd5519523dc5a5de1e50cdd72f7912d923996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204525Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#769472}
-
Yuke Liao authored
TBR=thakis@chromium.org Cq-Include-Trybots: chrome/try:mac-chrome Cq-Include-Trybots: chrome/try:win-chrome Cq-Include-Trybots: chrome/try:win64-chrome Bug: 1071576 Change-Id: Iaf6bd17b6973b46aa8ac5c5337f2b5c9c9803dc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204632Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#769471}
-
