- 05 Aug, 2018 3 commits
-
-
Ivan Krasin authored
build/build_config.h defines one of two macros: https://cs.chromium.org/chromium/src/build/build_config.h // Compiler detection. #if defined(__GNUC__) #define COMPILER_GCC 1 #elif defined(_MSC_VER) #define COMPILER_MSVC 1 #else #error Please add support for your compiler in build/build_config.h #endif And in the most of the case, the following checks are performed: #if defined(COMPILER_GCC) // Do something. #elif defined(COMPILER_MSVC) // Do something else. #else // Do something completely else. #endif There's one use in base/compiler_specific.h that violates this convention, as it tests: #if COMPILER_GCC && defined(NDEBUG) #define ALWAYS_INLINE inline __attribute__((__always_inline__)) #elif COMPILER_MSVC && defined(NDEBUG) #define ALWAYS_INLINE __forceinline #else #define ALWAYS_INLINE inline #endif That leads to a preprocessor error on Windows. While this error is not triggered in Chromium, it can be reproduced, if link WebRTC Native Code with //base shipped as a part of their checkout. BUG=chromium:871039 Change-Id: I868b4a47a574fba48e7d2743cd64ace99ea64940 Reviewed-on: https://chromium-review.googlesource.com/1162343Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Ivan Krasin <krasin@chromium.org> Cr-Commit-Position: refs/heads/master@{#580770}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I8752bc781eea3f608aee8ff6356e3cc350d0d9b2 Reviewed-on: https://chromium-review.googlesource.com/1163133Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#580769}
-
Ned Nguyen authored
Sample usage: ./tools/perf/core/retrieve_story_timing.py analyze-benchmark-runtime -c 'Android One Perf' -o benchmark_runtime_android_one.json Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: I9b7e42a1c8a74093c5dcb311f5ee11d5875a8946 Reviewed-on: https://chromium-review.googlesource.com/1160762 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#580768}
-
- 04 Aug, 2018 37 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium 88ba9d16. With Chromium commits locally applied on WPT: 7dad0f17 "Added new Sec-Metadata Web Platform Tests." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22377 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=robertma No-Export: true Change-Id: I329ce5e5cc214ae37b74caa4a1f025219d185ce4 Reviewed-on: https://chromium-review.googlesource.com/1163068 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#580767}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I31a4d1633a652b317f21231e55e53ee3cc9d670f Reviewed-on: https://chromium-review.googlesource.com/1163069Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580766}
-
Nico Weber authored
If /debug is passed to lld, the pdb aging in PDB70DebugInfo currently means that repeat builds get different PDB70DebugInfo headers, so for now don't pass /debug to the linker. Bug: 330260 Change-Id: I86e6b470ad95f3f6556c8f8f69d6d394a32661ff Reviewed-on: https://chromium-review.googlesource.com/1162948Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#580765}
-
John Abd-El-Malek authored
P2PSocketDispatcherHost is now split into two. The code that owns and manages P2PSocket classes moves to services/network's P2PSocketManager. There are corresponding trusted Mojo interfaces for the two to communicate. Bug: 844146 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I5bb9265c4eba5a5bc7d4cb0bd0707c7b535e4c1c Reviewed-on: https://chromium-review.googlesource.com/1161568Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#580764}
-
Mohamed Amir Yosef authored
Remove duplicate SpecificsFromBookmarkNode() and use CreateSpecificsFromBookmarkNode() from bookmark_specifics_conversions.cc Bug: 516866 Change-Id: I7879421a1cf6e342eb9f13c10366044418c20b87 Reviewed-on: https://chromium-review.googlesource.com/1162337Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#580763}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2f6a9937. With Chromium commits locally applied on WPT: 7dad0f17 "Added new Sec-Metadata Web Platform Tests." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22363 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=robertma No-Export: true Change-Id: I54eea71ce8bd5e2075a525f3632e175a05c70a9a Reviewed-on: https://chromium-review.googlesource.com/1163064 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
Daniel Cheng authored
Provide a global constant for a null unguessable token, for functions that need to return a const base::UnguessableToken&. Change-Id: Ib07dde7862dcab19baac409eaecda3482cfc5f4d Reviewed-on: https://chromium-review.googlesource.com/1162986Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#580761}
-
Harald Alvestrand authored
This is part of an effort to characterize RTCPeerConnection usage. UKM metric review document: https://docs.google.com/document/d/1Pq6Xxv8Mf10cgRFDCYPgIPD-US7uHyxQ31hdZT6uu4Y/edit Bug: chromium:866792 Change-Id: I38e0d7ee406e6246d8d013d7f96ad50f51b96a78 Reviewed-on: https://chromium-review.googlesource.com/1150539 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#580760}
-
Saman Sami authored
They just don't work at all right now. Video capture doesn't work on Android WebView. We need to call CopyFromSurface. Bug: 813929, 865430 Change-Id: I4360d3f53f852eb7e3182ac58540a1500cc6fee3 Reviewed-on: https://chromium-review.googlesource.com/1159199Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#580759}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/49ed2f6af744..9f470261e593 git log 49ed2f6af744..9f470261e593 --date=short --no-merges --format='%ad %ae %s' 2018-08-04 vapier@chromium.org lint: avoid oldstyle except styles 2018-08-04 vapier@chromium.org toolchain_lib: drop unused NoDefaultToolchainDefinedError 2018-08-04 vapier@chromium.org argparse: drop license too 2018-08-04 vapier@chromium.org cros_sdk: delete unused _FindSubmounts 2018-08-04 lannm@chromium.org Remove tree_status update code 2018-08-04 xixuan@chromium.org cbuildbot: Let blocking suite run first. Created with: gclient setdep -r src/third_party/chromite@9f470261e593 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ie92710bf3a8c35d83035b8f3a931d339a7f8c89d Reviewed-on: https://chromium-review.googlesource.com/1162816Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580758}
-
Koji Ishii authored
Following bot results are included. 8549 8551 8553 8556 8558 8569 8580 8583 8588 8591 8592 8595 8597 8600 8605 8608 8611 8615 8620 8621 8622 8623 2 lines were removed and 6 lines were deflaked by consecutive results since 8592. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I0f5f4a18bf191d1a770c19602d1973fa2a5bd65c Reviewed-on: https://chromium-review.googlesource.com/1158673 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#580757}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=amineer@chromium.org Change-Id: Ie080cd8571b7f5a90bc914a48cfd71faa0fd3d41 Reviewed-on: https://chromium-review.googlesource.com/1162956Reviewed-by:
-
Yuichiro Hanada authored
Bug: 845079 Test: ash_unittests Change-Id: I022910de2c6fa820909ae1a415b9ce5cdd3859dd Reviewed-on: https://chromium-review.googlesource.com/1156339 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#580755}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/baeba30e635d..49ed2f6af744 git log baeba30e635d..49ed2f6af744 --date=short --no-merges --format='%ad %ae %s' 2018-08-04 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@49ed2f6af744 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: If0a33b3ea1577ef16d5c4ad63bc344ffd5c46e72 Reviewed-on: https://chromium-review.googlesource.com/1162815Reviewed-by:
-
Jinho Bang authored
This patch was initiated from here[1] and makes the code more readable. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1142045/5/third_party/blink/renderer/modules/payments/payment_request.h#132 Bug: none Change-Id: I28b464e89c67029cc1642e8095469a19b9a86050 Reviewed-on: https://chromium-review.googlesource.com/1162091 Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#580753}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/03395da5d582..a7a957f7cec2 git log 03395da5d582..a7a957f7cec2 --date=short --no-merges --format='%ad %ae %s' 2018-08-04 thestig@chromium.org Use more text object state in DrawTextPathWithPattern(). 2018-08-04 thestig@chromium.org Clarify integer types in CPDF_Parser::LoadCrossRefV5(). Created with: gclient setdep -r src/third_party/pdfium@a7a957f7cec2 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:668762 TBR=dsinclair@chromium.org Change-Id: I8152b379a6bd55f71dd12efff57aedf1ee7cd898 Reviewed-on: https://chromium-review.googlesource.com/1162814Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580752}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/4e706b495ebe..baeba30e635d git log 4e706b495ebe..baeba30e635d --date=short --no-merges --format='%ad %ae %s' 2018-08-04 lannm@chromium.org Add git.RunRepo function Created with: gclient setdep -r src/third_party/chromite@baeba30e635d The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I1d57e8deff38fe236459eed95551b94bf8983c12 Reviewed-on: https://chromium-review.googlesource.com/1162782Reviewed-by:
-
Johannes Henkel authored
Use Clear() instead. And for the dom_debugger_agent, use ClearAllFields. This does reset the boolean field pauseOnAllXhrs as well, which is probably desired. Bug: 851762 Change-Id: I2a167892a37e1d8637ed4186ef90963a04d15753 Reviewed-on: https://chromium-review.googlesource.com/1162861Reviewed-by:
-
Krishna Govind authored
R=cmasso@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ifc43fae76e966ddba79fe957fdc550aebb4a47c7 Reviewed-on: https://chromium-review.googlesource.com/1163040Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#580749}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ff52e88a74bc..46671402fff3 git log ff52e88a74bc..46671402fff3 --date=short --no-merges --format='%ad %ae %s' 2018-08-04 buildbot@webrtc.org Roll chromium_revision d6a13562..39d45f08 (580628:580730) Created with: gclient setdep -r src/third_party/webrtc@46671402fff3 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I2e8fa96248e5204c2343b1322eb9857a8b518dea Reviewed-on: https://chromium-review.googlesource.com/1162812Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580748}
-
PhistucK authored
This commit was made possible by Janitor - https://janitor.technology Bug: none Change-Id: I4cda6d93040e52104efa93cb14f8459ae352bafe Reviewed-on: https://chromium-review.googlesource.com/1162228Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: PhistucK <phistuck@gmail.com> Cr-Commit-Position: refs/heads/master@{#580747}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/607be37e3d4d..59aabbcf3b0d git log 607be37e3d4d..59aabbcf3b0d --date=short --no-merges --format='%ad %ae %s' 2018-08-04 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 b8430dd749b0..a6d34af67286 (1 commits) 2018-08-03 herb@google.com Remove SkAutoDescriptor move ctor 2018-08-03 herb@google.com Hoist path check into regenerateGlyphRunList. Created with: gclient setdep -r src/third_party/skia@59aabbcf3b0d The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I4629e3b036e066cee1c31c4b12aefef5ebfd9023 Reviewed-on: https://chromium-review.googlesource.com/1162813Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580746}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/e819c2057ffd..03395da5d582 git log e819c2057ffd..03395da5d582 --date=short --no-merges --format='%ad %ae %s' 2018-08-04 thestig@chromium.org Set the CPDF_Font doc / font dict in the ctor. 2018-08-04 thestig@chromium.org Do more CBA_FontMap initialization in the ctor and header. Created with: gclient setdep -r src/third_party/pdfium@03395da5d582 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Icd7d280ec3395b154adf3225a0fb6cb7ae75f27e Reviewed-on: https://chromium-review.googlesource.com/1162114Reviewed-by:
-
Daniel Cheng authored
Also update base::EmptyString to use base::NoDestructor. Change-Id: I5004a7c4881af0dd7e499ccae59df4cab0369e87 Reviewed-on: https://chromium-review.googlesource.com/1162989Reviewed-by:
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d30f10814bd0..d2f6e76cbc6b git log d30f10814bd0..d2f6e76cbc6b --date=short --no-merges --format='%ad %ae %s' 2018-08-04 dtu@chromium.org [telemetry] Output a valid histogram set when running a disabled benchmark. Created with: gclient setdep -r src/third_party/catapult@d2f6e76cbc6b The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I9df5d4e83e63845000a596c7abdaaaa202e92a70 Reviewed-on: https://chromium-review.googlesource.com/1162811Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580743}
-
Alexey Kozyatinskiy authored
Current logic produces one Debugger.setBlackboxedRanges call on each scriptParsed event. It makes our frontend too much chatty. This CL simplify blackbox manager. With new logic blackbox manager sends Debugger.setBlackboxedRanges iff script has sourceMap and at least one sourceURL from sourceMap is blackboxed. When blackbox pattern changed frontend will send setBlackboxedRanges iff ranges are affected by change. R=lushnikov@chromium.org Change-Id: I8b9511f9feba50127de4add98c8d191877103145 Reviewed-on: https://chromium-review.googlesource.com/1162308 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
-
Tom Anderson authored
Because of the code in [1], themes are now expected to provide the background tab color themselves. This change restores the old computation of the background colors for the GTK theme. [1] https://cs.chromium.org/chromium/src/chrome/browser/themes/theme_service.cc?rcl=306871de3e87f2d1844952ee730112e1fdabbae4&l=473 BUG=866953 Change-Id: I16c4577a78f25e95d1a602ed7f795d2b032f2e0a Reviewed-on: https://chromium-review.googlesource.com/1162671Reviewed-by:
-
Jia authored
Model could error out so we need to record this response in the log. Also, the logged inactivity_score and decision_threshold are quantized version of the actual values used in the inference. Hence the model now returns it decision as part of the prediction. Bug: 862461 Change-Id: I14c889d97bebd93b88a86027ff94b2ce7fad5bfb Reviewed-on: https://chromium-review.googlesource.com/1154243 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Cr-Commit-Position: refs/heads/master@{#580740}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8bf477cb2a8d..ff52e88a74bc git log 8bf477cb2a8d..ff52e88a74bc --date=short --no-merges --format='%ad %ae %s' 2018-08-04 emircan@webrtc.org Revert "Extract color space from Vp8 decoder" Created with: gclient setdep -r src/third_party/webrtc@ff52e88a74bc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I4b36a20e49cffba9270b8b8368e60e36d5bed6ed Reviewed-on: https://chromium-review.googlesource.com/1162809Reviewed-by:
-
Yuri Wiitala authored
As part of the major clean-up/refactoring of the legacy GLHelper code, this change addresses the "low-hanging fruit." 1. Removed dead code. Removed support for image formats that callers never use, such as RGB565. 2. Moved-out trivial one-liners and most methods having only one caller (where the justification for a centralized/shared utility method is doubtful). 3. base::Callback → base::OnceCallback migration foo. 4. Deleted GLHelperReadbackSupport, and added some simple "GL_BGRA_EXT preference" code (the only use case was internal gl_helper.cc code). 5. Removed several dependencies on GLHelper (mainly, in content/browser/compositor) that were no longer needed. Testing: Existing unit tests run through most of the code. Also, manually tested the HTML Canvas Video Capture feature to double-check BGRA readback code changes. Bug: 870036 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I759f8cf342b30e151d121c2929ed5456185e73a3 Reviewed-on: https://chromium-review.googlesource.com/1159739 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#580738}
-
Jun Choi authored
According to the CTAP spec, CTAP2 authenticators will always error out when MakeCredential request with an empty "pinAuth" parameter is received to a device that has client pin already set. This prevents any users with CTAP2 devices with client pin set to use Chrome as a client. Until client pin command is implemented on Chrome, use U2F register request when possible when we know that the device has client pin set. Bug: 870131 Change-Id: Ia26d991f2b92e46c0d67625e25d88365d1d72089 Reviewed-on: https://chromium-review.googlesource.com/1159726Reviewed-by:
Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#580737}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/2958a8faf500..e819c2057ffd git log 2958a8faf500..e819c2057ffd --date=short --no-merges --format='%ad %ae %s' 2018-08-03 rharrison@chromium.org Make CFX_XMLParser less permissive Created with: gclient setdep -r src/third_party/pdfium@e819c2057ffd The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:863098 TBR=dsinclair@chromium.org Change-Id: I81774696680a4484449360a9c75cb70fad3995d4 Reviewed-on: https://chromium-review.googlesource.com/1162388Reviewed-by:
-
Philip Rogers authored
PaintArtifactCompositor is a new compositing algorithm (slimming paint v2, SPV2) and we also have a legacy algorithm. Blink gen property trees is an incremental step towards lunching the new algorithm, and uses parts of both the new and legacy systems. To disambiguate our metrics, the PaintArtifactCompositor metrics are being renamed to Blink.CompositingCommit.UpdateTime. SPV175 (current): Only Blink.Compositing.UpdateTime BlinkGenPropertyTrees: Blink.CompositingCommit.UpdateTime and Blink.Compositing.UpdateTime SPV2: Only Blink.CompositingCommit.UpdateTime Bug: 865168 Change-Id: Ia676208a8b10cf14f5add11c09f2d7884b5d71e1 Reviewed-on: https://chromium-review.googlesource.com/1145478Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#580735}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3671fec0. With Chromium commits locally applied on WPT: 7dad0f17 "Added new Sec-Metadata Web Platform Tests." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22286 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: dcheng@chromium.org, scottmg@chromium.org: external/wpt/domparsing eae@chromium.org, szager@chromium.org: external/wpt/intersection-observer rijubrata.bhaumik@intel.com, mcasas@chromium.org: external/wpt/html-media-capture tdresser@chromium.org: external/wpt/hr-time external/wpt/navigation-timing TBR=foolip No-Export: true Change-Id: I5eb61e8b039845d861dd2339ffaf07f571d73c66 Reviewed-on: https://chromium-review.googlesource.com/1162965 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
Emircan Uysaler authored
This is the first CL in adding getDisplayMedia() support in chromium. See the bug and linked design doc for the detailed plan. This CL adds getDisplayMedia() interface behind runtime enabled features flag "GetDisplayMedia". This call will use the same call stack as getUserMedia() but have different media request type and handling of constraints. - Adds WebUserMediaRequest enums to differentiate this call. - Adds specific handling of constraints in UserMediaRequest::Create(). As defined in the spec, this accepts empty constraints. - Currently ends up in a NotSupported error as chromium changes are landing. - Adds first set of Layout Tests to check these expectations. Intent To Implement: https://groups.google.com/a/chromium.org/forum/#!msg/Blink-dev/j7k2nI_9nng/OE6IvgJyAQAJ Bug: 326740 Change-Id: I03c54cab259a57db99449d9c4510c484f22c5b93 Reviewed-on: https://chromium-review.googlesource.com/1155942Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#580733}
-
John Abd-El-Malek authored
chrome_rlz_tracker_delegate.cc depended on browser_process.h which had transitive dependencies on generated mojoms. But it didn't get the public_deps because the rlz target didn't depend on chrome/browser to avoid circular dependencies. Fold it into chrome/browser to fix this properly. This does mean that the one unit test in chrome_rlz_tracker_delegate_unittest.cc will not run on chromium-branded bots anymore. That seems better than having flaky dependencies, since untangling the build dependencies looks like a lot of work. This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1161610 with official Google ChromeOS build fix. TBR=avi Cq-Include-Trybots: luci.chromium.try:linux_chromium_dbg_ng Change-Id: If1cbab605ee0f14ec4c942d0c4b03b318e7d3c41 Reviewed-on: https://chromium-review.googlesource.com/1162922Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#580732}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/3387250e88bc..4e706b495ebe git log 3387250e88bc..4e706b495ebe --date=short --no-merges --format='%ad %ae %s' 2018-08-03 xixuan@chromium.org chromeos_config: Move nyan_blaze-release to Skylab for testing. Created with: gclient setdep -r src/third_party/chromite@4e706b495ebe The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ie7b6b591483e8a1d699fc8c64c16c0a4c6c90762 Reviewed-on: https://chromium-review.googlesource.com/1162808Reviewed-by:
-
