GitLab

Change-Id: I1127d2bceaa5fa0fcb596f1f5b854e8e75572080
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641964Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Auto-Submit: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665717}

Upstream AppHooksImpl.java https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/AppHooksImpl.java has a conflict with downstream AppHooksImpl.java like https://cs.corp.google.com/clank/java/src/org/chromium/chrome/browser/AppHooksImpl.java when generating coverage report.
Don't instrument the upstream one as the downstream targets will provide implementation.


Bug: 965606
Change-Id: I3094b3fcf846fceab4b3acb9624f96be0d36bee9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641542Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Yun Liu <yliuyliu@google.com>
Cr-Commit-Position: refs/heads/master@{#665716}

Bug: 778674
Change-Id: If526c9e498e804e26f0ed6d55df8a69b98714b97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640583
Commit-Queue: Stuart Langley <slangley@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665715}

Bug: 967793
Change-Id: I70a3b5e9451dbf9dbbd79a3fe6d7371adf9e9666
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641366
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Auto-Submit: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665714}

This CL passes PseudoElement to StyleResolverState, so that
ElementStyleResources::LoadPendingResources() can listen on the
appropriate pseudo element to defer and lazyload the background image.

Bug: 950503
Change-Id: Ieab6c4284ac6d405ba49d0d2535d3b05ce95fea2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632595
Commit-Queue: rajendrant <rajendrant@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665713}

This is in preparation of removing the custom cr.EventTarget
implementation in favor of native EventTarget.

Bug: 854268
Change-Id: Idb59b729ec3a3026ff08c9a87aed02714b11fc22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639644
Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665712}

Bug: 969137
Change-Id: I05d0646f11e0546197b1502f35b3d79bfa8cb324
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637055Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Commit-Queue: Caitlin Fischer <caitlinfischer@google.com>
Cr-Commit-Position: refs/heads/master@{#665711}

Update histogram expiry for Declarative Net Request histograms.

BUG=967476

Change-Id: I45410b21e8b30600d412e71075cbc182ba395dc6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636228
Auto-Submit: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665710}

I also reduced the wait time in the optional dimensions for mac_10.14 bot
from 10 minutes to 5 since I was adding the additional dimension to
(possibly) wait for.

Bug: 968531
Change-Id: Icc7e224c7e7c7fdc72258c9fb898f06d781b4538
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636557Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665709}

The test parameterization changes are essentially an undoing of
https://chromium-review.googlesource.com/c/chromium/src/+/1207193/

Bug: 878416
Change-Id: I2672a3cdf8c90f338ab9036dbed2fefd2ea06587
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639820Reviewed-by: Anne Lim <annelim@google.com>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#665708}

This was only set once, and the caller set it to the default behavior.

Bug: 957264
Change-Id: I13b47fe69e44fe8394bf22fe6433655023d1b4c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640604
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665707}

Rewrote some of the codes because if we want to take a screenshot, the
screenshot call should go before the CrossFade animation starts.

This CL changes some of the logic for the UMA logging for that future
purpose. We now observe the window layer before the cross fade, then
start the fps counter once a transform animation on that layer has been
scheduled. If after the tabletModeWindowState objects are created and
the there is no animation, the observation is cancelled.

Test: manual
Bug: 968766
Change-Id: I2087962489f7da11b9cb56e33b988eb7ab89b106
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616001Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665706}

This commit creates a settings page for Switch Access behind the
Switch Access experimental flag. The page is not accessible to users at
this point except by typing in the direct URL
(chrome://settings/manageAccessibility/switchAccess) with the flag
enabled. The preferences set here are not yet connected to the behavior
of Switch Access.

Bug: 958081
Change-Id: I86951e2877c18c047053a4ec3fcb3b2f18dd46b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600082
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Reviewed-by: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665705}

This code isn't needed anymore. There's still a lot of related code left; I'm stopping at this point to keep changes manageable to review.

Bug: 934009
Change-Id: Ibe2b5861fa45f0bd8e67f86aed1d52c256b2e0a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640718Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665704}

In a future patch we need to associate attach TabSizeInfo with
individual TabAnimationStates, so that group headers can be sized
differently than tabs. However, because tab_strip_layout calculates
the cached active/inactive tab widths using fake TabAnimationStates,
it's not clear which TabSizeInfo it should use.

This patch moves that calculation into TabStripLayoutHelper, which can
use the active tab index to get an actual tab's width for the cached
values.

Bug: 905491
Change-Id: I32894ca93d7d5d7961ca44b87ea1437037996cfa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639045Reviewed-by: Taylor Bergquist <tbergquist@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665703}

We shouldn't allow the page to override the outline style if the user is
using spat nav since that could lead to invisible interest.

Change-Id: I64c5ab39768033f56b8ffb6efa9e72672ae641da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635194
Auto-Submit: David Bokan <bokan@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665702}

TBR=simonhatch@chromium.org

Bug: 969819
Change-Id: I772891cbfacaae9c6d0c233e2934e54826bec69c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639576Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Auto-Submit: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665701}

Builders migrated (CI/CQ):
- Android FYI 32 Vk Release (Pixel 2) / gpu-fyi-try-android-p-pixel-2-32-vk
- Android FYI 32 Vk Release (Pixel XL) / gpu-fyi-try-android-p-pixel-xl-32-vk
- Android FYI 32 dEQP Vk Release (Pixel 2) / gpu-fyi-try-android-p-pixel-2-32-deqp-vk
- Android FYI 32 dEQP Vk Release (Pixel XL) / gpu-fyi-try-android-p-pixel-xl-32-deqp-vk
- Android FYI 64 Vk Release (Pixel 2) / gpu-fyi-try-android-p-pixel-2-64-vk
- Android FYI 64 Vk Release (Pixel XL) / gpu-fyi-try-android-p-pixel-xl-64-vk
- Android FYI 64 dEQP Vk Release (Pixel 2) / gpu-fyi-try-android-p-pixel-2-64-deqp-vk
- Android FYI 64 dEQP Vk Release (Pixel XL) / gpu-fyi-try-android-p-pixel-xl-64-deqp-vk
- Android FYI Release (NVIDIA Shield TV) / gpu-fyi-try-android-n-nvidia-shield-tv-64
- Android FYI Release (Nexus 5) / gpu-fyi-try-android-l-nexus-5-32
- Android FYI Release (Nexus 5X) / android_angle_rel_ng
- Android FYI Release (Nexus 6) / gpu-fyi-try-android-l-nexus-6-32
- Android FYI Release (Nexus 6P) / gpu-fyi-try-android-m-nexus-6p-64
- Android FYI Release (Nexus 9) / gpu-fyi-try-android-m-nexus-9-64
- Android FYI Release (Pixel 2) / gpu-fyi-try-android-p-pixel-2-32
- Android FYI dEQP Release (Nexus 5X) / android_angle_deqp_rel_ng
- Deterministic Android / android-deterministic-rel
- Deterministic Android (dbg) / android-deterministic-dbg

Bug: 950413
Change-Id: I105e8400c7e7375fc5fc1a029bb2fd9e78744e56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641762Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Simon Que <sque@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665700}

Uses existing single buffered low latency path i.e.
ExternalCanvasResource and CanvasResourceProviderPassthrough

Bug: 939657
Change-Id: Iab01d658de9e77012f4d87fd54984930cabf6561
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622367
Commit-Queue: Ashitha Santhosh <ashithasantosh@google.com>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665699}

Instead of set the pointer to nullptr during error,
CHECK the error w/ u_errorName for better diagnostic.

Bug: 950322
Change-Id: I9b0c0ba0d26a375a35a8e9c5df3431398c193e42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623465Reviewed-by: Jungshik Shin <jshin@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665698}

The host installer package was trying to run the config-upgrade tool
using the wrong path to the host binary.

Bug: 970029
Change-Id: I1d63c0151343ef6fa8e45c7d56663c29ef6754f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642129
Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Auto-Submit: Lambros Lambrou <lambroslambrou@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665697}

Bug: 967793
Change-Id: I94808c1645c87c81f789bd6e8165042ae4246574
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640800Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665696}

Rename the following classes
  views::BridgedNativeWidgetHostImpl ->
     views::NativeWidgetMacNSWindowHost
  views::BridgedNativeWidgetImpl ->
     remote_cocoa::NativeWidgetMacNSWindowBridge
  remote_cocoa::BridgedNativeWidgetHostHelper ->
     remote_cocoa::NativeWidgetNSWindowHost
  remote_cocoa::mojom::BridgedNativeWidget ->
     remote_cocoa::mojom::NativeWidgetNSWindow
  remote_cocoa::mojom::BridgedNativeWidgetHost ->
     remote_cocoa::mojom::NativeWidgetNSWindowHost

TBR=ellyjones (reviewed doc)

Bug: 958255
Change-Id: I5eb9dd8170a7636968da08cb554efa7f955f7022
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640804Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665695}

TBR=tsepez@chromium.org

Change-Id: I92c4525694b3092cb5eccac07977f8663c058c71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639520Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665694}

If neither feature is enabled, only DragToClose mode should be available

BUG=969815
TEST=Manually, Added tests

Change-Id: Iafaab2ef36a5c1f14bfcec266c3c558145a5f7f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642147Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665693}

The signature for the function is changed for simplicity, as there is
only one callsite for this helper. Confirmed test works on EG1.

Bug: 922813
Change-Id: I2684bd847e072da5f060eb8766f8e27101081c66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636279
Commit-Queue: ericale <ericale@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665692}

Split the forced live thumbnail capturing out of the normal caching
path. The forced live thumbnail is captured as low-res, and won't be
saved to the cache. This makes it faster so that using it during
the Tab-to-Grid transition animation won't affect the frame rate too
much.

Bug: 968829
Change-Id: I32ffa8553b5aefb29944781404292a8b891d8d80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637979
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665691}

Reland of "DevTools: Make Settings Blackboxing Pane Accessible"

Initially, the change https://chromium-review.googlesource.com/c/chromium/src/+/1605506 was reverted in order to
revert "DevTools: Make Preferences Settings Pane Accessible" crrev.com/c/1618170.
Both of the original changes had added axe tests for it in basic-a11y-test.js which was timing out in Ubuntu build 14.04.
The change here only makes blackboxing pane accessible and doesn't add test in basic-a11y-test.js.
Test for it will be added in a seperate PR.
Original change: https://chromium-review.googlesource.com/c/chromium/src/+/1605506
Reverted change: https://chromium-review.googlesource.com/c/chromium/src/+/1618026

Change-Id: I51f80cfec544118d6173ca8fafd1b3eff50de6b1
Bug: 963183
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636728
Commit-Queue: Chandani Shrestha <chshrest@microsoft.com>
Reviewed-by: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665690}

When a text node starts with a space run that contains newlines, it's
possible that the text node's inline items can't be reused in relayout
due to segment break transformation rules.

This patch applies the rules to check if the newline is handled
differently in relayout, and if so, stops reusing the old inline items.

Bug: 969089
Change-Id: I163b2542154ea79971fb13922489441873c1712b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641989Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665689}

- Previously, only discovered printers would show the subtext in the
  make/model dialog.
- This change will enable the subtext in the make/model dialog for manual
  printers.

Bug: 955130
Test: end to end manual
Change-Id: If1421bc0db890bdd8e66aa93abf0dc1a4e007289
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635852Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Commit-Queue: jimmy gong <jimmyxgong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665688}

Bug: 968585
Change-Id: Iac1fb526167a0b3ba53a418db439cfdf4f6754ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639179Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Andrew Luo <aluo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665687}

TBR=meacer@chromium.org

Change-Id: I3252bc2dd7f73716e8d16618e8e1d70c6bc4207f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642028
Commit-Queue: Krishna Govind <govind@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665686}

- Make DocumentScanScanFunction a UIThreadExtensionFunction so that
  API -> DocumentScanInterface -> LorgnetteManagerClient runs on UI
  thread;
- Update DocumentScanInterface to use OnceCallback;

Bug: 966178
Change-Id: I0428299174dcd949ff06b2a17fb492aef0df7349
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637874
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665685}

Bug: 969239
Change-Id: I90d3d7421394e8801969eda2dbc2bcce8e6832e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641367
Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org>
Auto-Submit: Jeffrey Cohen <jeffreycohen@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: sebsg <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665684}

Bug: 927809
Change-Id: Ibd37e6fe3ec7fc43b1ae72d3d52e695b7fd865f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641991
Commit-Queue: Bruno Santos <brunoad@chromium.org>
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Auto-Submit: Bruno Santos <brunoad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665683}

Adds a syncable extension preference for pinned extensions to keep them
in sync. This is used in place of the previous "visible extensions"
paradigm.

Notably extensions are not pinned by default, whereas before they were
initially visible on the toolbar.

Bug: chromium:959932
Change-Id: I23fa0d5314317c079841540e18449646f4da9076
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598818
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665682}

No longer used anywhere.

Bug: 965663
Change-Id: I7ea45227ff810bcb6696ce6ce50063e1e5c2be26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637981Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665681}

If request it too large for the server, we move to the next request
without retry. If there is no more request, we notifies the accomplishment
to the caller as they are succeeded.

Bug: 956237
Change-Id: Ie157c8b8d884d345d4212bbc86b8ceaa76428de1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639238Reviewed-by: Marc-André Decoste <mad@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665680}

This change removes whitespace between list items and bottom navbar.
Screenshot before (with old styling): http://screen/BMAx13oRGeP
Screenshot after: http://screen/4RB0K6kaYTX

BUG=959317
R=mdjones@chromium.org

Change-Id: I33927472dbb7c04639c80dd4314e388a92bd39a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639352Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Pavel Yatsuk <pavely@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665679}

This CL has no behavior change.

Bug: None
Change-Id: I0efcac8a947d15e1f7b87f00d0bea0bf385c5fa9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641517Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665678}