- 24 Sep, 2020 40 commits
-
-
Andrew Grieve authored
Our version of R8 no longer works with java -jar Bug: None Change-Id: Ida233fed73b2be6f65a54a292efbda6a1c2ec4cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426772 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#810200}
-
David Roger authored
This CL adds logic to trigger the profile customization after signin interception. The UI is not implemented yet and will be added in other changes. Bug: 1130945 Change-Id: I8878ec80ef6135c30fedd06b00c49ba76249d6de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423509Reviewed-by:
Monica Basta <msalama@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#810199}
-
Xida Chen authored
This CL creates a new JSAnimation tracker to track whether there is inline style mutation in the current frame or not. Bug: 1111392 Change-Id: Idc08e8c6ba7d0243eccd9623a325eee34fcbc91b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418536Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#810198}
-
Joel Hockey authored
Bug: b/168506505 Change-Id: Ic73019e3027d259e52bfb75d6f0716b0c42b1605 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426069 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Jason Lin <lxj@google.com> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#810197}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1600927122-8b2948f1592bbc4f5258707765d485dd2b5e6892.profdata to chrome-linux-master-1600948720-175990bf7d350cbec3f87177d4fba26f3b99d541.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com Change-Id: Iec3a83ada08f2eed2c7cf61101ed6064e299ce52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428808Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810196}
-
Hans Wennborg authored
prev_match can be set to -1 after sliding the window. In that case, the window has slid past the first byte of the last match, which means it cannot be compared in check_match. This would cause zlib to crash on some inputs to deflate when built with ZLIB_DEBUG enabled. Check for this situation and avoid crashing by not trying to compare the first byte. Bug: 1113142 Change-Id: I26f006d81b91591e07fb02207e64b8440f7a5c50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426443 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Adenilson Cavalcanti <cavalcantii@chromium.org> Cr-Commit-Position: refs/heads/master@{#810195}
-
Samuel Huang authored
This CL fixes the problem where .sizediff files created by SuperSize-save_diff differ across identical runs. This happens because the order of alised symbols from _ExpandSparseSymbols() become arbitrarily ordered. The fix is to refine sort key in SortSymbols(). Change-Id: Ida24d0d97e261ce9aa65ed3a393e9e754c0951d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426552Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#810194}
-
Yunke Zhou authored
Bug: 1131446 Change-Id: Ia547d067838981be1ff5237f9e178cdc39e2e3e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424141Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Yunke Zhou <yunkez@google.com> Cr-Commit-Position: refs/heads/master@{#810193}
-
Matt Falkenhagen authored
The intent is to measure the page loads that do a blocking (i.e., non-deferrable) subresource request with cookies to a third-party from a first-party frame. This is meant in the context of prererendering: deferrable means the request can be delayed until navigation, without blocking progress by the prerendered page. Currently this is only measuring synchronous classic (non-module) <script> elements with cookies (not other credentials), but this may expand later. Bug: 1131317 Change-Id: I34eea95c67501406928875ce3fe3c3c14e6f372e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423757 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#810192}
-
Andrew Grieve authored
Bug: 1131899 Change-Id: Idd9ba4dfa834a079da696102b9cbb60dd2813739 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428824 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#810191}
-
Viktor Semeniuk authored
This reverts commit b74492d3 Original change's description: > Update ChangeSavedPassword function. > > In the previous version, this function allowed changing the username > and optionally changing the password. > In the new version, this function allows to change only the password > and returns true if the password was successfully changed. > > > Bug: 377410 > Change-Id: I0b555b404b781d8fa35c9eda1aff442141ab9219 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302638 > Commit-Queue: Irina Fedorova <irfedorova@google.com> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#791170} Bug: 377410 Change-Id: I48ff8e1ce006a736adbe7c6202ae8ae6c83cb92a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410032 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#810190}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0ed7f1fab2e9..afef7a74a796 2020-09-24 gustaf@webrtc.org HMM based transparent mode classifier 2020-09-24 hta@webrtc.org Reland "Remove stopped transceivers at both local and remote SetDescription" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I5658fffbd33922ecf998926aaf18c207d8653b4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428084Reviewed-by:
-
Benoit Lize authored
Bug: 998048 Change-Id: I94a817cfeeb08233078c1727fca1ab21ee83d099 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424161 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#810188}
-
Mariia Shvedchenko authored
Making class singleton, added implementation for methods. Change-Id: I85fd35dff65a809e6b486ced91f7899e140fc667 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404850Reviewed-by:
Christoph Schwering <schwering@google.com> Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Mariia Shvedchenko <mariiash@google.com> Cr-Commit-Position: refs/heads/master@{#810187}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/75e5ed6161fc..ed0b3cf15389 2020-09-24 cwallez@chromium.org Refactor PipelineLayoutBase::CreateDefault If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ieebbd06d73cf7a2e03a89fd2493b1568764f00ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428214Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/52c1ebb26cdd..85d92d37c4c2 2020-09-24 landrey@webrtc.org Use OAUTH for /uploads API If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1114056 Tbr: wenbinzhang@google.com Change-Id: I5ae00c0b149b91d56a7901935432d8b48495959d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428204Reviewed-by:
-
Aya ElAttar authored
Changed EnterpriseClipboardDlpController to show toast notification when clipboard data access is blocked. Bug: 1096461, 1102332 Change-Id: I8f3aaf066c04468ba3a1c4716da02bdf878b7beb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416514 Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#810184}
-
Rune Lillesveen authored
Per CSSWG resolution[1]. Also move the tests to wpt/html since the spec is moving there per the same resolution. Relevant spec pull requests are [2][3]. [1] https://github.com/w3c/csswg-drafts/issues/3846#issuecomment-648923121 [2] https://github.com/whatwg/html/pull/5938 [3] https://github.com/w3c/csswg-drafts/pull/5540 Bug: 1103669 Change-Id: I553c5ca8c1223cd746dc05471eb6d3c5d9d5f19b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380654Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#810183}
-
Samuel Huang authored
Change-Id: Ic647c643d9719d8c2f358df92163cbd4657a1f3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426614Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c23abb18bf27..a3fd937cbdee 2020-09-24 patrick.brosset@microsoft.com Don't display grid adorners on shadow roots 2020-09-24 alexrudenko@chromium.org Refactor distances tool to use new Overlay class 2020-09-24 patrick.brosset@microsoft.com Fix jumping horizontal scrollbar in the Elements pane 2020-09-24 alexrudenko@chromium.org Add Contrast Issues section to CSS Overview 2020-09-24 tmathmeyer@chromium.org Fix blank row where text track information goes on no-track videos 2020-09-24 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. 2020-09-24 szuend@chromium.org [ts] Type-check sources/SourcesSearchScope.js with TypeScript 2020-09-24 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1120316,chromium:1128314,chromium:1128873,chromium:1129760,chromium:1131801 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6e826891450be40ba223b40f0018f01831197927 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427684Reviewed-by:
-
Eric Willigers authored
We now follow the recent spec change limiting the permitted scheme for shared urls to http and https - see https://github.com/w3c/web-share/issues/173 https://github.com/w3c/web-share/pull/174 https://github.com/w3c/web-share/pull/177 We make an exception if the page performing the share it itself loaded from a different scheme (e.g. file) - in that case we allow the same scheme to be used for the shared url. Bug: 1131755 Change-Id: I6abf0f9acd40ef79ec49379314e2ef3a81d3467e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425977 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#810180}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4005bb741040..3eb2555a627b 2020-09-24 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com Change-Id: I3c3cc74bea5942dfbd14b265693b299dbe2ff6bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427664Reviewed-by:
-
Sigurd Schneider authored
This test is re-written as a unittest in https://crrev.com/c/2428327 Bug: chromium:1011811 Change-Id: I00d1416663fec352fe01fff7823da336ce5ac05a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426434Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#810178}
-
Sigurd Schneider authored
This CL adds a method to the Network domain that DevTools can use to fetch resources in a more secure way. Such resources are, for example, source maps, or files referenced by source maps. The improvement over the old implementation is that the fetch now is very similar to a fetch in the page and uses the correct settings for SiteForCookies and NIK. Initially, we had planed to change source map fetching to CORS, but this would be a breaking change, so due to COVID-19 and the hold on breaking changes, this CL uses a no-CORS fetch with CORB blocking disabled to fetch source maps. CORB-blocking must be disabled because source maps may be valid JSON. The front-end can provide a frame_id (in DevTools terms, a devtools frame token in Chromium terms) and the page will look for this frame id in its sub resources. The fetch will then occur using a loader that is very similar to the loaders for that frame. Change-Id: Ideb36adbd79b9a36e6d3333299dcd036eb7a1332 Bug: chromium:1069378 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027416 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#810177}
-
David Roger authored
These features will be launched together, so it's better to consolidate them under a single flag. This will make testing easier in particular, and reduce the number of possible configurations. The features kProfileThemeSelectorInSettings and kSignInProfileCreationFlow are now merged as kProfilesUIRevamp. The profile switch bubble is also moved under this flag. Bug: 1108289 Change-Id: I5c5fe9a9686a355e075b5dc3db69311d1e05b138 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426565 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#810176}
-
Caitlin Fischer authored
Bug: 1126640 Change-Id: I15f954580b9d6bb4ed692183dacbd51917b4e149 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427355Reviewed-by:
-
Rohit Agarwal authored
This CL does the following changes: a) Aligns the buttons more towards the right with 24dp spacing in the end as per the UX mocks. b) Adds a 20dp bottom spacing under the buttons as per the UX mocks. Screenshot: crbug.com/1129357#c2 Bug: 1129357, 1116419 Change-Id: I391be1ff726e6645a58252d31f0b97c49afe2202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420610Reviewed-by:
Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#810174}
-
Koji Ishii authored
This patch refactors |NGFragmentItem::RecalcInkOverflow| to take |const NGInlineCursor&| instead of |NGInlineCursor*|. With this refactoring, it is callers' responsibility to advance the cursor. This is to prepare using this function for self-painting |LayoutInline|. This patch has no behavior changes. Bug: 1128199 Change-Id: Iee1964255f5d1c31b4d3cf4e1bb73b6c4b50f327 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426213Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#810173}
-
Andrei-Laurențiu Olteanu authored
Add implementation to chrome://. Add implementation to chrome-untrusted://. Add tests. Bug: b:162051831 Change-Id: Ia0389cc9f7fbd052559121b8c69d521cc433777a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414178 Commit-Queue: Laurențiu Olteanu <lolteanu@google.com> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Cr-Commit-Position: refs/heads/master@{#810172}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1600775907-34bfad4572405dae937638ebe3b1eeb7936a17be.profdata to chrome-win32-master-1600905490-fe209194e056a39e0ecce0cfbf9501bffc967720.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com Change-Id: I7955d03fa0c10544c6f0e803645ad8fa88b72951 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427966Reviewed-by:
-
Christian Dullweber authored
Show confirmation for cookie deletion before deleting cookies. Screenshot: https://crbug.com/1077766#c50 Bug: 1077766 Change-Id: I916cdde882dcaf31b9313661a8f734c9112b2640 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426424Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#810170}
-
Lei Zhang authored
This is a reland of 0ca8e290 The problem that triggered the revert has been resolved in https://crrev.com/810037 Original change's description: > Check for static initializers on linux-chromeos-rel. > > Bug: 537099 > Change-Id: I7d006d2a563de005b22945f0eabb723f86657862 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416563 > Commit-Queue: Lei Zhang <thestig@chromium.org> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#809945} Tbr: thakis@chromium.org,thomasanderson@chromium.org Bug: 537099 Change-Id: Ic4f699ac781c47412cbe4995e7e75139cfe4a631 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427294Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#810169}
-
Jan Wilken Dörrie authored
This change adds a separate header for forward declarations of password_manager::PasswordForm. Since this is currently only an alias of autofill::PasswordForm, a naive forward declaration does not work. Furthermore, this change creates a new target for password_form, making it easier to split up cycling dependencies between several password_manager sub components. Bug: 1067347 Change-Id: Ia5e6cd83dfd84b09c7dd3069d4f86ca2830102fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426449 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#810168}
-
Andrew Grieve authored
All usages have now moved to build_vars.json Bug: 1114750 Change-Id: Ibf6c74fdd24070ba2e32f2c8c43a9b40948d5beb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424525 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Reviewed-by:
Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#810167}
-
Stepan Khapugin authored
Move some methods from MainControllerGuts to StartupInformation, where I think these methods belong, as they are startup-related. Bug: 1045659 Change-Id: I1e915f9c95c7c965a9fbdb1858608feedc4cf32b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418406 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#810166}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I26977782060c595e8d35df0e83203783e5b72465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428168Reviewed-by:
-
George Burgess IV authored
field_info is having `(char)field->initial_value_hash().value()` appended to it here. The actual number is probably what was intended. Bug: 1130867 Change-Id: I40a0c993938d354a19d79e3ea3673fd3f17d2f94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426344Reviewed-by:
-
Martynas Sinkievic authored
Change-Id: I9ffc936f26122a54297ec99e8f1f1a947cb854a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423884Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Martynas Sinkievič <marsin@google.com> Cr-Commit-Position: refs/heads/master@{#810163}
-
Hidehiko Abe authored
Bug: 1110266 Test: Built locally. Change-Id: I291f594060beed19d8497c5d6b7689effbe3dc9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413458Reviewed-by:
-
Danila Kuzmin authored
Tab keystroke from user options menu on a lock screen should move focus to the next available user pod or "Shut down" button, if there is no more user pods in a row. Also focus should stay in a dropdown menu, if keys other than Tab or Escape are pressed. Previously any keystroke from the “Remove account” button inside the dropdown menu has always moved focus to the “Shut down” button. Bug: 1107667 Change-Id: I8b0579e477b9f055ead9cd13e06a88982ab31db1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418572Reviewed-by:
-
