- 11 Jan, 2019 40 commits
-
-
Eric Stevenson authored
The script will generate a regular report for the build and a diff report (using a .size file from the latest build of the previous branch). Example usage: tools/binary_size/libsupersize/generate_official_build_report.py \ --version 73.0.3666.0 \ --size-path Monochrome.apk.size \ --gs-size-url gs://some_bucket_path \ --gs-size-path arm/Monochrome.apk.size \ --arch arm \ --platform android The script takes less than a minute to run locally. Bug: 919213 Change-Id: Ie52df4dc52634488e24d48ecf306c343a45fbc7b Reviewed-on: https://chromium-review.googlesource.com/c/1405174 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#622001}
-
Tim Volodine authored
This reverts commit 0b15d057. Reason for revert: broke many bots (go/clankbot) and also official build (see e.g. crbug.com/920520) one related patch was already reverted, for reference: https://chromium-review.googlesource.com/c/chromium/src/+/1404736 Original change's description: > Track when the auto-fetch in progress notification should be shown > > Watch for navigations and request coordinator changes to determine when > the in-progress notification should be shown. > > A follow-up CL will introduce an instrumentation test to supplement the > unit tests here. > > Bug: 883486 > > Change-Id: Ib3fe1eececab45eafbeca56fe05425919ba43f04 > Reviewed-on: https://chromium-review.googlesource.com/c/1381233 > Reviewed-by: Peter Williamson <petewil@chromium.org> > Commit-Queue: Dan H <harringtond@google.com> > Cr-Commit-Position: refs/heads/master@{#621849} TBR=petewil@chromium.org,harringtond@google.com Change-Id: I7bf6944094512239bb97dc20f295bcd654792d8d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 883486 Reviewed-on: https://chromium-review.googlesource.com/c/1406997Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#622000}
-
Ramin Halavati authored
'PageLoadInIncognito' metrics is based on page load starts that include pre-sign-in requests for ChromeOS. The metrics is moved to RecordMainFrameNavigation to only record navigations in incognito mode after ChromeOS sign-in. Bug: 912346 Change-Id: Ifba62d9bddf67b3157ae8650cb344b9c77449803 Reviewed-on: https://chromium-review.googlesource.com/c/1404085Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#621999}
-
Marc Treib authored
Turns out the previous crrev.com/c/1402889 missed not one, but two owners files... Bug: none Change-Id: I609ca114a08c1ac811ff8503d2d3e976c71acf1a Reviewed-on: https://chromium-review.googlesource.com/c/1406994Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#621998}
-
Arthur Sonzogni authored
In content/public, there is two ways to act on a new navigation: 1) The "new" ones that are NavigationHandle based. Users of the API needs to implement either a WebContentsObserver or a NavigationThrottle. Then, they can act on the NavigationHandle. 2) The "legacy" ones where you implement the ContentBrowserClient: ContentBrowserClient::NavigationRequestStarted() ContentBrowserClient::NavigationRequestRedirected() The latter are used to modify request headers and load flags. The goal is to remove 2) and keep only 1) This CL is making able to modify headers from the NavigationHandle. Following CL will deprecate and then remove 2). Bug: 919432 Change-Id: I4db812d4cf1df2f67cf8bf97dca410009a1a3046 Reviewed-on: https://chromium-review.googlesource.com/c/1392949Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#621997}
-
Peter E Conn authored
Bug: 917689 Change-Id: I47ebc888c2dbcfec92d450ab04bd29ffb9e1f301 Reviewed-on: https://chromium-review.googlesource.com/c/1393267 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#621996}
-
Xida Chen authored
It appears that this type is never used. This CL removes it. It should be fine as long as all bots are green. Bug: None Change-Id: I7ce93b45c4788f9d48edd0c0c7c0ed27ffd14e17 Reviewed-on: https://chromium-review.googlesource.com/c/1406075Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#621995}
-
Roman Sorokin [CET] authored
This reverts commit cc10cead. Reason for revert: Broke the build (see https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Fuchsia%20ARM64/50818 ) Original change's description: > Support IsolatedCodeCache for service worker pass-through responses. > > Previously code caching of scripts served from service workers was only > supported if the Response was produced from cache_storage. If the > service worker implemented a pass-through handler like: > > evt.respondWith(fetch(evt.request)) > > Then the v8 compiler could not store or load code cache for the script. > > With IsolatedCodeCache shipping it becomes much simpler to now > support this feature. This CL enables support by: > > 1) Fetching the code cache for service worker controlled scripts. > 2) Allowing the code cache to be used for pass-through responses. > 3) Storing any code cache produced for pass-through responses. > > We still explicitly disable code cache for service worker handlers that > produce either: > > a) Synthetic `new Response()` objects. > b) Response objects produced by `fetch()` to a URL different from the > original request URL. > > Bug: 917414 > Change-Id: I4efdc852a27069d2937056af0133a986e745b2be > Reviewed-on: https://chromium-review.googlesource.com/c/1394740 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: Ben Kelly <wanderview@chromium.org> > Cr-Commit-Position: refs/heads/master@{#621993} TBR=kinuko@chromium.org,mythria@chromium.org,wanderview@chromium.org Change-Id: I966c165c6978121a6ca68823d10ec697d0fa94f6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 917414 Reviewed-on: https://chromium-review.googlesource.com/c/1406995Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#621994}
-
Ben Kelly authored
Previously code caching of scripts served from service workers was only supported if the Response was produced from cache_storage. If the service worker implemented a pass-through handler like: evt.respondWith(fetch(evt.request)) Then the v8 compiler could not store or load code cache for the script. With IsolatedCodeCache shipping it becomes much simpler to now support this feature. This CL enables support by: 1) Fetching the code cache for service worker controlled scripts. 2) Allowing the code cache to be used for pass-through responses. 3) Storing any code cache produced for pass-through responses. We still explicitly disable code cache for service worker handlers that produce either: a) Synthetic `new Response()` objects. b) Response objects produced by `fetch()` to a URL different from the original request URL. Bug: 917414 Change-Id: I4efdc852a27069d2937056af0133a986e745b2be Reviewed-on: https://chromium-review.googlesource.com/c/1394740Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#621993}
-
Mounir Lamouri authored
Found that the code examples were using the old coding style. Bug: None Change-Id: I3ce8f3bc1ab3b6c6c3f4484685b1f42d66437cf8 Reviewed-on: https://chromium-review.googlesource.com/c/1406723Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#621992}
-
Fumitoshi Ukai authored
- "Chromium Linux Goma GCE Staging" - "Chromium Mac Goma GCE Staging" - "CrWinClangGomaGCEStaging" remove win_clang_release_bot_disable_nacl from mb_config. Bug: 919752 Change-Id: I24077bf761c8cef26cdd774d228dcc7145e12005 Reviewed-on: https://chromium-review.googlesource.com/c/1404757 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Shinya Kawanaka <shinyak@chromium.org> Cr-Commit-Position: refs/heads/master@{#621991}
-
Xiaocheng Hu authored
When the input is upstream after a line break, LayoutNG caret resolution algorithm should resolve at the downstream position instead. This patch does that and fixes 4 crashes when bidi caret affinity is enabled. Bug: 894651 Change-Id: I178f1c0b209b907bd6ccad88b3e82d2df60f2907 Reviewed-on: https://chromium-review.googlesource.com/c/1404565 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#621990}
-
Carlos Caballero authored
MessageLoop will go away, eventually. BUG=891670 Change-Id: If7fa4256e30de4939bf77bfc46231fc921119513 Reviewed-on: https://chromium-review.googlesource.com/c/1352426Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#621989}
-
Fredrik Söderquist authored
78cf9afa added this include, as well as an 'inline' keyword on the declaration of the methods in it. Undo this to avoid ballooning the files downstream of element_resolve_context.h. Fix the fallout which is all due to missing includes of platform/wtf/functional.h. Bug: 242216 Change-Id: Iae7d8aa96c043e76a12d3fb76972730e70113c8c Reviewed-on: https://chromium-review.googlesource.com/c/1406247Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#621988}
-
Javier Ernesto Flores Robles authored
Bug: 916125 Change-Id: I92d7d56208d07cceb714a383bc5bc42150ad1144 Reviewed-on: https://chromium-review.googlesource.com/c/1406720Reviewed-by:
David Jean <djean@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#621987}
-
Sebastien Lalancette authored
When this feature is enabled, expired (unused for >14 months) Autocomplete entries will be cleaned-up from the client. The cleanup logic ensures that no tombstone updates will be sent to the Sync servers, and the data will simply be deleted from the client. The cleanup logic is triggered in the Init function of AutocompleteHistoryManager. Manual Testing (Linux): - Picked an Autocomplete entry and set its last_used_date to sometime in 2015. - Started the browser with the feature ON and saw that the entry was cleaned-up. - Saw the metric being logged, - Saw that the entry was still in my other client (Mac) and being synced - This is expected, as the Mac client didn't have the retention policy feature. If it did, it would also have cleaned-up the entry (same for the server). - Closed the browser and set another entry as expired, - Saw that the clean-up didn't run (expected, same major version). Bug: 907570 Change-Id: I11e0b26153f196b35efbd2c7288ad12aa5704bac Reviewed-on: https://chromium-review.googlesource.com/c/1401119Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#621986}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0554368eedf9..87da937789ae git log 0554368eedf9..87da937789ae --date=short --no-merges --format='%ad %ae %s' 2019-01-11 nisse@webrtc.org Delete unused constant kVideoCodecI420 2019-01-11 ssilkin@webrtc.org Use RTP timestamp when checking for frame duplication. 2019-01-11 gustaf@webrtc.org AEC3: More efficient comfort noise generation Created with: gclient setdep -r src/third_party/webrtc@87da937789ae The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:b/122636276 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I642c31fd0848548a7260ed9ba7cc25e3bab06b51 Reviewed-on: https://chromium-review.googlesource.com/c/1405819Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#621985}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b13a5da6a4e6..f7793ef4be2e git log b13a5da6a4e6..f7793ef4be2e --date=short --no-merges --format='%ad %ae %s' 2019-01-11 primiano@google.com TraceProcessor: don't skip log events < first clock snapshot Created with: gclient setdep -r src/third_party/perfetto@f7793ef4be2e The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:122243384 TBR=perfetto-bugs@google.com Change-Id: I3a6046f5704f0f47da035755ffccef2414467319 Reviewed-on: https://chromium-review.googlesource.com/c/1405820Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#621984}
-
Boris Sazonov authored
This CL revises how SyncCustomizationFragment and SyncAndServicesPreferences pause sync while the user is configuring it. ProfileSyncService.setSetupInProgress(boolean) is replaced with SyncSetupInProgressHandle class and getSetupInProgressHandle method that are similar to the native-side SyncSetupInProgressHandle. Counting in SyncSetupInProgressHandle allows nested settings pages to keep sync paused until all sync-related settings pages are closed. Applying sync configuration and pausing/unpausing sync no longer depends on AndroidSyncSettings.isSyncEnabled and mSyncSwitchPreference comparison and isChangingConfigurations check. TBR=msarda@chromium.org Bug: 914056 Change-Id: I735dfc693cb348fa6f27cf51dbe0cbda3bb2c8a1 Reviewed-on: https://chromium-review.googlesource.com/c/1390002 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#621983}
-
Max Morin authored
This reverts commit 176f1b6a. Reason for revert: https://crbug.com/921003 Original change's description: > Add VP9 profile 2 end-to-end tests > > Bug: 908945 > Change-Id: Ie45a80acd72298e7d7ab4db240f086c2a8b4fb0c > Reviewed-on: https://chromium-review.googlesource.com/c/1374571 > Commit-Queue: Emircan Uysaler <emircan@chromium.org> > Reviewed-by: Henrik Boström <hbos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#621568} TBR=emircan@chromium.org,hbos@chromium.org Change-Id: I9fdbd4690b8475b09d5a2eb7f2a75bbcd45bbd67 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 908945, 921003 Reviewed-on: https://chromium-review.googlesource.com/c/1406810Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#621982}
-
Arthur Hemery authored
To be able to reduce internal content exposure in content/public we make NavigationSimulator a pure interface and implement it inside content. The implementation now lives in content/test. This also allows us to have much stronger primitives usable only inside content (things like StartWithParams()) that should allow to further convert unit tests to use NavigationSimulator. Used the opportunity to tidy up the forward declarations/includes. Bug: 728571 Change-Id: Iba517e315fa3b3a069a2c77e7c6fbd636f2df02c Reviewed-on: https://chromium-review.googlesource.com/c/1402571 Commit-Queue: Arthur Hemery <ahemery@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#621981}
-
Oskar Sundbom authored
It was used to try and root-cause another issue. At this point, the histogram has expired and enough data has been collected. Bug: 911298, b/67327907 Change-Id: I92cff00449516672a55efc39720c124e30982937 Reviewed-on: https://chromium-review.googlesource.com/c/1400667 Commit-Queue: Oskar Sundbom <ossu@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#621980}
-
Sami Kyostila authored
Since all categories are now statically defined, there's no need to warm any of them up explicitly in order for the categories to show up in the tracing UI. Depends on https://chromium-review.googlesource.com/c/chromium/src/+/1401273 TBR=sandersd@chromium.org Bug: 914579 Change-Id: Idbabec3fa9e3f35716663d08260691d7bf4ecfa7 Reviewed-on: https://chromium-review.googlesource.com/c/1402760Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#621979}
-
Roman Sorokin authored
Bug: 919988, 920901 Change-Id: I50831b7a94c1b83027241f34b748048d2fabbc65 Reviewed-on: https://chromium-review.googlesource.com/c/1406718Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#621978}
-
Mike Reed authored
Change-Id: Ied3561f9ba6a9360cb352bcce73e7ba161e908c1 Reviewed-on: https://chromium-review.googlesource.com/c/1406318 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#621977}
-
Alex Clarke authored
The previous patch was starving low priorirty tasks more by accident which was enough to make some layout tests "leak" blink objects. Previous patch: http://crrev.com/c/1397612 This patch reimplements the priority selection logic by maintaining a priority queue of task priorities. I.e. to select a task we first check the current highest priority priority with tasks and then select the oldest queue from within that priority. To account for task starvation we keep a count of the number of times we have selected a task, and assign each priority a sort key based on the current task count plus a priority specific bias. After selecting a queue, we re-evaluate the sort key for the associated priority. This means if we run a lot of say high priority tasks, the sort key for any waiting normal priority will eventually become lower than the key for the high priority, resulting in us selecting a "starving" normal priority queue. Despite the overhead of maintaining this new queue, it's still makes a 4% improvement on SequenceManagerPerfTest.PostImmediateTasks_OneQueue. Bug: 897751 Change-Id: Ia7737343f1a82f190802e0da1ed16989cf10e14e Reviewed-on: https://chromium-review.googlesource.com/c/1404091 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#621976}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0df132fe0a47..a24a725f7834 git log 0df132fe0a47..a24a725f7834 --date=short --no-merges --format='%ad %ae %s' 2019-01-11 perezju@chromium.org [soundwave] Allow unicode in bug descriptions Created with: gclient setdep -r src/third_party/catapult@a24a725f7834 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:920565 TBR=sullivan@chromium.org Change-Id: I9916f54c1dcdcad09b4e1d493e14b179930e60f7 Reviewed-on: https://chromium-review.googlesource.com/c/1405818Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#621975}
-
Rayan Kanso authored
- Pass download/upload stats from storage to the delegate - Keep track of in progress upload/download progress per request - Rename variables for consistency Bug: 919864, 774054 Change-Id: I7bf78a0e688753584bde51233ecd8c9f9b1049cd Reviewed-on: https://chromium-review.googlesource.com/c/1405009Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@google.com> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#621974}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e2a911298a26..b13a5da6a4e6 git log e2a911298a26..b13a5da6a4e6 --date=short --no-merges --format='%ad %ae %s' 2019-01-11 taylori@google.com Merge "perfetto_ui: Fix text size of chrome slices" Created with: gclient setdep -r src/third_party/perfetto@b13a5da6a4e6 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Iedb38609e971e5e4474efc2a766c3abc1ff27ca2 Reviewed-on: https://chromium-review.googlesource.com/c/1405817Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#621973}
-
Henrik Boström authored
The previous test was, and always had been, completely broken. In a loopback call scenario such as in WPT tests, no CSRCs are being received so we should not expect them to. In order to properly test this method one would need fakes, mocks or a server to receive CSRCs from. This test is updated to test the only thing that we can test in Web Platform Tests: in a loopback call, getContributingSources() returns an empty list. Bug: 893158 Change-Id: I18782ea7912001c012c98145500d8b3c5e95a7ba Reviewed-on: https://chromium-review.googlesource.com/c/1404266Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#621972}
-
Oleh Prypin authored
This reverts commit abef97f5. Reason for revert: That didn't help. Original change's description: > Disable capture_unittests on WebRTC Chromium Linux Tester > > As part of investigating persistent Swarming failures on the machine. > > Bug: 901810 > Change-Id: Ic82c2857cb6e952cdd1b93b76436689ed450ffc7 > Reviewed-on: https://chromium-review.googlesource.com/c/1363843 > Commit-Queue: Oleh Prypin <oprypin@chromium.org> > Commit-Queue: John Budorick <jbudorick@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#614202} Change-Id: I5836fee6dc6d27bfc8ec858d4a2fc132860e7ebb Reviewed-on: https://chromium-review.googlesource.com/c/1377429Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Oleh Prypin <oprypin@chromium.org> Cr-Commit-Position: refs/heads/master@{#621971}
-
Koji Ishii authored
This patch adds two line-layout performance tests: * Both have `width: fit-content`, with its parent set to `width: 400px`. * One has `word-break: break-all`, a commonly used property for source code, bug tracker, etc. Current view-source puts each line into a table cell with `word-break: break-all`. Table cells might need additional code path, but uses the common underlying code as `fit-content`. Currently with Win x64 Canary running on Z620: * line-layout-fit-content.html ~600ms. LayoutNG is ~1500ms, ~2.5x slower. * line-layout-fit-content-break-word.html ~230ms. LayoutNG is ~1150ms, ~5x slower. Note, `break-word` slows down both engines. The amount of text is adjusted to 1/5 so that tests finish within 1-2 seconds. Bug: 919123 Change-Id: Ib8646d17625e86496f262efcafb5d4e1b5cc6136 Reviewed-on: https://chromium-review.googlesource.com/c/1405108Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#621970}
-
Hajime Hoshi authored
Support |task_runner| parameter in: - mojo::BindingSet::AddBinding - mojo::StrongBinding - mojo::StrongAssociatedBinding Using per-frame task runner at mojo is necessary for bfcache since JavaScript execution needs to be suspended when the tab is frozen. This CL is based on Alexander's CL: https://chromium-review.googlesource.com/c/chromium/src/+/1369499 Bug: 913192 Change-Id: I3a2a7193f22313ec39383a7794f08ddff3bf8375 Reviewed-on: https://chromium-review.googlesource.com/c/1379608 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#621969}
-
Marc Treib authored
It's flaky due to an SQLite data race. Bug: 920738, 917380 Change-Id: I3ed269d487daa25ebd973bda8b1689ebd22977ec Reviewed-on: https://chromium-review.googlesource.com/c/1406708 Commit-Queue: Marc Treib <treib@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#621968}
-
Yutaka Hirano authored
As a preparation to move more properties to FrameResourceFetcherProperties, this CL passes FrameOrImportedDocument, not LocalFrame, to FrameResourceFetcherProperties. Bug: 914739 Change-Id: Ib56c7013eeb2c7cb66d5d6651e832f7d475bd58c Reviewed-on: https://chromium-review.googlesource.com/c/1405161 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#621967}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6fb2d7633e67..2d0af9555211 Created with: gclient setdep -r src-internal@2d0af9555211 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I8edb4e4e3b659695d6db8430adb7ef8e9db04666 Reviewed-on: https://chromium-review.googlesource.com/c/1405816Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#621966}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0486f0914f1c..0554368eedf9 git log 0486f0914f1c..0554368eedf9 --date=short --no-merges --format='%ad %ae %s' 2019-01-11 nisse@webrtc.org Delete method DecoderDatabase::RegisterPayload(...NetEqDecoder...) Created with: gclient setdep -r src/third_party/webrtc@0554368eedf9 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie0d26c02d2b8156534493243d48317a501c161ea Reviewed-on: https://chromium-review.googlesource.com/c/1405597Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#621965}
-
Tanja Gornak authored
Metric Sync.InvalidationPerModelType is recorded two times. Remove one of them. Bug: 801985 Change-Id: I6b04cfe38dc29fc03cf317daf946376c06e36725 Reviewed-on: https://chromium-review.googlesource.com/c/1405050Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#621964}
-
Henrik Boström authored
This is a member in both RTCRtpContributingSource and the derived dictionary RTCRtpSynchronizationSource. For SSRCs, this value must always be present, either from the RFC6464 header extension data or obtained through calculations, though the third_party/webrtc implementation only does the former. For CSRCs, this value is optional depending on if the RFC6465 header extension is present. Currently, the third_party/webrtc implementation does *not* fill in the audio level in the CSRC case, but this CL takes care of the plumbing for both SSRCs and CSRCs based on whether or not audio_level() is present in the webrtc layer. The getSynchronizationSources() test now passes. Demo page: https://codepen.io/anon/pen/xmJVoy?editors=1010 Bug: 893172 Change-Id: I9c3fac818c271875e6b14cf062057df034a5fc71 Reviewed-on: https://chromium-review.googlesource.com/c/1401521 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#621963}
-
Sylvain Defresne authored
All observers of that method were UI components that refreshed themselves when notified. Since they then fetch the data from the AccountTrackerService, and does the same refresh when the account is updated, it is simpler to just use OnAccountUpdated for both events. Bug: 914783 Change-Id: I4d085baceb72373eda1c11e169d04ce55a2ac8e2 Reviewed-on: https://chromium-review.googlesource.com/c/1402568Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#621962}
-