GitLab

Previously when the user clicks on an offline host, the client will still
attempts to connect to it, then it crashes.

This CL prevents the client from attempting to connect to an offline host.
When the offline host is selected, the client will just show a snack bar
message and do nothing else.

Review-Url: https://codereview.chromium.org/2914233003
Cr-Commit-Position: refs/heads/master@{#476455}

https://chromium.googlesource.com/angle/angle.git/+log/cae72d6..b7d5e30

BUG=2016

TBR=geofflang@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2915203002
Cr-Commit-Position: refs/heads/master@{#476454}

BUG=718187

Review-Url: https://codereview.chromium.org/2904293002
Cr-Commit-Position: refs/heads/master@{#476453}

BUG=727959

Review-Url: https://codereview.chromium.org/2921453003
Cr-Commit-Position: refs/heads/master@{#476452}

Remove _URLOnStartLoading from crw_web_controller as its not read anywhere.

BUG=

Review-Url: https://codereview.chromium.org/2919473004
Cr-Commit-Position: refs/heads/master@{#476451}

R=dpapad@chromium.org
BUG=727449

Review-Url: https://codereview.chromium.org/2919663002
Cr-Commit-Position: refs/heads/master@{#476450}

BUG=

Review-Url: https://codereview.chromium.org/2914923002
Cr-Commit-Position: refs/heads/master@{#476449}

In stacked tab mode, if the active tab's x-position
is maximal and there is a stacked tab to its left,
gesture-dragging the active tab to the left will
produce a gap in the tabstrip. Prevent this from
happening by invoking AdjustStackedTabs() rather than
ResetToIdealState(), as is done in the symmetric case
of gesture-dragging to the right.

BUG=454479
TEST=StackedTabStripLayoutTest.DragActiveTabExisting

Review-Url: https://codereview.chromium.org/2918653002
Cr-Commit-Position: refs/heads/master@{#476448}

Change-Id: Ice22726f0bfb7cda5c5b1e60dd844c415527fd1f
Reviewed-on: https://chromium-review.googlesource.com/513527Reviewed-by: Jeff Carpenter <jeffcarp@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476447}

- CSS Parser now is ThreadSpecific and not only static local.
- Multi threaded tests for all code that OffscreenCanvas filters
currently use:
  - CSSToLengthConversionData
  - CreateOffscreenFilterOperations

Bug: 724565
Change-Id: I7fdc7f2ff0246709211740d8f708f65513aa2a4f
Reviewed-on: https://chromium-review.googlesource.com/517969
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476446}

This allows developers to request a decode of an img element.
When the promise resolves, the compositor will keep the image
locked for two frames, ensuring that if appended into the DOM,
jank is minimized.

Intent to implement:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/LMV9dBG_1-I

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2769823002
Cr-Commit-Position: refs/heads/master@{#476445}

The GetUrlForPagewithTitle method on ChromeWebViewTest needed to be
implemented manually becuase the previous default handler which was
handling the echotitle url only looks for the value within the request
body which is not usable for CWVWebView tests as they must pass all data
within the url.

BUG=704038

Review-Url: https://codereview.chromium.org/2902403002
Cr-Commit-Position: refs/heads/master@{#476444}

In order to notify FrameFetchContext of frame detach event, this CL adds a
new function. FrameFetchContext::document_ has been a weak member due to a
reference cycle. This CL also makes the reference strong and break the cycle
explicitly on the event.

Bug: 695939
Change-Id: I0395c649c1da4797be3f9055ee38c86ff5e6e844
Reviewed-on: https://chromium-review.googlesource.com/516843Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476443}

Bug: 718063
Change-Id: I7c9769b3115c2de8dc07443117271d8b10782b87
Reviewed-on: https://chromium-review.googlesource.com/520284Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476442}

The workaround to confine ARC windows to the primary display is no
longer needed now that ARC supports multiple displays.

BUG=718627
TEST=Extended desktop mode works for ARC and other clients.

Review-Url: https://codereview.chromium.org/2862173004
Cr-Commit-Position: refs/heads/master@{#476441}

BUG=726553

Review-Url: https://codereview.chromium.org/2911583003
Cr-Commit-Position: refs/heads/master@{#476440}

This CL adds a lock indicator image as well as the corresponding "https://"
scheme to a host name if the connection is secure. The logic for determining
if the connection is secure (which should be in the Payment Request Manager
class) will not be implemented in this CL. As of now there is a bool created
in that manager class that is set to false denoting that the connection is not
secure. However I have attached images showing what the UI would look like
if this boolean was set to true. A later CL will implement the logic behind
determining if the web context is secure.

Screenshot #1: http://imgur.com/a/2HbUG
Screenshot #2: http://imgur.com/a/qWmpo

Bug: 602666
Change-Id: I959189bb8e06ace669d06df960360947c52d6638
Reviewed-on: https://chromium-review.googlesource.com/518247
Commit-Queue: Randall Raymond <rayraymond@google.com>
Reviewed-by: mahmadi <mahmadi@chromium.org>
Reviewed-by: Louis Romero <lpromero@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476439}

BUG=672263

Review-Url: https://codereview.chromium.org/2913363002
Cr-Commit-Position: refs/heads/master@{#476438}

https://pdfium.googlesource.com/pdfium.git/+log/f6ca07b3fda4..5f34d479d06e

$ git log f6ca07b3f..5f34d479d --date=short --no-merges --format='%ad %ae %s'
2017-06-01 tsepez Move CCodec_GifModule state to CGifContext
2017-06-01 thestig Simplify code in fpdfformfill.cpp.
2017-05-31 thestig Clarify IPWL_Filler_Notify::QueryWherePopup() parameters.

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: I49adabc079052c90f0f69451156fda02009e9d0c
Reviewed-on: https://chromium-review.googlesource.com/521886
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476437}

Chrome creates QuirksManager, so that when mash tries to access
QuirksManager we get a crash.

BUG=728748,718860
TEST=none
R=kylechar@chromium.org

Change-Id: I13f33abde92cb13048542469440f5ab8cc562e00
Reviewed-on: https://chromium-review.googlesource.com/521922Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476436}

ResourceSettings holds the field that are used by LayerTreeHostImpl and
LayerTreeHostImpl no longer needs LayerTreeSettings::renderer_settings.

cc: :Display to create ResourceProviders. With ResourceSettings,
Bug: 711146
Change-Id: Ib3594b35cbf698913fde91a5ec72c6323aa561d6
Reviewed-on: https://chromium-review.googlesource.com/517748Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Xingyu Zhang <staraz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476435}

BUG=727825

Review-Url: https://codereview.chromium.org/2909283003
Cr-Commit-Position: refs/heads/master@{#476434}

Bluez recent changes corresponding to this CL:
https://chromium.googlesource.com/chromiumos/third_party/bluez/+/758dae03725ed7a1138d848aad940a73bbf5d659
https://chromium.googlesource.com/chromiumos/third_party/bluez/+/d356a6242be9a1aba2cca871b79618e3b28a5ec2

BUG=725349
TEST=Called chrome.bluetoothLowEnergy.registerAdvertisement with
advertisement data containing both manufacturerData and serviceData, the
operation succeeded.

Review-Url: https://codereview.chromium.org/2907913002
Cr-Commit-Position: refs/heads/master@{#476433}

Bug: 166704
Change-Id: I3f95a10ea12e1155272a0d3213e1cc0eb4c7a607
Reviewed-on: https://chromium-review.googlesource.com/521388Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Alexandre Elias <aelias@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476432}

https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/6b09df23f8a9..ff270ca217a8

$ git log 6b09df23f..ff270ca21 --date=short --no-merges --format='%ad %ae %s'
2017-05-23 sonnysasaka New DBus constant for BlueZ API ResetAdvertising.
2017-05-19 tengs CHROMIUM: Add SetLEConnectionParameters to DBUS service constants.
2017-04-27 ljusten Move authpolicy's ErrorType to a proto
2017-05-15 yunlian system_api: use '-fPIC' for libsystem_api-chaps-protos.a

Created with:
  roll-dep src/third_party/cros_system_api

Adjustments need to be made to include headers of some of chrome/browser/ui/webui/chromeos/login/*
due to https://chromium-review.googlesource.com/c/488881/

BUG=636142
TEST=gclient sync and confirmed that Chrome compiled fine.

Change-Id: Iabae04950d6c5c54c04a13c1a6d45544aa116726
Reviewed-on: https://chromium-review.googlesource.com/517309
Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Miao-chen Chou <mcchou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476431}

Includes failing tests from https://codereview.chromium.org/2707263011/ and https://codereview.chromium.org/2906083002/
Bug: 726740,726751
Change-Id: I6b06018f805c4fce781843141109626bab557dcc

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I6b06018f805c4fce781843141109626bab557dcc
Reviewed-on: https://chromium-review.googlesource.com/516586Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476430}

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implcitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

R=posciak@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2911113003
Cr-Commit-Position: refs/heads/master@{#476429}

Also remove TODO in test since the test requires access to its custom
context class in other methods.

Bug: 646094
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester
Change-Id: I36534c78d6cb8510f8837f52d8dbe26d9dae1b47
Reviewed-on: https://chromium-review.googlesource.com/517647Reviewed-by: Alok Priyadarshi <alokp@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476428}

In general we've been putting all of the manual tests that we never
want to run into NeverFixTests. It looks like this particular test was
imported before the csswg-test merge, and it should have been disabled
at that time but wasn't.

Bug: 728522
Change-Id: I467c1c3db7d7a0417d521d18356d6ff56efb87f5
Reviewed-on: https://chromium-review.googlesource.com/521444Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476427}

DrmOverlayValidator::TestPageFlip() can be called before
HardwareDisplayController is installed in GPU process. In the case, it reports
any planes are not overlayable. However, the client keeps this information as cache and the
overlay never happens.

To fix it, when the browser updates display configuration, it resets the cache.

BUG=683347
TEST=Run chrome on samus

Review-Url: https://codereview.chromium.org/2920613002
Cr-Commit-Position: refs/heads/master@{#476426}

1. Expose IconDescription in vector icon code so when we add or
   modify parameters we don't have to update the API.
   TODO: remove the parts of the API that use multiple parameters
         and replace them all with IconDescription.
2. Add AnimatedIconView, which caches the start and end states and
   controls animating in between as well.
3. Add an animated version of browser_tools.icon. This was crafted
   by hand based on the non-animated version and a visual description,
   but in the future designers should deliver Android vector drawables
   which will make the process of creating these icons much easier
   (and perhaps automate-able).
   TODO: actually craft a 2x version instead of reusing 1x.
4. Apply this all to the app menu. This solves the issue of pixel
   perfection in the steady state.

BUG=718549,704786

Review-Url: https://codereview.chromium.org/2892563004
Cr-Commit-Position: refs/heads/master@{#476425}

https://chromium.googlesource.com/angle/angle.git/+log/9216a6e..cae72d6

BUG=None

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2919583004
Cr-Commit-Position: refs/heads/master@{#476424}

Since the client-side DPI in ARC is configured at build time based on
the internal display, the client must scale the cursor by the DSF of
the internal (not the primary) display to convert from pixels to DIPs.

BUG=642894
TEST=caroline: Cursor scale is correct for each display/resolution.

Review-Url: https://codereview.chromium.org/2779823002
Cr-Commit-Position: refs/heads/master@{#476423}

This reverts commit 5d0edd94.

Reason for revert: Possible cause of Chromium Win x64 PGO Builder compile failures; hypothesis is that filenames are exceeding the maximum path length.  See https://build.chromium.org/p/chromium.fyi/builders/Chromium%20Win%20x64%20PGO%20Builder/builds/19881 .

This will likely also fix bug 728584 as a side effect, though we could fix that differently long term.

Original change's description:
> bindings: Generate entries for .cpp/.h files from IDL dictionaries in GN
> 
> By auto-generating those entries, we can stop requiring people to manually
> update lists such as |generated_core_dictionary_files| every time Blink's
> lists of IDL dictionary files change.
> 
> Since the names of the generated .cpp/.h follow a fixed, specific format
> that only depends on their respective IDL file's path and file name, we can
> use GN itself to do some path introspection and generate the file names we
> want in idl_impl().
> 
> While here, change the names of idl_impl()'s required arguments to make
> their purpose more explicit: it is not immediately obvious that we
> differentiate unions and callback functions from dictionary files in terms
> of where the latter are generated and their file names, as well as why
> idl_impl() only expects non-dictionary files in its outputs list. A good
> next step would be generating dictionary impl files separately from unions
> and callbacks to avoid the confusion altogether.
> 
> Bug: 725996
> Change-Id: I41b06e8d71f33b21d77944216fcb07d0557ac47b
> Reviewed-on: https://chromium-review.googlesource.com/517795
> Commit-Queue: Raphael Kubo da Costa (rakuco) <raphael.kubo.da.costa@intel.com>
> Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
> Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#476262}

TBR=peria@chromium.org,yukishiino@chromium.org,raphael.kubo.da.costa@intel.com,bashi@chromium.org,haraken@chromium.org
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 725996,728584

Change-Id: I3d41d2517c33b30b92b72686f669881eb62a7a00
Reviewed-on: https://chromium-review.googlesource.com/521702
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476422}

This makes it so that if some bot fails to run for some reason,
new expectation lines include the port for the builder that didn't
have results.

For example, suppose mac10.9_blink_rel fails compile and there
are cross-platform test failures that are observed on all other bots.
The newly-added lines would be cross-platform.
(This is what happened last week.)

Bug: 722887
Change-Id: I209267ba9e63ec912e62b08b6469f47db7bba6df
Reviewed-on: https://chromium-review.googlesource.com/520582
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Jeff Carpenter <jeffcarp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476421}

This change was intended as a test for rebaseline-cl.

Change-Id: I91e843aa461e2bbd66a2608330fcbb238d1dafdb
Reviewed-on: https://chromium-review.googlesource.com/513616
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Manuel Rego Casasnovas <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#476420}

In https://codereview.chromium.org/2904093002, I'm eliminating the
DocumentMarkerDetails subclass for TextMatchMarker in favor of storing the
TextMatchMarker-specific data directly on TextMatchMarker. In
https://codereview.chromium.org/2908643002, I'm creaing a similar subclass for
CompositionMarker. In this CL, I'm doing the same for SpellingMarker and
GrammarMarker, which means we can now eliminate DocumentMarkerDetails.

In a follow-up CL, I will make MarkerType() virtual so we won't have to store
the MarkerType as a field in DocumentMarker.

BUG=707867

Review-Url: https://codereview.chromium.org/2911723002
Cr-Commit-Position: refs/heads/master@{#476419}

Modules generate fake script to report an import exception, this fake script should have correct start_position.

Bug: chromium:721589
Change-Id: Iac2aa91b9269210d39e834c5467e6ae071cce1e4
Reviewed-on: https://chromium-review.googlesource.com/521143Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476418}

BUG=chromium:724273

Review-Url: https://codereview.chromium.org/2901173002
Cr-Original-Commit-Position: refs/heads/master@{#474725}
Committed: https://chromium.googlesource.com/chromium/src/+/cb9bde9860d070b022407e3d988ba3239e00f35a
Review-Url: https://codereview.chromium.org/2901173002
Cr-Commit-Position: refs/heads/master@{#476417}

BUG=726776

Review-Url: https://codereview.chromium.org/2914883003
Cr-Commit-Position: refs/heads/master@{#476416}