- 08 Dec, 2020 40 commits
-
-
Ben Wagner authored
Change-Id: I95a145f0380b0f413a71ef5a9bbacf840eb20b9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577205 Commit-Queue: John Chen <johnchen@chromium.org> Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#834889}
-
rajendrant authored
This CL introduces PublicResourceDecider interface that has the redirect decision making API that subclasses should implemeent. This class also has the mojo interface got interacting with browser process. This interface also has the RedirectResult enum that will have ineligible reasons for public image hints approach and robots checking based approach. PublicImageHintsDeciderAgent (rename of SubresourceRedirectHintsAgent) is introduced which is the subclass of the decider interface for public image hints approach. Change-Id: I5ef43c2ee821f7d5aa6501683c22e09464da7972 Bug: 1152527 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572755 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#834888}
-
Alan Cutter authored
This trick of serialization does not compile on GCC (or vanilla clang). This CL replaces it with base::StrCat() and more conventional uses of std::stringstream. Bug: 819294 Change-Id: Ida5ae89f41ba4a3f80ff763fbcda6661a9f665b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576877Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#834887}
-
Xida Chen authored
This CL is the first step of the background-color animation using off-thread paint worklet infrastructure. The design doc is here: https://docs.google.com/document/d/1usCnwWs8HsH5FU_185q6MsrZehFmpl5QgbbB4pvHIjI/edit In particular, this CL just make sure that we are able to create a compositor animation for background-color. Then the compositor thread ticks the animation and dispatches the paint job to the worker thread to paint. In the actual paint, we do hard code the result, which means there is no interpolation implementation at this moment. We will implement the interpolation logic in a coming CL. Bug: 1139008, 1148369 Change-Id: I9d2aba2106f38f89bce0e97df29fa0d4f30b2c76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549530Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#834886}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a532031e70b4..b57da84fcd71 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jrw@google.com,domfc@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1139446,chromium:1156109 Tbr: jrw@google.com,domfc@google.com Change-Id: I2b0139a5711641e47076d32c94860840d7841226 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580307Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834885}
-
Aleks Totic authored
Borders spacing for empty border sections was not being handled correctly. Failing tests included: external/wpt/css/css-tables/bounding-box-computation-3.html fast/table/anonymous-table-section-removed.html fast/table/multiple-captions-display.xhtml The correct behaviour is: - empty sections do contribute to border spacing - sections are empty if they have no children. This is non-intuitive: abspos child, or an empty row still make section non-empty. This matches empty criteria for table cell when computing baseline. Bug: 958381 Change-Id: Ib960a54794897ef346bfc26821efe26fb33a853f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578696 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#834884}
-
Elly Fong-Jones authored
Remove some overrides, replace them with setters, and remove some member vars that are no longer needed because of that. Bug: 1075649 Change-Id: Ic065415a86db28b19592418678eac27825515b0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574787 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#834883}
-
Curt Clemens authored
Add a help string. The caption row hasn't been added to the settings page yet and will be handled in a followup cl. Bug: 1154834, 1156331 Change-Id: Ie87a71f7d4a303cd61a14387ecebedcee5356914 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578099Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Curt Clemens <cclem@google.com> Cr-Commit-Position: refs/heads/master@{#834882}
-
Nancy Wang authored
For a new user, when the system starts, the "restore_apps_and_pages" pref could be set for below scenarios based on the ui review deck: https://docs.google.com/presentation/d/1iCqnD3IEeTpy5rstMq5Gw_PfYEMFCPVjrYi9TtLtjQg/edit#slide=id.g838f61fb61_2_5 1. At startup, both the OS restore pref "restore_apps_and_pages" and the browser's "restore_on_startup" are empty, so the "restore_apps_and_pages"'s value is initialized as |kAskEveryTime|. 2. When synced, there are 3 scenarios: A. The OS restore pref "restore_apps_and_pages" is not empty in the init sync list, then don't update the "restore_apps_and_pages"'s value, and use the value from sync. B. The OS restore pref "restore_apps_and_pages" is empty in the init sync list, and "restore_apps_and_pages" is set by the user, then don't update the "restore_apps_and_pages"'s value, and use the value set by the user. C. The OS restore pref "restore_apps_and_pages" is empty in the init sync list, "restore_apps_and_pages" is not set by the user, and the browser's "restore_on_startup" is not empty, reset the "restore_apps_and_pages" value based on the browser's setting "restore_on_startup". However, currently we don't have a notification to know whether the pref item is listed in the sync init list, so we don't have a good way to know whether we should keep the sync value or modify based on the other synced pref(e.g. synced browser's restore pref) To address the issue, this CL adds a OnStartedSyncing interface. When merge data and start syncing, if the pref path is list in the init sync data, call OnStartedSyncing to notify the observer. BUG=1146900 Change-Id: I5f3e9462f6e4bcbf38b0aeff6cac4515a3c40b46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575777 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#834881}
-
Jenny Zhang authored
This will enable feedback pre-processing code to process lacros crash ids in the same way it does for ash crash ids, and generate magic_signature, magic_signature_link, all_crashes_link for lacros crash report ids. Bug:1129051 TEST: Induce a crash with Lacros, invoke feedback dialog, preview system information, verify lacros crash id shows in crash_report_ids. If the testing account is google.com account, all_crash_report_ids should show both lacros and ash crash ids within 120 days. Also, verify that there are no "Lacros crash_report_ids" and "Lacros all_crash_report_ids" show up. Send the report, and locate it on listnr, verify magic_signature, magic_signature_link, and all_crashes_link fields are generate in the feedback report for lacros crashes. Change-Id: Ie7ae9ccbf3fd8ec3b3272444d685446e479da679 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575952 Commit-Queue: Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Miriam Zimmerman <mutexlox@chromium.org> Cr-Commit-Position: refs/heads/master@{#834880}
-
James Darpinian authored
Change-Id: I6ad897d737f49df6111319c886b8ace83d56b18f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580439 Auto-Submit: James Darpinian <jdarpinian@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#834879}
-
Travis Skare authored
Currently running as an experiment on stable. Bug: 1153589 Change-Id: Iacf871c763e9b0b8588f4dab07cd3d3211453c5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572377Reviewed-by:
Kyle Milka <kmilka@chromium.org> Commit-Queue: Travis Skare <skare@chromium.org> Cr-Commit-Position: refs/heads/master@{#834878}
-
Istiaque Ahmed authored
The test was mistakenly disabled for SW based extensions in crrev.com/c/1813504. Bug: None Change-Id: I2c98ac935bba841f0c11e4c3e5a6b5e2de7e91c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578122Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#834877}
-
Toni Barzic authored
BUG=1142572 Change-Id: Iefc890de450ed2037e5755441f116df4aaeb01e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577726Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#834876}
-
Joon Ahn authored
Update the string to include number of minutes visible. Following up with actual timer implementation Bug: 1156229 Change-Id: I1a0596a9e5574613e9a63f871614ac6b3c32eb80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577465 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Auto-Submit: Joon Ahn <joonbug@chromium.org> Cr-Commit-Position: refs/heads/master@{#834875}
-
Sebastien Lalancette authored
This new class will be used to mock the UKM recorder living in the browser process and being served UKM events over Mojo. When instantiated, this class will set itself automatically to receive UKM events, and those events will be made available for validation from this class' recorder instance. Cleaned-up the two fixtures that used a less-than-ideal approach to use this new class instead. Bug: 1153990 Change-Id: I71ba82a0150af307e7d9e426f5c42476278229a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568353 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#834874}
-
Gavin Mak authored
Generate DIR_METADATA files and remove metadata from OWNERS files for directories under //chrome. Bug: 1113033 Change-Id: I05c775ed0bc20599533846f2f7392296f3ad4dee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577007Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Gavin Mak <gavinmak@google.com> Cr-Commit-Position: refs/heads/master@{#834873}
-
Donn Denman authored
Extends a few histograms needed for Contextual Search or Related Searches from M89 to M91. BUG=1153763,1153764444 Change-Id: I5b2693325cf1bf81cad1f9fc5e7ef86a0097b782 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575359Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#834872}
-
Liquan (Max) Gu authored
This CL moves AndroidPaymentApp from //chrome to //components, adding necessary build dependencies: - "//components/browser_ui/strings/android:browser_ui_strings_grd": R.string.ok/cancel/external_app_leave_incognito_warning_title - "//components/browser_ui/styles/android:java_resources": R.style.Theme_Chromium_AlertDialog - "//components/strings:components_strings_grd": R.strings - "//ui/android:ui_no_recycler_view_java": WindowAndroid - "//ui/android:ui_utils_java": UiUtils This CL also move AndroidPaymentAppUnitTest. Bug: 1156191 Change-Id: Ib45404f6ea4a8717838e7616d18b06fa3d5e5125 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577008Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#834871}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4670e2c2..56b18c5a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic98ff753e348724dac46d72d75739d4571a00b65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579723Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834870}
-
Gavin Mak authored
Generate DIR_METADATA files and remove metadata from OWNERS files for directories under //chrome. Bug: 1113033 Change-Id: I9fc881649c5972273f10710168c88a03091341a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577006Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Gavin Mak <gavinmak@google.com> Cr-Commit-Position: refs/heads/master@{#834869}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1607428729-15b0b20b7f7ec45672a4f128279fd58906f3383e.profdata to chrome-linux-master-1607450253-17283bab00baae11cd74f4b35406a0ad23f10e88.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I3d52a37abe0e15a37cb25d6f553ec22dbbcf0433 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580310Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834868}
-
Adam Langley authored
This "display" name is never actually displayed and never contains non-ASCII. Drop the use of string16 and clarify the different between it and |GetId|. Change-Id: I0abf916d9dc21dac7f8d3e50a303ee649df05647 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575039 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#834867}
-
Cammie Smith Barnes authored
This change merely adds the string array `dns_aliases` to network::mojom::URLResponseHead in preparation to expose CNAME aliases to the SubresourceFilter. The rest of the plumbing in the network stack is underway in separate CLs (https://crrev.com/c/2561274, https://crrev.com/c/2563439, https://crrev.com/c/2563450, https://crrev.com/c/2569956) but this new field in URLResponseHead is needed for the renderer-side and browser-side code. Bug: 1151047 Change-Id: Ifb20801b50634fd3a719bd894b8e82c4a53be70e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574793Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> Cr-Commit-Position: refs/heads/master@{#834866}
-
Tommy Martino authored
This incorporates a significant speed improvement for certain fragment generation use-cases, enough to alleviate many of the timeout issues we were encountering. Bug: 1155329 Change-Id: If4b13aa99545092064f5ce2ed2e68d3e1ee0eb2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580318 Commit-Queue: Tommy Martino <tmartino@chromium.org> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#834865}
-
Jonah Chin authored
SharedImageRepresentationSkia Local OOPR Canvas tests revealed an issue when uploading YUV video frames to the GPU. When provided a mailbox representing a YUV plane, RasterDecoderImpl::DoWritePixelsINTERNAL() fails because Skia does not allow wrapping these formats in SkSurfaces. To combat this, this CL introduces a new version of SharedImageRepresentationSkia::ScopedWriteAccess that works directly with an SkPromiseImageTexture rather than an SkSurface. Bug: 1115217 Change-Id: I63e3f0e74f6bb42642545516407ede42279e9bf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528695Reviewed-by:
Jonah Chin <jochin@microsoft.com> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Jonah Chin <jochin@microsoft.com> Cr-Commit-Position: refs/heads/master@{#834864}
-
Primiano Tucci authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3bf980426002..26a24ee9aeb 2020-12-08 primiano@google.com Add PERFETTO_EXPORT to CloseFile fwd declaration 2020-12-08 primiano@google.com Add missing includes for Windows build 2020-12-08 primiano@google.com Fix mismatching signature in base::OpenFile 2020-12-08 primiano@google.com Fix chromium roll 2020-12-08 primiano@google.com base: Move OpenFile to file_utils.h and fix IWYU If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:174454879 Change-Id: I0eff5233f3419cb5901e509609ea45055d67f5de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577783 Commit-Queue: Primiano Tucci <primiano@chromium.org> Auto-Submit: Primiano Tucci <primiano@chromium.org> Reviewed-by:
Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#834863}
-
dpapad authored
This minor refactoring of the chrome:extra_resources" target leads to better encapsulation, and more importantly relieves build/OWNERS from having to review trivial/mechanical CLs that could be reviewed by chrome/browser/resources/OWNERS. Bug: None Change-Id: I2eeeb812099a4dfeb88aecda42c0453c9c2993ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578712 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#834862}
-
Patrick Noland authored
This change moves keyboard visibility manipulation to UrlBarCoordinator, shifting setKeyboardVisibility and setSoftInputMode. It also shifts the implementation of AutocompleteDelegate to LBCoordinator, re-ordering some methods as a result. Change-Id: I6465891fe67edbacef87692bce1bfa982023cc95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569434 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#834861}
-
John Lee authored
Bug: 1142082 Change-Id: Ibdadd23bb877fdbbe63dd499a80e0969aefbe7ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577891Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#834860}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I4c2c0ae8a65324b022a4dc3a23cfa12b5f47596d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580278Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#834859}
-
Nina Satragno authored
Request handlers were DCHECKing on AuthTokenRequester HavePINUVAuthTokenResultForAuthenticator callbacks that the authenticator had been selected. However, this is not the case for pre-touch errors. This patch moves the DCHECK after handling those, and adds request handler tests. Fixed: 1154859 Change-Id: I8475c597c1bc10666c970626eee14dc55de32d54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577868 Auto-Submit: Nina Satragno <nsatragno@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#834858}
-
Ben Pastene authored
Adding these to a test's isolate will allow folks to symbolize crash dumps from tests with only the test input & a crash .dmp file. Note that it's not necessary to add these to the test isolate since the test itself won't use them. (These tools could be built locally by hand instead.) It's merely a convenience since the test isolate would have to be downloaded locally anyway to retrieve the outdir symbols. This should have minimal impact on test compile time (since dump_syms and minidump_* binaries are pretty simple) as well as test isolate size since those binaries are also fairly small. Bug: 1155738, 1156772 Change-Id: Iaaa47299edb1c592ba3b143408454fe9c271604a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576076 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#834857}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/e05f7b914762..e2c30849a21d 2020-12-08 tsepez@chromium.org Fix longstanding typo in bug_481363.in If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I04cc23562ee6043ab945d4ec7a956cc9acaf1c76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580302Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834856}
-
Li Lin authored
Migrate to Gaia reauth endpoint for supervised user. Handle message "removeUserByEmail" triggered by the button on the deleted user page: - If the removed user is the device owner, trigger powerwash. - Otherwise, remove the user locally. Bug: 1115203 Test: manual Change-Id: I9ac37359b68acb3038d9b451926af267d584a27c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506613 Commit-Queue: Li Lin <llin@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#834855}
-
Rob Clark authored
Needed by mesa, for a similar reason as the amd gpu sandbox BUG=b:174909812 TEST=gpu process does not crash Change-Id: I6c82f4371f354e2bd16625c47a9893fb39bd4a39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576942 Auto-Submit: Rob Clark <robdclark@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: Jorge Lucangeli Obes <jorgelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#834854}
-
Vladimir Levin authored
Since we pass this node as a reference, we need to ensure that it isn't null. This is a speculative fix for the referenced bug. R=aleventhal@chromium.org Bug: 1156599 Change-Id: I117910cd1304c61f7accea1b70fca92c75ece647 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579943Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#834853}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/61355d416d9c..30805557e651 2020-12-08 enga@chromium.org Enable use_tint_generator w/ test suppressions for SPIR-V based backends 2020-12-08 rharrison@chromium.org Fix issues with roll into Skia 2020-12-08 cwallez@chromium.org Rename TryConvertAspect to better reflect what it does. 2020-12-08 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from b8a3078bbec9 to 195917c0be32 (17 revisions) 2020-12-08 stha09@googlemail.com use cstring instead of string.h 2020-12-08 stha09@googlemail.com GCC: fix template specialization in ObjectContentHasher If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC rharrison@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: rharrison@google.com Change-Id: I36597fcaff5c9fee9f830c70aee55f24652b3a50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579765Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834852}
-
Aaron Leventhal authored
DCHECK Occurs when running test in a11y FYI bot, which uses --additional-driver-flags=--force-renderer-accessibility. Bug: None Change-Id: Ia7764492cb1aa171197b0f7e6ac7a6011aa15f0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577703Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#834851}
-
Yi Gu authored
The verification backend may be unavailable for some reasons. In most cases we will fall back to the user consent backend but occasionally we need to cancel the request. Regardless, we want to measure how often this happens and why. Bug: 1127397, 1141024 Change-Id: I7e8e92878c100d20df012705ef3b944e2ad3ae64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572956Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#834850}
-