GitLab

BUG=413855

Review URL: https://codereview.chromium.org/639183003

Cr-Commit-Position: refs/heads/master@{#299193}

This moves the ExtensionCache interface out to extensions and
delegates instance provisioning out to ExtensionsBrowserClient
implementations.

BUG=398671

Review URL: https://codereview.chromium.org/612423003

Cr-Commit-Position: refs/heads/master@{#299192}

SigninManager.Observer was renamed to SignInFlowObserver, which should now
be used instead.

BUG=421058

Review URL: https://codereview.chromium.org/648843002

Cr-Commit-Position: refs/heads/master@{#299191}

BUG=422386
NOTRY=true

Review URL: https://codereview.chromium.org/648783002

Cr-Commit-Position: refs/heads/master@{#299190}

R=tonyg@chromium.org,qyearsley@chromium.org,nednguyen@chromium.org
BUG=422093

Review URL: https://codereview.chromium.org/645753002

Cr-Commit-Position: refs/heads/master@{#299189}

BUG=None

Review URL: https://codereview.chromium.org/649793002

Cr-Commit-Position: refs/heads/master@{#299188}

BUG=None
TBR=oshima@chromium.org
TEST=None

Review URL: https://codereview.chromium.org/649803002

Cr-Commit-Position: refs/heads/master@{#299187}

BUG=380875, 421444
R=oshima@chromium.org, xiyuan@chromium.org
TBR=pkasting@chromium.org, jar@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/640103002

Cr-Commit-Position: refs/heads/master@{#299186}

BUG=421208
R=zea@chromium.org

Review URL: https://codereview.chromium.org/635073002

Cr-Commit-Position: refs/heads/master@{#299185}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/853a4b9..6f078f3f

TBR=eseidel@chromium.org,caseq@chromium.org,apavlov@chromium.org

Review URL: https://codereview.chromium.org/648853002

Cr-Commit-Position: refs/heads/master@{#299184}

BUG=None
R=rockot@chromium.org
TEST=None

Review URL: https://codereview.chromium.org/642353003

Cr-Commit-Position: refs/heads/master@{#299183}

This reverts commit 6b730574, except for the
AUTHORS change from that commit.

BUG=398345,420226
TBR=garykac

Review URL: https://codereview.chromium.org/643243002

Cr-Commit-Position: refs/heads/master@{#299182}

Texture::Update() was doing a lot of calculations that did not change
much per frame. Some of the calculations such as whether or not has
non-power of 2 dimensions has been moved to when the texture
levels are set since they do not change. Others are only recalculated
when a dirty bit is set.

BUG=420152
TEST=trybots

Review URL: https://codereview.chromium.org/633773002

Cr-Commit-Position: refs/heads/master@{#299181}

BUG=401311,421705
TEST=gpu bots
NOTRY=true
R=kbr@chromium.org

Review URL: https://codereview.chromium.org/641173002

Cr-Commit-Position: refs/heads/master@{#299180}

NOTRY=true
TBR=benwells@chromium.org, halcanary@chromium.org
BUG=422485

Review URL: https://codereview.chromium.org/642353004

Cr-Commit-Position: refs/heads/master@{#299179}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/71856d5..7bb9ed7

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=reed@google.com

Review URL: https://codereview.chromium.org/647073002

Cr-Commit-Position: refs/heads/master@{#299178}

We can enable those tests now that crbug.com/419020 is fixed.

BUG=352293

Committed: https://crrev.com/9b10e4b077ee7106ab57d4728c5199a03638701a
Cr-Commit-Position: refs/heads/master@{#298062}

Review URL: https://codereview.chromium.org/623193002

Cr-Commit-Position: refs/heads/master@{#299177}

See the bug.

I was told that one of the pieces of code that could cause jank is the callback invoked in IO thread once the read on a socket is complete. I'm not familiar with the code, and I instrumented places that look relevant; feel free to suggest adding or removing the instrumentation.

BUG=418183
TBR=asanka@chromium.org

Review URL: https://codereview.chromium.org/637733002

Cr-Commit-Position: refs/heads/master@{#299176}

NOTRY=true
TBR=benwells@chromium.org, burnik@chromium.org
BUG=422472

Review URL: https://codereview.chromium.org/647153002

Cr-Commit-Position: refs/heads/master@{#299175}

NOTRY=true
TBR=benwells@chromium.org, burnik@chromium.org
BUG=422472

Review URL: https://codereview.chromium.org/643443005

Cr-Commit-Position: refs/heads/master@{#299174}

The current implementation is not used in production code
and there is no reasonable common denominator anymore between
the different implementations.

Also removing the compositor example app (which was using
cc::OutputSurface) since James says it's not incredibly useful anymore.

Review URL: https://codereview.chromium.org/640023004

Cr-Commit-Position: refs/heads/master@{#299173}

This class is the single entry point for all Geofencing related API calls, and will be responsible for storing all geofence registrations, and registering them with the underlying platform specific GeofencingProvider.

BUG=383125

Review URL: https://codereview.chromium.org/586163003

Cr-Commit-Position: refs/heads/master@{#299172}

Plumb LTHI::OnRootLayerDelegatedScrollOffsetChanged to the affected
layers and properly set damage on those layers as if they have been
scrolled.

BUG=422061

Review URL: https://codereview.chromium.org/642113004

Cr-Commit-Position: refs/heads/master@{#299171}

For supporting sending browser-hosted resources (like FileSystem and FileRef) in postMessageAndAwaitResponse, the ResourceConverter is going to need to save some state across conversions. Therefore, MessageChannel will have to use one V8VarConverter instead of using it entirely on the stack. This also means PepperTryCatch* needs to be passed a V8VarConverter instead of making its own.

BUG=417316

Review URL: https://codereview.chromium.org/635593004

Cr-Commit-Position: refs/heads/master@{#299170}

This message fills up about:gpu and stdout, and doesn't provide any
value.

BUG=

Review URL: https://codereview.chromium.org/645143002

Cr-Commit-Position: refs/heads/master@{#299169}

The original attempt to land the CL incorrectly interacted with another
recently landed CL that added the tabStripBackgroundView
(https://codereview.chromium.org/611453004). This CL was causing that view to
become layer backed, which caused it to draw on top of non-layer backed window
content, including the window controls.

This reland reworks the logic so that the tabStripBackgroundView is added to
the root view and does not become layer backed. This reland also updates
browser_tests to catch similar such errors in the future.

--------------Original CL Description---------------
Make the window's contentView have the same size as the window itself. Adjust
the view hierarchy so that Chrome does not add subviews directly to the root
view.

By default, the contentView does not occupy the full size of a framed window.
Chrome still wants to draw in the title bar. Historically, Chrome has done this
by adding subviews directly to the root view. This causes several problems. The
most egregious is related to layer ordering when the root view does not have a
layer. By making the window's contentView full-sized, there is no longer any
need to add subviews to the root view.

I deleted the tests in presentation_mode_controller_unittest.mm since they were
layout tests for the browser_window_controller, but the tests in
browser_window_layout_unittest.mm are both more robust and more comprehensive.

I fixed a bug in moveViewsForImmersiveFullscreen:... where the tabStripView was
being added to the source window rather than the destination window.

This CL is mostly a reland of https://codereview.chromium.org/399803002/.

Original CL Committed: https://crrev.com/746dbb9cfefaac243704956db431ff9bb9b0485b
Original CL Cr-Commit-Position: refs/heads/master@{#298584}

BUG=417923

Review URL: https://codereview.chromium.org/646703002

Cr-Commit-Position: refs/heads/master@{#299168}

BUG=422450
TBR=govind@chromium.org

Review URL: https://codereview.chromium.org/641183007

Cr-Commit-Position: refs/heads/master@{#299167}

Revert of Roll WebGL conformance tests. (patchset #4 id:250001 of https://codereview.chromium.org/641173002/)

Reason for revert:
might cause a bunch of texture related tests to timeout

conformance_textures_texture_formats_test
conformance_textures_texture_hd_dpi
conformance_textures_texture_mips
conformance_textures_texture_npot
conformance_textures_texture_npot_video
conformance_textures_texture_size
conformance_textures_texture_size_cube_maps
conformance_textures_texture_size_limit
conformance_textures_texture_sub_image_cube_maps
conformance_textures_texture_transparent_pixels_initialized
conformance_textures_texture_upload_cube_maps

Original issue's description:
> Roll WebGL conformance tests.
>
> BUG=401311,421705
> TEST=gpu bots
> NOTRY=true
> R=kbr@chromium.org
>
> Committed: https://crrev.com/84d03b89afa3baade276d0f7ac7892ab77ed8d21
> Cr-Commit-Position: refs/heads/master@{#299134}

TBR=kbr@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=401311,421705

Review URL: https://codereview.chromium.org/648833003

Cr-Commit-Position: refs/heads/master@{#299166}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c96f7be..853a4b9

TBR=eseidel@chromium.org,caseq@chromium.org,apavlov@chromium.org

Review URL: https://codereview.chromium.org/644063002

Cr-Commit-Position: refs/heads/master@{#299165}

Check to see if previously-allocated queries are done before allocating
new ones. It turns out that destroying a massive list of queries
accounts for 50% of our watchdog timeouts in the GPU process.

BUG=398072

Review URL: https://codereview.chromium.org/642993002

Cr-Commit-Position: refs/heads/master@{#299164}

This is a first pass only changing values of string resources, so we can
smoothly merge it to M38.

Note: strings that are not in M38 are not changed.

BUG=421466
TEST=manual, no merge conflicts for 2125

Review URL: https://codereview.chromium.org/649723002

Cr-Commit-Position: refs/heads/master@{#299163}

Two changes here:
1. When finding the max scale of an animation, only consider the scales
at each of the animations keyframes excluding the animations origin.

This is done because the origin is not an interesting scale to use, we
are animating away from it. And in the case of a layer at a high scale,
we are unable to raster all of its content at that scale. It would be
better to use the scale at the end of the transform since that is what
we will want to raster eventually.

2. When PictureLayerImpl chooses to use the animation scale:
a) Always allow using it if the scale is less than the current raster
scale choice. It can only put us in a better position memory-wise.
b) Don't use the max() with the current raster scale choice, that means
we will never use the animation scale if it is zooming out, which is
not what we want. This would also mean we choose a new raster scale on
every frame, which is bad. Just use the scale of the animation straight
up, and if it's not known, use a source scale of 1.

R=ajuma, vmpstr
BUG=421812

Review URL: https://codereview.chromium.org/642983003

Cr-Commit-Position: refs/heads/master@{#299162}

This CL turns const by value return values into const by ref.

Replacing const value by a const ref when a member variable is safe, because
the member variable will live at least as long as the temporary object returned
now. It can also be more efficient, because returning a ref can spare copying.

BUG=393155

Review URL: https://codereview.chromium.org/646853003

Cr-Commit-Position: refs/heads/master@{#299161}

Turns out attributes like AXPosition will crash with @[] :/

BUG=412707
TEST=Start Chrome with --enable-new-avatar-menu. Provided you have zooming
enabled in your Mac Accessibility settings, press Ctrl and scroll up to zoom
in. Click on the avatar button. The avatar bubble should open and Chrome should
not crash.

Review URL: https://codereview.chromium.org/645933002

Cr-Commit-Position: refs/heads/master@{#299160}

This execution path is currently seen used when destroying a
VideoDecoderJob that's still decoding:
* MediaDecoderJob::Release (early return, destroy_pending_=true)
* ...
* MediaDecoderJob::OnDecodeComplete
* ~VideoDecoderJob
* ~MediaDecoderJob
* MediaDecoderJob::ReleaseMediaCodecBridge
* MediaDecoderJob::OnMediaCodecBridgeReleased <-- !!!

The last line should be:
* VideoDecoderJob::OnMediaCodecBridgeReleased

but since it is invoked during the destructor the overridden
implementation is not executed.

R=qinmin@chromium.org,xhwang@chromium.org
BUG=internal b/17671489

Review URL: https://codereview.chromium.org/647553003

Cr-Commit-Position: refs/heads/master@{#299159}

This introduces the new files and dependencies (not used yet). A further improvement will be to switch to use gfx::Image.

TBR=senorblanco
BUG=409156

Review URL: https://codereview.chromium.org/641513003

Cr-Commit-Position: refs/heads/master@{#299158}

Only space seems to work by default.

BUG=415823

Review URL: https://codereview.chromium.org/644023002

Cr-Commit-Position: refs/heads/master@{#299157}

BUG=

Review URL: https://codereview.chromium.org/427953005

Cr-Commit-Position: refs/heads/master@{#299156}

Review URL: https://codereview.chromium.org/647623002

Cr-Commit-Position: refs/heads/master@{#299155}

BUG=

Review URL: https://codereview.chromium.org/647843002

Cr-Commit-Position: refs/heads/master@{#299154}