GitLab

Revert of Make FTP directory parser less strict (patchset #3 id:40001 of https://codereview.chromium.org/2608213002/ )

Reason for revert:
Fails on all platforms.

https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%281%29/builds/62042

Original issue's description:
> Make FTP directory parser less strict
>
> FTP directory listing returns empty result if encoding detection or
> conversion fails. This CL puts less strict constraint on conversion
> so that the whole list can survive some filenames with broken chars
> and be shown to users. Other browsers seem to work this way.
>
> The broken chars can happen due to wrong encoding detection, which
> cannot be avoided 100%, as reported in the bug.
>
> BUG=676762
> R=mmenke@chromium.org, phajdan.jr@chromium.org
>
> Review-Url: https://codereview.chromium.org/2608213002 .
> Cr-Commit-Position: refs/heads/master@{#441856}
> Committed: https://chromium.googlesource.com/chromium/src/+/ed3ef90ecc3c01246a3d838fbeefdab72c94c228

TBR=phajdan.jr@chromium.org,mmenke@chromium.org,jinsukkim@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=676762

Review-Url: https://codereview.chromium.org/2614103002
Cr-Commit-Position: refs/heads/master@{#441866}

These UseCounters will allow an investigation into how often
navigator.vibrate is called for sites with different engagement levels.

BUG=655415

Review-Url: https://codereview.chromium.org/2614913005
Cr-Commit-Position: refs/heads/master@{#441865}

This CL adds delete bookmarks and folders function and copy URL function.

BUG=651980
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2613683002
Cr-Commit-Position: refs/heads/master@{#441864}

By default, closing a dialog on Views using the Esc key behaves as if
the secondary button was pressed. In the external protocol handler, this
can create a state where the user inadvertently blocks external
protocol launching for a particular scheme with no way to allow them
again. This occurs when they tick the checkbox to always open links, but
then use Esc to close the dialog. Until UI to edit external protocol
settings is implemented, this permanently prevents any dialogs from
the page for that scheme.

This CL addresses part of the bug by ensuring that closing the external
protocol dialog without interacting with the buttons ignores the checkbox
state.

BUG=671658

Review-Url: https://codereview.chromium.org/2559783003
Cr-Commit-Position: refs/heads/master@{#441863}

This converts 1 of the 2 existing ChromeViewMsg_SetContentSettingRules
uses. Converting the other will be a separate commit.

BUG=577685

Review-Url: https://codereview.chromium.org/2582203003
Cr-Commit-Position: refs/heads/master@{#441862}

https://pdfium.googlesource.com/pdfium.git/+log/7855a2c57745..c4fcad23b143

$ git log 7855a2c57..c4fcad23b --date=short --no-merges --format='%ad %ae %s'
2017-01-04 dsinclair [libtiff] Fixup unitialized access issue
2017-01-05 dsinclair Cleaning up memory allocation in CXFA_FM2JSContext - II
2017-01-05 tsepez Banish CFX_Points, CFX_PointsF, and CFX_RectFArray to XFA-side only.
2017-01-05 npm Fix bCJK calculation in Windows MapFont

BUG=677377

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2615183002
Cr-Commit-Position: refs/heads/master@{#441861}

BUG=670150
TEST=manually with and without the background video track optimization flag.

Record time between the play or seek and when the player has enough
data for both audio and video renderers.

Review-Url: https://codereview.chromium.org/2552493002
Cr-Commit-Position: refs/heads/master@{#441860}

Reland of Make run_webkit_tests random order by default for all platforms (patchset #1 id:1 of https://codereview.chromium.org/2617563002/ )

Reason for revert:
Re-land

Original issue's description:
> Revert of Make run_webkit_tests random order by default for all platforms (patchset #2 id:20001 of https://codereview.chromium.org/2591933002/ )
>
> Reason for revert:
> fast/text/ellipsis-stroked.html started failing on some Linux and Mac bots.
>
> Original issue's description:
> > Make run_webkit_tests random order by default for all platforms.
> >
> > BUG=671805
> > R=dpranke@chromium.org,qyearsley@chromium.org
> >
> > Committed: https://crrev.com/86c477efe2039ae9f9970313769f337d8606ca95
> > Cr-Commit-Position: refs/heads/master@{#441424}
>
> TBR=dpranke@chromium.org,qyearsley@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=671805
>
> Committed: https://crrev.com/c51ad71bc112439aedbc8c8e1906f9ea098da9cc
> Cr-Commit-Position: refs/heads/master@{#441465}

TBR=dpranke@chromium.org,qyearsley@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=671805

Review-Url: https://codereview.chromium.org/2612083003
Cr-Commit-Position: refs/heads/master@{#441859}

Revert of cros: Small visual tweaks for material design palette. (patchset #2 id:20001 of https://codereview.chromium.org/2608343002/ )

Reason for revert:
Fails to build on Linux ChromiumOS Builder (dbg) since SkColorSetARGB is not a constexpr function

Original issue's description:
> cros: Small visual tweaks for material design palette.
>
> BUG=678034
>
> Review-Url: https://codereview.chromium.org/2608343002
> Cr-Commit-Position: refs/heads/master@{#441800}
> Committed: https://chromium.googlesource.com/chromium/src/+/9abb5f3f351b0d3831f79da9980a00db4d7d4815

TBR=stevenjb@chromium.org,jdufault@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=678034

Review-Url: https://codereview.chromium.org/2614063005
Cr-Commit-Position: refs/heads/master@{#441858}

If a PDF file is loaded via a link click with a history.replacestate call
in the pagehide/pageshow event for the main html page, we get a DidStartNavigation
notification on the guest webcontents created for the EmbeddedObserver.
Currently we abort the stream if it is a top level navigation.
It seems like we should not abort the stream if the navigation is within the same page.

The problem does not occur if the PDF is opened in a different tab or window

Should fix the black PDF issues with M55.

BUG=677580
TEST=Covered by browser test PDFExtensionTest.OpenPDFOnLinkClickWithReplaceState

Review-Url: https://codereview.chromium.org/2611643004
Cr-Commit-Position: refs/heads/master@{#441857}

FTP directory listing returns empty result if encoding detection or
conversion fails. This CL puts less strict constraint on conversion
so that the whole list can survive some filenames with broken chars
and be shown to users. Other browsers seem to work this way.

The broken chars can happen due to wrong encoding detection, which
cannot be avoided 100%, as reported in the bug.

BUG=676762
R=mmenke@chromium.org, phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2608213002 .
Cr-Commit-Position: refs/heads/master@{#441856}

https://skia.googlesource.com/skia.git/+log/3afa628e50e3..b38db9a48db0

$ git log 3afa628e5..b38db9a48 --date=short --no-merges --format='%ad %ae %s'
2017-01-05 brianosman Revert "Hard code bicubic coefficients in the shader"

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=csmartdalton@google.com

Review-Url: https://codereview.chromium.org/2614043003
Cr-Commit-Position: refs/heads/master@{#441855}

There's no longer a PageState mismatch from bug 617239, so we can
re-enable the test expectations for these tests.

BUG=236848, 617239
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2614913002
Cr-Commit-Position: refs/heads/master@{#441854}

This is so a single line comment can be used to exclude <if> in .js
files. I've added tests for both <include> and <if>. They need to be
commented for clang-format purposes.

BUG=678778
R=thakis@chromium.org

Review-Url: https://codereview.chromium.org/2615953002
Cr-Commit-Position: refs/heads/master@{#441853}

ViewResourceAdapter re-uses bitmaps where possible. The app icons
drawn into the quick action ImageView have transparent backgrounds,
so when the bitmap is re-used some of pixels do not get re-drawn
making it look like two app icons are layered on top of each other.

Setting a background on the quick action ImageView causes all
pixels to get redrawn when the bitmap is captured.

BUG=678708

Review-Url: https://codereview.chromium.org/2615753005
Cr-Commit-Position: refs/heads/master@{#441852}

This CL tries to shorten the lifetime of VideoFrames that go to MediaRecorder sink.
In order to release frames earlier, the video parameters that WebmMuxer later needs
are stored in VideoParameters struct and passed.

BUG=678095
TEST=Tested https://rawgit.com/Miguelao/demos/master/mediarecorder.html
H264/VPX on Mac.

Review-Url: https://codereview.chromium.org/2612403002
Cr-Commit-Position: refs/heads/master@{#441851}

HostExperimentSessionPlugin is a host side SessionPlugin to send host attributes
to, and receive configuration from the client side.
A host can attach this plugin to the Session and use its configuration to
initialize a HostSessionOptions.

This is part of host experiment framework.

BUG=650926

Review-Url: https://codereview.chromium.org/2586133002
Cr-Commit-Position: refs/heads/master@{#441850}

BUG=677582
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2613023003
Cr-Commit-Position: refs/heads/master@{#441849}

This patch changes to insert a line break when user inserts a space at
the top of wrapped lines, so that the inserted space appear at the
caret position.

The change is for plaintext only for now, so that we can collect
feedback and discuss with editor developers for what to do with
contenteditable.

BUG=76113

Review-Url: https://codereview.chromium.org/2618613004
Cr-Commit-Position: refs/heads/master@{#441848}

This is for a better right key line now that controls are more
consistently on the right of md-settings.

R=dschuyler@chromium.org
BUG=673953
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2611183003
Cr-Commit-Position: refs/heads/master@{#441847}

BUG=none

Review-Url: https://codereview.chromium.org/2618633005
Cr-Commit-Position: refs/heads/master@{#441846}

BUG=678495
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2614083002
Cr-Commit-Position: refs/heads/master@{#441845}

A policy icon was being rendered when enforced, but without an icon to
show. This wasn't a big deal as it was invisible and taking up empty
space. But when flipping the position of this indicator, as in
https://codereview.chromium.org/2615093003/, it visually matters.

BUG=673953
R=dschuyler@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2611243002
Cr-Commit-Position: refs/heads/master@{#441844}

SignalStrength was a member of CellularStateProperties, but not
Cellular{Managed}Properties which are supposed to be a superset.

BUG=none

Review-Url: https://codereview.chromium.org/2618793004
Cr-Commit-Position: refs/heads/master@{#441843}

Methods of IntentHandler typically take a context, but the context is
merely used to get the package name and start an Activity.  We can
instead use ContextUtils.getApplicationContext().

Review-Url: https://codereview.chromium.org/2607633002
Cr-Commit-Position: refs/heads/master@{#441842}

BUG=677884

Review-Url: https://codereview.chromium.org/2613723004
Cr-Commit-Position: refs/heads/master@{#441841}

BUG=None

Review-Url: https://codereview.chromium.org/2611123003
Cr-Commit-Position: refs/heads/master@{#441840}

From what I can tell, skipping base (UITEF) class's PreRunValidation isn't
a good idea. Make those subclasses include calling the base function.

The two subclasses are:
AppCurrentWindowInternalExtensionFunction and
FileSystemProviderInternalFunction

BUG=None
Test=None, in theory we should correctly send errors to extension APIs when
browser is shutting down.

Review-Url: https://codereview.chromium.org/2617023003
Cr-Commit-Position: refs/heads/master@{#441839}

Added CSSPropertyAPITransformOrigin which implements CSSPropertyAPI for
the transform-origin property. Parsing logic is the same as before,
just was moved from CSSPropertyParser to the .cpp file. Added flag
to CSSProperties.in so that the .h file will be generated.

BUG=668012

Review-Url: https://codereview.chromium.org/2615443007
Cr-Commit-Position: refs/heads/master@{#441838}

BUG=none

Review-Url: https://codereview.chromium.org/2616743004
Cr-Commit-Position: refs/heads/master@{#441837}

For "Update CCT/Herb menu item" CL (https://codereview.chromium.org/2596973002), there are some small changes needed after it is landed. This CL updates based on these comments.

BUG=None

Review-Url: https://codereview.chromium.org/2618833003
Cr-Commit-Position: refs/heads/master@{#441836}

BUG=132847
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2612953002
Cr-Commit-Position: refs/heads/master@{#441835}

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL replaces append() with push_back() in Source/core/inspector/.
There are too many references to change them all at once, so this CL is
part 8 of many.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431

Review-Url: https://codereview.chromium.org/2610383002
Cr-Commit-Position: refs/heads/master@{#441834}

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL replaces append() with push_back() in Source/core/loader/.
There are too many references to change them all at once, so this CL is
part 10 of many.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431

Review-Url: https://codereview.chromium.org/2614833005
Cr-Commit-Position: refs/heads/master@{#441833}

BUG=674215

Review-Url: https://codereview.chromium.org/2573213002
Cr-Commit-Position: refs/heads/master@{#441832}

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL replaces append() with push_back() in Source/modules/.

There are too many references to change them all at once, so this CL is
part 13 of many.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2614663008
Cr-Commit-Position: refs/heads/master@{#441831}

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL replaces append() with push_back() in Source/web/.

There are too many references to change them all at once, so this CL is
part 15 of many.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431

Review-Url: https://codereview.chromium.org/2612903007
Cr-Commit-Position: refs/heads/master@{#441830}

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL replaces append() with push_back() in Source/core/page/.
There are too many references to change them all at once, so this CL is
part 11 of many.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431

Review-Url: https://codereview.chromium.org/2614033002
Cr-Commit-Position: refs/heads/master@{#441829}

Now that Navigator supplements can get the Navigator object via host(),
the supplements don't need to observe ContextClient.

BUG=610176

Review-Url: https://codereview.chromium.org/2618713002
Cr-Commit-Position: refs/heads/master@{#441828}

BUG=646176

Review-Url: https://codereview.chromium.org/2615713004
Cr-Commit-Position: refs/heads/master@{#441827}