- 06 Jun, 2014 40 commits
-
-
pavely@chromium.org authored
Tree doesn't compile, returning to original state. > Revert 275046 "ChromeOS login webui refactoring: split user sele..." > > Revert change as it likely causes KioskTest failure > http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%283%29/builds/35748 > > > ChromeOS login webui refactoring: split user selection/gaia login screens. > > Phase two : move user list processing to UserSelectionScreen > > > > BUG=373314 > > R=nkostylev@chromium.org > > > > Review URL: https://codereview.chromium.org/296823009 > > TBR=antrim@chromium.org > > Review URL: https://codereview.chromium.org/317243006 TBR=pavely@chromium.org Review URL: https://codereview.chromium.org/319273002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275555 0039d316-1c4b-4281-b951-d872f2087c98
-
vandebo@chromium.org authored
Removes the second dialog implementation, which was a slightly modified version of the first one. BUG=NONE Review URL: https://codereview.chromium.org/318733003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275554 0039d316-1c4b-4281-b951-d872f2087c98
-
rosca@adobe.com authored
SkGpuDevice constructors are deprecated and the factory should be used instead when filters and blending require offscreen targets. Extra NULL check added: for many reasons, something can go wrong within GrGpuGL::onCreateTexture() and fail to create the backing store's texture. Instead of crashing, we can handle this gracefully and simply render the page without the blending applied. BUG=359947 Review URL: https://codereview.chromium.org/315913002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275553 0039d316-1c4b-4281-b951-d872f2087c98
-
rch@chromium.org authored
set up a timer to cancel any requests, if the handshake takes too long. The requests will be retried and will use either QUIC or TCP, whichever connects first. Review URL: https://codereview.chromium.org/318993004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275552 0039d316-1c4b-4281-b951-d872f2087c98
-
stevenjb@chromium.org authored
This is in preparation of merging NetworkState and FavoriteState, crbug.com/375955. The merge will involve a number of changes to ShillPropertyHandler and in the process of making those changes some additional logging and test cleanup was necessary that isn't directly related to the merge itself. BUG=none For trivial changes to chrome/browser/ui/webui/options/ TBR=dbeam@chromium.org Review URL: https://codereview.chromium.org/299403012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275551 0039d316-1c4b-4281-b951-d872f2087c98
-
pavely@chromium.org authored
Revert change as it likely causes KioskTest failure http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%283%29/builds/35748 > ChromeOS login webui refactoring: split user selection/gaia login screens. > Phase two : move user list processing to UserSelectionScreen > > BUG=373314 > R=nkostylev@chromium.org > > Review URL: https://codereview.chromium.org/296823009 TBR=antrim@chromium.org Review URL: https://codereview.chromium.org/317243006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275550 0039d316-1c4b-4281-b951-d872f2087c98
-
pavely@chromium.org authored
This change preventing me from reverting r275046 which seems to be causing failures in KioskTest http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%283%29/builds/35748 > ChromeOS login webui refactoring : Move GAIA-related code to gaia_screen_handler > > BUG=373314 > R=nkostylev@chromium.org > > Review URL: https://codereview.chromium.org/304303005 TBR=antrim@chromium.org Review URL: https://codereview.chromium.org/310313006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275549 0039d316-1c4b-4281-b951-d872f2087c98
-
pavely@chromium.org authored
This change preventing me from reverting r275046 which seems to be causing failures in KioskTest http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%283%29/builds/35748 > ChromeOS login webui refactoring : Simplify login methods. > > > BUG=373314 > R=nkostylev@chromium.org > > Review URL: https://codereview.chromium.org/324463003 TBR=antrim@chromium.org Review URL: https://codereview.chromium.org/319633005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275548 0039d316-1c4b-4281-b951-d872f2087c98
-
sergeyu@chromium.org authored
Android keyboard generates key press and key release events for latin keyboard. The client was sending them as KeyEvent, as result the host was not injecting correct characters when remote keyboard layout is not Qwerty. Now client sends TextEvent for events that come from software keyboard. BUG=364276 Review URL: https://codereview.chromium.org/303443004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275547 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@chromium.org authored
InputManager provides ToplevelEventTarget and AcceleratorManager. Added test short cut (ctrl-l) to show the home card. BUG=375534 TEST=covered by unit tests R=sadrul@chromium.org, sky@chromium.org Review URL: https://codereview.chromium.org/305873002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275545 0039d316-1c4b-4281-b951-d872f2087c98
-
jamesr@chromium.org authored
The size of the frame data from a delegated source will not in general match up exactly with the delegated layer's bounds. Frame sizes and layer bounds are both expressed as integers, but frame sizes are in physical pixels and layer bounds are in device-independent pixels. If the device scale is not an integer, there may not be an exact mapping between the two spaces. For instance, if the layer size is 105 x 211 and the device scale is 1.5, the delegated content is responsible for filling 157.5 x 316.5 physical pixels in the final output. This isn't really possible so what actually happens is the delegated renderer produces a frame with a physical size of 158 x 317 pixels and sends that up to the DRLI. To map this frame into physical space, the DRLI should apply the inverse of the device scale factor to reflect that the frame covers 105.333 x 211.3333 logical pixels. Before this patch, DRLI would attempt to scale the frame by (105/158, 211/317) resulting in the frame being scaled down non-uniformly to try to make 158 x 317 pixels fit into a 157.5 x 316.6 space. This scaling looks bad and ends up mapping pixels partially outside of the layer's logical bounds into the layer's logical bounds. BUG=370074 Review URL: https://codereview.chromium.org/311253004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275544 0039d316-1c4b-4281-b951-d872f2087c98
-
rvargas@chromium.org authored
BUG=322664 Review URL: https://codereview.chromium.org/320513002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275542 0039d316-1c4b-4281-b951-d872f2087c98
-
nednguyen@google.com authored
TBR=nduca@chromium.org BUG= Review URL: https://codereview.chromium.org/322553003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275541 0039d316-1c4b-4281-b951-d872f2087c98
-
pkasting@chromium.org authored
* Make FixupUserInput() just return the fixed-up input text, since almost every caller wanted that (and the one that didn't, the HUP, will change in the future) * Make some functions which took an AutocompleteInput object and then only cared about the text() just take a string16 * Eliminated HistoryURLProvider::RunAutocompletePasses(), since it had only one caller, and just inline the code into Start(). Also got rid of the |fixup_input_and_run_pass_1| variable that was never false. BUG=none TEST=none Review URL: https://codereview.chromium.org/312423003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275540 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275539 0039d316-1c4b-4281-b951-d872f2087c98
-
dcheng@chromium.org authored
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=175623:175677&mode=html TBR=peter@chromium.org Review URL: https://codereview.chromium.org/316383003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275538 0039d316-1c4b-4281-b951-d872f2087c98
-
dcheng@chromium.org authored
BUG=381893 TBR=perkj@chromium.org Review URL: https://codereview.chromium.org/320103002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275537 0039d316-1c4b-4281-b951-d872f2087c98
-
rvargas@chromium.org authored
BUG=322664 Review URL: https://codereview.chromium.org/316373003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275536 0039d316-1c4b-4281-b951-d872f2087c98
-
sl.ostapenko@samsung.com authored
Call RenderViewImpl::SetScreenOrientationForTesting from MockScreenOrientationController::UpdateScreenOrientation() to make sure that events are not sent when orientation is locked. Existing implementation calls SetScreenOrientationForTesting and sends screen orientation events even when the test screen orientation is locked. BUG=162827 Review URL: https://codereview.chromium.org/302553007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275535 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
Fix an easily reproducible crash that happens locally in the PDF plugin. BUG=375126 Review URL: https://codereview.chromium.org/298803010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275534 0039d316-1c4b-4281-b951-d872f2087c98
-
isherman@chromium.org authored
Move the functionality we still need into the BluetoothDevice class. BUG=372495 TEST=none R=keybuk@chromium.org Review URL: https://codereview.chromium.org/317073011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275532 0039d316-1c4b-4281-b951-d872f2087c98
-
rdevlin.cronin@chromium.org authored
The methods GetActivePermission() and HasAPIPermission() have been deprecated for more than a year. Finally remove them. Also clean up some includes in extension.h, and fix transitive includes. BUG=379356 TBR=atwilson@chromium.org (c/b/background) TBR=yurys@chromium.org (c/b/devtools) TBR=bauerb@chromium.org (c/b/managed_mode) TBR=dalecurtis@chromium.org (c/b/media) TBR=dewittj@chromium.org (c/b/notifications) TBR=msw@chromium.org (c/b/ui) All TBRs are for strictly mechanical changes - no functional difference. Review URL: https://codereview.chromium.org/314113010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275531 0039d316-1c4b-4281-b951-d872f2087c98
-
dalecurtis@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275527 0039d316-1c4b-4281-b951-d872f2087c98
-
imcheng@chromium.org authored
getting the logs. The current fields (os, product, product version) is populated using chrome_version_info.h. Review URL: https://codereview.chromium.org/317823008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275526 0039d316-1c4b-4281-b951-d872f2087c98
-
ccameron@chromium.org authored
TBR=miu BUG=381542 Review URL: https://codereview.chromium.org/319183003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275525 0039d316-1c4b-4281-b951-d872f2087c98
-
picksi@chromium.org authored
The FeatureUtilities class has been moved upstream. The original class has been left in place; It will be removed and all package references changed to the new version once the change has been rolled into Clankium. Unit Tests for FeatureUtilities.java have been added. Currently I have added only tests for the speech recognition feature. BUG=243060 Review URL: https://codereview.chromium.org/304573002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275524 0039d316-1c4b-4281-b951-d872f2087c98
-
joaodasilva@chromium.org authored
CanBeEditedByUser indicates if a bookmark can be edited by the user or not. All of the bookmarks in the bookmark_bar_node, the other_node and the mobile_node are always editable but some of the extra nodes provided by the client may be unmodifiable. Also updated other methods to work only with user-editable nodes, and added utility helpers to detect nodes that can or can't be edited. BUG=49598 Review URL: https://codereview.chromium.org/317333004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275523 0039d316-1c4b-4281-b951-d872f2087c98
-
mdempsky@chromium.org authored
BUG=376567 Review URL: https://codereview.chromium.org/314133003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275522 0039d316-1c4b-4281-b951-d872f2087c98
-
danakj@chromium.org authored
Revert of suppress uninit error at SkUnPreMultiply::PMColorToColor in content_browsertests (https://codereview.chromium.org/322463004/) Reason for revert: Should no longer be needed. Original issue's description: > suppress uninit error at SkUnPreMultiply::PMColorToColor in content_browsertests > > BUG=380680 > TBR=reed@google.com > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275306 TBR=reed@google.com,zhaoqin@google.com NOTREECHECKS=true NOTRY=true BUG=380680 Review URL: https://codereview.chromium.org/324513004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275521 0039d316-1c4b-4281-b951-d872f2087c98
-
jamesr@chromium.org authored
With gn, it'll probably be common for folks to generate their out directory in places other than out/{Debug|Release}. This is technically possible (and busted) in gyp as well. This avoids the relative path dependency from the script and simplifies it some more by adding the src/ui/gl and src/gpu directories in the build files (where they can be relativized properly) instead of trying to do so in the script. R=brettw@chromium.org Review URL: https://codereview.chromium.org/317813002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275520 0039d316-1c4b-4281-b951-d872f2087c98
-
jianli@chromium.org authored
BUG=none TEST=none TBR=zea@chromium.org Review URL: https://codereview.chromium.org/321593003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275519 0039d316-1c4b-4281-b951-d872f2087c98
-
samuong@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/311343006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275515 0039d316-1c4b-4281-b951-d872f2087c98
-
dmichael@chromium.org authored
BUG=380827 Review URL: https://codereview.chromium.org/324453003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275514 0039d316-1c4b-4281-b951-d872f2087c98
-
starodub@google.com authored
BUG= Review URL: https://codereview.chromium.org/314293004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275513 0039d316-1c4b-4281-b951-d872f2087c98
-
jgraettinger@chromium.org authored
SpdyFramer will accept them, and frame them if present. We may want to leave this for later SPDY versions, but certainly don't emit them in SPDY4. BUG=345769 Review URL: https://codereview.chromium.org/316983006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275512 0039d316-1c4b-4281-b951-d872f2087c98
-
danakj@chromium.org authored
not everything in the video frame is opaque. R=reed@google.com, sievers@chromium.org BUG=380680 Review URL: https://codereview.chromium.org/319133003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275511 0039d316-1c4b-4281-b951-d872f2087c98
-
mseaborn@chromium.org authored
BUG=https://code.google.com/p/nativeclient/issues/detail?id=3114 TEST=compile Review URL: https://codereview.chromium.org/322443007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275510 0039d316-1c4b-4281-b951-d872f2087c98
-
tonyg@chromium.org authored
The previous code made it possible to try to access tabs prior to the session restore completing. This should make the benchmark much more deterministic. BUG=375979 Review URL: https://codereview.chromium.org/313923003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275509 0039d316-1c4b-4281-b951-d872f2087c98
-
zeeshanq@chromium.org authored
|adb_gdb --su-prefix=su| wasn't working for me, so updating doc and script. BUG=337423 Review URL: https://codereview.chromium.org/315223005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275508 0039d316-1c4b-4281-b951-d872f2087c98
-
mukai@chromium.org authored
In the case of the reported crash, we doesn't set the transient parent, which means we cannot unregister the window observer. BUG=373522 R=erg@chromium.org TEST=see the bug Review URL: https://codereview.chromium.org/317303002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275507 0039d316-1c4b-4281-b951-d872f2087c98
-