- 03 Sep, 2020 40 commits
-
-
Hidehiko Abe authored
This CL unifies those two buildflags file for Chrome OS. BUG=1114198 TEST=Build locally. Ran tryjob. Change-Id: Id7343da06ac6b17cb20cb20babdd8ab06ac40028 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377525 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#804308}
-
Karel Král authored
Implement an overloaded function to trace its argument into a given TracedValue pointer. Thus enable using type deduction to decide which way to trace a given argument. Bug: 1111787 Change-Id: I058c3436f59f3b6d98e34c1f620b467e4d5c41e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364872 Commit-Queue: Karel Král <karelkral@google.com> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#804307}
-
Antonio Sartori authored
This CL implements a unittest in the AncestorThrottle for testing the logic of the check for Content-Security-Policy: Embedded Enforcement. Bug: 1094909 Change-Id: I935110d1718b7d39d364f20e57a24e59ba141463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294801 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#804306}
-
Ben Pastene authored
This reverts commit 0839d38f. Reason for revert: chromium/ci/linux-chromeos-rel never times out All builds are < 2 hours: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel Original change's description: > [infra] Increase linux-chromeos-rel build timeout from 3 to 4 hours > > Bug: 1121834 > Change-Id: Ic98a994d225795788e10c4b161f9de1b1bde60d2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376572 > Auto-Submit: Gregory Guterman <guterman@google.com> > Reviewed-by: Erik Staab <estaab@chromium.org> > Commit-Queue: Erik Staab <estaab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#801637} TBR=estaab@chromium.org,guterman@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1121834 Change-Id: Icbaf4999523e7c24bb0973b14c7517ae05c68e24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392918Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#804305}
-
Luke Zielinski authored
This rolls up to sha 7da1d0666575e5735fd1286e6b3e67e9973f4643 Just one minor change to testharness, likely a no-op Change-Id: Ia7e1318684542156d1906f1e67c7508aed903bac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392438 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Auto-Submit: Luke Z <lpz@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#804304}
-
Jinsuk Kim authored
The feature has been sunset. Remove the related flags, make some '..FeatureEnabled()' methods simply return false. Cleaning up the rest of Duet-related code will follow soon. Bug: 1081343 Change-Id: If58553cc7553b942bfbd97034efa86dc03f7aab9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386858Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Lijin Shen <lazzzis@google.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#804303}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202009030800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/tO_jo2xydYVZOxjRmrkRI5NL5AYbhmuV3J9LTRaaYEsC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: help-app@grotations.appspotmail.com Change-Id: Id129d7a5a29e6e14fd3455e9f45411772689a149 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392715Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804302}
-
danakj authored
This is from pre-compositing times. R=avi@chromium.org Change-Id: I95617aca135e455053130d53b357d95c0c563042 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392399Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#804301}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c4bfa82e48ed..fb45a94639ca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I1057be90d5501c55c72f34a982c1b20d8a4a1407 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390854Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804300}
-
Le Hoang Quyen authored
- yuv_to_rgb_converter.cc was only able to correctly handle rectangle YUV textures (GL_TEXTURE_RECTANGLE_ARB). However, it couldn't handle GL_TEXTURE_2D textures correctly (The Metal backend uses GL_TEXTURE_2D for IOSurface unlike the default OpenGL backend). - The shaders code as well as the OpenGL code were assuming the textures are rectangle whereas the 2D scenarios hadn't been tested properly. For example, the OpenGL code always passed texture size to "a_texScale" uniform to scale the texcoords, regardless of the texture being rectangle or 2D. In 2D fragment shader, the texcoords for UV texture were reduced by half as if the texcoords are for rectangle texture. - Furthermore, when binding IOSurface to 2D textures, the code forgot to disable mipmap filtering. Because by default 2D textures have mipmap filtering enabled, and IOSurface bound textures don't have mipmap, this led to the YUV textures were reported as incomplete by OpenGL. Thus decoding wouldn't be able to sample real results from the YUV textures. Bug: angleproject:4846 Bug: angleproject:2634 Bug: 1122432 Change-Id: Ie43b755c19b3dc149ddca3d68c381fee99479c00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378407 Commit-Queue: Le Hoang Quyen <le.hoang.q@gmail.com> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#804299}
-
Christian Dullweber authored
This is a reland of 1180542b The internal CL is rolled in now. Let's try again... Original change's description: > Remove BlockThirdPartyCookies preference > > The boolean BlockThirdPartyCookies preference was replaced by > CookieControlsMode enum. Existing settings were migrated since M83. > Since all usage of the preference has been removed, the preference > can be removed and existing settings cleared. > > Bug: 1104836 > Change-Id: Ie6e38b0a424981395c627459d684030ea84a58b7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387805 > Reviewed-by: Balazs Engedy <engedy@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Commit-Queue: Christian Dullweber <dullweber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#803844} Tbr: engedy@chromium.org, gab@chromium.org Bug: 1104836, 1124326 Change-Id: Iebe3205beb4426cda5305eb7c69eb4e575df2cfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391073Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#804298}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/be72801f29f9..f8823b572600 2020-09-03 kjlubick@google.com Reland "[canvaskit] Change SkRects to be arrays, not objects." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: michaelludwig@google.com Change-Id: Icd68c3d5f343b5c89a103f85bf4953fc747a250b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392666Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/9e261b46a4f7..b44ca92f1cdd 2020-09-03 rharrison@chromium.org Roll 4 dependencies If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I8316ca08f28c378d68b008f4b0ae33db999f372a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392717Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1599112620-a8868b59128a8bce1a265b8451e03eb5caa355ad.profdata to chrome-win64-master-1599134104-920143836f5d72550f74eec8979ce216d37b0d87.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I6ca7bb831139297361522029ebbd3cf2e9007310 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392667Reviewed-by:
-
Haiyang Pan authored
The bot pool looks sufficient for the extra traffic: http://shortn/_uTq3bMFtkS Bug: 997376 Change-Id: I19b127b71802c652137c94f54632395bf965f31c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387123Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#804294}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/72ab3787b4b4..ed9c15fc40f4 2020-09-03 wolfi@chromium.org Reland of "Fix context menu for issues banner" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1123455 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iffd0e2225e375059e693c39e2c0c7e6f9df0eb09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392671Reviewed-by:
-
K. Moon authored
Adds test fixture and some simple tests for BlinkUrlLoader. This class is still being implemented, so these tests mainly serve as examples. Also implements BlinkUrlLoader::GrantUniversalAccess(), to make the tests a little more interesting. BlinkUrlLoader::Client was changed to provide a WebAssociatedURLLoader instead of a WebLocalFrame. The former is easier to fake in unit tests. Bug: 1099022 Change-Id: I66a8132373cf61ab539321151253a20bbf7801b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391928 Commit-Queue: K. Moon <kmoon@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#804292}
-
Nicolas Ouellet-Payeur authored
This reverts commit 751a970a. Reason for revert: use-of-uninitialized-memory. crbug.com/1124805 Original change's description: > Make NGInlineNodeEditor to produce proper NGInlineItem and ShapeResult > > This patch changes |NGInlineNodeEditor| to produce |NGInlineItem| with > |ShapeResult| having same start and end offset for valid text painting. > > Before this patch, we see wrong painting, e.g. "AxXX" instead of "AxVX" > when insert "x" before "X" of "AVX". This is cause by kerning between > "A" and "V". > > Bug: 1121885 > Change-Id: I8242356ef6b865f2ad8b2e47de62d3200286e3f3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391701 > Commit-Queue: Koji Ishii <kojii@chromium.org> > Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> > Reviewed-by: Koji Ishii <kojii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#804257} TBR=yosin@chromium.org,tkent@chromium.org,kojii@chromium.org,ikilpatrick@chromium.org Change-Id: Iec0afbb96510b040fe0932000c74b2ccef0ebfe3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1121885 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392770Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#804291}
-
Brandon Tolsch authored
This reverts commit 5afc937a. Reason for revert: compile failure on chromeos-amd64-generic-dbg https://ci.chromium.org/p/chromium/builders/ci/chromeos-amd64-generic-dbg/15678? Original change's description: > [CrOS PhoneHub] Add ConnectionMedium parameter to SecureChannelClient > > Additionally, update all existing clients to use the kBluetoothLowEnergy > client. > > Bug: 1106937 > Change-Id: I064abe879b2a74612ff4a096f9305eef25e5bd11 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391739 > Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> > Reviewed-by: James Vecore <vecore@google.com> > Cr-Commit-Position: refs/heads/master@{#804286} TBR=khorimoto@chromium.org,vecore@google.com Change-Id: I9c66c9f09594b4a0dec2b934d2ead408ef0d5967 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1106937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392713Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Cr-Commit-Position: refs/heads/master@{#804290}
-
ckitagawa authored
Sending these events is no longer required to paint out-of-lifecycle. When originally creating CapturePaintPreview, we would get a crash if the caller didn't send these events. However, they don't appear to be required anymore. The PhishingClassifier::ExtractVisualFeatures has been using CapturePaintPreview without sending these events successfully for a while. Unfortunately, I'm not an expert on the internals of Blink paint or printing so the reason this behavior has changed is unclear to me. That said, I've tested manually and via unit/integration tests and nothing has regressed as a result of removing these calls so I believe it is safe to do so. Bug: 1123437 Change-Id: I89819d0cf50bcb0000589e64ac497ca34fac5a36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392735 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#804289}
-
Andrew Grieve authored
Renames occurrences in //tools/grit as well as all spots that are transitively affected by the rename. Opts grit testdata out of PRESUBMIT.py checks since we don't need UI snapshots for strings in unit tests. Bug: 1097644 Change-Id: Ieca51c233447ded9d5943ad878354cbdaa1de78d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386392Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#804288}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1580d2fe0230..2e32d90fa6b3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC nicolaso@google.com,melandory@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: nicolaso@google.com,melandory@google.com Change-Id: I91a9f247c01682e3fee3af54322c0b7b573b14b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392672Reviewed-by:
-
Kyle Horimoto authored
Additionally, update all existing clients to use the kBluetoothLowEnergy client. Bug: 1106937 Change-Id: I064abe879b2a74612ff4a096f9305eef25e5bd11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391739 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#804286}
-
Becca Hughes authored
Adds caching for the frameless code. Will store the data in Media History and will clear every 24 hours or if the user signs in or out. BUG=1121360 Change-Id: I0ae9112cbd5dc272158f2e369d8807da02f0e2b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375701 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#804285}
-
Peter Boström authored
This hides |listener_| as an implementation detail, which follows style better. This is a prerequisite for replacing |listener_| with a base::RepeatingCallback. Bug: 772945 Change-Id: I875872b10a03b2349319102daa2541bc72253bf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392397 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
-
Kyle Horimoto authored
This CL adds a medium to the Mojo API, which allows clients to choose the connection medium. It also adds an EnumTraits definition for ConnectionMedium and updates tests to reflect this new parameter. Note that currently, the client code is still hard-coded to use the kBluetoothLowEnergy medium. A follow-up CL adds the ability for clients to specify the medium themselves. Bug: 1106937 Change-Id: Ic0fa8fe13d1402928c49557220f2e45135cadff0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390965 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
-
Ali Juma authored
Error pages for unsafe subframes are triggered by associating an UnsafeResource with the corresponding main frame item and reloading that item. This reload is detected in SafeBrowsingTabHelper::ShouldAllowRequest and an error decision is created. This detection logic was incorrectly also applied to subframe reloads, triggering a crash since these can happen while both the pending item and last committed item are null. More specifically, this can happen when a subframe triggers a reload using JavaScript, at the same time as the user performs a back/forward navigation to a restore_session URL. This CL fixes this logic by only applying it to main frame requests. Bug: 1124308 Change-Id: Idc485b836e88c41116f16b5b42a964585666d9cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392398Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#804282}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/598906885691..999c85ee8215 2020-09-03 courtneygo@google.com Correct PCI Device ID for Pixel1 & Pixel2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: I5ad90e5be9cb889c466153c503bff60dbc9a1e82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392668Reviewed-by:
-
Ben Kelly authored
Bug: 1124632,1035448 Change-Id: Id12d83787b2f3aa815737ec0b263641e0ed051e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392404Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#804280}
-
Dominik Röttsches authored
Follow-up to: https://chromium-review.googlesource.com/c/chromium/src/+/2375329 content::GetGlobalJavaInterfaces() requires to be scheduled on the UI thread. RenderProcessHostImpl already has a path to schedule bindings there. Move AndroidFontLookup binding to being scheduled on this thread. Testing in [1] shows that otherwise the DCHECK in GetGlobalJavaInterfaces() is hit when binding to the AndroidFontLookup service. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2387017 Bug: 1121589 Change-Id: I003b4884a2373f6fc152a616e44b6be829f9f05a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391240Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
-
Patrick Noland authored
Bug: 795423 Change-Id: I99a4fb53e01b5e09a652c501f19b971046a59cf2 TBR: michaelbai@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390957Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#804278}
-
Xiang Ji authored
Bug: 1124114 Validation: https://ci.chromium.org/p/chromium/builders/try/win-celab-try-rel/140? Change-Id: Idc984c1fb038d4d2f4c26db62bb0cd9f540d233f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389227 Commit-Queue: Xiang Ji <jxiang@google.com> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#804277}
-
Kyle Horimoto authored
This CL adds a new ConnectionMedium::kNearbyConnections enum value and adds a few potential error cases with this value. Actual handling of Nearby Connections requests is left as a TODO in PendingConnectionManagerImpl. Note that this does not actually add a ConnectionMedium value to the top-level API, and all incoming requests are assumed to be BLE at this point. The parameter is added to the Mojo API as part of the follow-up CL at [1], and some tests verifying the functionality in this CL are added in that CL as well. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2390965 Bug: 1106937 Change-Id: I8e29613d6f2a11403d6815abebabeb21b64babe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391587 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/00e17f2cebef..011139094ec7 2020-09-03 rharrison@google.com Adding back non-spvc BUILD.gn that I accidentally nuked (#1136) 2020-09-03 rharrison@google.com Remove spvc (#1135) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: radial-bots+chrome-roll@google.com Change-Id: Iee77dff1220eb8b52792c577633190cc107640d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392669Reviewed-by:
-
Josiah K authored
Change-Id: I38e256e3e593c30a4d4e164d143c0b1d71d6352a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392262 Auto-Submit: Josiah Krutz <josiahk@google.com> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
-
Henrique Nakashima authored
Often we want to audit dependencies on a set of classes and it is tedious to run the script once for each class. Also change the matching logic not to match partial class names, as it gets in the way of, for example, ChromeTabbedActivity, because of MultiInstanceChromeTabbedActivity. Change-Id: Ib75b8bdd1361e446f61b7a9d979f0f3403882edf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391610 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#804273}
-
Daniel Hosseinian authored
Add a method to calculate the size of a thumbnail image in device pixels using the dimensions of the PDF page and the intended device to pixel ratio. Thumbnail images are raw RGBA bitmaps with their sizes capped at a maximum of 255KiB; their pixel dimensions are also bound to that limit. However, the aspect ratio of thumbnails will always be as close as possible to that of its corresponding PDF page. Bug: 652400 Change-Id: I1866f52e1eb1835d921e5653c76fc98d68d77f9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378387 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
K. Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#804272}
-
Daniel Classon authored
The kGetImageDescriptionsFromGoogle setting was placed within the Manage A11y subpage in the hierarchy but it is actually a top level setting. Needed to deep link to this setting in the A11yPage. Bug: 1084154 Change-Id: Iabad764847adcbfc4cfdbab530d21881c7d2dc5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390647Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Daniel Classon <dclasson@google.com> Cr-Commit-Position: refs/heads/master@{#804271}
-
Chris Sharp authored
Bug: 1018157 Change-Id: Ibddd7cdd6d100e5c551ede9efbedbe3f10a5585e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296062 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Olya Kalitova <okalitova@chromium.org> Cr-Commit-Position: refs/heads/master@{#804270}
-
Alexis Hetu authored
Updating expectations to reflect ANGLE side fixes Bug: angleproject:3930, angleproject:2914, angleproject:2899 Change-Id: I9fcdbd1d3a40c16289abdb71d753e271d5f7cad6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385880 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
-
