- 31 Aug, 2018 40 commits
-
-
Etienne Bergeron authored
This CL is turning on the CPU sampler category. see: https://chromium-review.googlesource.com/c/chromium/src/+/1191745/ It's also turning on the task scheduler info. Which is adding the task_priority to the trace and will ease finding priority inversion. Title TaskTracker::RunTask Category task_scheduler Args task_info {execution_mode: "parallel", task_priority: "USER_BLOCKING"} R=etiennep@chromium.org, oysteine@chromium.org Bug: 867931 Change-Id: I8f6e4772816cc446a25c04ce0cda4b9d45c44232 Reviewed-on: https://chromium-review.googlesource.com/1199567 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#588179}
-
James Cook authored
These keyboard shortcuts trigger focus changes that cause InputMethodMus to ack all in-flight keystrokes as unhandled. This causes ash to try to process the keystroke as an accelerator, resulting in the new-tab command running twice. Instead, ack the key events as handled during focus change. Bug: 874098 Test: updated aura_unittests Change-Id: Idda91cbcc7f5d9ad328f7bfb7d6dc0367d85817d Reviewed-on: https://chromium-review.googlesource.com/1195085Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#588178}
-
Steven Zhu authored
. Add ExternalMediaMetadata to the external input source and state. . Add ExternalMediaMetadataChangeObserver for the external pipeline to report media state change. . Report external pipeline state to the Assistant Server via MediaParams. Design doc: internal http://go/voice-control-for-external-audio-pipeline Bug: internal b/80156336 Change-Id: I68ec11cc6fe4f368c34fe705c05a0f50ee9011cc Reviewed-on: https://chromium-review.googlesource.com/1192116Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#588177}
-
Peter Kotwicz authored
This CL changes the behavior of the splash icon for WebAPKs to match that of non-WebAPK homescreen shortcuts. The splash icon for non-WebAPK-homescreen-shortcuts is downsampled to 128x128dp by ManifestIconDownloader::OnIconFetched() The WebAPK Minting server generates a single WebAPK per start URL. That single WebAPK needs to work with all screen densities, thus the downsampling needs to occur on the client side. BUG=879255 Change-Id: I5822e1c8bf3cf02d7d3935989ae4d786cc9d9bb8 Reviewed-on: https://chromium-review.googlesource.com/1197623Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#588176}
-
Mitsuru Oshima authored
Normal task window shouldn't be in the system modal container, but can happen due to a bug in Android side. (ex. b/111767668) This is a safe guard not to show the frame even if it happens. Bug: 878426 Test: Covered by unittest Change-Id: Ib6344acf0ff9ec86b1e40238a8c8e60828948cee Reviewed-on: https://chromium-review.googlesource.com/1194287Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#588175}
-
Farah Charab authored
Change-Id: I64832492a8019a24a4420d1a2dfdd65d69b503ee Reviewed-on: https://chromium-review.googlesource.com/1199769Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#588174}
-
Brandon Wylie authored
Bug: 875088 Change-Id: I5c09daa610bba32c8be8b411e1a9e333697e64f9 Reviewed-on: https://chromium-review.googlesource.com/1196163 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#588173}
-
khmel@google.com authored
TEST=N/A BUG=879413 Change-Id: I6e55415d41e8833a972a29e92ae26882d5c94912 Reviewed-on: https://chromium-review.googlesource.com/1199859Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#588172}
-
James Wallace-Lee authored
WebDialogDelegate should mirror DialogDelegate and provide an implementation of WidgetDelegate::GetAccessibleWindowTitle. This also adds an accessible title to the Print dialog. Bug: 868179 Change-Id: I8e1c4b7262130b1a68f861bae9822ee191b0a06c Reviewed-on: https://chromium-review.googlesource.com/1187623 Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> Reviewed-by:
-
Jordy Greenblatt authored
For context, when a change occurs in the a phone to which the Chromebook is tethered, the MultiDevice tethering item is alerted and updates accordingly. The bug was caused by the fact that the default value for the deviceState property was null when there is an update and no phone is found. In particular, this is exactly the situation that occurs immediately following a successful request to forget the tethering phone. Because the network-summary-item (the element directly responsible for deplaying the tethering data) has an A11y string that depends on a property (i.e. deviceState.Type) of deviceState, this triggers the error described in the bug when the binding is updated. The solutions was simply to change the default value for deviceState on updates where no device is found from null to {Type: 'Tether', State: 'Disabled'} (this is the minimal definition satisfying the TypeDef so that the binding can update safely. Bug: 878972 Change-Id: I1850e5c613a935b2fade129a1466638756d4af13 Reviewed-on: https://chromium-review.googlesource.com/1197350Reviewed-by:Tommy Li <tommycli@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#588170}
-
Matthew Jones authored
This patch makes ContextualSearchObserver package protected since its use is specific to the feature itself. Bug: 878006 Change-Id: If2e2a660199baf4600caf28729e7b2af3f41d8a1 Reviewed-on: https://chromium-review.googlesource.com/1198005Reviewed-by:
-
Tatiana Buldina authored
Change-Id: Id6bb42a68175888f286f6529529039785cb0753e Reviewed-on: https://chromium-review.googlesource.com/1199608Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#588168}
-
Alexis Hetu authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/c47cd43..fe5861b BUG= TBR=kbr@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_cfi_rel_ng;luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I61552f908249afc978aa24f43714ed49ff953714 Reviewed-on: https://chromium-review.googlesource.com/1199935Reviewed-by:
Alexis Hétu <sugoi@chromium.org> Commit-Queue: Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#588167}
-
Xiangjun Zhang authored
This CL adds the implementation to open a new OffscreenTab to support OffscreenTab mirroring through the mirroring service. Bug: 734672 Change-Id: I560e39d74b0e1a147ffee2dfccf0b38ae8ed7fae Reviewed-on: https://chromium-review.googlesource.com/1195820 Commit-Queue: Xiangjun Zhang <xjz@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#588166}
-
Lakshman Annadorai authored
Bug: 755630 Change-Id: Ia5940e7be3821200a38a2405c2676ef37326bcf7 Reviewed-on: https://chromium-review.googlesource.com/1199485Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Lakshman Annadorai <lakshmana@chromium.org> Cr-Commit-Position: refs/heads/master@{#588165}
-
chcunningham authored
onNativeSignOut() triggers a call to signOut() -> nativeSignOut() Parts of signOut() are needed, but the call to nativeSignOut() should be avoided for flows that originated at the native side (native signout is already done). Change-Id: Ib205cfd61e94b49838e738b87c5cdb43b2d9f563 Bug: 873116 Reviewed-on: https://chromium-review.googlesource.com/1169462 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#588164}
-
Theresa authored
Remove padding from modern_toolbar_background and update/simplify the location bar layout logic to better match the UX spec. BUG=815343 Change-Id: I24e0239f3763c6c2fd7bd1f8c5f286ebf4f0b78c Reviewed-on: https://chromium-review.googlesource.com/1197902Reviewed-by:
-
Emircan Uysaler authored
This CL adds observable settings to MediaStreamTrack objects returned by getDisplayMedia() calls. These constrainable properties are set before the stream is returned based on user choice. Information about these settings are stored in DisplayMediaInformation struct. It is set in the low level device selection and then parsed by UserMediaProcessor before passing it to blink. Bug: 326740 Change-Id: I81d5f2eb24d2c1a37df0fbe2d34bc469fa575bf1 Reviewed-on: https://chromium-review.googlesource.com/1185875Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Weiyong Yao <braveyao@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#588162}
-
Owen Min authored
The API has been proposed by crbug.com/876800 Bug: 877238 Change-Id: Ic3ad7466d4bff95d8626e8339e13799545bf3f50 Reviewed-on: https://chromium-review.googlesource.com/1187514 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Georges Khalil <georgesak@chromium.org> Cr-Commit-Position: refs/heads/master@{#588161}
-
Bailey Forrest authored
Bug: None Test: le_scan_result_fuzzer Change-Id: I38a27cf7edfe1624a71f0a33850185c03312a299 Reviewed-on: https://chromium-review.googlesource.com/1189125Reviewed-by:
-
Kurt Horimoto authored
This allows for the optional disabling of the default LoadIfNecessary() behavior that previously occurred in TabModelWebUsageEnabledObserver. This can be used when restoring a large number of Tabs to prevent the creation of many WKWebViews at once. Bug: 864478 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ie80722aa178e260e6c6841de8e4cad8bb1e7ada4 Reviewed-on: https://chromium-review.googlesource.com/1148596 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#588159}
-
Kyle Horimoto authored
It should be required that users enter their password to enable SmartLock, since it is a security-sensitive feature. As a corollary, it should also be required that users enter their password to enable the Better Together suite if doing so would implicitly cause SmartLock to become enabled. Previously, entering a password was required for enabling the Better Together suite under any circumstances, but this was unnecessary, since no password should be required if SmartLock were turned off. This CL fixes this issue; additionally, it updates the authentication code here, which was previously not as robust. Bug: 876436, 824568 Change-Id: Ia61dd112675485972361a51b406482a0bb0a1f05 Reviewed-on: https://chromium-review.googlesource.com/1200148Reviewed-by:
-
Oksana Zhuravlova authored
Bug: 879248 Change-Id: Ib2ac501729e0376eb17dc467df5be849ebf416f5 TBR=mastiz@chromium.org Change-Id: Ib2ac501729e0376eb17dc467df5be849ebf416f5 Reviewed-on: https://chromium-review.googlesource.com/1199696 Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#588157}
-
Vaclav Brozek authored
The feature has been enabled in stable releases for a number of versions by now, hence the flag can be safely removed. Bug: 838789 Change-Id: I172df59564d881c8c7b6b5cad3b49d0971fc0251 Reviewed-on: https://chromium-review.googlesource.com/1195489 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Friedrich Horschig [CEST] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#588156}
-
chrome://discardsSigurdur Asgeirsson authored
Bug: 874968 Change-Id: I05a6fb88d7a013c7df74234f4ece03d53c275789 Reviewed-on: https://chromium-review.googlesource.com/1178236Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#588155}
-
Ted Meyer authored
Bug: 849379 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Iab509858f50280fb8e0ab2f2e71dadc5d5fcc6d5 Reviewed-on: https://chromium-review.googlesource.com/1173429Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#588154}
-
Miguel Casas authored
This CL cleans up a bit the jpeg_decode_accelerator_unittest file; singleton JpegDecodeAcceleratorTestEnvironment created a number of temporary files on SetUp() (via CreateTestJpegImage() method) that were removed on TearDown(). It also created by hand the content of TestImageFile objects. All this logic is moved to the struct TestImagefile (renamed to ParsedJpegImage), so that a) the struct is better defined in terms of what it holds and how is it initialized (CreateFromFile() and CreateBlackImage() are the factory methods), b) there's one place only to fill in its sizes (InitializeSizes()) and c) there's no need for temporary files written to disk and deleted. Also for good measure: - GetOriginalOrTestDataFilePath() is simplified and folded inline. - Couple of consts/constexprs here and there. - Initialize members in ctor initialization lists (ISO ctor body). Test: compile and run j_d_a_unittest on nautilus Bug: 877694 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ib2cb4ba218df84955757298e7d0cd85503ee1c98 Reviewed-on: https://chromium-review.googlesource.com/1197372 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#588153}
-
Yuwei Huang authored
Turns out I forgot to include the resize-to-fit feature in Android client's What's New text. This CL adds it back. Bug: 877704 Change-Id: I277c5e5eaefd3247769b7cdf17c84f95a8db0072 Reviewed-on: https://chromium-review.googlesource.com/1198565Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#588152}
-
braveyao authored
webrtc::ScreenCapturerMac requires to be started and destroyed on same thread. The current SequencedTaskRunner can't satisfy this and will cause random crashes. This cl is to use an exclusive capture thread as same as the one in content/browser/media/capture/desktop_capture_device.cc. Bug: 877982,851883 Change-Id: I6508add3660f63e1d2539dd2175a131f869a836a Reviewed-on: https://chromium-review.googlesource.com/1199806 Commit-Queue: Weiyong Yao <braveyao@chromium.org> Reviewed-by:
Julien Isorce <julien.isorce@chromium.org> Cr-Commit-Position: refs/heads/master@{#588151}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9951cbf4ca79..7bfe8438a94b git log 9951cbf4ca79..7bfe8438a94b --date=short --no-merges --format='%ad %ae %s' 2018-08-31 bsalomon@google.com Test glbetex and glbert configs on BonusConfigs bots 2018-08-31 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader 5fb5e817a20d..fe5861bf5bb1 (1 commits) 2018-08-31 stani@google.com Support more hardware buffer formats 2018-08-31 michaelludwig@google.com Fixes for primitive handling for uniforms 2018-08-31 jvanverth@google.com Simplify perspective shadows to match future MD specs. 2018-08-31 fmalita@chromium.org [skottie] Lazily-initialized default font manager 2018-08-31 benjaminwagner@google.com Unomit passing tests for Radeon. 2018-08-31 benjaminwagner@google.com Remove GTX1070 and GTX1050 jobs. 2018-08-31 bsalomon@google.com Fix GrAAConvexTessellator colinear point removal. 2018-08-31 benjaminwagner@google.com [infra] Add rack dimension for QuadroP400 tasks. 2018-08-31 benjaminwagner@google.com Unomit passing tests for Win Intel. 2018-08-31 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-31 brianosman@google.com Revert "Add support for gray + colorspace to SkCodec" Created with: gclient setdep -r src/third_party/skia@7bfe8438a94b The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:113555199,chromium:869172,chromium:784662 TBR=stephana@chromium.org Change-Id: I75ea11ce12a9a2eed101571b2adfde0c7c93ced8 Reviewed-on: https://chromium-review.googlesource.com/1199694Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588150}
-
Will Harris authored
This suppresses a number of warnings that will be enabled in the future. Remove unneeded extra warnings, as these are covered by a global config. ../../third_party/ots/src/prep.cc(25,20): warning: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long long') to 'uint32_t' (aka 'unsigned int') [-Wshorten-64-to-32] this->m_length = length; ~ ^~~~~~ ../../third_party/ots/src/fpgm.cc(24,18): warning: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long long') to 'uint32_t' (aka 'unsigned int') [-Wshorten-64-to-32] this->length = length; ~ ^~~~~~ ../../third_party/ots/src/post.cc(104,44): warning: implicit conversion loses integer precision: 'std::vector<std::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::basic_string<char, std::char_traits<char>, std::allocator<char> > > >::size_type' (aka 'unsigned long long') to 'const unsigned int' [-Wshorten-64-to-32] const unsigned num_strings = this->names.size(); ~~~~~~~~~~~ ~~~~~~~~~~~~^~~~~~ ../../third_party/ots/src/cvt.cc(28,18): warning: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long long') to 'uint32_t' (aka 'unsigned int') [-Wshorten-64-to-32] this->length = length; ~ ^~~~~~ ../../third_party/ots/src/cmap.cc(153,49): warning: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long long') to 'uint32_t' (aka 'unsigned int') [-Wshorten-64-to-32] ranges[i].id_range_offset_offset = subtable.offset(); ~ ~~~~~~~~~^~~~~~~~ ../../third_party/ots/src/cmap.cc(884,42): warning: implicit conversion loses integer precision: 'std::vector<ots::OpenTypeCMAPSubtableVSRecord, std::allocator<ots::OpenTypeCMAPSubtableVSRecord> >::size_type' (aka 'unsigned long long') to 'const unsigned int' [-Wshorten-64-to-32] const unsigned num_records = records.size(); ~~~~~~~~~~~ ~~~~~~~~^~~~~~ ../../third_party/ots/src/cmap.cc(886,30): warning: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long long') to 'uint32_t' (aka 'unsigned int') [-Wshorten-64-to-32] !out->WriteU32(this->subtable_0_5_14_length) || ~~~~~~~~ ~~~~~~^~~~~~~~~~~~~~~~~~~~~~ ../../third_party/ots/src/cmap.cc(901,44): warning: implicit conversion loses integer precision: 'std::vector<ots::OpenTypeCMAPSubtableVSRange, std::allocator<ots::OpenTypeCMAPSubtableVSRange> >::size_type' (aka 'unsigned long long') to 'const unsigned int' [-Wshorten-64-to-32] const unsigned num_ranges = ranges.size(); ~~~~~~~~~~ ~~~~~~~^~~~~~ ../../third_party/ots/src/cmap.cc(916,48): warning: implicit conversion loses integer precision: 'std::vector<ots::OpenTypeCMAPSubtableVSMapping, std::allocator<ots::OpenTypeCMAPSubtableVSMapping> >::size_type' (aka 'unsigned long long') to 'const unsigned int' [-Wshorten-64-to-32] const unsigned num_mappings = mappings.size(); ~~~~~~~~~~~~ ~~~~~~~~~^~~~~~ ../../third_party/ots/src/cmap.cc(963,40): warning: implicit conversion loses integer precision: 'std::vector<ots::OpenTypeCMAPSubtableRange, std::allocator<ots::OpenTypeCMAPSubtableRange> >::size_type' (aka 'unsigned long long') to 'const unsigned int' [-Wshorten-64-to-32] const unsigned num_groups = groups.size(); ~~~~~~~~~~ ~~~~~~~^~~~~~ ../../third_party/ots/src/cmap.cc(985,40): warning: implicit conversion loses integer precision: 'std::vector<ots::OpenTypeCMAPSubtableRange, std::allocator<ots::OpenTypeCMAPSubtableRange> >::size_type' (aka 'unsigned long long') to 'const unsigned int' [-Wshorten-64-to-32] const unsigned num_groups = groups.size(); ~~~~~~~~~~ ~~~~~~~^~~~~~ ../../third_party/ots/src/cff.cc(69,36): warning: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long long') to 'uint32_t' (aka 'unsigned int') [-Wshorten-64-to-32] index->offset_to_next = table->offset(); ~ ~~~~~~~^~~~~~~~ ../../third_party/ots/src/cff.cc(112,28): warning: implicit conversion loses integer precision: 'unsigned long long' to 'unsigned int' [-Wshorten-64-to-32] object_data_offset + (rel_offset - 1)); // less than length(), 1GB. ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~ ../../third_party/ots/src/ots.cc(545,23): warning: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long long') to 'Cr_z_uLongf' (aka 'unsigned long') [-Wshorten-64-to-32] uLongf dest_len = *table_length; ~~~~~~~~ ^~~~~~~~~~~~~ ../../third_party/ots/src/ots.cc(776,33): warning: implicit conversion loses integer precision: 'unsigned long long' to 'uint32_t' (aka 'unsigned int') [-Wshorten-64-to-32] out.length = end_offset - out.offset; ~ ~~~~~~~~~~~^~~~~~~~~~~~ ../../third_party/ots/src/ots.cc(793,21): warning: implicit conversion loses integer precision: 'const size_t' (aka 'const unsigned long long') to 'off_t' (aka 'long') [-Wshorten-64-to-32] if (!output->Seek(table_record_offset)) { ~~~~ ^~~~~~~~~~~~~~~~~~~ ../../third_party/ots/src/ots.cc(819,39): warning: implicit conversion loses integer precision: 'unsigned long long' to 'off_t' (aka 'long') [-Wshorten-64-to-32] if (!output->Seek(head_table_offset + 8)) { ~~~~ ~~~~~~~~~~~~~~~~~~^~~ ../../third_party/ots/src/ots.cc(826,21): warning: implicit conversion loses integer precision: 'const size_t' (aka 'const unsigned long long') to 'off_t' (aka 'long') [-Wshorten-64-to-32] if (!output->Seek(end_of_file)) { ~~~~ ^~~~~~~~~~~ BUG=879657 Change-Id: I7a69310b9672657f7373bdc79b6a4b4cb9181c12 Reviewed-on: https://chromium-review.googlesource.com/1199489 Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:Behdad Esfahbod <behdad@chromium.org> Cr-Commit-Position: refs/heads/master@{#588149}
-
sebsg authored
Remove the master toggle. Add sublabels for the profile and credit card toggles. Add row to inform users if an extention is managing the toggles. Change the title from "Addresses" to "Addresses and more". Bug: 860526, 877801 Change-Id: I2d0d156108667d9463263f4e490761a506bf9a13 Reviewed-on: https://chromium-review.googlesource.com/1196924 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#588148}
-
Matthew Jones authored
Contextual search's observer is unreliable for show/hide events of the feature. This patch replaces the use of that observer with an observer that watches any overlay panel and its visibility. Bug: 878006 Change-Id: I271b61504ca99ceebe308f7a65bdb4c06ee64cc7 Reviewed-on: https://chromium-review.googlesource.com/1197166 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
-
Marina Ciocea authored
When running audio service sandboxed on Mac, the audio process is a daemon process and should not connect to launchservicesd. Bug: 874785 Change-Id: I84ffe96fea85d3d54fb9b1cca1d441b5d6f085a1 Reviewed-on: https://chromium-review.googlesource.com/1194073Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#588146}
-
chrome://webrtc-logs/Elad Alon authored
Before this CL, chrome://webrtc-logs/ only displayed textual logs. After this CL, event logs are also displayed. Bug: 775415 Change-Id: Iadfaf6173b118edb11641736b566c96b346c376e Reviewed-on: https://chromium-review.googlesource.com/1189483 Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by:
Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#588145}
-
Christopher Cameron authored
Take the existing BridgedNativeWidgetHost and break it into two parts - a mojo interface views_bridge_mac::mojo::BridgedNativeWidgetHost - a helper and "stuff we haven't mojo-ified-yet" interface BridgedNativeWidgetHostHelper - this is not named BridgedNativeWidgetHost to avoid conflicts - this will be moved to //ui/views_bridge_mac soon (build is tangled) Add mojo support for ui::DialogButton, because it's used by this interface. For keyboard event handling, use the BridgedNativeWidgetHostHelper interface because a mojo-compatible interface would be hard for the callers to use. Bug: 859152 Change-Id: If6802ab4d6e518184cd3fa57eef5d8a510b80e59 Reviewed-on: https://chromium-review.googlesource.com/1198014Reviewed-by:
-
Antonio Gomes authored
TBR=dullweber@chromium.org (for tools/traffic_annotation/summary/annotations.xml) BUG=773295 Change-Id: Id47e63bd76376712ab8f0a8a68edd501d8db4227 Reviewed-on: https://chromium-review.googlesource.com/1197045 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Joe Downing <joedow@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#588143}
-
James Wallace-Lee authored
When a tab-modal dialog is shown, the page underneath it is inert. But NVDA reads the page underneath the dialog when users press Insert+B to read the whole dialog. To fix this, we hide the rest of the browser from the accessibility tree when a tab-modal dialog is visible by modifying AXPlatformNodeDelegate::PopulateChildWidgetVector to return only the dialog. Bug: 775680 Change-Id: I2a5ec2eeef5ffe50ebd8819836c89ae73ddfdd36 Reviewed-on: https://chromium-review.googlesource.com/1189054 Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#588142}
-
Xing Liu authored
This CL obseletes two expired histograms. And update the expired date for several others. These metrics are kept: Download.DeleteRetentionTime.Video, Android.DownloadManager.ViewRetentionTime.Video: This is recent work that PM may not have time to check the data yet. Download.ParallelDownloadAddStreamSuccess, Download.ParallelDownloadRequestCount: Still useful to monitor feature health. Bug: 876072,876070 Change-Id: Iab713f6dccf674556bd1d67d16b2f99bb3c29d5a Reviewed-on: https://chromium-review.googlesource.com/1199491Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#588141}
-
Ovidio Henriquez authored
This change adds validation checks to the USBDeviceFilter parameters passed into navigator.usb.requestDevice. Bug: 854703 Change-Id: I921a7f30a9e2ec5d46d3a74801de594565ab8a6f Reviewed-on: https://chromium-review.googlesource.com/1196034Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#588140}
-
