- 19 Oct, 2018 40 commits
-
-
Gabriel Charette authored
And fix CanIncreaseThreadPriority(REALTIME_AUDIO) to use the per-platform path. Bug: 816389 Change-Id: I15409a7e00f8ed0f132d348bb42c93e574a83f73 Reviewed-on: https://chromium-review.googlesource.com/c/1283021Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#601131}
-
Alexandr Ilin authored
The Mojo union more closely matches the actual intent of GpuMemoryBufferHandle, since the handle can store only one of several types of platform handles. GpuMemoryBufferHandle has |id| member that should be present all the time, so mojom::GpuMemoryBufferHandle remains a Mojo struct and the union is embedded into it. Bug: 863011 Change-Id: I5dc9100392cd0a6f701e93ac4c91ca50e5077967 Reviewed-on: https://chromium-review.googlesource.com/c/1288609 Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#601130}
-
Mihai Sardarescu authored
This CL adds information about token events in the chrome://signin-internals page. This is needed to allow developers to debug issues when the Google auth state if changed by the browser (either due to Mirror or Dice). A follow-up CL will add the source for the refresh token events. Bug: 896182 Change-Id: Ie70e3e647947aa771572ed47992e2d0c59bea361 Reviewed-on: https://chromium-review.googlesource.com/c/1286460 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#601129}
-
Anders Hartvoll Ruud authored
Currently we accept zero items, which is wrong. R=futhark@chromium.org Bug: 641877 Change-Id: I8acdc4c5c7ba54a71a478e7eed79223271e1e92d Reviewed-on: https://chromium-review.googlesource.com/c/1290889Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#601128}
-
Christian Dullweber authored
TouchSelectionControllerClientAndroidSiteIsolationTest.SelectionThenPinchInOOPIF is quite flaky. TBR: kenrb@chromium.org Bug: 897062 Change-Id: I7aae2557f42aa8bd1d54d194c6775cb25a03e995 Reviewed-on: https://chromium-review.googlesource.com/c/1290977Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#601127}
-
Mikel Astiz authored
They verify some otherwise-untested but privacy-sensitive requirements of what is being sent on the wire, where most (without custom passphrase) or all (with custom passphrase) proto fields should be encrypted. The actual verification is done using the state in the fake server, which is assumed to store committed content without pruning. This holds true today and is unlikely to change in the future. Bug: 856941,870624 Change-Id: I9198ca69c53d55a80f4b2a0c55cd5265e57741aa Reviewed-on: https://chromium-review.googlesource.com/c/1290809 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#601126}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f608aa22d174..a0b50a9a0590 git log f608aa22d174..a0b50a9a0590 --date=short --no-merges --format='%ad %ae %s' 2018-10-19 perezju@chromium.org [soundwave] Add module to get timeseries data for v8 study Created with: gclient setdep -r src/third_party/catapult@a0b50a9a0590 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:894773 TBR=sullivan@chromium.org Change-Id: If8e1f0cb20d29514f94113a444312891f2194f87 Reviewed-on: https://chromium-review.googlesource.com/c/1291149Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601125}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fa30285b915e..759a2673ff90 Created with: gclient setdep -r src-internal@759a2673ff90 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ied856a9be703a5b99df1d414d3defe8f5032b164 Reviewed-on: https://chromium-review.googlesource.com/c/1291050Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601124}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ea377862..d206a4b9 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I160e2f43613fb5edb80bcc8148fe789f0256804f Reviewed-on: https://chromium-review.googlesource.com/c/1291090Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601123}
-
Etienne Pierre-doray authored
This is a reland of 7a77c4e0 Death test should run in single thread. Adding testing::GTEST_FLAG(death_test_style) = "threadsafe"; before EXPECT_DCHECK_DEATH() to fix flakiness. Original change's description: > [Task Scheduler]: Merge blocking and non-blocking pools. > > This CL creates a feature experiment that removes blocking worker pools > from the task scheduler. Tasks with MayBlock trait are instead posted to > the usual foreground/background pool, giving us better control over scheduling. > > Note: ScopedBlockingCall is used to add extra workers to the pool when a task is > blocking. In this CL, we take advantage of this behavior to make sure enough > workers are running on the CPU. > > Bug: 874080 > Change-Id: I7889a941f82203388c259b0d96073eb5ddf3de69 > Reviewed-on: https://chromium-review.googlesource.com/c/1249836 > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Reviewed-by: Robert Kaplow (sloooow) <rkaplow@chromium.org> > Cr-Commit-Position: refs/heads/master@{#600401} TBR=rkaplow@chromium.org Bug: 874080 Change-Id: I54665c798d332eead0f81da0f15c93368ec883a8 Reviewed-on: https://chromium-review.googlesource.com/c/1290911 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2461c319ed08..82d432980cff git log 2461c319ed08..82d432980cff --date=short --no-merges --format='%ad %ae %s' 2018-10-19 nisse@webrtc.org Delete unused test class StreamSource Created with: gclient setdep -r src/third_party/webrtc@82d432980cff The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I37382d8385ad133ccccd6304b764978d1d76af05 Reviewed-on: https://chromium-review.googlesource.com/c/1290783Reviewed-by:
-
Caitlin Potter authored
https://github.com/tc39/ecma262/pull/1320 proposes changing the JS language so that the following: ``` let P = {}; Object.defineProperty('prop', { writable: false, value: 1 }); let O = { __proto__: P }; O.prop = 2; console.log(O.prop); ``` will print '2' (instead of '1' in sloppy mode, or throwing a TypeError in strict mode). We intend to measure the frequency of both cases to determine how web compatible the change will be. This is the Chromium side of required changes. The V8-side CL: https://crrev.com/c/1255549 BUG=v8:8175 Change-Id: If74e7aebcac01e034757c0c639bfb5518cd95c91 Reviewed-on: https://chromium-review.googlesource.com/c/1280618Reviewed-by:
Marja Hölttä <marja@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Caitlin Potter <caitp@igalia.com> Cr-Commit-Position: refs/heads/master@{#601120}
-
Xi Han authored
This is caused by not setting chrome channel before initializing FeatureList in early startup, which was introduced in CL (https://crbug.com/1173163). In this CL, we make GetChannel() call the SetChannel() if the channel hasn't been set yet. Bug: 896416 Change-Id: Id89c199779074d762f1d16edc711fedaaab66694 Reviewed-on: https://chromium-review.googlesource.com/c/1287850 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Robert Kaplow (sloooow) <rkaplow@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#601119}
-
Marc Treib authored
This removes one entry of the ServerConnectionCode enum which is unused, and removes an obsolete TODO. Bug: none Change-Id: I19a6653d30fc8f6c2bfd7d7d45c6a7a57f6f0473 Reviewed-on: https://chromium-review.googlesource.com/c/1290951Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#601118}
-
Tanja Gornak authored
Bug: 801985 Change-Id: I40d0f5819663cf2047344431bfd604cd5a89551f Reviewed-on: https://chromium-review.googlesource.com/c/1280462 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#601117}
-
Rune Lillesveen authored
Selectors in UA sheets are added case-sensitively to RuleSet buckets as if they were sheets in non-HTML documents in order to match correctly for xhtml and svg documents. That means we should not use the lower-case element name to lookup element rules as the lower-case of foreignObject would not find the foreignObject rules from the element bucket in the svg.css UA stylesheet. Bug: 819814 Change-Id: I2064f6669f6b7021feab2c93dd6b4d8a5c749b77 Reviewed-on: https://chromium-review.googlesource.com/c/1290849Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#601116}
-
Christian Dullweber authored
The test is flaky on windows bots. TBR: lazyboy@chromium.org Bug: 897059 Change-Id: I94deabc16016ffd723d1819ca5ef13b05ae150a1 Reviewed-on: https://chromium-review.googlesource.com/c/1290933Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/2f3bd7e85ec6..f608aa22d174 git log 2f3bd7e85ec6..f608aa22d174 --date=short --no-merges --format='%ad %ae %s' 2018-10-19 perezju@chromium.org [soundwave] Add dashboard_service module 2018-10-19 perezju@chromium.org [soundwave] Add timeseries --output-csv option Created with: gclient setdep -r src/third_party/catapult@f608aa22d174 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:890691,chromium:894773,chromium:879526 TBR=sullivan@chromium.org Change-Id: Ie326b24cd52919b8620f0907de755467ef428687 Reviewed-on: https://chromium-review.googlesource.com/c/1290784Reviewed-by:
-
Brian Osman authored
https://skia-review.googlesource.com/c/skia/+/160481 and https://skia-review.googlesource.com/c/skia/+/163520 Change-Id: Icade482f7a82fb4661f76486bc2c85af5abe7dfe Reviewed-on: https://chromium-review.googlesource.com/c/1288853 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by:
Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#601113}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0a5c62aa1bec..fa30285b915e Created with: gclient setdep -r src-internal@fa30285b915e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: If5893416ad3cb5ecaa18a4950e216079a89f31c7 Reviewed-on: https://chromium-review.googlesource.com/c/1290778Reviewed-by:
-
Marc Treib authored
It's unused - in practice, the value is queried through SyncClient::GetLocalSyncBackendFolder (which contains some extra logic). Bug: none Change-Id: Icc2dc605ea66ba86f6e6055c126739c37efbcb05 Reviewed-on: https://chromium-review.googlesource.com/c/1290275Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/80c79964c796..7a5d83bcb62f git log 80c79964c796..7a5d83bcb62f --date=short --no-merges --format='%ad %ae %s' 2018-10-18 fmayer@google.com profiling: Add heapprofd.rc. 2018-10-18 fmayer@google.com profiling: Add malloc hooks. Created with: gclient setdep -r src/third_party/perfetto@7a5d83bcb62f The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I1d8618dccb54f33d72d0439b60d28e278d5f58a1 Reviewed-on: https://chromium-review.googlesource.com/c/1290780Reviewed-by:
-
Gauthier Ambard authored
This CL converts the DataplanUsageCollectionViewController to UITableViewController. It also adds the cellBackgroundColor property to the styler so the cells can have a background color different from the table view's background. It also adds an accessoryType for the DetailTextItem. Bug: 894791 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ie1332811d3df6d8ef7650fb34fa3a17a515da3d9 Reviewed-on: https://chromium-review.googlesource.com/c/1286142 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#601109}
-
Mohamed Amir Yosef authored
This CL adds the support to convert GCMMessages to/from JSONObject In preparation for later patches that would actually persist GCMMessages in SharedPreferences as JSONObjects. GCMMessages are persisted for lazy FCM subscription that don't require immediate delivery if Chrome is not in the foreground. Bug: 882887 Change-Id: I674eae93262ee339c574b2f18da206785ebbadfb Reviewed-on: https://chromium-review.googlesource.com/c/1283609 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#601108}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/67ed0448..ea377862 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id35ec14911b0a29fa93f9ceb17245618542aa257 Reviewed-on: https://chromium-review.googlesource.com/c/1290779Reviewed-by:
-
Christian Dullweber authored
This reverts commit 7a77c4e0. Reason for revert: Findit identified that this introduced flakiness and it looks reasonable. Please take a look Original change's description: > [Task Scheduler]: Merge blocking and non-blocking pools. > > This CL creates a feature experiment that removes blocking worker pools > from the task scheduler. Tasks with MayBlock trait are instead posted to > the usual foreground/background pool, giving us better control over scheduling. > > Note: ScopedBlockingCall is used to add extra workers to the pool when a task is > blocking. In this CL, we take advantage of this behavior to make sure enough > workers are running on the CPU. > > Bug: 874080 > Change-Id: I7889a941f82203388c259b0d96073eb5ddf3de69 > Reviewed-on: https://chromium-review.googlesource.com/c/1249836 > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Reviewed-by: Robert Kaplow (sloooow) <rkaplow@chromium.org> > Cr-Commit-Position: refs/heads/master@{#600401} TBR=gab@chromium.org,fdoray@chromium.org,rkaplow@chromium.org,etiennep@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 874080, 897014 Change-Id: I5d125aba916dfb0dfce791b4d0a5b1ca5e6035d9 Reviewed-on: https://chromium-review.googlesource.com/c/1290152Reviewed-by:
-
Daniel Bratell authored
The target :make_core_generated_css_value_id_mappings was listed twice which made its output be twice in some sources lists. This confused some tools. Seems better to only have it there once. R=fs@opera.com Change-Id: I1da2cfbda7021fa5262d0c0a74b894989fc200de Reviewed-on: https://chromium-review.googlesource.com/c/1290929Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/237fb2a03b4b..2f3bd7e85ec6 git log 237fb2a03b4b..2f3bd7e85ec6 --date=short --no-merges --format='%ad %ae %s' 2018-10-19 perezju@chromium.org [soundwave] Refactor database connection management Created with: gclient setdep -r src/third_party/catapult@2f3bd7e85ec6 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:879526 TBR=sullivan@chromium.org Change-Id: I466a38fe2444294772f1634b0a50d45de102fdde Reviewed-on: https://chromium-review.googlesource.com/c/1290777Reviewed-by:
-
Gauthier Ambard authored
This CL creates a DetailTextItem for the TableView. This is a replacement for the SettingTextItem used in CollectionView. Here is a screenshot on the Table Cell Catalog, the cell with "Item with two labels" and "The second label..." https://drive.google.com/file/d/1cgTIs8h7mR8Ae8rnYSjvYZu9sMeqwxmX/view Bug: 894791 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Iab73928fca89131f326c7bbfc3c2bbb16fff5442 Reviewed-on: https://chromium-review.googlesource.com/c/1286141 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Etienne Pierre-doray authored
This CL uses ScopedBlockingCall to mark blocking calls in /content/browser/tracing. This CL was created by replacing calls to AssertBlockingAllowed() with instantiations of ScopedBlockingCall(MAY_BLOCK). I kindly ask the reviewer to make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation: MAY_BLOCK: The call might block (e.g. file I/O that might hit in memory cache). WILL_BLOCK: The call will definitely block (e.g. cache already checked and now pinging server synchronously). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). This CL was uploaded by git cl split. R=simonhatch@chromium.org Bug: 874080 Change-Id: I947898f0650e7a14a3133a4114c7fc30f326dedc Reviewed-on: https://chromium-review.googlesource.com/c/1191806 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#601102}
-
Jérôme Lebel authored
When the user refuse to sign-in with a managed account the current UnifiedConsentCoordinator should be reused instead of creating a new UnifiedConsentCoordinator instance. Bug: 872288 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ib851ba3337fa95a39608397f82e336b65000f579 Reviewed-on: https://chromium-review.googlesource.com/c/1288435Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#601101}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I890421bde5ace59508d35b9435fe5699d4690fa0 Reviewed-on: https://chromium-review.googlesource.com/c/1290782Reviewed-by:
-
Fredrik Söderquist authored
This moves code for transforming a HitTestLocation using with an AffineTransform from the helper function SVGLayoutSupport::TransformToUserSpaceAndCheckClipping into a helper class TransformedHitTestLocation. Calls to SVGLayoutSupport::IntersectsClipPath are hoisted into callers and SVGLayoutSupport::TransformToUserSpaceAndCheckClipping is removed. Change-Id: I52f95ba2480df86a509285c2ec2edea776517bc6 Reviewed-on: https://chromium-review.googlesource.com/c/1282930Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#601099}
-
Christian Dullweber authored
This reverts commit 8bd7e583. Reason for revert: Still flaky :( https://ci.chromium.org/p/chromium/builders/luci.chromium.try/mac_chromium_rel_ng/166516 Original change's description: > Reenable GPUProcessCrashesExactlyOncePerVisitToAboutGpuCrash > > This was flaky, but should be fixed. > > Bug: 878258 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: I3e037e41339ddff9d46ec0a7ca7679064a3322e0 > Reviewed-on: https://chromium-review.googlesource.com/c/1285526 > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: enne <enne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#600813} TBR=kbr@chromium.org,enne@chromium.org Change-Id: I0dd172bd7db86982f9b1bf49e2a57c059958d348 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 878258 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/1290950Reviewed-by:
-
Jérôme Lebel authored
Adding -UnifiedConsentCoordinator.identitySelectedByUser to track when the user selects an identity. This is to make sure the identity chooser dialog is opened automatically only when the user didn't select an identity yet. Bug: 896709 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ib849ac7d385910398f62bf7e7e933f79983e3691 Reviewed-on: https://chromium-review.googlesource.com/c/1288790Reviewed-by:
-
Yoshifumi Inoue authored
This patch renames |ContainsOnlyASCII()| to |ContainsOnlyASCIIOrEmpty()| as consistency with the patch[1] for improving readability. Note: All renaming is done by global replace tool. This patch similar to the patch[2] which renames |ContainsOnlyLatin1()|. [1] http://crrev.com/c/1288157 Rename ContainsOnlyWhitespace() to ContainsOnlyWhitespaceOrEmpty() [2] http://crrev.com/c/1288501 Rename ContainsOnlyLatin1() to ContainsOnlyLatin1OrEmpty() Change-Id: I666c4e3a6c74d59ab8cd6b74bdf011c0e06d0b0c Reviewed-on: https://chromium-review.googlesource.com/c/1288502 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#601096}
-
Amos Lim authored
Generated header files need to follow chromium style on header guards. Update bindings/tests/results files with run_bindings_tests. third_party/blink/tools/run_bindings_tests.py --reset-results This CL has no behavior changes. Bug: 896720 Change-Id: I76a467e088a9ac004a0b33a9661e25158cb670ac Reviewed-on: https://chromium-review.googlesource.com/c/1288167Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Amos Lim <eui-sang.lim@samsung.com> Cr-Commit-Position: refs/heads/master@{#601095}
-
David 'Digit' Turner authored
This CL slightly reduces the size of libchrome.so by removing the SysV symbol hash tables from them (only the GNU ones, which are now supported by the crazy linker [1], will be included). Note that this is not needed for libmonochrome.so which already does that. + Only use one SysV format table for libchromium_android_linker.so since it is always loaded by the system linker, on platforms that do not support the GNU format. This saves 445 bytes in ChromePublic.apk (woohoo!). [1] https://chromium-review.googlesource.com/c/chromium/src/+/1216122 BUG=851391 R=agrieve@chromium.org, pasko@chromium.org, rmcilroy@chromium.org, cjgrant@chromium.org Change-Id: I9ed7901312a25cda3b77440c32a1a2645e14beca Reviewed-on: https://chromium-review.googlesource.com/c/1254441 Commit-Queue: David Turner <digit@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#601094}
-
Mario Sanchez Prada authored
This includes migrating away of SigninManagerBase::Observer as well as from OAuth2TokenService::Observer, as all APIs in use are now available via IdentityManager::Observer. Bug: 887455 Change-Id: Ia21ae43e5c6a2554e837760485688f917dea1ad8 Reviewed-on: https://chromium-review.googlesource.com/c/1288277Reviewed-by:
-
Mirko Bonadei authored
First step in a series of small CLs to try to remove old dependencies and build targets that are not used anymore. Bug: 896154 Change-Id: Id3343e73b182c7468e9da2f68bdd7986b29e3987 Reviewed-on: https://chromium-review.googlesource.com/c/1286859Reviewed-by:
Henrik Grunell <grunell@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#601092}
-
