- 12 Jun, 2020 40 commits
-
-
Jorge Lucangeli Obes authored
The relevant codepath hasn't been used since ~2014 (!!!) and the reporting code was removed in crrev.com/c/1183895. BUG=chromium:1088699 TEST=validate_format, pretty_print. Change-Id: Ifcc98ce794a9def469b1bb29e66955145e93a8ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243533 Auto-Submit: Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#778005}
-
Tina Wang authored
Change the UI to managed when the pref is managed by policy. Screenshots: https://screenshot.googleplex.com/5YeV4SPvq1i https://screenshot.googleplex.com/BJwV90Tv3uB Bug: 1093167 Change-Id: I10bd1ddead11e129ad9762a5d75e7cb0ab4e3012 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239526 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#778004}
-
Xing Liu authored
This CL implements the download later flow logic in DownloadDialogBridge. Bug: 1078454 Change-Id: I1a0e6470a81ebda2add4a069addf21258c67c83c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240544 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#778003}
-
Ken Rockot authored
This introduces a new --mojo-core-library-path Content switch which instructs Content to initialize each process with an implementation of Mojo Core found in the referenced shared library rather than using the version linked into the main binary. This allows for IPC interoperability between a Content embedder and another application which provides its own copy of Mojo Core. Fixed: 1082473 Change-Id: I1e50c505e91a53e60056a4b8c691d91728f7a5ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229664Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#778002}
-
Jon Mann authored
This reverts commit 9398a65f. Reason for revert: no longer needed Original change's description: > Wi-Fi Sync: Add strings for feature announcement notification. > > Adding strings separately from implementation to give more time for > translation. > > Bug: 966270 > Change-Id: I110e960a802d5020c42ed7b65993399cef158bf9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243585 > Commit-Queue: Jon Mann <jonmann@chromium.org> > Reviewed-by: James Vecore <vecore@google.com> > Cr-Commit-Position: refs/heads/master@{#777992} TBR=jonmann@chromium.org,vecore@google.com Change-Id: I3aab30f8731c1f1cada280e2b7482a1dab38f9d9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 966270 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244043Reviewed-by:
Jon Mann <jonmann@chromium.org> Commit-Queue: Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#778001}
-
Dave Tapuska authored
This definition will eventually replace the content::TextInputState definition and will be sent directly from blink. Add additional typemaps for action and mode. BUG=1073560 Change-Id: Ia90592e1c8cf347053485ac6e0cf0cbc503aed4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240250Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#778000}
-
Ben Pastene authored
The Chrome OS chroot builds Chrome within a symlink'ed out dir. These relative paths don't play nicely with the symlink path and cause errors in //third_party/polymer/v3_0/components-chromium when compiling. Removing parent dirs from the paths fixes the errors, and somehow js_binary.py still appears to pick up the right path to //third_party/polymer/v3_0/components-chromium. Bug: 1093048 Change-Id: I9d4039d9022ac4d0f4767e2ab09496bee8f24823 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242193 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#777999}
-
Tina Wang authored
Change the UI to managed when the pref is managed by policy. Screenshots: https://screenshot.googleplex.com/9EdXBpco5JJ https://screenshot.googleplex.com/ksvxJXWjKMO Bug: 1093168 Change-Id: I581d6a24d3fb1320bf158e4620815bf706f7bce6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242180 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
-
Maxime Charland authored
Some messages in ios_google_chrome_strings had a name that was no longer referenced in code after a refactor of QR Scanner related classes. Also, both ios_chromium_strings and ios_google_chrome_strings were not sorted alphabetically, which caused confusion when trying to add new messages. This CL is fixing those two problems. Change-Id: I9cfc6bbaaaa812e6c45b0b472d8b1d48179f685a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239674Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Maxime Charland <mcharland@google.com> Cr-Commit-Position: refs/heads/master@{#777997}
-
Tibor Goldschwendt authored
Logs - NewTabPage.VoiceActions - NewTabPage.VoiceErrors on chrome://new-tab-page. Fixed: 1072882 Change-Id: I1d2b6fd42c1a76d1adf2855b0f5e3743c9fdf217 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241464 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#777996}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/922267825036..b919b0064c92 2020-06-12 wuwang@google.com Add instruction to update DEPS after upload file to CIPD. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1060399 Tbr: skyostil@google.com Change-Id: I79a92f764498ac404f9dc3e1a1884c0d633de91f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243447Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#777995}
-
Brian Liu Xu authored
Hides tooltips when windows are hidden or minimized on Windows. Previously, when a browser window was minimized by the OS, tooltips would stay open on top of other windows because they did not receive an event that the mouse left the window. This was due to a race condition between the minimize message and the WM_MOUSELEAVE message. Since Aura first receives the minimize message and makes the Aura window not "visible", the subsequent mouse exit event was thus rejected by the Aura window. Consequently, tooltips would stick around indefinitely until the window was restored and interacted with. To fix this, we make the tooltip controller respond to the WM_WINDOWPOSCHANGED message (which is also sent to us when the window is minimizing) by explicitly hiding the tooltip. Bug: 724538 Change-Id: I9e8a60e6de943230708b12f3a05b8ee03c27e54a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241631Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Brian Liu Xu <brx@microsoft.com> Cr-Commit-Position: refs/heads/master@{#777994}
-
Marc Treib authored
This CL introduces histograms PasswordManager.AccountStoreVsProfileStore.[Additional|Missing|Identical|Conflicting] that record the relative state of the account-scoped store vs. the profile-scoped store: How many credentialss are in the account store but not the profile store and vice versa, and how many identical and conflicting ones are there. Bug: 1063852 Change-Id: Idb6bdb82ca6423d224602be81f19235919e33713 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218277 Auto-Submit: Marc Treib <treib@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#777993}
-
Jon Mann authored
Adding strings separately from implementation to give more time for translation. Bug: 966270 Change-Id: I110e960a802d5020c42ed7b65993399cef158bf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243585 Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#777992}
-
John Delaney authored
It is currently possible for tasks to be posted to ConversionStorageSql that run on a database which failed to initialize correctly. This can occur when impressions/conversions are received prior to database setup completing. This adds a checks to all methods called externally that return early if the database is not in a working state. Bug: 1088072 Change-Id: I3f657b40dc29ecf8246b6df2b356e6d16ad11e6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235875Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#777991}
-
Anastasia Helfinstein authored
Clean up from the effort to migrate the Switch Access menu from a web-based implementation (sharing infrastructure with the ChromeVox panel) to a native views-based bubble. AX-Relnotes: n/a. Bug: 948386,1088528 Change-Id: I2f47c7e229f6042f98caf78f631b2b2b9c73198a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232836Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
-
Antonio Gomes authored
.... instead of WebMediaStreamTrack. This is part of the effort to reduce the needless use of public Blink APIs (wrappers) within renderer/modules. BUG=704136 R=guidou@chromium.org Change-Id: I5a6e683283b9a57f642a09d0f06410d2fde95690 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239973 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#777989}
-
Sinan Sahin authored
We check if the offsets are different from the previous ones in to update the prev_*_min_height_offset_pix values. This probably won't make any difference for now since the min-height offset changes are currently accompanied by offset changes. RenderWidgetHostViewAndroid: :UpdateControls(). However, I've forgotten Change-Id: I57c64c1bfcffa324b2384fad90db210bbec9db4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244012Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#777988}
-
Manuel Rego Casasnovas authored
BUG=1078401 TEST=CompositedLayerMappingTest.TransformedRasterizationForBackfaceVisibilityHidden Change-Id: I3ae4a581d247537d1211ebbc4688c6c8e1056a06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238926 Commit-Queue: Manuel Rego <rego@igalia.com> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#777987}
-
rajendrant authored
Bug: 1053696 Change-Id: I5888a658babb384833873b1ef54e5c9466af10e0 TBR: robertogden@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244193Reviewed-by:
rajendrant <rajendrant@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#777986}
-
James Cook authored
This reverts commit 29ca85f8. Reason for revert: Seems to cause flaky analyzer step failures on https://ci.chromium.org/p/chromium/builders/try/chromeos-amd64-generic-rel Example: https://ci.chromium.org/p/chromium/builders/try/chromeos-amd64-generic-rel/568950 Exception: Failed to open ../../out/Release/gen/chrome/browser/resources/chromeos/bluetooth_pairing_dialog/vulcanized.html while trying to flatten ../../out/Release/gen/chrome/browser/resources/chromeos/bluetooth_pairing_dialog/vulcanized.html. (No such file or directory) Original change's description: > [CrOS settings] Add bluetooth_pairing_dialog resource files > > Split bluetooth_pairing_dialog resources into > bluetooth_pairing_dialog_resources.grd > and bluetooth_pairing_dialog_resources_vulcanized.grd > > Bug: 1090882 > Change-Id: I0d9855aaaf21db900f27f92b7b38d7ab1daac18a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239147 > Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#777891} TBR=sky@chromium.org,khorimoto@chromium.org,tjohnsonkanu@google.com Change-Id: I4af97b356a782dcb6cb88472d8528c54350e9871 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1090882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243855Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#777985}
-
Dominic Mazzoni authored
Without this, they won't appear in the dashboard. Bug: 992074 Change-Id: I1792d7b2a2b1bb280fb5deef319cdc2ff46bafd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242116Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#777984}
-
sczs authored
Check Bug for more context. Bug: 1094467 Change-Id: I8e1182e83b7c0e52a05196c2821f0e33bf953c6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243732 Commit-Queue: Sergio Collazos <sczs@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#777983}
-
Vincent Boisselle authored
When using the feed header menu mSectionHeader.toggleHeader() has side effects needed by the subsequent steps to set the SectionHeader data model before updating the SectionHeaderView through updateVisuals(). Bug: 1094437 Change-Id: Id539e2f060398cde9b8319bf6d791e032202a723 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243601 Commit-Queue: Vincent Boisselle <vincb@google.com> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#777982}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I48373df609cd406f0282751e10dcf981d5879853 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242744Reviewed-by:
-
Jia authored
This is following an accessibility and UI review request. Bug: 1068851 Change-Id: I64d35e3f2254f5a597d2d67a579cc323a7c57ee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241363Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#777980}
-
Anastasia Helfinstein authored
Per the request of UI review, changing the back button for the Switch Access action menu to be a close button instead. Screenshot of the updated UI: https://screenshot.googleplex.com/pdygC1X43na AX-Relnotes: n/a. Bug: 1094415 Change-Id: I066ea888d9bf092a8fdd84846658cedfc4a9288a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243581Reviewed-by:
-
Moe Ahmadi authored
Change-Id: Iaa3a5b3a452e67aab6af4eccb4b1a4ce4f5335e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242746 Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#777978}
-
Sinan Sahin authored
Since we started caching the animations to clean-up on destroy, we've been keeping the Animator instances once they're created. This ignores the colors passed in #show and #updateContent, also keeps using an old status bar color. The fix is to simply remove the if null checks to create the Animators. Bug: 1094373 Change-Id: Ibf6de0c66626f3a9fe7f58214d765d18696530f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243493Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#777977}
-
Lei Zhang authored
HandleMessage() has gotten a bit too big. Move many message handlers into their own methods. Change-Id: Icc117a1056fdebe839b26defe3481b5416f0e014 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242587Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#777976}
-
Garrett Beaty authored
The current state of the main console does not match what is desired by the sheriffs and will need to be updated, so these consoles provide an overview of the CI builders that can affect the health of the CQ like the main consoles currently do. Change-Id: If04339aa0a74a16bf566367d2d0cc355c8c2aef0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242192 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#777975}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/5c9f7af77d0e..1663b1d04df9 2020-06-12 brandon1.jones@intel.com Make D3D12 Fuzzer Only Build On Windows 2020-06-12 yunchao.he@intel.com Vulkan: use one barrier if we can for non-pass operations 2020-06-12 cwallez@chromium.org Don't store unnessary SubresourceRange members in TextureBase If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ic3ebea7906a8678c7b333c07c7aa8c2fae84a7e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243458 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Ilia Samsonov authored
Bug: 1068400 Change-Id: I874464a4548fb6be0dc2a9fca265f89eafb2d105 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243492Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#777973}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/660b9dfbe395..80d38188db27 2020-06-12 brgoddar@microsoft.com Grid: Add settings for grid highlight config behind experiment If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1047356 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If7f00ec51cca97e041c502f9764a1e52002367a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241297Reviewed-by:
-
Garrett Beaty authored
Further adjustments may be required once branch sheriff responsibilities are clarified and a more maintainable solution can be crafted. Change-Id: I30df4e95e9d57c6b330f4d75af0e31c35500efa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243712 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#777971}
-
Hazem Ashmawy authored
Crash keys can be absent (null) in some cases like if it's a crash from an old version. Switch statements in java assume non-null values which causes NPE when checking for channel info on old crashes. To avoid this , we will use getCrashKeyOrDefault method. In addition, always show crashes if they are from UNKOWN/DEFAULT channel to avoid hiding crashes from older versions. Fixed: 1093898 Test: Build default channel, trigger a crash. Test: Manually remove channel info from log file and open the crash UI Change-Id: I1a445d59a267cb7f41b400b36caa7bf7a31296e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243291 Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#777970}
-
Jun Kokatsu authored
This change groups tests of Trusted Types for WebUI into 10 WebUI pages per test to minimize the size of the file. This change also fixes a bug where `CallJavascriptFunction` might be called before allowing JS. See: crrev.com/c/2242372 Bug: 41905 Change-Id: I5f28e056ca3bcb3f39678e2b6009e66316848322 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242656Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1591977558-7170645d7cf66fa796ff151165a33077272cf120.profdata to chrome-mac-master-1591991989-bc016108b2b5e29558a9e9ceecfec9b523f83fb2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I096c4097a7e99739babf900e02b35d607304372e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243467Reviewed-by:
-
Sahel Sharify authored
This cl sends the merchant provided updated payment details (in response to a change event) to the invoked native payment app. Change[PaymentMethod|ShippingAddress|ShippingOptions] calls with invalid arguments are responded immediately with a blank bundle only containing the error message. Bug: 1026667 Change-Id: I458120ecaf328140bd711c8e26e41978c71fe9cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240048Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Auto-Submit: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#777967}
-
Peng Huang authored
Bug: None Change-Id: I89d721e8dc5f1ad322ba1ecea0b45c0e4b97d5f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242040 Commit-Queue: Peng Huang <penghuang@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#777966}
-
