- 28 Oct, 2020 40 commits
-
-
Martin Kreichgauer authored
Make AuthTokenRequester not invoke its Delegate's PromptInternalUVRetry() method the first time it calls GetUvToken() and awaits a user interaction. Fixed: 1142969 Change-Id: I38ce9ebd35a968c7346ce0cecd6a3109a0b6fb34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504598 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#821883}
-
Anders Hartvoll Ruud authored
I want to try and remove the dynamic specificity calculation altogether. After this, it's only used by :host and :host-context. Also, we currently return kClassLikeSpecificity for pseudo-elements (for some reason), so use this for ::slotted as well. Even though it's not observable for authors, it makes things somewhat consistent internally at least. Test: external/wpt/css/css-scoping/slotted-specificity.html Change-Id: Ie64144dfca7439cb02ee839d33c53a409e3cc523 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505751Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#821882}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b28ec889c239..a4e218211286 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC takumif@google.com,nicolaso@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1141619,chromium:912681 Tbr: takumif@google.com,nicolaso@google.com Change-Id: Ie44b1cca8ba9ab062561df6f5d5f1d826311a8d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506252Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821881}
-
dpapad authored
In order to optimize the initial load time of the NTP, move non-essential UI elements to a "lazy" loaded module. This significantly reduces the amount of code that needs to load before the initial paint. Specifically: Before: 312K new_tab_page.rollup.js After: 97K new_tab_page.rollup.js 97K shared.rollup.js 122K lazy_load.rollup.js which means that there is a ~38% reduction (312 -> 97 + 97 = 194K), in the size of the code that is loaded on startup. Bug: None Change-Id: I8f9d0e41047538015f3c41cac0ac3ba5fb1fffdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425330 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#821880}
-
Mei Liang authored
Change-Id: Id164d3564d3fec41d3c1014d9282e5989b33f8b3 Bug: 1108496 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491444 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#821879}
-
Avi Drissman authored
-[AppControllerMac lastProfile] can return null; check for that. Bug: 1143001 Change-Id: I89abfd6171c12d6fceab982fb2d895137a6a0bde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505605 Commit-Queue: Avi Drissman <avi@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#821878}
-
Stephen McGruer authored
Bug: None Change-Id: I35d4c865e69968d53ceb73d248ca1bbdf952a288 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506112 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#821877}
-
Peter Kotwicz authored
This CL changes the current working directory to the chromium src root prior to running 'gn format'. This CL also changes the exception thrown by NormalizeAndroidDepsDir() to reference --android-deps-dir (instead of the non-existent --android-deps-path) BUG=1064277 Change-Id: Ia70b3c13d032027254a753e1297044055c1d61f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506079 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#821876}
-
Alexei Svitkine authored
Updates expand_owners_unittest.py to work even if the checkout does not begin with a 'chromium' dir. Note: This does not fix the issue that makes this test fail on bots yet and so doesn't re-add it to the list of tests ran by metrics_python_tests.py. This is a slightly different issue, where on bots, there isn't even a 'src' directory, which trips up other assumptions in the test. Bug: 1126653 Change-Id: I0f345f3efa3a54b4f7ba08106fd6d08ffbc5345b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505573 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#821875}
-
Oystein Eftevaag authored
Fix the allowlist used by the old filtering system to allow the newly added strongly typed trace events, and re-add entries removed accidentally. R=ssid@chromium.org Change-Id: I80ba44a19ed7f0be55650d16f325fc6377bcc42d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505626Reviewed-by:
ssid <ssid@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#821874}
-
Caleb Raitto authored
Bug: 973801 Change-Id: Ia1b993bbbde328442bf041c25de912f14be06d0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485677 Commit-Queue: Caleb Raitto <caraitto@chromium.org> Reviewed-by:
Florent Castelli <orphis@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#821873}
-
Jon Mann authored
Bug: 1129137 Change-Id: I00e33d76d9fd677ca47095c80230287d6d16c983 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505959 Auto-Submit: Jon Mann <jonmann@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Commit-Queue: Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#821872}
-
Peng Huang authored
Bug: 1143042 Change-Id: I70e3c4757e7f1e48a0df30495bffc99b2a9336f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505675 Commit-Queue: Peng Huang <penghuang@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#821871}
-
danakj authored
R=gab@chromium.org Bug: 1140582 Change-Id: I214c5b4e4f4b2ccd145027316cdd58feeb220481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505465Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#821870}
-
Henrique Nakashima authored
This option makes the script ignore dependencies from and to other classes being audited in the same run, which is useful when moving a group of classes to a module as part of the same refactoring effort (which is the primary use case for the script). Change-Id: I82c8b41ccd380c6fc50b1baab6a99e3680ab74f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504195Reviewed-by:
-
Sven Zheng authored
Currently, if a pixel test is flaky(failing->passing) on CQ, Skia Gold will send out a gerrit comment about test failure. We don't want that since the test finally passed. The comment should only get sent out when the test is deterministic failure. But on Skia Gold side, there's no way to know how many retry we have. To resolve this, we need the test to know if this is the last retry. If it is and the test is failing, the test can tell Gold to send out gerrit comment. Bug: 1139468 Change-Id: I68f9f47afc444227b285d6eae14c96854c79b62c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486391Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#821868}
-
Lucas Radaelli authored
Nodes that are scrollable containers contain scroll offset data. This change fills these offsets when converting to a Fuchsia node. Test: AXTreeConverterTest.* Bug: fuchsia:60263 Change-Id: Ie0a16e7f326cb0f37097fca9f22dfe11c24d27b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490250 Commit-Queue: Lucas Radaelli <lucasradaelli@google.com> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Sharon Yang <yangsharon@chromium.org> Cr-Commit-Position: refs/heads/master@{#821867}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/dfa44daef92d..e8dff372902f 2020-10-28 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I3f526ec283a697b38f3a13e0d71d4bb2d6ee04e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506094Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821866}
-
Jesse Schettler authored
Update the Letter page size dimensions to be more precise instead of rounding to the nearest integer. Also, add in some margin when determining whether a scan area can support a page size in case there are slight differences due to rounding. Bug: 171813619 Change-Id: Ie82e8cd28c94540b909884f6f7e89789769bbe22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504549 Auto-Submit: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#821865}
-
Sophey Dong authored
This is a reland of 6769a912 This caches the SHARE_BY_DEFAULT_IN_CCT flag, which should prevent JNI not enabled crashes. Original change's description: > [ShareCCT] Implement sharing in the toolbar and by default in CCT. > > Bug: 1135311 > Change-Id: I967300591d383a21b9f3f40233422b763180ddb0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459403 > Reviewed-by: Tanya Gupta <tgupta@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Peter Conn <peconn@chromium.org> > Commit-Queue: Sophey Dong <sophey@chromium.org> > Cr-Commit-Position: refs/heads/master@{#820029} Bug: 1135311 Change-Id: I46e7b10e56f092e6fcec5c07b1610dfd71649ca5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501189Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Sophey Dong <sophey@chromium.org> Cr-Commit-Position: refs/heads/master@{#821864}
-
Ben Pastene authored
This uses //build/android's result_sink.py to upload Tast results to RDB. It attaches any file artifact for a given test that Tast produces. Bug: 1129654 Change-Id: I8f00cbe5b03521d7875d66c062d5832be80caa6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504493Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/15b2c074595f..aba52f78e1ba 2020-10-28 chrome-bot@chromium.org Update config settings by config-updater. 2020-10-28 ahassani@chromium.org paygen: Make more lenient on App ID changes 2020-10-27 chrome-bot@chromium.org Update config settings by config-updater. 2020-10-27 chrome-bot@chromium.org Update config settings by config-updater. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: Iba507168af1058d5a873fbce88d80cff1230128a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503902Reviewed-by:
-
Ian Kilpatrick authored
Within NGSimplifiedLayoutAlgorithm we weren't copying across all the necessary fields in order for it to work correctly. This change copies these fields, and adds the necessary DCHECKs to ensure it is working correctly. Bug: 958381 Change-Id: I116fcff94adb7523841cf2d4ed1601fbb1fdcfd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503843 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#821861}
-
Mohamed Amir Yosef authored
... to match the new behaviour of the method. This is purely mechanical change. TBR=karandeepb@chromium.org,stevenjb@chromium.org Bug: 1139263 Change-Id: I6dc4b4f06af0688be8b1140d052faebbdc7fad6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505831Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#821860}
-
Xing Liu authored
The Chime DFM is built with two classes in chromium upstream and clank downstream that directly implement the ChimeModuleEntry auto generated interface. This creates an issue that we can't add new method to the interface. It also causes the revert of: https://chromium-review.googlesource.com/c/chromium/src/+/2487816 This CL introduces an empty base class that implements ChimeModuleEntry. So downstream can extend the base class to avoid compiling failure. This approach is similar to AppHooks.java. Downstream impl class will extend this new base class soon. Bug: 1136305 Change-Id: I5c028f0fd95a04904adc8cadbbc9c5dbb1083c04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500251Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#821859}
-
Trevor Perrier authored
This CL aims to fix a bug with native resources not loading after a locale override. Currently, when an override language split is downloaded and applied only Java resources load until Play Store daily hygiene runs and moves the language split apks to `/data/app/` from `/data/data`. To make resources available on a context SplitCompat.installActivity should be called. This CL calls SplitCompat.installActivity on the global application context ContextUtils. This context is used to load native resources in ResourceBundle.getLocalePakResourcePath. Bug: 1143026 Change-Id: I6cb05d2d3d45fe8aef9b0dfc8e193e00147d7e78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503621 Commit-Queue: Trevor Perrier <perrier@chromium.org> Reviewed-by:
-
Trent Begin authored
This adds a skeleton SWA that will be used to replace the current connectivity diagnostics Chrome app with a WebUI based app. This SWA is gated behind a feature flag to hide it during development. Bug: chromium:1140611 Change-Id: I52ffd2c21538a26d770b6344d3b6fe4f8a4fec5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490504Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Trent Begin <tbegin@chromium.org> Cr-Commit-Position: refs/heads/master@{#821857}
-
arthursonzogni authored
Those DumpWithoutCrashing have been removed twice. A few potential issue have been solved recently: - [ignore-csp-sandbox-report-only] - [sandbox-vs-mhtml] - [non-optional-frame-policy] This patch adds them again. I would like to know if they would still be triggered into the wild. ------- [ignore-csp-sandbox-report-only]: https://chromium-review.googlesource.com/c/chromium/src/+/2498605 [sandbox-vs-mhtml]: https://docs.google.com/document/d/13jcj_mATRxKakPEGy72YYHZBTBkkNrAHzaNIIjVsC8I https://chromium-review.googlesource.com/c/chromium/src/+/2450270 https://chromium-review.googlesource.com/c/chromium/src/+/2467917 https://chromium-review.googlesource.com/c/chromium/src/+/2480083 https://chromium-review.googlesource.com/c/chromium/src/+/2479365 https://chromium-review.googlesource.com/c/chromium/src/+/2467917 [non-optional-frame-policy]: https://chromium-review.googlesource.com/c/chromium/src/+/2460890 Bug: chromium:1041376 Change-Id: Ie503453ed163b01643a90122b61fa2567ec7660f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502930 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#821856}
-
Frank Tang authored
https://chromium.googlesource.com/chromium/deps/icu.git/+log/d3c1cdc3..c7c91f82 c7c91f8 Update IANA to tz 2020d by Frank Tang TBR=jshin@chromium.org Bug: 1143059 Change-Id: I0a464b5be7b9fe69a8a1acde7d297bee740a9e76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504633 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#821855}
-
Michael Hansen authored
This adds a "pulse" animation to the high-visibility receive page, which gives a visual indication that the device is actively waiting to receive shares from other devices. Screenshot: https://screenshot.googleplex.com/3wpVaUZyn57BL8x.png Spec: https://carbon.googleplex.com/cros-ux/pages/nearby-share/motion Bug: b:163147651 Change-Id: I035d78c42cfe1a27e38bf34a39e7083d9038c4a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503827 Commit-Queue: Michael Hansen <hansenmichael@google.com> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#821854}
-
Zhenyao Mo authored
BUG=1060785,1077725 TEST=bots R=rafael.cintron@microsoft.com Change-Id: I2e169acc0f138f635c5c1238065d29cb0a4f8ceb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505599 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com> Reviewed-by:
Rafael Cintron <rafael.cintron@microsoft.com> Auto-Submit: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#821853}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I89d6ef71e62f307f6de4c3eabc5d4a055f0c1e84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506073Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#821852}
-
Joshua Pawlicki authored
This is a reland of 31c7133d The change from the first patch set is to reinstate the call to Uninstall. Original change's description: > Updater: Implement candidate self-uninstall. > > Bug: 1098934 > Change-Id: I226fc7201e04dfbf1722399434e3900cedc35120 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487940 > Commit-Queue: Joshua Pawlicki <waffles@chromium.org> > Reviewed-by: Sorin Jianu <sorin@chromium.org> > Auto-Submit: Joshua Pawlicki <waffles@chromium.org> > Cr-Commit-Position: refs/heads/master@{#821372} Bug: 1098934 Change-Id: I5affeb8ef8a2ba447e33a9d4efc1059184fef58c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505459 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#821851}
-
Danan S authored
These calls allow the guest content to save its state (represented as an opaque Uint8Array of data) in such a way that it survives content reloads. This is needed because the flow redirects through GAIA, which triggers the content reload which wipes out the flow's state. This method is simpler than previous methods used to maintain state across page reloads and doesn't require extra network round-trips because the state is saved and retrieved locally via postMessage calls to the WebUI. Bug: 1136979 Change-Id: Ic1d3c1dbbf0d253f3e856365c0fafa64b8f55066 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498960 Commit-Queue: Dan S <danan@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#821850}
-
Sylvain Defresne authored
App built for "catalyst" environment are regular macOS app (linked with some support libraries). Update the build rules to generate a macOS app bundle when environment is "catalyst". Update the codesign.py and write_framework_modulemap.py script to use the correct bundle structure. Bug: 1138425 Change-Id: I135068a92101b755f588ca25ae9420660ea4a66c Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498527 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#821849}
-
Tanya Gupta authored
Bug: 1142520 Change-Id: I44b67c40a585a9c6438dfd47e8cb91e0d75bba82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498834 Commit-Queue: Tanya Gupta <tgupta@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#821848}
-
Ken Rockot authored
Today, service processes self-terminate as soon as they detect peer closure on their main service pipe. This is detected on the IO thread and results in the immediate scheduling of a main-thread task to terminate the process. Meanwhile, service instances themselves also watch for peer closure on the same pipe and are notified on whichever thread runs the service (IO or main thread). This triggers immediate destruction of the service instance. Because there is no ordering guarantee between the two independent signal handlers, the net result is that during clean shutdown of a service process, the service instance's destructor may not run, or may run after shutdown has already started. This can be problematic if the service continues to operate and perform tasks that depend on a now-partially-shut-down process environment like the task scheduler. As a separate but related issue, the pipe-watching logic has been watching for peer closure when it should really be watching for an unreadable state (i.e., peer closure AND empty inbound queue). This means that service termination could race with messages still on the pipe unless developers are careful to synchronize their browser-side Remote's teardown against some kind of ack message from the service. This change does a bunch of stuff all at once to solve these problems: - Modifies ContentClient ServiceFactory APIs so that they populate a shared instance (two shared instances really, one for IO, one for main thread) rather than having embedders provide their own instance. - Gives UtilityThreadImpl and its internal (IO-thread-bound) ServiceBinderImpl their own ServiceFactory instances with clearly-defined ownership and lifetime. - Removes independent pipe watching logic from ServiceBinderImpl, instead having it track service instance lifetimes from both ServiceFactory instances. - Modifies ServiceFactory's pipe watching logic to watch for an unreadable pipe rather than for peer closure. The net result is that service processes which are cleanly shut down, meaning they neither crashed nor were reaped during full browser process shutdown, will always run their service's destructor before initiating shutdown. Bug: 1135957 Change-Id: I16adbd7c98b4eb4333a92cd338643d4d5a9f2d6f Tbr: caseq@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503346 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#821847}
-
Peter Kotwicz authored
BUG=1142501 Change-Id: I42170e8cdb660ae35275ea688b0c758de72b9fb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504269Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#821846}
-
Kramer Ge authored
When WaylandSurfaceGpu is unregistered, its task_runner is also expected to be forgotten. There are crashes caused by not finding the task_runner. This CL adds a check if the task_runner is unregistered and avoid posting to non-existent task_runners. Change-Id: I1b7d64a5b469e365d5d87ecc5f2332e74d2faf15 Bug: 1139518 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502954Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Cr-Commit-Position: refs/heads/master@{#821845}
-
Maks Orlovich authored
...by converting it into a WPT test that runs on a different hostname Bug: 1076138 Change-Id: I2e687685ea32a4c742383900cd0b871dcc5b9c37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475934 Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
-
