GitLab

The WebSocket API defines that call to Close() on CLOSED state must do nothing
and cause no error. Currently Pepper API returns PP_ERROR_INPROGRESS. This
error code is confusing. We should return PP_OK here.

BUG=124866
TEST=browser_tests --gtest_filter='*WebSocket*'


Review URL: http://codereview.chromium.org/10169036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133894 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70664
TEST=


Review URL: http://codereview.chromium.org/9455078

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133893 0039d316-1c4b-4281-b951-d872f2087c98

We need these write stream interface for implementing generic cross-filesystem operation and to eventually deprecate OpenFileSystem::Write and PlatformFile related interface.

BUG=123993
TEST=unit_tests --gtest_filter='*LocalFileWriter*'

Review URL: http://codereview.chromium.org/10126004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133892 0039d316-1c4b-4281-b951-d872f2087c98

Since panel windows aren't transparent, we didn't draw anything so the
titlebars for panels were black with buttons drawn on top.

BUG=none
TEST=manual


Review URL: http://codereview.chromium.org/10169044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133891 0039d316-1c4b-4281-b951-d872f2087c98

BUG=123117
TEST=none


Review URL: http://codereview.chromium.org/10078001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133890 0039d316-1c4b-4281-b951-d872f2087c98

Move GDataFileSystem::UnsafeFindEntryByPath to GDataRootDirectory::FindEntryByPath.

BUG=chromium-os:29232
TEST=compiles, tests pass.
Review URL: https://chromiumcodereview.appspot.com/10204013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133889 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133888 0039d316-1c4b-4281-b951-d872f2087c98

TBR=hclam@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10134049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133887 0039d316-1c4b-4281-b951-d872f2087c98

Display site permissions in a tab and add a tab to display  information about the site's identity and the site's connection.

UI string changes: https://chromiumcodereview.appspot.com/10180002/

BUG=113688
TEST=WebsiteSettingsTest*

Review URL: https://chromiumcodereview.appspot.com/10163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133886 0039d316-1c4b-4281-b951-d872f2087c98

BUG=116954
TEST=content_unittest (ChunkedByteBufferTest.BasicTest)

Review URL: http://codereview.chromium.org/10123008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133885 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/10134050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133882 0039d316-1c4b-4281-b951-d872f2087c98

Fixed a bug in URLFetcherCore that caused random failures if stopped (because the URLFetcherImpl was destroyed) during a chunked upload.


BUG=124390
TEST=none

Review URL: http://codereview.chromium.org/10175006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133881 0039d316-1c4b-4281-b951-d872f2087c98

This will be imporved after introducing 'gdata properties updated' event.

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10187004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133880 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133879 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133877 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/10221003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133876 0039d316-1c4b-4281-b951-d872f2087c98

BUG=122015
TEST=This CL is self-verifying. If it passes presubmit checks, then
history.js has no more presubmit errors.

Review URL: https://chromiumcodereview.appspot.com/10164005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133875 0039d316-1c4b-4281-b951-d872f2087c98

On some desktop environments, this can enable DPMS with poor defaults.

Also reformat a bunch of poorly-wrapped comments.

BUG=111239

Review URL: http://codereview.chromium.org/10218008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133874 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133873 0039d316-1c4b-4281-b951-d872f2087c98

Temporarily disable ChromeMainTest on ChromeOS. These pass locally for me on linux_chromeos builds, but are failing on the bots after r133852.

TBR=sky
Review URL: https://chromiumcodereview.appspot.com/10173020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133872 0039d316-1c4b-4281-b951-d872f2087c98

TBR=mnaganov@chromium.org
BUG=None
TEST=Tree is green


Review URL: http://codereview.chromium.org/10207029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133871 0039d316-1c4b-4281-b951-d872f2087c98

BUG=123295
TEST=none


Review URL: http://codereview.chromium.org/10068036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133870 0039d316-1c4b-4281-b951-d872f2087c98

This change widens a suppression rule for Bug 118890 so it covers an occasional leak in sync_notifier::InvalidationNotifier::UpdateCredentials().

TBR=thakis
BUG=118890
TEST=make the "Linux Tests (valgrind)(6)" bot green.
Review URL: https://chromiumcodereview.appspot.com/10151012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133869 0039d316-1c4b-4281-b951-d872f2087c98

This change updates a suppression rule for Bug 107698 to catch up with WebKit r113922 <http://trac.webkit.org/changeset/113922>, which renamed CSSStyleSheet -> StyleSheetInternal.

TBR=thakis
BUG=107698
TEST=make the "Webkit Linux (valgrind layout)" bot green.
Review URL: https://chromiumcodereview.appspot.com/10225001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133868 0039d316-1c4b-4281-b951-d872f2087c98

BUG=124853
TEST=SafeBrowsingProtocolParsingTest.TestTruncatedHeader


Review URL: http://codereview.chromium.org/10216006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133867 0039d316-1c4b-4281-b951-d872f2087c98

No functionality change.

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/10151010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133866 0039d316-1c4b-4281-b951-d872f2087c98

BUG=123295
TEST=none


Review URL: http://codereview.chromium.org/10067033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133865 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:29684
TEST=Manual test.


Review URL: http://codereview.chromium.org/10155030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133864 0039d316-1c4b-4281-b951-d872f2087c98

This change suppresses the leaks in GDataDBTest, which are introduced by r133833 <http://crrev.com/133833>.

TBR=thakis,achuith
BUG=124961
TEST=make the "Chromium OS UI (valgrind)(8)" bot and the "Chromium OS Heapcheck" bot green.
Review URL: https://chromiumcodereview.appspot.com/10222002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133863 0039d316-1c4b-4281-b951-d872f2087c98

Adding this method is to dump image for DRT on Chromium Android port.
See https://bugs.webkit.org/show_bug.cgi?id=84682 for details.

NOTE. Skia pixel layout definition is in
<chrome-source-root>/third_party/skia/include/core/SkPostConfig.h for Chromium Android platform.
<chrome-source-root>/skia/config/SkUserConfig.h for other Chromium platforms.


BUG=None.
TEST=should not affect any tests.

Review URL: http://codereview.chromium.org/10202008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133861 0039d316-1c4b-4281-b951-d872f2087c98

In case of corruptions, the state of empty_ versus file_ may not be
what was expected.

BUG=124907
TEST=See bug.


Review URL: http://codereview.chromium.org/10211013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133860 0039d316-1c4b-4281-b951-d872f2087c98

Then new PepperPacketSocketFactory implements talk_base::PacketSocketFactory
based on Pepper's UDP sockets interface.

BUG=109630


Review URL: http://codereview.chromium.org/10121002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133859 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=unit_tests


Review URL: http://codereview.chromium.org/10049006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133858 0039d316-1c4b-4281-b951-d872f2087c98

Many TODOs here that will allow a quicker distribution of work to get the
remaining pieces upstreamed.

BUG=118591
TEST=


Review URL: http://codereview.chromium.org/10035034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133857 0039d316-1c4b-4281-b951-d872f2087c98

BUG=123856
BUG=120196
TEST=manual

Review URL: http://codereview.chromium.org/10155022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133856 0039d316-1c4b-4281-b951-d872f2087c98

BUG=114329
TEST=none


Review URL: http://codereview.chromium.org/10220001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133855 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/10217009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133854 0039d316-1c4b-4281-b951-d872f2087c98

The regression is introduced in r133603 where we use opacity to hide
newly added view but did not restore it properly on animation cancellation,
which happens when adding launcher item before animation finishes.

BUG=124855
TEST=Verify fix for issue 124855.


Review URL: http://codereview.chromium.org/10169038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133853 0039d316-1c4b-4281-b951-d872f2087c98

Convert the session restore ui_tests to browser_tests. I renabled the disabled tests; hopefully they're now more flaky.

I found a simple way of launching a browser_test binary as a regular chrome binary which is needed for the app test case. This means I can undo r133560 which I've done here.

BUG=121574,29110,52022
Review URL: https://chromiumcodereview.appspot.com/10202005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133852 0039d316-1c4b-4281-b951-d872f2087c98

This is in preparation for changing nacl_process_host.cc to reuse this
code instead of having its own copy in DebugContext.  This needs to go
into chrome/common rather than chrome/nacl so that
nacl_process_host.cc can #include it under the checkdeps rules.

This changes the code to use PostTask() instead of PostDelayedTask().

BUG=http://code.google.com/p/nativeclient/issues/detail?id=2618
TEST=run_inbrowser_exception_test in nacl_integration


Review URL: http://codereview.chromium.org/10211007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133851 0039d316-1c4b-4281-b951-d872f2087c98