- 13 Nov, 2017 40 commits
-
-
Luke Sorenson authored
Bug: 780546 Change-Id: Ib2f73178d7a4373d0bcfe772eea3a5c885d564b6 Reviewed-on: https://chromium-review.googlesource.com/749581Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Luke Sorenson <lasoren@chromium.org> Cr-Commit-Position: refs/heads/master@{#515959}
-
Finnur Thorarinsson authored
Introduce a class that supports hanging on to temporary files long enough for the OS to pick them up (and clean them up after restart of Chrome if it fails the first time around). Necessary because Windows doesn't guarantee temp file deletion on shutdown/restart. Bug: 734095 Change-Id: I2926dc33b489f150a75f97792266e1a31a4ea5a2 Reviewed-on: https://chromium-review.googlesource.com/708742 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#515958}
-
Jonathon Kereliuk authored
Previously incomplete, now complete :) Bug: Change-Id: Ia2a1fa584baf27b90d245c60501dfd074a18ac08 Reviewed-on: https://chromium-review.googlesource.com/736390Reviewed-by:
Shuotao Gao <stgao@chromium.org> Commit-Queue: Jonathon Kereliuk <kereliuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#515957}
-
Sylvain Defresne authored
Convert IOSTranslateDriver to directly track registration with the observed WebState instead of relying on the deprecated code in WebStateObserver. Bug: 775684 Change-Id: Iad1d53fcab9448e088a19cd75767235f9816a0b3 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/757105 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#515956}
-
Hui(Andy) Wu authored
For autofill fields marked as only_fill_when_focused, stop filling them unless they are the focused field. This is used to prevent filling multiple phone numbers in the same form so far, but might be used for other fields going forward. Bug: 780471 Change-Id: I517125c549b4a52daf7141080c33981484af4494 Reviewed-on: https://chromium-review.googlesource.com/744703Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Hui Wu <wuandy@chromium.org> Cr-Commit-Position: refs/heads/master@{#515955}
-
Paweł Hajdan, Jr authored
Bug: 783662 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: If14081b9b17a3502435d2f2c4fcccfbbe51ae813 Reviewed-on: https://chromium-review.googlesource.com/763447Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#515954}
-
Max Morin authored
Adding #if defined(OS_CHROMEOS) everywhere in the new mojo input stream factory is a pain (and ugly), so add a dummy KeyboardMicRegistration for other platforms and put platform-checking macros in AudioInputDeviceManager instead. Bug: 653861 Change-Id: If538fb6452f048fd6175a46e0e39dda3a2adfe5e Reviewed-on: https://chromium-review.googlesource.com/757376Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#515953}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ad1474a1..8b43ab72 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I9623aaf07d2a95b9308ff89267a3779d1442887e Reviewed-on: https://chromium-review.googlesource.com/765594Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#515952}
-
Sylvain Defresne authored
Convert WebFaviconDriver to directly track registration with the observed WebState instead of relying on the deprecated code in WebStateObserver. Bug: 775684 Change-Id: I7f7fcec4a57c1da79012069d971123c9e4144799 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-eg Reviewed-on: https://chromium-review.googlesource.com/758863 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/f5d92693eb80..755a485cfb8a $ git log f5d92693e..755a485cf --date=short --no-merges --format='%ad %ae %s' 2017-11-13 nednguyen Clean up statistical_analysis module Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I84a1f4fb69471ec6d0daf851383cf3290bd995f9 Reviewed-on: https://chromium-review.googlesource.com/766467 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#515950}
-
Koji Ishii authored
Following bot results are included. 2086 2087 2088 2090 2091 2092 2094 2095 2097 85 lines were removed by consecutive passes since 2069. Also, 7525 lines were "fully deflaked" by using last 38 bot results since 2000. It means all expectations including Pass are removed if they were not seen in the last 38 results. Many of them might have been added in CL:750602 probably due to bots config errors. This may cause some flakiness for a while though. TBR=eae@chromium.org NOTRY=true Bug: 591099 Change-Id: Ifc3da8c4b40d2e5024b86a9d4aa053bbd322d992 Reviewed-on: https://chromium-review.googlesource.com/766148 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#515949}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/703671e9fddc..1974452966bb $ git log 703671e9f..197445296 --date=short --no-merges --format='%ad %ae %s' 2017-10-11 yizhou.jiang Clear up deqp cases for multisampled texture Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I5450395c3c0432b15de85541447f983ff958b51f Reviewed-on: https://chromium-review.googlesource.com/766150Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#515948}
-
Michael Lippautz authored
Bug: chromium:757440 Change-Id: I59f77f644a900f5fa1480867eb8be22b35bd3ad8 Reviewed-on: https://chromium-review.googlesource.com/758415Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#515947}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/34922a64225b..8d5ce2d9ede0 $ git log 34922a642..8d5ce2d9e --date=short --no-merges --format='%ad %ae %s' 2017-11-10 robertphillips Patch up ref counting of proxies Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: I124fcdbb1090dede23480b36cd5b5292ae7c184c Reviewed-on: https://chromium-review.googlesource.com/766149Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#515946}
-
Becca Hughes authored
The animation event listener that was part of loading panel will be useful for some other motion in the media controls so this refactors it into a reusable component. BUG=779989 Change-Id: I30f3b3aebe20bbeb9886c1c7d4b4e2f5174e4042 Reviewed-on: https://chromium-review.googlesource.com/763413 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#515945}
-
Ned Nguyen authored
Bug: 784325 Change-Id: I4275e2fc034216678d3c982e735ea2dc603ef1c6 Reviewed-on: https://chromium-review.googlesource.com/765910Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#515944}
-
Marc Treib authored
This CL adds an explicit wait after the navigation to the page in question has finished, to give the renderer some time to actually paint it before we attempt to take a screenshot. Bug: 778248, 784300 Change-Id: I2a0ecd73b6f182a064728d03a380d2ed40fa50f8 Reviewed-on: https://chromium-review.googlesource.com/765828 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#515943}
-
Colin Blundell authored
These tests are exhibiting flake on the main waterfall, as detailed on the bugs listed below. TBR=mcasas@chromium.org Bug: 783301, 783800 Change-Id: I0770da4c7e7caf62ba65b3939f7417df7782ae36 Reviewed-on: https://chromium-review.googlesource.com/766189Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#515942}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/f4c21da08850..f5d92693eb80 $ git log f4c21da08..f5d92693e --date=short --no-merges --format='%ad %ae %s' 2017-11-09 perezju [Telemetry] Remove deprecated memory_stats 2017-11-13 perezju Revert "[Telemetry] Do not collect histograms when not requited by output" Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ief76a9a318491383ed8b181d22f73d7ab0a4823c Reviewed-on: https://chromium-review.googlesource.com/766147 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#515941}
-
Martin Sramek authored
This should not change during Chrome runtime, and thus is passed directly from the factory, similarly as we do for product version. Since we use the term "app locale", for consistency we also rename "product version" into "app version". Finally, as this addition caused even more repetition in tests, some common functionality has been extracted, and on the way, the ordering of expectations fixed. BASE: 731423 Bug: 781765 Change-Id: Id8093692a0cadd0d3ac127266dc9a814e780f602 Reviewed-on: https://chromium-review.googlesource.com/763510 Commit-Queue: Martin Šrámek <msramek@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#515940}
-
Hajime Hoshi authored
This CL makes RendererSchedulerImpl::IPCTaskRunner return a new task queue with the new type IPC instead of base::ThreadTaskRunnerHandle:: Get(). Bug: 780785 Change-Id: I41ca614cb6f894127902062b838092c2ecc48a5e Reviewed-on: https://chromium-review.googlesource.com/765688 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#515939}
-
depot-tools-roller@chromium.org authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1ea21322e369..bf7e8d8a5001 $ git log 1ea21322e..bf7e8d8a5 --date=short --no-merges --format='%ad %ae %s' 2017-11-10 phajdan.jr Remove references to phajdan.jr Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=phajdan.jr@chromium.org Change-Id: I8bb54f6d7d56e862b45a533cc069af919c0ff3c5 Reviewed-on: https://chromium-review.googlesource.com/766007Reviewed-by:
depot-tools-roller . <depot-tools-roller@chromium.org> Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#515938}
-
Yutaka Hirano authored
See https://github.com/whatwg/url/issues/350 and https://github.com/whatwg/url/issues/18. Bug: 776344 Change-Id: I7881add2fc5b858874da42cef7b14a9e8ee10262 Reviewed-on: https://chromium-review.googlesource.com/756537 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Cr-Commit-Position: refs/heads/master@{#515937}
-
Michael van Ouwerkerk authored
This reverts commit 2518c6f4. Reason for revert: RecyclerView crash as reported in https://bugs.chromium.org/p/chromium/issues/detail?id=784238 Original change's description: > In new-tab-Chrome-Home put the logo inside the RecyclerView. > > Bug: 781163 > Change-Id: Id0957afdf125feeefb6dbfa36c9b3754552c735f > Reviewed-on: https://chromium-review.googlesource.com/759002 > Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> > Reviewed-by: Bernhard Bauer <bauerb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#515591} TBR=bauerb@chromium.org,mvanouwerkerk@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 781163 Change-Id: I2850621a04dad0feb00f778d3ffe8374177294dd Reviewed-on: https://chromium-review.googlesource.com/765807Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#515936}
-
Sriram authored
Removing the following test cases infavor of the web platform tests in html/semantics/embedded-content/media-elements/interfaces/TextTrack/ 1. addCue.html 2. constants.html 3. cues.html 4. kind.html 5. label.html 6. language.html 7. mode.html 8. oncuechange.html 9. removeCue.html Bug: 782555 Change-Id: Id06d6c0908993e5628f9b16069ff291bc29d21f6 Reviewed-on: https://chromium-review.googlesource.com/765868Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#515935}
-
Ned Nguyen authored
Bug: 777664 Change-Id: Ib3341ab65ea528c8036115ff947bbe1f36b5c3bd Reviewed-on: https://chromium-review.googlesource.com/765101Reviewed-by:
-
Lalit Maganti authored
This CL achieves the long present goal to compute the shared memory footprint of each process in Chrome. It does this by utilising earlier work to perform the computation and adds it to the existing struct of metrics reported by the memory-infra service. For more context, see https://goo.gl/3kPb9S Bug: 781782 Change-Id: I6b9603e54ddd76e84fcb4898eb38d6be5c0c233f Reviewed-on: https://chromium-review.googlesource.com/757139 Commit-Queue: Lalit Maganti <lalitm@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#515933}
-
Guido Urdaneta authored
This CL runs requests on the same task where they are issued if possible, which is more similar to the way MST.stop() used to run. If this is not enough to make the failing racy test pass, the only solution is to disable the test on the bots where it fails. Reusing haraken@ lgtm for the Blink part. TBR=haraken@chromium.org This is a reland of 7c8e8e13 Original change's description: > Reland "Serialize MediaStreamTrack.stop() with getUserMedia()" > > This is a reland of a58c8bd6 > Original change's description: > > Serialize MediaStreamTrack.stop() with getUserMedia() > > > > When multiple getUserMedia and stop() requests are active concurrently, > > getUserMedia() sometimes fails with TrackStartError. > > The reason is that the underlying video capture subsystem does not keep > > a count of how many sources have opened a video device. > > It can happen that a stop request stops video capture while a > > getUserMedia() request is being processed, with the result being that > > the video device is closed before getUserMedia() starts the new video > > track, resulting in an error. > > > > One solution to this problem is to make sure that stop requests and > > getUserMedia() requests cannot run concurrently, which is the approach > > followed by this CL. > > > > This CL basically moves handling of MediaStramTrack.stop() from > > MediaStreamCenter to UserMediaClient, and puts stop() requests in the > > same queue used for getUserMedia() and applyConstraints() requests. > > > > > > Bug: 778039 > > Change-Id: Id7e0ee38e40265fd599dc6dd0712f0b667d2e1a5 > > Reviewed-on: https://chromium-review.googlesource.com/751981 > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > Reviewed-by: Henrik Boström <hbos@chromium.org> > > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#515494} > > TBR=haraken@chromium.org > > Bug: 778039 > Change-Id: I461e3c98f3d6471cc218d48501d22c6c0a8b03e9 > Reviewed-on: https://chromium-review.googlesource.com/763636 > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Henrik Boström <hbos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#515836} Bug: 778039 Change-Id: Idd2e1c95952b9c924037beaca987344093751009 Reviewed-on: https://chromium-review.googlesource.com/765657Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#515932}
-
Stepan Khapugin authored
This reverts commit 46e29e03 (breaks ios tests). Reason for revert: <INSERT REASONING HERE> Original change's description: > Use autolayout in LocationBarView > > Uses autolayout in LocationBarView to position the omnibox textfield. > > Bug: > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: If9f0f9ec65624785617bb3820d56509845f97e5e > Reviewed-on: https://chromium-review.googlesource.com/709215 > Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> > Reviewed-by: Rohit Rao (ping after 24h) <rohitrao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#515911} TBR=rohitrao@chromium.org,stkhapugin@chromium.org Change-Id: I3a935b9525fb504af1e41314ef3d5b9f7aefa697 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/766047Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#515931}
-
Yutaka Hirano authored
Bug: 709910,759934 Change-Id: I265d4c376a9fb68e577c1b1412564a614b48fc91 Reviewed-on: https://chromium-review.googlesource.com/757988Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
Martin Sramek authored
This is a prototype of the consent auditor component. This CL only lays out the component and adds the functionality to record local consent plus tests. The functionality to record consents in the user's Google account, and any callsites, will come in subsequent CLs. See the design doc for background: https://docs.google.com/document/d/1Iu040VPbAPdulCpvbnOu1HLh0nXNJfuNMAEckdwmHWQ/ Bug: 781765 Change-Id: I1aef65249afe98c20db7aa692a7c3a007069e56b Reviewed-on: https://chromium-review.googlesource.com/731423 Commit-Queue: Martin Šrámek <msramek@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#515929}
-
Boris Sazonov authored
This CL inlines ProfileDataCache creation into AccountSigninView instead of passing it to init methods. It simplifies both logic and interface of AccountSigninView. Bug: 783344 Change-Id: I39efcfd30f624907ddef7d9adbdeec0f916985a1 Reviewed-on: https://chromium-review.googlesource.com/761576Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#515928}
-
Anita Woodruff authored
- Only set the FLAG_RECEIVER_FOREGROUND flag on notification clicks and closes when the sdk version is >= O. Bug: 764437 Change-Id: I8a51f7cc7db670700ced543848c4bda092bf2248 Reviewed-on: https://chromium-review.googlesource.com/764148Reviewed-by:
-
Sriram authored
Removing cloneNode.html and src-clear-cues.html infavor of the existing web platform tests: html/semantics/embedded-content/media-elements/track/track-element/ cloneNode.html src-clear-cues.html Bug: 782555 Change-Id: Ibd98d32bb744ba16de51fa42210ff9492d8ef4a3 Reviewed-on: https://chromium-review.googlesource.com/765633Reviewed-by: -
Fredrik Söderquist authored
In media/track/, the following tests seemed to exhibit the same timeout behavior as track-kind.html: track-default-attribute.html track-load-error-readyState.html track-load-from-element-readyState.html The default track could finish loading before the event handler was added. Move the external <script>s earlier (to within <head>) and attach event handlers before </video>. Bug: 782095 Change-Id: I103e6d24a20f8b164a38a9014eae98528a6caf92 Reviewed-on: https://chromium-review.googlesource.com/757012 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
srirama chandra sekhar <srirama.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#515925}
-
Ramin Halavati authored
A users guide is added to docs/ for network traffic annotations. Annotations proto file's comments are updated. Bug: 656607 Change-Id: I524d0017a9b74c618b6f7088583706eab2bf0fcc Reviewed-on: https://chromium-review.googlesource.com/753085Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#515924}
-
Colin Blundell authored
This reverts commit 5abd7bfc. Reason for revert: Suspected of causing PointerLockBrowserTest flake as detailed on crbug.com/784236. Original change's description: > Enable render throttling for OOPIFs > > Throttle OOPIFs when they are off screen or clipped. This adds a > VisibilityObserver to RemoteFrames with LocalFrame parents, and > sends an update across processes to the OOPIF when throttling status > should change. > > This also fixes ScreenOrientation browser tests which has some > flakiness in OOPIF tests that appears when this patch is applied. > > Bug: 761478 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation > Change-Id: I9bfb57058e534e796c23e238664a66a142be3c4a > Reviewed-on: https://chromium-review.googlesource.com/719601 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Stefan Zager <szager@chromium.org> > Commit-Queue: Ken Buchanan <kenrb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#515875} TBR=dcheng@chromium.org,kenrb@chromium.org,szager@chromium.org,alexmos@chromium.org Change-Id: If713f93ff75ef4ea45853052fa05c3095f13e8aa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 761478 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Reviewed-on: https://chromium-review.googlesource.com/765847Reviewed-by:
-
Hajime Hoshi authored
TBR=hajimehoshi@chromium.org Bug: 780378 Change-Id: Ie3ced9c5c0a1914d9fa329d36209634d2ae55383 Reviewed-on: https://chromium-review.googlesource.com/763269Reviewed-by:
-
Christian Dullweber authored
This changes the popup permission to be inherited to incognito profiles. While other content settings are not inherited due to security or privacy concerns, inheriting sites allowed to show popups is save. Bug: 762349 Change-Id: Ia31f6cea46edf8c705302ee4a414a40a8321756e Reviewed-on: https://chromium-review.googlesource.com/672547Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#515921}
-
Matt Falkenhagen authored
This is a follow up to https://chromium-review.googlesource.com/c/chromium/src/+/758869, which added "ServiceWorker" to some of the constants. That approach seems misleading since it looks like "ServiceWorkerKey" is a type of key on the same level as a "RegKey" or "ResKey". Really we want to add "ServiceWorker" to all the constants, which we can accomplish by making a namespace. Bug: 746953 Change-Id: I61dffdaecffbeb088906f67907fdc47f0f81a5e1 Reviewed-on: https://chromium-review.googlesource.com/765556Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#515920}
-
