GitLab

This roll caused build breaks on Mac, Linux, and "Linux x64".
  http://build.chromium.org/p/chromium/builders/Mac/builds/9896/steps/compile/logs/stdio
  http://build.chromium.org/p/chromium/builders/Linux/builds/18264/steps/compile/logs/stdio
  http://build.chromium.org/p/chromium/builders/Linux%20x64/builds/19561/steps/compile/logs/stdio

BUG=None
TEST=Trybots
TBR=kbr

Review URL: http://codereview.chromium.org/8918002

TBR=bashi@chromium.org
Review URL: http://codereview.chromium.org/8921004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114007 0039d316-1c4b-4281-b951-d872f2087c98

Applications shortcuts will be added to the Start / Applications menu,
the taskbar and the desktop. This is a temporary change to help the
shortcut features of platform applications and make installed platform
applications more visible.

BUG=None
TEST=Manually tested on Windows


Review URL: http://codereview.chromium.org/8862007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114006 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114005 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Trybots
TBR=kbr


Review URL: http://codereview.chromium.org/8918002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114003 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8799011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114002 0039d316-1c4b-4281-b951-d872f2087c98

because the call stack changed due to adding a new variation of this
function.

TBR=wtc@chromium.org
BUG=chromium:82974
TEST=none


Review URL: http://codereview.chromium.org/8917003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113998 0039d316-1c4b-4281-b951-d872f2087c98

Fix for missing curly brace in the manifest. http://codereview.chromium.org/8885034/diff/1/manifest.json

BUG=chromium-os:23996
TEST=manual
TBR=jhawkins@chromium.org
Review URL: http://codereview.chromium.org/8920001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113997 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113996 0039d316-1c4b-4281-b951-d872f2087c98

This change applies upstream patches from 1.2.3 to 1.2.5.

BUG=30704,39219
TEST=build and run Chrome without any valgrind errors.

Review URL: http://codereview.chromium.org/8806004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113994 0039d316-1c4b-4281-b951-d872f2087c98

imported via ONC.

It also centralizes the label creation for nicknames and certificates
so that we can better control their values.

BUG=chromium-os:19403
TEST=Ran new unit tests, imported certs into certificate store via ONC.


Review URL: http://codereview.chromium.org/8566056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113993 0039d316-1c4b-4281-b951-d872f2087c98

InlineTextBox::expansionBehavior().

BUG=107179
TEST=none
TBR=epoger

Review URL: http://codereview.chromium.org/8919001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113992 0039d316-1c4b-4281-b951-d872f2087c98

For our purposes so far (IME/omnibox coordination) we don't plan to take any action when the suggestion window is opened/closed.  See design doc for more details.

BUG=chromium-os:17763
TEST=manually


Review URL: http://codereview.chromium.org/8888038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113991 0039d316-1c4b-4281-b951-d872f2087c98

BUG=107177
TEST=none
TBR=epoger

Review URL: http://codereview.chromium.org/8918001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113990 0039d316-1c4b-4281-b951-d872f2087c98

BUG=107175
TEST=none
TBR=bbudge

Review URL: http://codereview.chromium.org/8917001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113987 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113982 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Trybots
TBR=kbr


Review URL: http://codereview.chromium.org/8915003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113981 0039d316-1c4b-4281-b951-d872f2087c98

I tried to do this in http://codereview.chromium.org/8897020 but failed.

See:
http://build.chromium.org/f/chromium/perf/mac-release-10.5/intl1/report.html?history=150&rev=113976

TBR=cmp
Review URL: http://codereview.chromium.org/8911003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113980 0039d316-1c4b-4281-b951-d872f2087c98

That matches the CQ bots, and they're significantly faster.

The global trybots are added to all subdirectory PRESUBMITs automatically, so remove win, linux, mac from subdirectory PRESUBMITs (instead of changing them too).

BUG=99521
TEST=`git try` creates faster tryjobs.
TBR=willchan (net), akalin (sync)

Review URL: http://codereview.chromium.org/8162009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113979 0039d316-1c4b-4281-b951-d872f2087c98

NativeComboboxViews was not passing itself as a (transient) parent to
MenuRunner::RunMenuAt. All mouse events were sent to the open menu (since it
is set as the capture window), and ModalityEventFilter::PreHandleMouseEvent
dropped them all since they were not directed to a child of the active modal
dialog.


BUG=105155
TEST=none


Review URL: http://codereview.chromium.org/8893019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113978 0039d316-1c4b-4281-b951-d872f2087c98

This got broken with an earlier change to perform the change to
the default browser setting on the FILE thread. The file thread
isn't created at the point the default browser policy is enforced,
this change moves the code to later in the startup process.

BUG=106610
TEST=Manual testing performed with a hacked Chromium to always
set Chrome as the default regardless of local policy. QA should
test with all the policy machinery setup. Linux and Mac should
be tested as well.


Review URL: http://codereview.chromium.org/8872047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113977 0039d316-1c4b-4281-b951-d872f2087c98

Consolidate two very similar functions; ui::WindowsKeyCodeForGdkKeyCode and ui::KeyboardCodeFromXKeysym.

Add some X keysym names that are handled by the former function to the latter.

BUG=103511
TEST=ran try


Review URL: http://codereview.chromium.org/8803004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113976 0039d316-1c4b-4281-b951-d872f2087c98

Made changes to enable the button only on below conditions
1) If pref is user editable. In this case event.value['disabled'] would be false.
2) If pref is user editable and it does'nt hold a default value. In this case event.value['controlledBy'] would be recommended.
3) Otherwise if controlledBy is empty or null.

BUG=106592
TEST=None.


Review URL: http://codereview.chromium.org/8883015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113975 0039d316-1c4b-4281-b951-d872f2087c98

* Remove empty Linux & Win implementations of the class.
* Rename files and unit test to be Mac only.
* Rename namespace SpellCheckerPlatform -> SpellCheckerMac
* Surround usage in crossplatform files with #ifdef OS_MACOSX as a temporary measure (a future step will be to remove the calls entirely from these files).

BUG=69944
TEST=Spelling correction feature should continue to work as expected on Mac/Win/Linux .


Review URL: http://codereview.chromium.org/8890022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113974 0039d316-1c4b-4281-b951-d872f2087c98

BUG=107158
TEST=none
TBR=epoger

Review URL: http://codereview.chromium.org/8911002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113972 0039d316-1c4b-4281-b951-d872f2087c98

BUG=107154
TEST=none
TBR=thestig@chromium.org

Review URL: http://codereview.chromium.org/8914004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113971 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106966
TBR=cmp
Review URL: http://codereview.chromium.org/8910002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113970 0039d316-1c4b-4281-b951-d872f2087c98

- Update Linux size expectations to recent range of my code addition.
Review URL: http://codereview.chromium.org/8913001

TBR=brettw@chromium.org
Review URL: http://codereview.chromium.org/8914003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113969 0039d316-1c4b-4281-b951-d872f2087c98

fixed by r113954.

BUG=106402
TEST=none
TBR=brettw

Review URL: http://codereview.chromium.org/8914002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113968 0039d316-1c4b-4281-b951-d872f2087c98

Happening in a new place after a refactoring.

BUG=102255
TEST=none
TBR=rdsmith

Review URL: http://codereview.chromium.org/8914001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113967 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8913001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113966 0039d316-1c4b-4281-b951-d872f2087c98

I added a bunch of pepper code that pushed us over the previous limit. I also added several links to the perf instructions since it took me a while to figure this out.
Review URL: http://codereview.chromium.org/8910001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113962 0039d316-1c4b-4281-b951-d872f2087c98

- Improve RenderTextWin font fallback.

Don't use SCRIPT_UNDEFINED in the case of font fallback,
unless font fallback actually fails to return a script
that can display the characters. This fixes the problem
of some scripts not being properly displayed.

This actually makes RenderTextWin properly validate whether
a text position accepts a cursor, which caused several tests
to fail and revealed some additional issues in RenderTextWin.

The CL includes some modifications to address this.

Some tests are disabled under XP, see:
http://crbug.com/106450

Also, fixes some lint warnings.

BUG=90426
TEST=Run chrome.exe --use-pure-views and paste some Bengali
text into the omnibox. It should show up properly.
Review URL: http://codereview.chromium.org/8575020

TBR=asvitkine@chromium.org

TBR=thakis@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113960 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104142
TEST=none
TBR=joi

Review URL: http://codereview.chromium.org/8900002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113959 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=compiles

Review URL: http://codereview.chromium.org/8894033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113958 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=trybots

Review URL: http://codereview.chromium.org/8892023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113957 0039d316-1c4b-4281-b951-d872f2087c98

- Improve RenderTextWin font fallback.

Don't use SCRIPT_UNDEFINED in the case of font fallback,
unless font fallback actually fails to return a script
that can display the characters. This fixes the problem
of some scripts not being properly displayed.

This actually makes RenderTextWin properly validate whether
a text position accepts a cursor, which caused several tests
to fail and revealed some additional issues in RenderTextWin.

The CL includes some modifications to address this.

Some tests are disabled under XP, see:
http://crbug.com/106450

Also, fixes some lint warnings.

BUG=90426
TEST=Run chrome.exe --use-pure-views and paste some Bengali
text into the omnibox. It should show up properly.
Review URL: http://codereview.chromium.org/8575020

TBR=asvitkine@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113956 0039d316-1c4b-4281-b951-d872f2087c98

window.open() in BackgroundContents was failing in M17 because we were no longer
hooking ShowCreatedWindow() and forwarding the request to our delegate.

Now that BackgroundContents wraps a real TabContents, we now hook AddNewContents()
and pass it off to our Delegate to open a new window.

BUG=105992
TEST=instructions in bug.


Review URL: http://codereview.chromium.org/8899019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113955 0039d316-1c4b-4281-b951-d872f2087c98

This fixes a leak because the completion callbacks were not getting run on
resource destruction. This leaves the calling code waiting for the callbacks
with leaked data associated with the callback.

This patch just always runs the callbacks with PP_ERROR_ABORTED. I tweaked the
callback code to use the (newer than the original code) "run and clear"
completion callback macro which also cleans up the code a little.

BUG=106402

Review URL: http://codereview.chromium.org/8801027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113954 0039d316-1c4b-4281-b951-d872f2087c98

[ Reland of 113565 http://codereview.chromium.org/8764003 ]

This splits apart the old in-process implementation into a new object in shared_impl that does most of the general tracking. This alllows that code to be shared by the proxy.

BUG=http://crbug.com/101154

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113953 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113946 0039d316-1c4b-4281-b951-d872f2087c98