- 10 Jul, 2020 40 commits
-
-
Stephen Lin authored
R=pkasting@chromium.org Bug: 1097552 Change-Id: I60641142a6c05f3132b037810c7aecd533d779a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293456 Auto-Submit: Stephen Lin <stephenlin@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#787438}
-
Andrew Moylan authored
This CL rolls most recent mojom changes (excluding Clone method which I will roll separately). These are all comment changes apart from the addition Model.CreateGraphExectutorWithOptions. Also added a basic fake impl of that method. Bug: chromium:1081597 Change-Id: If2e02fcbde8eae800872d3cbfebf830dcede1be2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291794 Auto-Submit: Andrew Moylan <amoylan@chromium.org> Reviewed-by:
Honglin Yu <honglinyu@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#787437}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1594382405-1c0e0d15040ecb2cc25de0b60c76871095d44c41.profdata to chrome-win64-master-1594403996-e3eed77ce75692e0c0c19bee2acf225c6e767aa8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I7911aec00ae11e5fd32f9c8c133a69a48cc8177f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293045Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#787436}
-
Mei Liang authored
crrev.com/c/1464118 affects the TabModelObserver ordering. It adds TabModelFilter as a TabModelObserver to the system, and TabModelFilter becomes the first set of Observers to be notified when TabModel changed. More specifically, the TabModelFilter receives notification before the TabModelObserver in TabModelSelectorBase and eventually causes the CompositorViewHolder#updateContentOverlayVisibility(true) with a stale |mView| and affecting the focus. This CL addresses this issue by: 1. Attaches TabModelSelectorBase#TabModelObserver to TabModelFilter, So it becomes the first Observer to be notified as before. 2. Verifies the |mView| in CompositorViewHolder is the current tab view when show is requested. 3. Removes redundant logic in LayoutManagerChromeTablet. Don't need to call show StaticLayout explicitly, the LayoutManager will handle that automatically when the ToolbarSwipeLayout hides. Change-Id: I4e588194d8866b06dac1255532ec7094d5eabc1d Bug: 944777, 1073535 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290772 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:Matthew Jones <mdjones@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#787435}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2a2b4b135a86..73b6b3a8838f 2020-07-10 ianelliott@google.com Vulkan: Fully enable pre-rotation for Android If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Change-Id: I924e81cab645b495818f93355897f0ff4b147f43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293334Reviewed-by:
-
Haiyang Pan authored
android emulator team points out that the exception is related to DMA. Disable GLDMA temporarily to see if it can fix the timeout issue on MM Bug: 1093602 Change-Id: I940b8111db48d8b542b47f350b949dab7448d1d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293279 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#787433}
-
Cicy Tan authored
If the method is called a second time, instead make a window priority request. Bug: internal 160358649 Test: on device Change-Id: I6b38cafb3198a607136e54542f65c6f4df8b163b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293419Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Commit-Queue: Cicy Tan <shiyun@google.com> Cr-Commit-Position: refs/heads/master@{#787432}
-
Eugene Zemtsov authored
Bug: 1041930 Change-Id: Id6d90a7863cc27ad9f1e0f489bd78279de052132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291436Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/master@{#787431}
-
Jarryd authored
Replace all uses of blacklist with denylist in quota code. Bug: 1103891 Change-Id: Ia2d50a987a3f6d4f835a09ed20f3894186cb0e12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286009Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#787430}
-
Justin DeWitt authored
Bug: 1104367 Change-Id: Iba8556773dd0b72f1e69de96a05846e6be4d25b6 Tbr: rouslan@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293414Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#787429}
-
Xianzhu Wang authored
The value had only 3 possible values: 0, 0.5, 1.0. Now use 2 bits in DisplayItem, and reduce sizeof(DrawingDisplayItem) by 8 bytes on 64-bit systems. Change-Id: Ifa8660ea86122a863508a4b6fdcddc2908dcc4ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213089 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#787428}
-
Katie Dillon authored
Breaking up this cl[1] into two portions: before unload and unload metrics. Adding UKMs to help measure unload performance. More details on why we are adding these metrics can be found on the UKM Collection Review doc[2]. TL;DR is that Search is looking to see where they could improve unload and on the web platform side we are looking to run experiments to prioritize unload and these metrics will help measure impact. This CL adds the metrics we want to collect for before unload. For browser-initiated navigations we look at the queuing duration (renderer-initiated navigations run before unload handlers synchronously so we don't record queuing time. However, if the page has OOPIFs whose beforeunloads will be dispatched from the browser, then we will record queueing time for those) and for all navigations we look at the duration of the before unload handlers (if it is a renderer-initiated navigation who dispatches beforeunloads to OOPIFs from the browser process, the duration of those will be summed into the duration of the local beforeunloads). These metrics are recorded for both cross-process and same-process navigations upon a navigation commit and use the frames origin prior to the navigation committing not the destination (ie if we navigate from google.com to cnn.com the unload times are recorded for google.com). Metrics added in this CL are: 1. BeforeUnloadDuration 2. BeforeUnloadQueueingDuration (measuring the time from browser sending the before unload to the unload being run in the renderer). [1] https://chromium-review.googlesource.com/c/chromium/src/+/2191143 [2] https://docs.google.com/document/d/1DECc8eJQluwkV5k64TX7Krl4zAcP7-Qk7pSirmHuCJs/edit?usp=sharing Change-Id: Id6711f65ce3026c298b1b25d1b8a320b70adfdbe Bug: 1081617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2234546 Commit-Queue: Katie Dillon <kdillon@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#787427}
-
Jan Wilken Dörrie authored
This change adds a few more utilities for the string16 switch, makes CommandLine::AppendSwitchNative more generic, and removes further string16 usages in base/win. Bug: 911896 Change-Id: Id37a0c2b2c2c0e3eaafe30d4ec035f7d079fcb42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210580Reviewed-by:
-
Antonio Gomes authored
This CL exposes MediaStreamVideoTrack::CreateVideoTrack() through a helper method, to be used from content/renderer/pepper. No functionality change, but it will allow t_p/blink/public/web/modules/mediastream/media_stream_video_track.h to be moved out of the Blink API altogether. BUG=704136, 919293 R=guidou@chromium.org, haraken@chromium.org Change-Id: I284b245bc24e43de4c59c7d0f498472840782d31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292777Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#787425}
-
Matt Menke authored
URLFetcher and URLRequestStatus are deprecated and no longer used in production Chrome code, so code shouldn't be including those headers or using their constants. This CL also removes unused includes of url_request_context.h, url_request.h, cookie_manager.h, and a number of other net/ headers that shouldn't be used in the browser process, since the network code now runs out of process. Bug: 651119, 1010491 Change-Id: Id5963fbeb2f9fb4405fbebd6d8d09027b8df2f7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289912Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#787424}
-
Reilly Grant authored
This change finishes converting callbacks in the platform-specific Linux and Chromecast implementations of BluetoothAdapter and BluetoothDevice. There should be no functional change. Bug: 834319 Change-Id: I3abedefa4df23d79f803bd4cd2cc7252ee193386 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293156 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#787423}
-
Julian Pastarmov authored
These two new policies deprecate the old policies with less appropriate names. The old policies will still be used in the absence of the new ones for at least a few releases of Chrome. BUG=1095227,1095230 TBR=rohitrao,eugenebut Change-Id: Id1e5c0be5e5e2ed72547214f0669c0a2ae1440a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283163 Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#787422}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9af33fa208fb..8e404a7e4992 2020-07-10 kylixrd@chromium.org Added option to keep empty branches in rebase-update. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ie375d5a2408edcc8deb0afdbea33b52fe2a04c77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293056Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/27d352134c59..66ccc2b65ae8 2020-07-10 almuthanna@google.com Use strict equal to assert Console truncation scenario If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9eb0a71c536f31b82b0ebf47ca5581c0305ecfdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293335Reviewed-by:
-
Collin Baker authored
FeaturePromoBubbleView requires a ThemeProvider in its parent Widget. So, for TabGroupsIPHControllerTest to instantiate it the anchor view must be inside a Widget with a ThemeProvider. TestWidget used internally to ChromeViewsTestBase serves this purpose. This CL extracts it as ChromeTestWidget to be used elsewhere. TabGroupsIPHControllerTest uses this as the parent Widget. Bug: 1102655 Change-Id: Ib0d8a290789c1af1c08adb9fb6afc816ee2eeb90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289922 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#787419}
-
David Tseng authored
Previously, if a test did: this.newCallback(async function() {}); this.newCallback(async function() {}); the first call would immediately pass the test (and not decrement the expected number of callbacks). Correct this. R=anastasi@google.com AX-Relnotes: n/a Test: catches a ChromeVox test that instantiated a new MockFeedback (which creates a callback) that was never called. Change-Id: I158256031eb670b94be2918562d6dfafaa6819eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292854 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#787418}
-
Alexander Alekseev authored
This is first CL in series to make some viz debug flags dynamic. See the design document here: https://docs.google.com/document/d/1lWHJZK0LxLwN6y2YmPZTc0oTA-SXTo5PPM4OpieiI90/edit?usp=sharing Here we move some boolean debug flags from RenderSettings into a separate structure and add renderer API to modify them. Bug: 1085279 Change-Id: I802db6be7c1eb6dfe97dd4026547f7d7bb742eed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2234122Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#787417}
-
Donn Denman authored
Various updates to metrics recording for Contextual Search that are needed for the M85 experiments in progress. Some of the metrics are user actions that track the selection and how it is being adjusted. Existing actions that track manual adjusting of the selection was being done in the wrong part of the code making it not useful for the experiment that we need them for. Histograms for system resolve requests and responses are also added, along with a histogram for translation. Sometimes a histogram is used as a simple counter, but there doesn't seem to be a natural way to do that so a boolean histogram is used (with a signal that may not be very important). The new metrics entries are all in our UMA file, and they present a convenient bottleneck for future logging of selection adjustment for Smart Selection since it needs to know if the selection was adjusted by the system or the user. Metrics additions: UserAction: "ContextualSearch.SelectionEstablished" UserAction: "ContextualSearch.ManualRefineSingleWord" UserAction: "ContextualSearch.ManualRefineMultiWord" Histogram: "Search.ContextualSearch.SelectionExpanded" Histogram: "Search.ContextualSearch.ResolveRequested" Histogram: "Search.ContextualSearch.ResolveReceived" Histogram: "Search.ContextualSearch.TranslationNeeded" Also fix the logging of the CardTag. A regression caused the mapping from coca=>enum values to be called twice, which distorted the values. BUG = 1102670, 966203 Change-Id: I09f4941738e82c554f25ba9bfe0a7c417db9ba48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286480 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#787416}
-
Erik Chen authored
This CL is a refactor with no intended behavior change. Bug: 1104273 Change-Id: I3a17b8da6c2e61f8033b01b1d31dc1b5de84a91d TBR: dominickn@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293075 Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#787415}
-
Xing Liu authored
Download later dialog will be shown when these conditions are met: 1. Pref is enabled. 2. Not incognito. 3. Cellular network. Bug: 1099027,1078454 Change-Id: Ifdd8453c33d6ac647abd430a0183cec997b9d478 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276508 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#787414}
-
Tomasz Wiszkowski authored
This change replaces AutocompleteMatch 'subtype_identifier' with a set of 'subtypes', and ensures the entire set is accurately propagated back to GWS via AQS. Per offline discussion: - the order of the subtypes is irrelevant, so reordering items is okay. - the change ensures that any repeated subtypes appended by Chrome would be deduplicated if a corresponding subtype already exists. Bug: 1103056 Change-Id: I483f4ab4d64ab4e2af6f42de398c75c11bb7c360 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290754 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#787413}
-
Sammie Quon authored
This was previously animated after the main animation for performance reasons. With the improvements to overview, we think we run this animation at the same time as the window animation, and add it to the exit animation as well. Since we now need to animate removing clipping (clip rect = gfx::Rect()), this CL adds an observer which first animates the clip rect to the size of the layer, and the removes the clip. Otherwise the animation will contract hide everything before reshowing on the last frame. To help with this, windows with no clip in overview will have a clip the size of the window (visually equal to no clipping). This will avoid us changing to and from real no clip (clip = gfx::Rect()) which would make the logic more confusing and we would need to create more self deleting observers. Also refactors some logic so that this clipping, and the aspect ratio clipping (clips windows that will open in splitview so they have the same ratio as a splitview window), so they share more code. Test: manual Change-Id: I900f9a1801f9dd2e9847101e4c52d54f0ba41292 Fixed: 952158, 1103621 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277331 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#787412}
-
Sahir Vellani authored
Currently the device pixel content box for SVG elements is reported as the same as content box and border box. We change this to report the device pixel content box size as the bounding box in device pixels. Bug: 1088497 Change-Id: Iae78c49deb214b516792cefd751a09d57202f9c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240033 Commit-Queue: Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#787411}
-
Adam Ettenberger authored
Adding helper class VariantVector which can be populated similarly to an STL container but without the compile-time requirement of knowing what type will be stored. Internally represented as a vector of Scopedvariants with a uniform VARTYPE. - Can release ownership of its contents as either a Scalar VARIANT or, as a SAFEARRAY wrapped by a VARIANT. - When the vector is destructed, any remaining managed contents are released automatically. Also improving the ScopedVariant::Compare method to be able to handle some types that ::VarCmp cannot. e.g. VT_I1, VT_UI2, VT_UI4, VT_UI8, VT_UNKNOWN, VT_DISPATCH. Split out from : https://chromium-review.googlesource.com/c/chromium/src/+/2188057 Bug: 928948 AX-Relnotes: (Should not be user facing) Adjusted VARIANT comparisons to be more type-strict and adds support for a few previously unsupported VARTYPEs. Change-Id: I1e300bae6004ba17986643916e0a182f3e400da6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243839Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Adam Ettenberger <Adam.Ettenberger@microsoft.com> Cr-Commit-Position: refs/heads/master@{#787410}
-
Vikas Soni authored
Bug: 1031383 Change-Id: Iad752f19197fff7d351d360fc64f9c04380f1fc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293256Reviewed-by:
-
Xi Han authored
Bug: 1092931, 1104351 Change-Id: Id403d7836e40870357c4adee51e4796291ca04e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292127Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#787408}
-
Miriam Zimmerman authored
Feedback reports include a list of recent crashes, but only those that were already sent at the time the feedback report is generated. Since crash sender only runs periodically (rather than every time a crash happens) this results in feedback reports missing the most recent crashes, especially if the user is filing feedback because of that crash. To fix this, run crash_sender (and give it some time to finish) before getting the list of crashes. BUG=chromium:1096272 TEST=replaced crash_sender with script that logged and slept 15s; \ verified that UI did not hang on opening feedback window and that \ system log information was not available until after sender finished Change-Id: I49dcd776a266a4167f228ea89473d9a5cc3d3da1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258678 Commit-Queue: Miriam Zimmerman <mutexlox@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Ian Barkley-Yeung <iby@chromium.org> Cr-Commit-Position: refs/heads/master@{#787407}
-
Stefan Zager authored
This patch changes the numerical operations to match more closely the geometry code running in the renderer, to avoid rounding/precision errors. BUG=1092977 Change-Id: I1a8c887e07498813fcea31325745cb9a048c098b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290533 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#787406}
-
Erik Chen authored
This CL is a refactor with no intended behavior change. The API surface between lacros-chrome and ash-chrome is named crosapi. This allows a cleaner separation of code, since the word "lacros" will only be used by lacros-chrome, not ash-chrome. Bug: 1104273 Change-Id: I543ac6a44ab0d85c7f3cb672defcd73bcbba3066 TBR: kerrnel@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292995 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
-
David Schinazi authored
The QUIC netlog had not been updated when we changed how we handle versions and connection IDs. This broke searching by connection ID when using a version after 43. This CL fixes netlog to properly save connection IDs and versions. R=renjietang@chromium.org Change-Id: I8954a532df27770ae754d941f054324b650bef43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290468 Auto-Submit: David Schinazi <dschinazi@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Reviewed-by:
Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#787404}
-
Yaron Friedman authored
Fix: compare PS2 vs PS1. A conflicting refactoring went in at the same time. Original change: [Android R] Fix crash on tab restore with corrupt TabState. In the case where a corrupted tab state is created of a certain form (i.e. we map a 0-length byte buffer of contents state but don't hit EOF), getting the capacity in native of the empty ByteBuffer returns -1 causing us to construct an invalid Pickle and crash. Previously this would return 0 and would result in a failed tab restore / empty tab. https://android-review.googlesource.com/c/platform/art/+/1276315/ changed this in R. Update Chrome and a regression test. BUG=1094239 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290055Reviewed-by:
-
Adam Norberg authored
This includes a large, complicated test helper named StateChangeTestEngine. It's a callback-driven simulator that takes a vector of state change events (and how they should translate between Objective-C and C++), sends them as a sequence of state change events as the XPC client would see them, and also provides a state change client to make sure we get the expected states back out. This test is a smoke test for Update and for StateChangeTestEngine itself. Further unit tests will be implemented using these moving parts in upcoming CLs. Change-Id: I2b00e3c41a481714a59481fbd018cd6d2bb86460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268462Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Adam Norberg <norberg@google.com> Cr-Commit-Position: refs/heads/master@{#787402}
-
Evan Stade authored
The notifications don't outlast the browser, so this shouldn't have any compatibility implications. Bug: none Change-Id: Ic065497b65b14a924df9c679d6a8c01d48afe105 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291237Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#787401}
-
Lei Zhang authored
The 1-parameter version is simpler, and the 2-parameter version is deprecated. Bug: 1009837 Change-Id: I998cec68d2f27f7f6d12bfb10f70718aa1473e8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284357Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ca0adda2..6e90ebc7 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie4e5990c2cea30d05c4c887f38fcb2c5d4c7160d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292124Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#787399}
-
