GitLab

This is a re-land of an old CL, which was reverted in https://codereview.chromium.org/2977273002
due to a WebView issue. We believe the underlying issue may have been resolved, so should try
re-landing this.

Bug: 715699
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I0da6ab6f55d0fb4ba0760378f182217e8c4546c1
Reviewed-on: https://chromium-review.googlesource.com/1112387Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571143}

Also avoid a hop to get own clock via the RealTimeDomain.

Bug: 857101
Change-Id: I0433f8442b061ff2b2f33f839eb08719fb76bc5d
Reviewed-on: https://chromium-review.googlesource.com/1118267Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571142}

The returned status string is only for debug UI (about:sync-internals),
there's no reason why the Java side would have to know of it (and
accordingly, it was unused).

Bug: none
Change-Id: I84c33d32c426e05f9ec04516ca93d6775354548d
Reviewed-on: https://chromium-review.googlesource.com/1116705Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571141}

This is needed as the TraceWriters we create and keep in TLS
keep a reference to the SharedMemoryArbiter object that the
ProducerClient keeps, and during shutdown may still be
used after the ProducerClient previously got deleted.

R=hjd@chromium.org
BUG=844379

Change-Id: Ib27b59b48ce50f88f954618e7eee4f046b3029b7
Reviewed-on: https://chromium-review.googlesource.com/1117776Reviewed-by: Hector Dearman <hjd@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571140}

Recent table refactoring means we expose more layout tables. This is
generally a good thing.

It broke some accessibility in Hangouts, where there was a layout table
inside of an ARIA button and the accessible text of the button came from
inside the layout table. Previously the layout table was just exposed as
generic elements, and layout table roles should behave the same way with
regards to how text is exposed to ancestors.

Bug: 856277
Change-Id: I9b30931b306fda09a5408df4dc3b3dd1c54e619e
Reviewed-on: https://chromium-review.googlesource.com/1117628
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571139}

Bug: 836246
Change-Id: I6db06e859468e7ab4d19424a91d8a90bffa23a2e
Reviewed-on: https://chromium-review.googlesource.com/1070658
Commit-Queue: Bruno Kim Medeiros Cesar <brunokim@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571138}

Mocks:
https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZeqwFvuvKaZQ/files/MCGxzIhEyEZFkDOfw1G1Tu4Z

Bug: 827376
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I1206687fff441ec6be5a3bb9e6dddba7469f292b
Reviewed-on: https://chromium-review.googlesource.com/1100237
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571137}

Feature is landed in M66. Now we can remove the flag in M69.

Bug: 805046
Test: manual

Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Id98b066228f5f5b45d9d02d405bcc57d41fde20a
Reviewed-on: https://chromium-review.googlesource.com/1113097Reviewed-by: Mitsuru Oshima (OOO 6/27) <oshima@chromium.org>
Commit-Queue: Qiang Xu <warx@google.com>
Cr-Commit-Position: refs/heads/master@{#571136}

Move key_hit_test_cases into the rendering folder and refactor to
inherit from RenderingStory

Bug: 849392
Change-Id: Iecf8c273fb137b051ab51ee47f4020addef2548d
Reviewed-on: https://chromium-review.googlesource.com/1118279Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#571135}

In pathological cases, such as those provided in the relevant bug,
Zucchini could exhibit O(n^2) behavior during seed selection. To remedy
this, this CL adds a quota to limit the total number of bytes covered
in seed selection search. However, as demonstrated in CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1115710
this is insufficient. haungs@ determined that if this is the only
limitation then the ExtendEquivalenceBackward method will perform a
linear time extension resulting in O(n) behvior which when applied
over O(n) offsets results in O(n^2) behavior again. To limit this he
proposed limiting the distance ExtendEquivalenceBackward can search
which is also implemented in this CL.

These parameters are tuned such that they have no noticeable impact
when patching chrome.7z for Windows. For the pathological testcases in
the bug the results are significantly better (refer to the bug for
exact improvements).

This solution results in linear time performance on the pathological
cases. We could get these numbers down even smaller by reducing the
limit on backward extension. However, this had a small, but noticeable
~5 kiB increase in patches for chrome.7z.

Bug: 849471
Change-Id: If7e857884b00daeeae7a4a29b1236c749f0b84e4
Reviewed-on: https://chromium-review.googlesource.com/1117273
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571134}

It shouldn't be used as an API method, use DelayTillNextTask
method instead. The are intercahngable for RealTimeDomain but
NextScheduledRunTime disreards any additional logic which
might be defined in a DelayTillNextTask override.
So this change also makes it more semantically correct.

Bug: 857101
Change-Id: Ie6170312d7840a2acfe32e592fb2d799e4eaf0a7
Reviewed-on: https://chromium-review.googlesource.com/1118224Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571133}

https://boringssl.googlesource.com/boringssl/+log/6ff2ba80b758025fdb137d9357dcbba0a9c04dbf..fec83fc78d489a8d444c3a99c51101fdf54d5b71

BUG=none

Change-Id: I01a78a1b5e1d2d6fe8d8170306b9ddaee812649c
Reviewed-on: https://chromium-review.googlesource.com/1117607
Commit-Queue: Steven Valdez <svaldez@chromium.org>
Reviewed-by: Steven Valdez <svaldez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571132}

The previous version of this helper function incorrectly assumed that
the number of planes and the number of FDs in a GbmBuffer are always
the same, but they are not necessarily so. Note that this bug did not
affect any production code; it was only a bug in the unit test.

Bug: 851343
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I5db5a5d571fad24aa0fa0d73863f0157bf30f90f
Reviewed-on: https://chromium-review.googlesource.com/1116018
Commit-Queue: Sharif Elcott <selcott@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Pawel Osciak <posciak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571131}

replace std::find() with base::containsValue()
at components/certificate_transparency and components/policy
and components/feature_engagement

Bug: 561800
Change-Id: I481fcc85d3d0043301991f08be47d1280a2585df
Reviewed-on: https://chromium-review.googlesource.com/1114406
Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571130}

The PeerConnectionTracker logs events relating to an RTCPeerConnection
(APIs called, events firing, tracks added or removed) and lists them in
chrome://webrtc-internals.

Ever since the days of addStream()/removeStream(), the tracker has
listed a local or remote stream being added or removed as an event.
These APIs are no longer in the spec and are in fact implemented on top
of the spec-compliant addTrack()/removeTrack().

Prior to this CL, the tracker reported a stream being added by any means
as "addStream" and removed as "removeStream", which is misleading
because they may have been added through other APIs.

In preparation for Unified Plan, which expresses media sections in terms
of transceivers (sender-receiver pairs), the PeerConnectionTracker is
updated to more accurately express what is going on. In Unified Plan you
may for example add a transceiver that does not have a track yet or
receive a track by reusing an already existing transceiver. You may also
send the same track multiple times, or send/receive tracks that don't
belong to any stream or that belongs to multiple streams. This is all
described by the sender/receiver, not by any set of "local" or "remote
streams". In Unified Plan, because receiving tracks are created
alongside transceivers, often before being used if ever used, speaking
of tracks being "added" or "removed" is confusing.

Instead of "addStream"/"removeStream" we get
"[sender/receiver/transceiver][Added/Modified/Removed]".
The chrome://webrtc-internals log shows state of the sender or receiver
(TODO: or in Unified Plan, the transceiver) that was added, updated or
removed.

This will continue to make sense moving forward, and removes the
dependency on streams, which is a RTCRtpTransceiver blocker because
Unified Plan uses stream IDs, not streams.

Bug: 810708, 777617
Change-Id: I47dad2cb0b754c4ab8fb47ca5c7da3e0f33c6072
Reviewed-on: https://chromium-review.googlesource.com/1117063Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571129}

Using wpt-import in Chromium f67bbacc.
With Chromium commits locally applied on WPT:
ab4fb5ca "Update links to feature policy documentation."


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/20297

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

TBR=markdittmer

No-Export: true
Change-Id: I79984ede877feafd838921daa2af13167f4acde5
Reviewed-on: https://chromium-review.googlesource.com/1118015
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571128}

When this flag is specified (e.g. in tryjob retry without patch &
FindIt), the test runner doesn't fail if no tests are run (e.g. because
of an empty test list). Previously, the runner would still exit early
and produce no artifacts in such case. This CL changes the behaviour to
keep executing and produce valid empty (*) test result JSONs.

* Caveat: the JSONs aren't really empty; they still contain a list of
WONTFIX (and hence skipped) tests because of implementation details.

Bug: 851639
Change-Id: Idfc990263e130bc02dc441bc0d375a149e8b44d3
Reviewed-on: https://chromium-review.googlesource.com/1117623Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571127}

This CL increases CheckableImageView size specified in
checkable_image_view_widget.xml to match the size of standard checkbox
widget and fix alignment.

Bug: 857267
Change-Id: I6beb61a6d7d27092b3a491b3e8e2c9ee962f69ae
Reviewed-on: https://chromium-review.googlesource.com/1118272Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571126}

This reverts commit ccd4ec08.

Reason for revert: multiple tests failing on https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20(dbg)(1)(32)/50984

UpdateServiceTest.UninstallExtensionWhileUpdating
PolicyUpdateServiceTest.PolicyCorruptedOnStartup
PolicyUpdateServiceTest.FailedUpdateRetries
UpdateServiceTest.TwoUpdateCheckErrors
UpdateServiceTest.UpdateCheckError
UpdateServiceTest.SuccessfulUpdate
ComponentUpdaterPolicyTest.EnabledComponentUpdates
PolicyUpdateServiceTest.Backoff
UpdateServiceTest.PolicyCorrupted
UpdateServiceTest.NoUpdate

[5637:5892:0628/072239.370548:FATAL:http_request_headers.cc(129)] "POST /pinghost/service/ping HTTP/1.1" is missing colon delimiter.
 


Original change's description:
> Migrate client_update::SendProtocolRequest to SimpleURLLoader
> 
> URLFetcher et al will stop working in the browser process with advent
> of Network Service, and SimpleURLLoader is the replacement API
> for most clients. CL migrates SendProtocolRequest to the new API.
> 
> Major remarks:
> 
> * URLRequestPostInterceptor is replaced by URLLoaderPostInterceptor although the public APIs
> of the former is kept (are almost the same) in the later. This allows the extensive set of unit
> tests to remain untouched. The replacement is needed because URLRequestPostInterceptor used
> to intercept requests instantiated by URLFetcher, precisely the class we are moving away to use.
> 
> * URLLoaderPostInterceptor operates in two modes: it supports working both with TestURLLoaderFactory
> and EmbeddedTestServer. Two constructors are offered that control the 'mode' it operates on.
> This is needed because of the nature of the tests: some tests manipulate the TestConfigurator
> directly, hence the needed SharedURLLoaderFactory instance can be acquired directly from it,
> eg PingManagerTest, UpdateCheckerTest and RequestSenderTest.
> Some other tests, trigger the respective SimpleURLLoader machinery from upper layers, and then
> have no access to TestConfigurator instances. In such cases, URLLoaderPostInterceptor operates
> using EmbeddedTestServer in order to intercept URL loads.
> 
> Note that this CL migrates components/update_client/utils.cc|h to SimpleURLLoader, but there
> some other classes on the same directory that still use URLFetcher (eg UrlFetcherDownloader),
> so we simply can not *yet* remove all the references to URLFetcher and URLRequestContextGetter.
> It will be done in a follow up CL.
> 
> BUG=773295,844973
> 
> Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
> Change-Id: I3d8be368818ba77b559907c0217995f8c6a95b04
> Reviewed-on: https://chromium-review.googlesource.com/1097337
> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
> Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
> Reviewed-by: Sorin Jianu <sorin@chromium.org>
> Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
> Reviewed-by: David Roger <droger@chromium.org>
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#571097}

TBR=droger@chromium.org,rdevlin.cronin@chromium.org,mmenke@chromium.org,sorin@chromium.org,emaxx@chromium.org,tonikitoo@igalia.com,mxnguyen@chromium.org

Change-Id: I0974aeef814ac153bf7da86ebf3e2f09b410bdd6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 773295, 844973
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Reviewed-on: https://chromium-review.googlesource.com/1118585Reviewed-by: Olga Sharonova <olka@chromium.org>
Commit-Queue: Olga Sharonova <olka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571125}

Extensions may be whitelisted to suppress the zoom bubble when
performing an extension initiated zoom (e.g. the PDF viewer). However,
this also suppressed updates to the zoom bubble if it was already
being shown.

We now update the zoom bubble (if it exists) in this case.

Bug: 817278
Change-Id: Ia746f25de2760e8349a1ec3d3f4c899392d0fc81
Reviewed-on: https://chromium-review.googlesource.com/1086153Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571124}

So far, all instances of this missing selector crash linked in the bug have
come from 10.10.0, but my copy of 10.10 has it. This change checks
`respondsToSelector:`, instead of OS version, before calling SPI.

Bug: 856211
Change-Id: Ib2aa07e0e24b83f1766a2f6e16e19b2b123970a6
Reviewed-on: https://chromium-review.googlesource.com/1115781Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571123}

Bug: 753924
Change-Id: I4656a4f3d409bb6aada86654f675dc0e51cb93d2
Reviewed-on: https://chromium-review.googlesource.com/1117601Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571122}

A new Clang version caught this.

TBR=wangxianzhu

Bug: 857393
Change-Id: Ib3d9d7c0bd67d9b2deed699662de91e75ee47694
Reviewed-on: https://chromium-review.googlesource.com/1118380Reviewed-by: Hans Wennborg <hans@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571121}

IdentityProvider currently has baked-in knowledge of OAuth2TokenService
for functionality that is shared between ProfileIdentityProvider and
DeviceIdentityProvider. However, as we will be converting
ProfileIdentityProvider to talk to IdentityManager rather than
OAuth2TokenService, this baked-in knowledge needs to be moved out of
IdentityProvider; ultimately, it will end up only in
DeviceIdentityProvider.

This CL takes a step along that path by moving the IdentityProvider
method implementations that interact with access tokens into the two
derived classes, making fetching and invalidating access tokens virtual
methods of IdentityProvider.

TBR=pastaramovj@chromium.org

Bug: 809452
Change-Id: I7b80f54d783dfa4de3236aec46c663bbfcb92422
Reviewed-on: https://chromium-review.googlesource.com/1114611
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571120}

The experiment expired a year ago, so we presumably don't need to keep
it around.

Bug: None
Change-Id: Ie8ad4237aea5e4dadbaf9b9a1b7a8439829645d9
Reviewed-on: https://chromium-review.googlesource.com/1117024Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571119}

Noticed while preparing
https://chromium-review.googlesource.com/c/chromium/src/+/1113548: this
test currently does not test what it is intended to. It is intended to
test that when an ongoing access token request is fulfilled with an
expired token, GCMAccountTracker notices that the token is no longer
valid and marks the account as needing a token request. However, the
current structure of the test prevents any access token request ever
being made for the newly-added account: the account is added when the
driver isn't connected, in which case GCMAccountTracker doesn't make
access token requests. Hence, the test passes even if the call to
IssueExpiredAccessToken() is replaced by a call to IssueAccessToken().

This CL changes the test to match its intention: we add the account
with the driver connected and check that the request was started, then
disconnect the driver before fulfilling the request (so that another
token request isn't made immediately), and *then* check that a new
token request is now marked as being needed. In particular, the test
now fails if the replacement mentioned in the previous paragraph is
made.

Bug: 809923
Change-Id: Idc2458d4a0d8e9e702ac8a61cdff9ad138e16fa3
Reviewed-on: https://chromium-review.googlesource.com/1113677
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571118}

This is a reland of 30184c71

Original change's description:
> Add a test helper method in services/network to get the body from a ResourceRequest.
> 
> Also remove the custom URLLoaderFactory in content_hash_fetcher_unittest. This isn't needed anymore as TestURLLoaderFactory now supports Clone.
> 
> Cq-Include-Trybots: luci.chromium.try:linux_mojo
> Change-Id: Id70ec605886a6b0f2cb9bf7392fac4eff85fc1b3
> Reviewed-on: https://chromium-review.googlesource.com/1115346
> Reviewed-by: Doug Turner <dougt@chromium.org>
> Commit-Queue: John Abd-El-Malek <jam@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#570813}

Change-Id: If27653a4cc7e94d7f44b02f9eb790e2a46949cc4
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/1118438Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571117}

The test has been previously disabled (skipped) on Windows due to
recurrent timeouts. Running the test locally leads to an average of ~
3.7 sec runtime on a high-performance Windows 10 rig (Z840). The test is
not skipped on Linux right now, but since its runtime exceeds the 2 sec
rule of thumb (from the comments in SlowTests), this CL will make it
slow on Linux as well.

Bug: 850964
Change-Id: Ib478c0f59313da4302325578d9b768e1070bdcb6
Reviewed-on: https://chromium-review.googlesource.com/1115214Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571116}

https://skia.googlesource.com/skia.git/+log/0ce5ab9d3122..385804514edf


git log 0ce5ab9d3122..385804514edf --date=short --no-merges --format='%ad %ae %s'
2018-06-28 robertphillips@google.com Revert "Remove drawTextBlob from device use drawGlyphRunList"
2018-06-28 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files
2018-06-28 herb@google.com Remove drawTextBlob from device use drawGlyphRunList


Created with:
  gclient setdep -r src/third_party/skia@385804514edf

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jcgregorio@chromium.org

Change-Id: I3fdc9150792c2f951218ab3332f70c627254e283
Reviewed-on: https://chromium-review.googlesource.com/1117945Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#571115}

Many of the uses are of page allocator, which can just be used directly. partition_alloc.h
previously included wtf.h but did not use it; removing this required adding it to various
source files which were using IsMainThread but not including the appropriate header.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I9ee136ed2396b83639b99224e6aaf0622ef12e3a
Reviewed-on: https://chromium-review.googlesource.com/1115500Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571114}

https://chromium.googlesource.com/angle/angle.git/+log/26581113047a..a26de2500503


git log 26581113047a..a26de2500503 --date=short --no-merges --format='%ad %ae %s'
2018-06-28 lucferron@chromium.org Vulkan: Enable dEQP a passing test in buffer.write
2018-06-28 lucferron@chromium.org Vulkan: Enable the remaining dEQP fbo.render tests


Created with:
  gclient setdep -r src/third_party/angle@a26de2500503

The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ynovikov@chromium.org

Change-Id: I8ee418f33f09f274cb4267c8e533ae51f09ea00e
Reviewed-on: https://chromium-review.googlesource.com/1117947Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#571113}

Bug: 807724
Change-Id: I51a758649dc72cc4835311264d883e0acac98a42
Reviewed-on: https://chromium-review.googlesource.com/1117035Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571112}

This CL adds accessibility traits to the toolbars such as they are
acting as VoiceOver "container". If the user sets the accessibility
rotor to "containers", the user is able to go navigate quickly between
the toolbars and the webpage.

Bug: 856212
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I309a1308bb200bf9f90aaa4b164a3798c93c0f31
Reviewed-on: https://chromium-review.googlesource.com/1118275Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571111}

The new State encompasses (and should eventually largely replace) the
following state getters:
- CanSyncStart
- IsEngineInitialized
- GetAuthError
- IsFirstSetupComplete
- HasUnrecoverableError
- IsSyncActive
- ConfigurationDone

Other SyncService state that it *not* packed into the enum:
- Setup in progress
- Encryption
- Anything that's per-ModelType
- Local Sync

Bug: 839834
Change-Id: Iec1c3d744ffcb33fceccfe0bb0d028cc17203655
Reviewed-on: https://chromium-review.googlesource.com/1102331
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571110}

The URL and security state are read first. The next accessible
element is the share button.

Bug: 821808
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I0416aae221309f3202b2e1644b55b6755e88fbfd
Reviewed-on: https://chromium-review.googlesource.com/1112010
Commit-Queue: Elodie Banel <lod@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571109}

Prior to a refactoring in crbug.com/827334,
NewTabPageView#onAttachedToWindow used to update the search box scroll
position which is used by ToolbarPhone to determine location bar properties.
In the refactoring, this logic moved to NewTabPageLayout#onAttachedToWindow.
This method, however, is not always guaranteed to be called when the NTP is
refocused because the NTPLayout may be scrolled off screen and not
immediately bound to a RecyclerView ViewHolder.

This CL re-introduces NewTabPageView#onAttachedToWindow, ensuring
ToolbarPhone is properly notified of the current NTP scroll position
when the NTP is refocused.

BUG=856936

Change-Id: Iefa82aff60cd1e60a2787734c93793e5e50a65f4
Reviewed-on: https://chromium-review.googlesource.com/1117860Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571108}

Each v8::Context is wired with a ScriptState, and it clears the
self-reference of ScriptState at its termination.
In worker threads, it means that ScriptState is kept alive until
terminating v8::Isolate, although ScriptState is not used after
disposing global scope.

This CL explicitly does tasks in weak callback registered in v8::Context
at disposing global scope. Actual tasks are (1)to clear self-persistent
of ScriptState and (2)to drop a weak reference from ScriptState to
v8::Context.
This change makes it possible to release ScriptState at anytime before
v8::Isolate termination.


Bug: 773605
Change-Id: I9da5052c035a0b56dd47a6305df89809b05408a7
Reviewed-on: https://chromium-review.googlesource.com/1117976
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571107}

Following bot results are included.
7278 7285

0 lines were removed and 0 lines were deflaked by consecutive
results since 7194.

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: If4116f789a84eab78272c231cad0c3aff7166569
Reviewed-on: https://chromium-review.googlesource.com/1118095
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571106}

This reverts commit 0c2015e1.

Reason for revert: This CL isn't actually disabling the test.

Original change's description:
> Disable WebStateTest.MessageFromIFrame test.
> 
> TBR=eugenebut@chromium.org
> 
> Bug: 857129
> Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
> Change-Id: I407a6464e71296cc15eef43bf7ed2a8ca8181909
> Reviewed-on: https://chromium-review.googlesource.com/1117300
> Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
> Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#570882}

TBR=eugenebut@chromium.org,michaeldo@chromium.org

Change-Id: I444e4e1b224685b63cee4f2a672066bfeca8983f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 857129
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Reviewed-on: https://chromium-review.googlesource.com/1118319Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571105}

Decreased top inset from 5 to 4 px. With 5 px, the top of the omnibox was 1 pixel higher than the top of the location bar.

Bug: 857068
Change-Id: Id1ea4601aed65f62fffccd05deac5dcbeab8d0d5
Reviewed-on: https://chromium-review.googlesource.com/1117642
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571104}