GitLab

These are still needed to track DWrite stability and work in progress
related to font src: local() matching.

Change-Id: I522adb5773bdaf50a749c61daefcc0e821a4e4b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642631
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Auto-Submit: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666063}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/29e2ec5aa31e..002d0e113a3b


Created with:
  gclient setdep -r src-internal@002d0e113a3b

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome

BUG=chromium:961548
TBR=harringtond@google.com,orphis@google.com,shend@google.com

Change-Id: Ibfa808277f2c1241d3a7732ebfd4f57eb5d98388
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643900Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#666062}

If the input is invalid UTF-8, both GetHFSDecomposedForm and
CFStringStringCreateWithBytesNoCopy will fail, the latter returning
nullptr. This nullptr is then dereferenced, creating the crash from the
bug. If this occurs, we fallback to strcmp, since case won't be
meaningfully defined for invalid UTF-8.

Bug: 960873
Change-Id: I50c551a5687e26fb777a8005b14e7f261051630f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627656Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666061}

See crrev.com/c/1590404 and the linked bug for context -- the goal is to
fix the broken memory-leak checking in Chromium's ASAN
(AddressSanitizer) trybots, which are supposed to also run LSAN
(LeakSanitizer).

Currently-leaking tests must be fixed or disabled before leak checking
can be enabled in the ASAN trybot.

WARNING: This will result in a loss of ASAN coverage for the affected
tests given that LSAN runs as part of the ASAN trybot.

If that's not acceptable, we can wait until the leaks are fixed before
fixing leak detection in trybots, but keep in mind that newly-introduced
leaks Chromium-wide won't be caught until then.

Bug: 960985,969555
Change-Id: I1971900a4cc893d3ef79491c2550b95e16c6802a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636863Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Caleb Raitto <caraitto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666060}

See crrev.com/c/1590404 and the linked bug for context -- the goal is to
fix the broken memory-leak checking in Chromium's ASAN
(AddressSanitizer) trybots, which are supposed to also run LSAN
(LeakSanitizer).

Currently-leaking tests must be fixed or disabled before leak checking
can be enabled in the ASAN trybot.

WARNING: This will result in a loss of ASAN coverage for the affected
tests given that LSAN runs as part of the ASAN trybot.

If that's not acceptable, we can wait until the leaks are fixed before
fixing leak detection in trybots, but keep in mind that newly-introduced
leaks Chromium-wide won't be caught until then.

Bug: 961023
Change-Id: I1899fbea3d1ce8288c954c97d4d486bd3cda3371
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638818
Commit-Queue: Caleb Raitto <caraitto@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Patrick Noland <pnoland@chromium.org>
Reviewed-by: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666059}

TBR=mkwst@chromium.org

Bug: 970334
Change-Id: I10c31612c6623d50382f485fd26845a2f4c8faa1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643498Reviewed-by: Dan H <harringtond@chromium.org>
Commit-Queue: Dan H <harringtond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666058}

Delete myself from various OWNERS files. Also delete my
entries from WATCHLISTS and delete an old TODO.

Bug: none
Change-Id: Id226c2eb8ecf2aebe1c9dd2008f52de5f2050a34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643400
Commit-Queue: Dan Erat <derat@chromium.org>
Auto-Submit: Dan Erat <derat@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666057}

WPTs have not yet been updated to new spec requirement of expecting
"script timeout" when a script times out, resulting in failures that
actually adhere to the living spec.

Change-Id: Idc7543d01bb1fd83693240e74920bd3f48d5e6d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643839Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Rohan Pavone <rohpavone@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666056}

The test appears to already be enabled everywhere without generating
complaints about flakiness, and the MAYBE definition isn't used.

Bug: 806684
Change-Id: I02b61b79cfce047be4c021401f41298f9d1aef3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642673
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Auto-Submit: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666055}

The present CL moves ShowAppCannotSnapToast() from split_view_controller
to split_view_utils. The latter is a much more natural choice, because
the function is used outside split_view_controller, it does not use
anything inside split_view_controller, and it goes hand in hand with
CanSnapInSplitview() which is already in split_view_utils.

Test: manual
Bug: 970013
Change-Id: I6bd4e2044a0622d5604adbb287045befcdf20eaa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639666Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Avery Musbach <amusbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666054}

CI/CQ builders migrated:
- Chromium Mac 10.13 / mac_chromium_10.13_rel_ng
- Mac ASAN Release
- Mac ASAN Release Media
- Mac ASan 64 Builder / mac_chromium_asan_rel_ng
- WebKit Mac10.13 (retina) / mac10.13_retina-blink-rel
- Libfuzzer Upload Mac ASan
- Site Isolation Android
- Android CFI / android_cfi_rel_ng
- Android x64 Builder (dbg) / android_compile_x64_dbg
- Android x86 Builder (dbg) / android_compile_x86_dbg
- Mojo Android / android_mojo
- Android WebView L (dbg)
- Android WebView M (dbg)
- Android WebView N (dbg) / android_unswarmed_pixel_aosp
- Android WebView O (dbg)
- Android WebView O NetworkService (dbg)

Bug: 950413
Change-Id: I2f08995a73a6d03ff9031a3833002cd717ca98fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642854Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Simon Que <sque@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666053}

Removes circular background behind Messages badge that existed when
it was selected. Removes methods that only serve to toggle the selected
state of the badge.

Change-Id: I255b98290223c955d24abf4cf44aef7dabb36225
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637592Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666052}

Bug: 968296
Change-Id: I893b369b466545e83a91a530e3b44be967934734
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644010
Auto-Submit: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666051}

This patch rolls the third_party/openscreen repository to include
changes to build macros, fixing the build inside Chromium.

Change-Id: I7418da93ea222383b98ab074c1e5b1d627e76db7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643890
Commit-Queue: Jordan Bayles <jophba@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Auto-Submit: Jordan Bayles <jophba@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666050}

Change-Id: Id6a310cf1f9b956a558f13c18d0553429928e02d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642162Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Matt Mueller <mattm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666049}

Navigations to a MimeHandlerView type could finish without calling
ReadyToCommitNavigation which is when MimeHandlerViewEmbedder sets
its |render_frame_host_| reference (e.g., due to FrameTreeNode
being removed mid navigation). This adds a null check to the
DidFinishNavigation override to avoid browser crashes.

Bug: 969840
Change-Id: I2aa595a9a444cb77c10d124e6e345505b76cc81c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643092
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666048}

Also adds them to a test to confirm they execute. The test is not rigid
enough to check for correctness at the moment (due to lack of helpers),
but will be expanded in future CLs.

Bug: 922813
Change-Id: I0f8c6c1cb4a9f2f5290a1244deca9b80d970f039
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629168
Commit-Queue: ericale <ericale@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666047}

Change-Id: I2b8690fed52d7751027d280d53091b93ddd7e80e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618267
Commit-Queue: Cathy Li <chili@chromium.org>
Reviewed-by: Kristi Park <kristipark@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666046}

When Launcher is closed when embedded Assistant Ui visible, need to
reset the model AppListState to make it consistent with the
assistant_ui_controller state.

Bug: 970039
Test: manual
Change-Id: Iab119f3267d62a5eb3a4f2456e1c14c7e38ba0d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642963Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666045}

Selecting remove will remove last navigation from history and switch
last button to Google logo.
The logic is implemented by remembering timestamp of last removed
history entry in SharedPreferences. Only History items with later
timestamp are displayed on last tab button.

BUG=959317
R=wylieb@chromium.org

Change-Id: I8e67afca631bbc233d90f34791eff146bc1f37dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644155Reviewed-by: Brandon Wylie <wylieb@chromium.org>
Commit-Queue: Pavel Yatsuk <pavely@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666044}

This CL offloads majority of mojo methods in VoiceInteractionController.
The new public ash::VoiceInteractionController can do the same
tasks.

The mojom file and VoiceInteractionObserver interfaces should
continue to exist, since it's used in chromeos/services/assistant,
which would eventually want the accesses through mojo. But many
mathods in the VoiceInteractionController are for the controls
from chrome, which doesn't have to be mojo anymore. This will
simplify some interfaces.

TBR=xiaohuic@chromium.org

Bug: 958224
Test: trybot
Change-Id: I1768e51986120799d5bb034151eced5e3341a72e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637943Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666043}

The term "bridge" was proliferating to the point of not having any
meaning. Now it refers specifically to the
remote_cocoa::NativeWidgetNSWindowBridge class.

The term "impl" was unwise. Extirpate.

Prefer the term "in process" instead of "local".

Use GetNSWindowMojo() to refer to "get the mojo interface to the
NSWindow, wherever it may happen to live" function.

List of renames is:

NativeWidgetMac:
  bridge()      -> GetNSWindowMojo()
  bridge_impl() -> GetInProcessNSWindowBridge()
  bridge_host() -> GetNSWindowHost()
  bridge_host_  -> ns_window_host_

NativeWidgetMacNSWindowHost:
  bridge_impl()          -> GetInProcessNSWindowBridge()
  bridge_impl_           -> in_process_ns_window_bridge_
  bridge()               -> GetNSWindowMojo()
  bridge_ptr_            -> remote_ns_window_ptr_
  host_mojo_binding_     -> remote_ns_window_host_binding_
  CreateLocalBridge()    -> CreateInProcessNSWindowBridge()
  CreateRemoteBridge()   -> CreateRemoteNSWindow()
  GetLocalNSWindow()     -> GetInProcessNSWindow()
  local_window_          -> in_process_ns_window_
  local_view_id_mapping_ -> in_process_view_id_mapping_

TBR=ellyjones

Bug: 958255
Change-Id: Ic2bc28f006832a2f62c2d0369c2f85631b350544
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642988Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666042}

This is required for input tracing once some input traces are
asynchronous.

TEST=Locally in context of other CLs + unit test
BUG=b/132709527

Change-Id: I9c35c27433ba1cce838ce30a6a6e2ebae05d194a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642490Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666041}

Bug: 968065, 968085
Change-Id: If205092b52b72d3aff7cda35005a32f74d93444d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641362Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666040}

Make use of acquire memory order to obtain the hash set to ensure its
internal fields have properly initialized values.

BUG=968801

Change-Id: Id93aed0a76ec559a5fe92b4443a94367fafaf2ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643894Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666039}

https://chromium.googlesource.com/catapult.git/+log/f8aef9991ba9..dd7a2ceeb49e


git log f8aef9991ba9..dd7a2ceeb49e --date=short --no-merges --format='%ad %ae %s'
2019-06-04 khokhlov@google.com Fix metadata writing in protobuf format


Created with:
  gclient setdep -r src/third_party/catapult@dd7a2ceeb49e

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:944418
TBR=charliea@google.com

Change-Id: Ic79df1f4b48656d231040f2896dab9ebf45c3a6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643319Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#666038}

Grid - Remove unused injected ToolbarManager.
Toolbar - Remove unused code and duplicate condition check.

Change-Id: I24d148fca7dc20b9251a041939e7b914bfcb3694
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627696Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Matt Simmons <mattsimmons@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666037}

This adds a new browsertest which adds a hook into the feedback uploader
to catch it right before it does the actual report upload. This ensures
that clicking on the button to send a feedback report actually results
in the report getting queued to be sent. This covers a regression case
which is in crbug.com/954563.

Bug: 955039, 954563
Test: Browser tests pass, fail if prior regression was put back
Change-Id: I92762c1b6741ad057e78c8cafeb924f93995b249
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632534
Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666036}

This reverts commit f3d36175.

Reason for revert: The bug thought to be caused by this change was actually caused by crbug.com/966345 and fixed in https://chromium-review.googlesource.com/c/chromium/src/+/1636226/.

Original change's description:
> Revert "webvtt: Add background opacity in mac"
> 
> This reverts commit 8e606757.
> 
> Reason for revert: Caused crbug.com/964244
> 
> Original change's description:
> > webvtt: Add background opacity in mac
> >
> > To test, open a video that has a WebVTT captions file. For example, https://www.iandevlin.com/html5test/webvtt/html5-video-webvtt-sample.html is a nice example.
> >
> > Introduce new background opacity text track property for webvtt captions and wire it to apply opacity to the WebVTT caption HTML element.
> >
> > Bug: 897730
> > Change-Id: Ic8dabc2279117b7ff12eb75a9daa8d26c9d9bb25
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592622
> > Commit-Queue: Abigail Klein <abigailbklein@google.com>
> > Auto-Submit: Abigail Klein <abigailbklein@google.com>
> > Reviewed-by: Avi Drissman <avi@chromium.org>
> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#659116}
> 
> Bug: 964244
> Change-Id: I76ce88cee600ed98d48426b49d1d88a40d95e507
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622433
> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
> Auto-Submit: Abigail Klein <abigailbklein@google.com>
> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#662163}

TBR=ellyjones@chromium.org,abigailbklein@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 964244
Change-Id: Ib14f2e59e1b84525382b207131258a46c9a18cb4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643927Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Abigail Klein <abigailbklein@google.com>
Cr-Commit-Position: refs/heads/master@{#666035}

Tbr: boliu@chromium.org, dvadym@chromium.org, bengr@chromium.org
Bug: 908139
Change-Id: I1b816b24c1a6a4d3813ae392348eaa9974151845
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631749
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666034}

Obtaining the sign in state from the handler does not work in incognito
mode or in other cases where both Dice and Mirror are disabled. Continue
to request the Print to Google Drive destination from the cloud print
server on every load for this case, and also query the server for
printers when the sign in tab closes, instead of waiting for updates to
the cookie jar (since these do not occur in incognito mode).

This CL restores much of the code that was removed in
https://crrev.com/c/1626933 for the incognito case.

Bug: 970036
Change-Id: I7265beb11ed68c8b4d1cc4959561e63688ff8ebe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639665Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666033}

Bug: 969204
Change-Id: I0f7c3d0a4dee0c6debd09ddc6ea67587dd744cbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639639
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666032}

Switch from "Wake Lock is being released" to "Wake Lock released" to make it
less confusing. The former can sound like the lock is still being released
by the time the message can be inspected, while the latter indicates this is
an operation that has been completed and cannot be reversed.

Bug: 257511
Change-Id: I8b0d3b749d404031d2e23da4050988c733be6689
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643471
Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#666031}

Change schedule of the notification so the deadline takes place between
2am and 4am local time.

Bug: 968188
Change-Id: Ie55e9f50cf365ef384fd3c7d9faaef6a0886ab91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635252
Commit-Queue: Roman Aleksandrov <raleksandrov@google.com>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666030}

This UMA has been falling over time but there are still significant
differences in how streaming media is handled, and therefore it remains
useful to measure.

Bug: 969990
Change-Id: Ib047bd320e2d77dd2018ac03f55d8c37efe24b39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642387Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666029}

The fix for crrev.com/641485 only saved off the event for redispatch
in a single situation where it wasn't handled. This was too
conservative, and didn't address cmd+C and cmd+V.

Save off the event for redispatch whenever it is unhandled.

Bug: 964052
Change-Id: Iaa9b8d747e396aa1f0a3144c83400ae73dd44a80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643732Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666028}

In |ShelfWidget|, override |OnNativeWidgetActivationChanged| instead of
|OnWidgetActivationChanged|. This achieves the same purpose, is more
consistent with what |StatusAreaWidget| does, and avoids the need to
add/remove widget observers.

Note that this doesn't directly fix the linked bug but is a step in the
right direction. No behavior change is expected from this change.

Bug: 956080
Change-Id: Id4002b30197a5d6a97baccaaf1a912db39c45e9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643413Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666027}

The directory layout is reworked. public/internal files now live in
public/internal subdirectories.

The root directory contains files belong to chrome and build target
used to include the internal library.

Bug: 966535
Change-Id: Ib53a3e3696b381cc989278e9c13fd015c82da053
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639359
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666026}

The UMA was added to get data on how often we need to serialize ops >
512k and what the size distribution for these ops looks like. The data
from stable channels puts it at ~0.4 ops per million tiles, and even in
those cases ~85% of them fit within 600k and only 0.01% of the cases
exceeded the max limit of 16M. So it looks like this is enough of an
edge case that the current solution for reallocation on a serialization
failure is good enough.

This change removes the UMA since its no longer needed and increments the
default size we begin with to 600k so the common cases require minimum
reallocations.

R=enne@chromium.org, piman@chromium.org

Change-Id: I022ead6728c2b0a04bc898db892d3ccc4ac5d0e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641810
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666025}

Original CL description:

Implement AppLaunchManager for controlling app-under-test for EG2 tests.

No tests are added to smoke_egtest to test app relaunching, as it descends
from ChromeTestCase, which currently has logic which is required to run
every time the app-under-test is launched. Long-term, it is preferred if
this logic is moved to -setUp and executing before every test method. This
refactor will happen in a later CL as it requires some planning.

Confirmed that smoke_egtest does however only launch the app once with the
change to use AppLaunchManager.

Bug: 922813
Change-Id: I02d7e65cb47d86c35c09d049bc628c0220b4adb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641468Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: ericale <ericale@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666024}