- 06 Jan, 2020 40 commits
-
-
Tobias Sargeant authored
This paves the way to unfork the weblayer MinidumpUploader, which splits MinidumpUploadCallable into two classes, one of which is responsible for uploading a single minidump. Unfortunately that causes a naming collision; resolve it in favour of renaming the minidump_uploader class, which is responsible for managing the upload of multiple minidumps as a JobService job. Bug: 1029724 Test: run_webview_instrumentation_test_apk -f \ Test: 'org.chromium.android_webview.test.services.MinidumpUploadJobTest#*' Test: run_chrome_public_test_apk -f \ Test: 'org.chromium.components.minidump_uploader.*#*' Change-Id: Ib82dd334e77ee0e60a3c35a0d2f8bd38cfb6ed3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975881 Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Anna Malova <amalova@chromium.org> Cr-Commit-Position: refs/heads/master@{#728489}
-
Monica Basta authored
This CL is part of the profile info cache refactoring project. Bug: 305720 Change-Id: I70c4642227b9cf39ee71db983ea987bbde79d1fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985777Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#728488}
-
Monica Basta authored
This CL adds a check on the |FetchImage| request state before overriding the account image stored in the |AccountTrackerService|. We should not override the image with an empty image in case of failure to re-fetch the image in one of the 24 hours update interval. Bug: 1037865 Change-Id: Ia78cf1d04791711a74f4f8fccb7a1ad53de2004d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985765Reviewed-by:
-
Gauthier Ambard authored
When the layout of the NTP is invalidated because the search engine has changed, the Collection View needs to be scrolled so the header is correctly resized and positioned. Fixed: 1025694 Change-Id: Id64d421b07b9c55c640c77740bacd813c6ab5ef2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985778 Auto-Submit: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#728486}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8dd0c7f8. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I1466c595364ae6f865b87c92e3488b860c2e3280 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988285Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728485}
-
Colin Blundell authored
It has been cleaned of //chrome-level dependencies in a predecessor CL, so the componentization is trivial. Bug: 1025059 Change-Id: I47da26916a614fd8925bdbae1cb6fda9d72623ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983236Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#728484}
-
Hitoshi Yoshida authored
In ReferenceType, attributes that start with '_' are not proxied. So ReferenceType._unwrap() calls IdlType._unwrap() which does nothing even if it refers either of NullableType or TypedefType. This CL makes it possible. Bug: 839389 Change-Id: I23e8a54997f7f88420998acc7672eb4ee875b988 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980266 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#728483}
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Remove unwanted DEFINE_TYPE_CASTS 2. Use To<WebGLRenderingContextBase>(element) in place of ToWebGLRenderingContextBase(element) Bug: 891908 Change-Id: I5d38ded1229b5ac969a6d9249ff5e8a76f4982f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986691Reviewed-by:Kentaro Hara <haraken@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#728482}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I0b2a898057371271bebb51c7439baca313724349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987319Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728481}
-
Eric Seckler authored
The deprecated TRACE_EVENT_ASYNC* macros have been superseded by TRACE_EVENT_NESTABLE_ASYNC*. Updating to the new macros is mostly straight-forward, except in cases where STEP_INTO/PAST macros were used extensively: In those cases, the steps have been converted into nested sub-events. Bug: 1038710 Change-Id: I53d2f80b1efda29722b8e5b7e0872a5095ca595c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985666Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#728480}
-
Colin Blundell authored
In preparation for implementing integration with system autofill in WebLayer, this CL componentizes //android_webview's infrastructure that does the heavy lifting for this integration in WebView. The infrastructure is self-contained and will be reusable out of the box. This CL also suitably generalizes the context of the files: - Renames them appropriately - Removes/generalizes most references to WebView (a few need to be left for legacy compatibility; these are documented). We note that it would be possible to consider merging AutofillProviderImpl.java into AutofillProvider.java in a followup; as far as we know, there are no other implementations of the AutofillProvider interface in the codebase. We did not do that here as (a) it would have introduced a large amount of noise into the CL, and (b) it is debatable whether it is better, as there is some value to having separation between the tight AutofillProvider.java interface exposed to Chromium's autofill and the sprawling AutofillProviderImpl implementation necessary to integrate with the system AutofillService. This CL also adds michaelbai@ as OWNER of the relevant files for integration with system autofill on Android under //components/autofill/android. TBR=michaelbai@chromium.org Bug: 1025617 Change-Id: I4ca7bbd03983d8b46558db1cd0f2d632d36f787c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980738 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#728479}
-
Kuo Jen Wei authored
Bug: 141518780 Test: Pass closure compiler check, tast run <DUT> 'camera.CCAUI*' on both HALv1 and v3 devices. Change-Id: I73a9cf7befd738171822bc58cb746ccf712f354d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983695 Commit-Queue: Kuo Jen Wei <inker@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#728478}
-
Kuo Jen Wei authored
Bug: 141518780 Test: Pass closure compiler check, tast run <DUT> 'camera.CCAUI*' on both HALv1 and v3 devices. Change-Id: Iac9a59809856274b86b0bca1c182576449d37133 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988086 Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
-
Kuo Jen Wei authored
Bug: 141518780 Test: Pass closure compiler check, tast run <DUT> 'camera.CCAUI*' on both HALv1 and v3 devices. Test: Manually verify validity of metrics data. Change-Id: I2c9af053a29ac42d903bc75e4de3222f9b65fc97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986569 Auto-Submit: Kuo Jen Wei <inker@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Reviewed-by:
-
Greg Thompson authored
Tests may leak files/directories in temp due to ScopedTempDir lifetime issues (see linked bug) or as a result of crashes. This CL augments the TestLauncher to handle such leaks a bit better. When launching a child proc on Windows and macOS, the TestLauncher now directs that child to its own dedicated temporary directory. Upon child exit, the launcher checks for leaked files/directories in that dir and deletes the dir. On test iteration completion, the launcher will emit a list of the tests that produced leaks when run with --test-launcher-print-temp-leaks that looks a lot like this: ERROR: 2 files and/or directories were left behind in the temporary directory by one or more of these tests: PaymentManagerTest.ClearPaymentInstruments:PermissionControllerImplTest.ResettingOverridesForwardsReset:PermissionControllerImplTest.SettingOverridesForwardsUpdates:PermissionControllerImplTest.RequestPermissionsDelegatesIffMissingOverrides:PermissionControllerImplTest.GetPermissionStatusDelegatesIffNoOverrides:PermissionControllerImplTest.GetPermissionStatusForFrameDelegatesIffNoOverrides:PermissionControllerImplTest.NotifyChangedSubscriptionsCallsOnChangeOnly:PermissionControllerImplTest.PermissionsCannotBeOverriddenIfNotOverridable:PermissionControllerImplTest.GrantPermissionsReturnsStatusesBeingSetIfOverridable:PictureInPictureServiceImplTest.EnterPictureInPicture Curious developers can binary search in that short list of tests to find the one(s) that are leaking and clean them up. BUG=546640 TBR=sky@chromium.org Change-Id: If3be7034094827979c225d2eb2beba2d92e6e7ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978679 Commit-Queue: Greg Thompson <grt@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#728475}
-
Alexandre Courbot authored
The format and plane count variables are closely related, yet they were initialized in different parts of the code. Make sure they are initialized together to make the code more readable. BUG=None TEST=Video playback working on Kevin with VD disabled. Change-Id: I07e8e7e7e833ab818f9ac7d8e8a750805a923a19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982505 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#728474}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/57923928ffaf..61fe7a44e909 Created with: gclient setdep -r src-internal@61fe7a44e909 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I91507bf0a4cc66097f8fc4710db34bead0cd1fc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987317Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728473}
-
Takashi Toyoshima authored
Now the OOR-CORS is enabled by default on TOT, and the main waterfall runs tests with OOR-CORS being enabled. Fyi Builders should be switched to run *without* OOR-CORS now, and their names should be aligned with actual running parameters, Blink-CORS or blink-cors rather than oor-cors. Bug: 1039165 Change-Id: Ib48398cea01fc684d6e6911d2ac1315a9b2ebf5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980264 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#728472}
-
Hayato Ito authored
TBR=robliao@chromium.org,raymes@chromium.org Bug: 1038957 Change-Id: I29e701ad3fe42b2a96968ca40b506d873600c1b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986568Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#728471}
-
Colin Blundell authored
This CL prepares BadClockBlockingPage for componentization and sharing with WebLayer by cleaning it of //chrome-level dependencies. Bug: 1025059 Change-Id: Icacd88b16ad1a50b7b93412986b9a113f138cee5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982555Reviewed-by:
-
Ting Shao authored
When 'Service-Worker-Allowed' header takes a cross-origin url to override the scope restriction, it must be rejected for security. Bug: 968436 Change-Id: Ia4e8745d2fd86fe014187ade593363eaedf7c8ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984901Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Ting Shao <ting.shao@intel.com> Cr-Commit-Position: refs/heads/master@{#728469}
-
Kuo Jen Wei authored
Bug: 141518780 Test: Pass closure compiler check, tast run <DUT> 'camera.CCAUI*' on both HALv1 and v3 devices. Change-Id: Idb985eb2585fe80b8d8ade877b994ed3392b878e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986477 Commit-Queue: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
-
Alexandre Courbot authored
These variables were useful when the number of planes was something we needed to worry about, but now they are just used in superficial ways, so remove them. We just need to keep the output and GL plane counts in the SVDA, since it uses them for sanity checks. BUG=None TEST=Video playing in Chrome on Hana and Kevin with VD disabled. Change-Id: Ib6cbebd1555a6e7e8bc9113e2d8d3443bad1cd86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982504 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
-
Rachel Carpenter authored
These strings are provided to the untrusted js to read and pass up to the server. TESTED: Manually on device to check the strings are initialised with sensible values. Bug: b/140151178 Change-Id: Id96a28319ed78a68d5bb635ff092c70a976754a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983688Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Rachel Carpenter <carpenterr@google.com> Cr-Commit-Position: refs/heads/master@{#728466}
-
Hitoshi Yoshida authored
Defines Create() and accessor functions in the class definition. Bug: 839389 Change-Id: I9a2c0a8ec768fa219f95bdd73e8d923830b09545 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983689Reviewed-by:
-
Kuo Jen Wei authored
This CL add logic for monitering visibility of CCA window and close camera stream when window is idle (not recording) and is non-visible in tablet mode. Bug: 1035653 Test: Pass tast run <DUT> 'camera.CCAUI*'. Test: Manually test camera stream is closed when CCA is idle and is invisible in tablet mode. Test: Manually test recording can be continued when CCA is invisible in tablet mode. Change-Id: I05c1ddf3c16dce3897d694e07208b18fd78acc42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986468Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/03f3f75e4828..f1db2661f17c git log 03f3f75e4828..f1db2661f17c --date=short --first-parent --format='%ad %ae %s' 2020-01-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 1fdf6ca5141d..1031d2c65b5e (5 commits) Created with: gclient setdep -r src/third_party/skia@f1db2661f17c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jvanverth@google.com Change-Id: Id39eeff323d1046a248b4101f66e86246b150934 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987316Reviewed-by:
-
Takashi Toyoshima authored
Now the OOR-CORS m79 rollout is started. To follow the best practices for incremental feature rollouts, this patch enables the OOR-CORS by default on TOT. NOAUTOREVERT=true Bug: 905971, 1001450, 1035763, 1039165 Change-Id: I2ca742eab6a14891968892f7f1ef40adbe8bad67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988127 Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#728462}
-
Yuzu Saijo authored
This CL implements eviction when clients.claim is called on bfcached client. In order for the claim API to see the bfcached clients, this CL adds |include_cached_clients| option for ServiceWorkerContainerHost iterator, which defaults to false. Bug: 1036744 Change-Id: I654698aee083f881c3dd6ff19486b34835206004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980522 Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
-
Zhuoyu Qian authored
As the comment in service_worker_navigation_handle.h, rename ServiceWorkerNavigationHandle to ServiceWorkerMainResourceHandle. This CL has no behavior changes. Change-Id: I44ace8344e6feff740dc89517bafbb96d9c1b229 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982513Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1573f3772170..57923928ffaf Created with: gclient setdep -r src-internal@57923928ffaf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Id7942703ac9aebf8d4ba17a7f4ce97b9d8ac7163 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987207Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d445e2b6fcf1..03f3f75e4828 git log d445e2b6fcf1..03f3f75e4828 --date=short --first-parent --format='%ad %ae %s' 2020-01-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src a12a9d87..3beaf136 (315 commits) Created with: gclient setdep -r src/third_party/skia@03f3f75e4828 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jvanverth@google.com Change-Id: Ib01302f7936b071d3ec13360088e0b4e8dd47812 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987382Reviewed-by:
-
Kuo Jen Wei authored
Bug: 141518780 Test: Pass closure compiler check, tast run <DUT> 'camera.CCAUI*' on both HALv1 and v3 devices. Change-Id: I8273ed4dd738b740700f51098a2456a8d2030581 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986537 Commit-Queue: Kuo Jen Wei <inker@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
-
Kuo Jen Wei authored
Bug: 141518780 Test: Pass closure compiler check, tast run <DUT> 'camera.CCAUI*' on both HALv1 and v3 devices. Change-Id: I3e0c50fa838a2b5ce3878d79f7d7137db66ff17e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986647 Commit-Queue: Kuo Jen Wei <inker@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
-
Matt Falkenhagen authored
Incorporate information into the main documentation and link to them. Change-Id: I16432d5454ab39a52fe5212cf38239717e4f132c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983691Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#728455}
-
Kuo Jen Wei authored
Bug: 141518780 Test: Pass closure compiler check, tast run <DUT> 'camera.CCAUI*' on both HALv1 and v3 devices. Change-Id: I1e51752fc913e8f2d4072f17d170a74a82e72d15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980258 Auto-Submit: Kuo Jen Wei <inker@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Reviewed-by:
-
Zhaoliang Ma authored
if blitsurface failed, then return directly. Bug: 1031436 Change-Id: Ie351d8a22d94f1b3116b2470432db9264db6c57a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988024Reviewed-by:
-
Peter Kasting authored
Mostly initializing variables in declarations and shortening code. Also changed AppInfoDialogViewsTest.ViewInStore to call the link callback instead of pressing the link directly, since in a future CL I'll be removing the link member variable, so the test wouldn't work. Bug: none Change-Id: I90c689be86785a9b297b3161dafb01a0a8bb3568 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983510 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
-
Matt Falkenhagen authored
Bug: 795989 Change-Id: I8185bf021d255ab279bea5ff03651b70ab4eb2a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982340Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#728451}
-
Alexandre Courbot authored
We used to pass a vector of DMABuf FDs to the GL/EGL image creation functions. This was very error-prone, as these vectors could contain less FDs than there were planes in the buffer, and this information was used to signal that the last FD contained several planes. The function receiving these incomplete FDs would then try to figure out the actual planes layout, with more or less luck, often introducing bugs in the way. Solve this issue once and for all by passing all importable buffer information within the VDAs through NativePixmapHandles: they always contain as many FDs as there are planes, and also have detailed layout information. On top of that, they are what we receive when using import mode (which means we can pass the exact layout information down to GL/EGL), and we already have a function that creates them from a VideoFrame. This helps reduce the amount of code, all the while making it safer and more readable. BUG=b:146842214 TEST=VDAtest passes on Hana. TEST=VDAtest passes on Kevin with VD disabled. TEST=VDAtest passes on Kukui. TEST=crosvideo.appspot.com plays videos properly on Hana. TEST=crosvideo.appspot.com plays videos properly on Kevin with VD disabled. TEST=crosvideo.appspot.com plays videos properly on Kukui. TEST=Youtube Android plays properly on Hana. TEST=Youtube Android plays properly on Kevin with VD disabled. TEST=Youtube Android plays properly on Kukui. Change-Id: I88a78b786b1c90820221c9f0770a52a339913537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982499 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
-
