GitLab

TBR=bruening@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/375893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281752 0039d316-1c4b-4281-b951-d872f2087c98

BUG=347295

Review URL: https://codereview.chromium.org/368873004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281751 0039d316-1c4b-4281-b951-d872f2087c98

clang warns:
..\..\win8\delegate_execute\delegate_execute.cc(97,39) :  error(clang): cannot pass object of non-trivial type 'const base::string16' (aka 'const basic_string<wchar_t, char_traits<wchar_t>, allocator<wchar_t> >') through variadic function; call will abort at runtime [-Wnon-pod-varargs]
           operation.mutex().c_str(), operation.relaunch_flags());
                                      ^
1 error generated.

How did this every work? My guess is that %s interpreted the size_
member variable at the start of string16 as C string, and since the size
usually has a at least the upper byte set to 0, this ended up logging
1-2 garbage bytes.

BUG=82385
NOTRY=true

Review URL: https://codereview.chromium.org/370943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281750 0039d316-1c4b-4281-b951-d872f2087c98

Since root cause http://crbug.com/342478 has been fixed.

BUG=363183

Review URL: https://codereview.chromium.org/371353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281749 0039d316-1c4b-4281-b951-d872f2087c98

This CL drops recording histogram suffixes for SpdyCwnd field trial
from 2010. These are based on depracated timing information recorded in
DocumentState and have no indicated owner.

BUG=384330
R=isherman@chromium.org, tonyg@chromium.org

Review URL: https://codereview.chromium.org/375503005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281748 0039d316-1c4b-4281-b951-d872f2087c98

This ancient CL suggested a simplication in mapped_file_posix.cc:
https://codereview.chromium.org/160288

After hitting this DCHECK on an embedded device where using a debugger
is difficult, I decided to make the suggested change and add some useful
logging while I was at it.

BUG=391937

Review URL: https://codereview.chromium.org/372113003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281747 0039d316-1c4b-4281-b951-d872f2087c98

Fix Windows logoff race by posting a sentinel task to each taskrunner used to save state, and blocking on the completion of all sentinels.
De-flake and re-enable ProfileBrowserTests, by not running the tasks queued to initialize Bookmarks. This caused test failures when the delayed initialization managed to run.
This depends on https://codereview.chromium.org/370323002/, which fixes a BookmarkStorage lifetime issue, and https://codereview.chromium.org/375683002/ which annotates a remaining leak.

TBR=sky@chromium.org, brettw@chromium.org

R=erikwright@chromium.org, gab=chromium.org, brettw@chromium.org
BUG=386126, 141141, 141517, 142787, 140882, 165760, 163713, 391508

Review URL: https://codereview.chromium.org/349263004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281746 0039d316-1c4b-4281-b951-d872f2087c98

BUG=392035

Review URL: https://codereview.chromium.org/374043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281745 0039d316-1c4b-4281-b951-d872f2087c98

Break some of the chrome/common dependencies in implementation by moving some paths and constants to the component.

Design doc: https://docs.google.com/document/d/1F76yNZCnPnGzgNXhI-sCFKlXulwx_s_OKTGbJS5NhbA/edit?usp=sharing

BUG=371463

Review URL: https://codereview.chromium.org/334783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281744 0039d316-1c4b-4281-b951-d872f2087c98

BUG=389276

Review URL: https://codereview.chromium.org/373833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281743 0039d316-1c4b-4281-b951-d872f2087c98

This landed in revision 281638 (https://codereview.chromium.org/354693004/)

BUG=388836

Review URL: https://codereview.chromium.org/372163007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281741 0039d316-1c4b-4281-b951-d872f2087c98

BUG=297647

Review URL: https://codereview.chromium.org/371753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281740 0039d316-1c4b-4281-b951-d872f2087c98

These histograms are based on deprecated timing information from
DocumentState and have no indicated owner.

BUG=384330
R=isherman@chromium.org, tonyg@chromium.org

Review URL: https://codereview.chromium.org/370273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281739 0039d316-1c4b-4281-b951-d872f2087c98

crbug.com/285303 describes how family name based font fallback
does not work in the case of ttf files with identical family name.
The two added files, GardinerMod(Bug|Cat).ttf are derivatives from
the public domain Gardiner font. For license information, see
the LayoutTests/third_party/GardinerMod directory in Blink.
They have the same family name, but different available glyphs,
and are used in the family-fallback-gardiner.html test case.

BUG=381684

Review URL: https://codereview.chromium.org/356733003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281738 0039d316-1c4b-4281-b951-d872f2087c98

Skia no longer looks at this define. It's as if it's always set now.

BUG=

Review URL: https://codereview.chromium.org/371983003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281737 0039d316-1c4b-4281-b951-d872f2087c98

TBR=machenbach@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/373113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281736 0039d316-1c4b-4281-b951-d872f2087c98

Otherwise, before the ActiveTexture0 binding to other texture,
the thumbnail texture will be blended with other decoded frames.

This can be observed with low rendering fps on ARM CrOS device.

BUG=None
TEST=Run the vda_unittest on arm cros device.

Review URL: https://codereview.chromium.org/367373008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281735 0039d316-1c4b-4281-b951-d872f2087c98

BUG=370551
R=marja@chromium.org

Review URL: https://codereview.chromium.org/377893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281734 0039d316-1c4b-4281-b951-d872f2087c98

In the componentization effort, we must remove all dependence on chrome/

BUG=387751
TEST=BlacklistStoreTest
R=huangs@chromium.org

Review URL: https://codereview.chromium.org/372073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281733 0039d316-1c4b-4281-b951-d872f2087c98

It was unnecessary for a debug page.

BUG=387751
R=huangs@chromium.org

Review URL: https://codereview.chromium.org/377713003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281731 0039d316-1c4b-4281-b951-d872f2087c98

Enables precise control of the isolate depending on correct
versions of msvc*.dll.

BUG=390686

Review URL: https://codereview.chromium.org/373973002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281730 0039d316-1c4b-4281-b951-d872f2087c98

The original CL:
https://codereview.chromium.org/315673002/

The revert of the CL above:
https://codereview.chromium.org/349293006/

The reason for the original revert:
Media tests started failing consistently on a tsan bot
(http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28tsan%29%281%29?numbuilds=200) with revision 277414 (the commit of original CL).
Cl was reverted in revision 279198.

This CL solved the problem differently, by not using the release_optimize flag, and instead replace the cflag -Os with -O3.

Opus speed gain with -03 flag on ARM:
ARM32b - 6-8% for encoding, 2% for decoding
ARM64b - 20% for encoding, 17% for decoding

Increased binary size: 

BUG=chromium:354539

Review URL: https://codereview.chromium.org/354903003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281729 0039d316-1c4b-4281-b951-d872f2087c98

Previous strategy: remove all the Chrome passwords not referenced by the local database.
New strategy: remove exactly those passwords which were removed from the database.

BUG=379933

Review URL: https://codereview.chromium.org/360343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281728 0039d316-1c4b-4281-b951-d872f2087c98

When the screen is locked after some time not used, the initial text input focus is not in the password field when --enable-text-input-focus-manager is enabled.  This CL fixes this issue and puts the text input focus in the password field of the lock screen.

The issue occurs only when the screen gets locked because of time-out.  When it's explicitly locked by a user, the issue doesn't occur.  Please allow me about not adding a test case because it's tough to add a test case.

BUG=290701
TEST=Done manually.

Review URL: https://codereview.chromium.org/371923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281727 0039d316-1c4b-4281-b951-d872f2087c98

A scoped_ptr has less overhead than a vector. This CL refactors to
store ZoomChangedEventData structs via a scoped_ptr since there will
be (at most) one of these at a time.

BUG=none

Review URL: https://codereview.chromium.org/373603007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281726 0039d316-1c4b-4281-b951-d872f2087c98

CertificatePattern was already parsing/writing ONC dictionaries, but the method naming and the duplicate constants didn't convey that.

BUG=391292
TBR=stevenjb@chromium.org

Review URL: https://codereview.chromium.org/366103004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281725 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281724 0039d316-1c4b-4281-b951-d872f2087c98

https://skia.googlesource.com/skia/+log/ff644145242631a46d9dce6cb99c97f9340f172c..a26bbb95a64c1507ba81d39b971f079f3f9c5646

CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_layout_rel
TBR=jcgregorio@google.com
BUG=

Review URL: https://codereview.chromium.org/378813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281723 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
R=marja@chromium.org

Review URL: https://codereview.chromium.org/370973004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281722 0039d316-1c4b-4281-b951-d872f2087c98

Tidied up some divs and css classes. Also added some colors to improve the usability of the page highlighting the buttons required to setup a call.

Added green color to the buttons used to setup a call.
Added red color to the buttons that stop/cancel streams or calls.

This is part of a larger refactor effort but doing it in baby steps.

BUG=NONE
TEST=Manual, no style errors in chrome.
NOTRY=TRUE

Review URL: https://codereview.chromium.org/368043004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281721 0039d316-1c4b-4281-b951-d872f2087c98

BUG=347425
TEST=./unit_tests --gtest_filter="MetadataDatabaseInexOnDiskTest.*"

Review URL: https://codereview.chromium.org/377463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281720 0039d316-1c4b-4281-b951-d872f2087c98

BUG=n/a
TEST=cpplint

Review URL: https://codereview.chromium.org/377873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281719 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391520
TBR=eae@chromium.org,jshin@chromium.org

Review URL: https://codereview.chromium.org/372843004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281718 0039d316-1c4b-4281-b951-d872f2087c98

On the JS side, the argument is called displayName, so on C++ side it should
be display_name for consistency.

TBR=nkostylev@chromium.org
TEST=Not related. Refactoring only.
BUG=248427

Review URL: https://codereview.chromium.org/375793003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281717 0039d316-1c4b-4281-b951-d872f2087c98

This starts GN targets for //content/test:*support*. They aren't used
anywhere yet but will be used by many unit test targets.

R=brettw@chromium.org

Review URL: https://codereview.chromium.org/353113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281716 0039d316-1c4b-4281-b951-d872f2087c98

Allow WebView.loadUrl-family functions to terminate execution of JS code that
seems to be stuck in a loop.

BUG=390906

Review URL: https://codereview.chromium.org/366913006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281715 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit 291b1ce3.

BUG=392117
NOTRY=true
TBR=starodub

Review URL: https://codereview.chromium.org/371343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281714 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/360893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281713 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281712 0039d316-1c4b-4281-b951-d872f2087c98

Please reply to the V8 sheriff dslomov@chromium.org in case of problems.

TBR=dslomov@chromium.org

Review URL: https://codereview.chromium.org/372953003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281711 0039d316-1c4b-4281-b951-d872f2087c98