- 10 Jul, 2017 40 commits
-
-
edchin authored
1) Uses the proper title for tab grid tab cells. 2) Properly sets snapshot image. It was previously setting the button's image rather than the imageView. Bug: 686770 Change-Id: I1f400f9b543528355f3014f3e1503e50166b33e9 Reviewed-on: https://chromium-review.googlesource.com/564346 Commit-Queue: Ed Chin <edchin@chromium.org> Reviewed-by:
Ed Chin <edchin@chromium.org> Reviewed-by:
Jean-François Geyelin <jif@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#485449}
-
Bo Liu authored
This is partial revert of r457679. Some old thirdparty android devices do not deal well with bindService intent with a Parceable. So make LinkerParams explicitly set fields in a Bundle rather than pass it as a Parceable. BUG=740653 Change-Id: I0ad409a20c638ec4ff91c4331a189aee381edf7b Reviewed-on: https://chromium-review.googlesource.com/565165Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Commit-Queue: Bo Liu <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#485448}
-
pfeldman authored
Revert of [CacheStorage] [IndexedDB] [DevTools] Added refresh button to category view of cache storage and in… (patchset #2 id:20001 of https://codereview.chromium.org/2916193003/ ) Reason for revert: The UI does not look right. Original issue's description: > Added refresh button to category view of cache storage and indexeddb > > BUG=727920, 727897 > > Review-Url: https://codereview.chromium.org/2916193003 > Cr-Commit-Position: refs/heads/master@{#478099} > Committed: https://chromium.googlesource.com/chromium/src/+/423c0eff455de15f2e3f0cc6c54002fa9b7db5a6 TBR=dmurph@chromium.org,dgozman@chromium.org,eostroukhov@chromium.org,kristipark@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=727920, 727897 Review-Url: https://codereview.chromium.org/2973113002 Cr-Commit-Position: refs/heads/master@{#485447}
-
Tommy C. Li authored
Previously, we determined which part of the URL the match was in by by searching the formatted URL string (in string16 form) for delimiters. After this refactor, we do this by using the "official" GURL component offsets adjusted for URL formatting. This is good both as a refactor, and also to lay the groundwork for adding |match_in_subdomain| and |match_in_path| flags. This CL doesn't actually add the above flags, and is intended to provide identical functionality as before (which is why no tests changed). Bug: 732582, 595524, 448659 Change-Id: I133c2ecb462597941b7284fd88f99e55f341f6b4 Reviewed-on: https://chromium-review.googlesource.com/564300 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#485446}
-
dpapad authored
BUG=739964 Review-Url: https://codereview.chromium.org/2975713002 Cr-Commit-Position: refs/heads/master@{#485445}
-
Christopher Cameron authored
These will be rebaselined after the roll. TBR=fmatila Bug: 739559 Change-Id: I08c06b60ba9a8d2e1a9dc973c29d89b9a054ba83 Reviewed-on: https://chromium-review.googlesource.com/565905Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: ccameron chromium <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#485444}
-
Stefan Zager authored
In the non-root-layer case, the CLM's main graphics layer will have a compositing container with a scroll origin, but in the root layer case, it makes no sense to give the root graphics layer a non-zero position. This fixes most or all of the pixel diffs in the compositing/rtl/ layout tests with RLS enabled. Those tests still need to be rebaselined for text diffs. BUG=542432 R=skobes@chromium.org Change-Id: I1b37d8c96dd3328754770e4a7249c22b87550e14 Reviewed-on: https://chromium-review.googlesource.com/563487Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#485443}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/cb9577c6..15d0e7ca Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: Ia581bb5cf0a8584bf42d201015f833b4936ced9e Reviewed-on: https://chromium-review.googlesource.com/565766Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#485442}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/f8681638b945..601f74b9033b $ git log f8681638b..601f74b90 --date=short --no-merges --format='%ad %ae %s' 2017-07-10 sullivan Add an API to get bug and bisect data. Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ided9c9760b1f6dd5e0728098b1e5deadba6d9b9d Reviewed-on: https://chromium-review.googlesource.com/565356 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#485441}
-
Sergey Ulanov authored
Several fixes to make net_unittests compile for Fuchsia: 1. Added cert_database_fuchsia.cc and test_root_certs_fuchsia.cc. 2. Disabled Kerberos (not implemented on Fuchsia). 3. Updated CertVerifyProc to use CreateCertVerifyProcBuiltin() with OS_FUCHSIA. Currently it uses DummySystemTrustStore, so cert verification will always fail. This will need to be fixed later, once Fuchsia adds an API for root certs store. 4. res_ninit() is not yet implemented, so res_init() is used instead. 5. Disabled DnsReloader. It relies on res_ninit() and it's unlikely to be useful on Fuchsia. Bug: 731302 Change-Id: I05cbb7a4b571d82894b7c62740fc2f5b36870214 Reviewed-on: https://chromium-review.googlesource.com/560050Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#485440}
-
takumif authored
This CL removes the media_route_provider_extension_id() getter from MediaRouterMojoImpl, which was previously being accessed by static-casting MediaRouter into MediaRouterMojoImpl. The getter in EventPageRequestManager is now used. It seems that we cannot simply hard-code the ID, since it's different between dev and release builds of the component extension. BUG=597778 BUG=727993 Review-Url: https://codereview.chromium.org/2970273002 Cr-Commit-Position: refs/heads/master@{#485439}
-
Fernando Serboncini authored
Related spec: https://drafts.fxtf.org/geometry/#DOMRect and: https://drafts.fxft.org/geometry/#DOMRectList Bug: 719246 Change-Id: I0322c12ab5c327b869e925a8c06fbfae6b659ad3 Reviewed-on: https://chromium-review.googlesource.com/559978 Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#485438}
-
imcheng authored
- Removed method declarations that are not defined. - Removed PresentationFrameManager. There is not much reason to keep it since most of the logic is just delegating from PSDImpl. - Push the URL validity check for screen availability to PSImpl. BUG=736557 Review-Url: https://codereview.chromium.org/2958663002 Cr-Commit-Position: refs/heads/master@{#485437}
-
Megan Jablonski authored
SaveFrameWithHeaders should use SPLIT_WANT_NONEMPTY to ignore terminating CRLF separators. Bug: 738161 Change-Id: Id5deaee597baa48fd90ac447f020094072ba707d Reviewed-on: https://chromium-review.googlesource.com/563820 Commit-Queue: Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#485436}
-
Daniel Erat authored
Remove calls to content::BrowserThread::GetBlockingPool()->FlushForTesting() and base::RunLoop().RunUntilIdle() from TearDown(). content::TestBrowserThreadBundle is documented as already running remaining tasks during destruction. BUG=667892 Change-Id: I0368a0f94e9ddbfde284b18e3222894ee1d80b55 Reviewed-on: https://chromium-review.googlesource.com/560643Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Satoru Takabayashi <satorux@google.com> Commit-Queue: Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#485435}
-
Steven Bennetts authored
This moves the preview pane into a separate element in preparation for sharing UI between Settings and login/oobe. Bug: 730031 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7dae1a01579e89ca8f4b8fdc3be7393b2310c869 Reviewed-on: https://chromium-review.googlesource.com/557462Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#485434}
-
Peter Collingbourne authored
An upcoming version of clang removes the ability to suppress availability warnings by redeclaring functions. The new way to suppress warnings is to either annotate the caller with an availability attribute or enclose the function reference in an "if (@available)" block. But we don't need to do any of that for crdmg. According to source code comments, the executable only works with 10.10+, so we can adjust the minimum SDK version to match. Bug: 735328 Change-Id: Ib735ffe60c67681b2d13f5dbbfddb6aa6b928248 Reviewed-on: https://chromium-review.googlesource.com/564290Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Sidney San Martin <sdy@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#485433}
-
raymes authored
We were originally planning to make content settings type a string, but that effort was never completed. This comment is just adding confusion at the moment. Review-Url: https://codereview.chromium.org/2965183002 Cr-Commit-Position: refs/heads/master@{#485432}
-
btolsch authored
This change enables DiscoveryNetworkMonitor to work on Windows. It supports both MAC addresses and WiFi SSIDs for the network ID. Bug: 698943 Change-Id: I0c94743fd51019438fd53472f38a2d83e21a3246 Reviewed-on: https://chromium-review.googlesource.com/527774 Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#485431}
-
rbpotter authored
Remove remaining global javascript functions from the print preview native layer and convert to sendWithPromise and web UI events. BUG=717296 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2969383003 Cr-Commit-Position: refs/heads/master@{#485430}
-
Takumi Fujimoto authored
Update from v1.0.15 by running third_party/polymer/v1_0/reproduce.sh. This includes the fix for a bug in which the slider cannot be LTR on a RTL page. Bug: 736954 Change-Id: I73f77fb0a053ec7f00b996a125f853848fbc56b6 Reviewed-on: https://chromium-review.googlesource.com/565067Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#485429}
-
justincarlson authored
metadata. We don't *actually* need this information for anything other than usage tracking, and having these printers actually *work* is more important that getting good metadata about them. BUG= Review-Url: https://codereview.chromium.org/2974103002 Cr-Commit-Position: refs/heads/master@{#485428}
-
Chris Cunningham authored
This CL plumbs the signal from the renderers through pipeline, ultiately arriving at WebMediaPlayerImpl where it will later be used to start/stop reporting of MediaCapabilities playback stats. Note: OnVideoNaturalSizeChange is still not obsoleted by OnVideoConfigChange because it possible to for natural size to change outside of a config change. Includes new unit and e2e tests. Bug: 695264 Change-Id: Ib04e13e2e8ab6b6974f2a9059466d7a87986b4b2 Reviewed-on: https://chromium-review.googlesource.com/541721Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#485427}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/1437643bfaca..92e2276a8be4 $ git log 1437643bf..92e2276a8 --date=short --no-merges --format='%ad %ae %s' 2017-07-10 dsinclair Move core/fxge/ge to core/fxge. Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: I2dce82ab97dc5fa07c957aea334da2889c69f005 Reviewed-on: https://chromium-review.googlesource.com/565885 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#485426}
-
Bruce Dawson authored
linker_verbose_tracking.py is a useful script for understanding why particular symbols and object files get pulled in to Chrome binaries on Windows. Previously this script did its tracking purely by object file name, which breaks down for things like mime_util.obj because there are *four* object files with that name. This change updates the script so that it tracks the chain of dependencies using fully-specified object file names - basically foo.lib(bar.obj) instead of just bar.obj. This avoids the dead-ends and misleading information that occasionally happened with the previous version. In order to make this usable (specifying a fully-qualified object file name to search for is unwieldy) the search string is now understood to be any sub-string of the object file name. The set of matches is printed so that the search can easily be refined. It works much better now. This was made necessary by the investigation of the linked bug. R=stanisc@chromium.org BUG=717103 Change-Id: I25682e6d5b534c69d3743456918c60d42f746e10 Reviewed-on: https://chromium-review.googlesource.com/565221 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Stanislav Chiknavaryan <stanisc@chromium.org> Cr-Commit-Position: refs/heads/master@{#485425}
-
Ned Nguyen authored
benchmark TBR=ulan@chromium.org Bug: 728464 Change-Id: I3eee89c2b34da5488da2d967119a232e1d3978bc Reviewed-on: https://chromium-review.googlesource.com/565034 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#485424}
-
Chris Harrelson authored
Bug: 734363 Change-Id: I014249729a4606fdc422cfa92a4deb0f70474ec7 Reviewed-on: https://chromium-review.googlesource.com/565456Reviewed-by:
Walter Korman <wkorman@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#485423}
-
Emily Stark authored
The Superfish software causes certificate errors on every HTTPS page load starting in M57, because it uses SHA-1 signatures. We've decided to blacklist the root to prevent these errors from being bypassable and guide users into cleaning up their machines. Blacklisting the root will also protect users who may have uninstalled the software but not the root, or for whom SHA-1 is allowed by policy. BUG=734590 Change-Id: I99d38b0d8940d52dfc3355b9ca3aa619ddfec3ee Reviewed-on: https://chromium-review.googlesource.com/565747 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#485422}
-
bsheedy authored
Adds a benchmark runner for VR Telemetry tests that installs and configures the necessary APKs before running the benchmark. VR benchmarks, pages, actions, etc. will be added in follow-up CLs. Bug: 738074, 726906 Change-Id: I88feccafbee51e83114ca0182e394d25a7c7f936 Reviewed-on: https://chromium-review.googlesource.com/563761 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#485421}
-
Julien Brianceau authored
Bug: none Change-Id: I663dadcd4d34bcc0964b45dcbcc78621b5b213a2 Reviewed-on: https://chromium-review.googlesource.com/565263Reviewed-by:
Stanislav Chiknavaryan <stanisc@chromium.org> Commit-Queue: Stanislav Chiknavaryan <stanisc@chromium.org> Cr-Commit-Position: refs/heads/master@{#485420}
-
Jeff Carpenter authored
This change is based on jsbell's crrev.com/2767673002. When .any.js and .worker.js files are seen during MANIFEST generation they are mapped to .any.html, .any.worker.html, and .worker.html files as appropriate which WPTServe will generate on-the-fly. This allows for easy testing of [Exposed=(Window,Worker)] APIs and tests that are simply script with no boilerplate HTML. These are now supported in run-webkit-tests. When specifying tests to run, the source name should be specified, for example: $ run-webkit-test external/wpt/storage/interfaces.worker.js But expectations will use the generated name, e.g.: external/wpt/storage/interfaces.worker-expected.txt And failures will be reported under the generated name: external/wpt/storage/interfaces.worker.html Bug: 653514 Change-Id: I2f531e142c4ca41b1f3223a69a1e6f61343464c2 Reviewed-on: https://chromium-review.googlesource.com/461722Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Jeff Carpenter <jeffcarp@chromium.org> Cr-Commit-Position: refs/heads/master@{#485419}
-
John Abd-El-Malek authored
BUG=736375 Change-Id: I109fab5e41a40ba0d6f5f478c31070d7ef4ea9df Reviewed-on: https://chromium-review.googlesource.com/565196 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Eric Lawrence <elawrence@chromium.org> Cr-Commit-Position: refs/heads/master@{#485418}
-
Ryan Hamilton authored
Change-Id: I6ba620ef9b00af26c628269acec3d9bbdba0a093 Reviewed-on: https://chromium-review.googlesource.com/565447Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#485417}
-
Vladimir Levin authored
This patch reworks PaintShader to store needed parameters, instead of constructing an SkShader immediately. This allows the PaintShader to be introspectible (for things like images), without relying on SkShader::asAImage(). This patch also removes the sk_shader uses from outside of the flags in order to restrict access and construction of the SkShader. This would also unblock the gif animations on the compositor for the same reason (ie, it will be able to get a PaintImage directly from PaintShader). R=enne@chromium.org, chrishtr@chromium.org, khushalsagar@chromium.org Bug:728359 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I480195299205e8a7c01298095d5662b63980f80b Reviewed-on: https://chromium-review.googlesource.com/544119 Commit-Queue: Vladimir Levin <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#485416}
-
Marco authored
https://chromium.googlesource.com/webm/libvpx.git/+log/ec4afbf74a4b..4e16f7070354 $ git log ec4afbf74..4e16f7070 --date=short --no-merges --format='%ad %ae %s' 2017-07-06 johannkoenig sad neon: avg for 64x[32,64] 2017-07-06 johannkoenig sad neon: macroize 64xN definitions 2017-07-06 johannkoenig sad neon: avg for 32x[16,32,64] 2017-07-06 johannkoenig sad neon: macroize 32xN definitions 2017-07-06 johannkoenig sad neon: avg for 16x[8,16,32] 2017-07-06 johannkoenig sad neon: macroize 16xN definitions 2017-06-30 jzern cosmetics,vp9/: normalize inv/fwd_txfm naming 2017-07-06 jzern vp8cx,cosmetics: correct VP9_SET_TILE_COLUMNS docs 2017-07-06 marpan vp9: Nonrd mode: use content_state_sb for high motion. 2017-07-06 jzern vp8cx,cosmetics: correct VP9_SET_FRAME_PARALLEL_DECODING docs 2017-07-06 johannkoenig sad neon: macroize 8xN definitions 2017-06-28 johannkoenig sad neon: avg for 8x[4,8,16] 2017-06-28 johannkoenig sad neon: avg for 4x4 and 4x8 2017-06-29 johannkoenig fdct neon: 32x32_rd 2017-06-29 jzern vp9: remove FrameWorkerData & vp9_dthread.h 2017-06-27 jzern vp9: remove (un)lock_buffer_pool 2017-07-01 jzern dct_partial_test: cover vpx_fdct8x8_1_msa in hbd 2017-07-05 johannkoenig test/buffer.h: move range checking to compiler 2017-05-19 paulwilkins Further refactoring of mod error calculation. 2017-07-04 paulwilkins Fix incorrect index test in GF group rate assignment. (...) Created with: roll-dep src/third_party/libvpx/source/libvpx R=johannkoenig@google.com Bug: Change-Id: I7f8db8c21c295b12f31ffcdafdc028b6f84bff53 Reviewed-on: https://chromium-review.googlesource.com/565749Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Marco Paniconi <marpan@google.com> Cr-Commit-Position: refs/heads/master@{#485415}
-
Quinten Yearsley authored
Bug: 731182 Change-Id: Iebe8ada3bfd78cad3127e351b05703da258de6be Reviewed-on: https://chromium-review.googlesource.com/565103Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#485414}
-
Qiang Xu authored
Bug: 740321 TEST: covered by tests and the issue in crbug.com/740321 can be solved. Change-Id: I9ff64cde700bc280efda6f27fdf8dc6acac4faa7 Reviewed-on: https://chromium-review.googlesource.com/564317Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Qiang(Joe) Xu <warx@chromium.org> Cr-Commit-Position: refs/heads/master@{#485413}
-
tbansal authored
Make secure proxy check URL as a data reduction proxy param instead of a config value. This further cuts down on the functionality provided by data_reduction_proxy_config_values class. Also, remove unused flags for carrier testing, and for setting warmup url. BUG=597768 Review-Url: https://codereview.chromium.org/2967993002 Cr-Commit-Position: refs/heads/master@{#485412}
-
erikchen authored
Bug: 669240 Change-Id: I34b33ec646ba7ab6c57af052bfe78380b15dcc48 Reviewed-on: https://chromium-review.googlesource.com/565443Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#485411}
-
Vaclav Brozek authored
The current implementation of the password detail view in iOS settings tries to display the password value, which federated credentials have none. Instead, they have a web origin identifying the federated identity provider associated with the stored credential. This origin is currently not displayed. Therefore this CL changes the password detail view for federated credentials by replacing the password section with a federation section. The federation origin is very likely to be just a short hostname which fits on one line so there is no copy button for it as in the case of the other meta data. Desktop settings already do something similar: they replace the password field with a "with <federation origin>" string. Screenshot at https://crbug.com/740384#c2. Bug: 740384 Change-Id: Ibf4ff13a864fab450b3558246d8b26e04182b804 Reviewed-on: https://chromium-review.googlesource.com/563623 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Louis Romero <lpromero@chromium.org> Cr-Commit-Position: refs/heads/master@{#485410}
-