GitLab

libdbus-glib uses the glib main loop internally.  We were making calls on a background thread that wound up telling libdbus-glib to get a connection to the system bus on said background thread.  This led to a background thread trying to use the same glib main loop as Chrome's UI thread, and concurrency issues led to crashing.  Sadly, there can be only one main loop per process, as I understand it.

This code takes away the attempts to use the background thread.  As our interaction with dbus is semantically asynchronous, this seems ok to me. 
Review URL: http://codereview.chromium.org/339013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30135 0039d316-1c4b-4281-b951-d872f2087c98

extension_action.*.

Final bit of refactor will be to rename ExtensionAction2 to
ExtensionAction will be the next CL.

BUG=24472,25844

Review URL: http://codereview.chromium.org/332021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30133 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=builds ok
Review URL: http://codereview.chromium.org/295049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30132 0039d316-1c4b-4281-b951-d872f2087c98

on Mac and Linux as it does on Windows.

BUG=25869
TEST=about:terms should work.  In a branded build, terms should show up.
     In an unbranded build, the about:terms page is supposed to be blank,
     but there should be some skeletal HTML visible in "View Source".
Review URL: http://codereview.chromium.org/338028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30130 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30129 0039d316-1c4b-4281-b951-d872f2087c98

The following descriptions were taken from <http://blogs.msdn.com/wndp/articles/IPV6_PAC_Extensions_v0_9.aspx> 

---------------------------- 
* myIpAddressEx(): 
Returns a semi-colon delimited string containing all IP addresses for localhost (IPv6 and/or IPv4), or an empty string if unable to resolve localhost to an IP address. 

* dnsResolveEx(host): 
Returns semi-colon delimited string containing IPv6 and IPv4 addresses or an empty string if host is not resolvable. 

* isResolvableEx(): 
Returns TRUE if the host is resolvable to a IPv4 or IPv6 address, FALSE otherwise. 
---------------------------- 

These differ from the vanilla PAC functions in the following ways: 

* myIpAddressEx() returns all the addrsses for localhost (including IPv6 ones), whereas myIpAddress() only returns the first IPv4 one. 
* On failure, myIpAddress() returns "127.0.0.1" whereas on failure myIpAddressEx() returns empty string. 
* dnsResolveEx() returns a list of addresses (including IPV6 ones), whereas dnsResolve() only returns the first IPv4 address. 
* On failure, dnsResolve() returns |null|, whereas on failure dnsResolveEx() returns empty string. 

BUG=25407
TEST=ProxyResolverV8Test.DNSResolutionFailure, ProxyResolverJSBindingsTest.RestrictAddressFamily, ProxyResolverJSBindingsTest.ExFunctionsReturnList
Review URL: http://codereview.chromium.org/333006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30127 0039d316-1c4b-4281-b951-d872f2087c98

TEST=run the unittests and watch them pass.
BUG=none

Review URL: http://codereview.chromium.org/334016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30126 0039d316-1c4b-4281-b951-d872f2087c98

http://trac.webkit.org/changeset/49985

Review URL: http://codereview.chromium.org/329025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30125 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30124 0039d316-1c4b-4281-b951-d872f2087c98

Add SSL wrapper for linux and mac.  This allows notifier to use chrome's SSL layer instead of OpenSSL.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/270074

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30123 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30122 0039d316-1c4b-4281-b951-d872f2087c98

A couple tests added by chromium folks that need to be rebaselined.

TBR=jorlow

Review URL: http://codereview.chromium.org/338026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30121 0039d316-1c4b-4281-b951-d872f2087c98

BUG=24307
TEST=tsan mac bot should remain green - (http://build.chromium.org/buildbot/waterfall/waterfall?builder=Linux+Tests+(tsan)&builder=Chromium+Mac+(tsan))

Review URL: http://codereview.chromium.org/333029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30120 0039d316-1c4b-4281-b951-d872f2087c98

 * show/hide chromeos components based on fullscreen status
 * added compact_navigation_bar_enabled_ flag to differentiate being in fullscreen and
   being disabled.

BUG=22805
TEST=Toggle fullscreen mode using F11. Try with/without compact navigation bar, which can be enabled by "shift-ctrl-0".

Review URL: http://codereview.chromium.org/332032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30119 0039d316-1c4b-4281-b951-d872f2087c98

namespace. That's so I can add command_buffer::xxx namespace for
different command buffer.

Review URL: http://codereview.chromium.org/332036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30118 0039d316-1c4b-4281-b951-d872f2087c98

Add a ctor for creating a CommandLine for carrying arguments;
convert all the users to either that or the FilePath version.

BUG=24672

Review URL: http://codereview.chromium.org/329017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30117 0039d316-1c4b-4281-b951-d872f2087c98

BUG=25862
TEST=The About box
Review URL: http://codereview.chromium.org/330023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30116 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=green


Review URL: http://codereview.chromium.org/339011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30114 0039d316-1c4b-4281-b951-d872f2087c98

BUG=25308
TEST=go to gmail, pin the tab, select another tab. Have someone IM you
     and make sure your gmail tab throbs.

Review URL: http://codereview.chromium.org/329021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30113 0039d316-1c4b-4281-b951-d872f2087c98

BUG=25656
TEST=Mac UI valgrind bots

Review URL: http://codereview.chromium.org/330022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30112 0039d316-1c4b-4281-b951-d872f2087c98

This will allow lower-level targets to change their desired optimization level.  In particular, the ffmpeg build requires this because it has problems compiling with -O0.

BUG=22307
TEST=none

Review URL: http://codereview.chromium.org/334018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30110 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/334008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30109 0039d316-1c4b-4281-b951-d872f2087c98

BUG=25849
TEST=none
Review URL: http://codereview.chromium.org/335032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30108 0039d316-1c4b-4281-b951-d872f2087c98

version, legal block, and update icon (if present) should all line up.

BUG=25582
TEST=Look at it.  Come over here and look at it.
Review URL: http://codereview.chromium.org/334031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30107 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/338008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30106 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=18020

Review URL: http://codereview.chromium.org/329013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30105 0039d316-1c4b-4281-b951-d872f2087c98

layout test dashboard. Also, if a path does not match any failing
tests, then assume it's a full path so we can still show it's expectations.
Review URL: http://codereview.chromium.org/334030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30104 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/333019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30102 0039d316-1c4b-4281-b951-d872f2087c98

a new update check even when an existing update check or installation attempt
is in progress.

Remove the check that validates that the Update button is disabled after
being clicked.  This test has become very fragile now that the Update button
reliably enables itself as soon as an update installation attempt fails.

BUG=13165
TEST=Get the About box to offer you the opportunity to install an update.
     Click "Install Now".  Close the About box and quickly reopen it.  The
     update status should be "Installing new version..." and not "Checking
     for updates..."
Review URL: http://codereview.chromium.org/339010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30100 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/297015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30099 0039d316-1c4b-4281-b951-d872f2087c98

BookmarkBubbleController has been made an NSWindowController instead of the
view controller that it used to be, and now loads its window from the nib instead
of creating it on the fly. Also cleans up fullscreen mode so that the window
referenced from browser_window_controller stays constant instead of having
[self window] and window_ potentially pointing at two different windows.

BookmarkBubble.xib has been modified so that it instantiates a window containing
a bubble view instead of just instantiating a view.

BUG=25054
TEST=Try going in and out of full screen mode. Try bringing up a bookmark bubble by clicking on the star. Try creating a pile of windows and then quitting,
Review URL: http://codereview.chromium.org/333017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30095 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/330020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30093 0039d316-1c4b-4281-b951-d872f2087c98

BUG=18120
TEST=Open google.com, type Ctrl+F, type in garbage. Erase one letter at a time and there should be no beeping while you erase. Try it again, but this time use shift-delete to cut a few letters off the end. It should not ding. Now Copy the whole find string, press Esc, open Find again and on Paste it should not ding.

Review URL: http://codereview.chromium.org/338005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30092 0039d316-1c4b-4281-b951-d872f2087c98

o Adds Cocoa implementation of the extension installation prompt.
o Added new cross-platform implementations of the extension install error prompt.
o Got rid of unused extension install strings from early implementations.
o Added a string to display as the header of the error dialog, since it was inline English.

Patch by Andrew Bonventre <andybons@gmail.com>

BUG=19654
TEST=Install an extension on any platform, observe consistent visual behavior and messaging.
Review URL: http://codereview.chromium.org/333015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30091 0039d316-1c4b-4281-b951-d872f2087c98

TBR=ojan

Review URL: http://codereview.chromium.org/335033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30089 0039d316-1c4b-4281-b951-d872f2087c98

This also cleans up some of the InfoBubbleGtk code a bit.

BUG=23373
TEST=tested LTR and RTL under metacity

Review URL: http://codereview.chromium.org/332022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30088 0039d316-1c4b-4281-b951-d872f2087c98

BookmarkHTMLWriterTest.Test (suspected resource flakiness)
LoginPromptTest.TestTwoAuths

TEST=none
BUG=17592, 25794

Review URL: http://codereview.chromium.org/332024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30087 0039d316-1c4b-4281-b951-d872f2087c98

BUT=24145
Review URL: http://codereview.chromium.org/338024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30086 0039d316-1c4b-4281-b951-d872f2087c98

TBR=ojan

Review URL: http://codereview.chromium.org/337029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30085 0039d316-1c4b-4281-b951-d872f2087c98

BUG=25823
TEST=HostCacheTest.KeyComparator

Review URL: http://codereview.chromium.org/338023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30084 0039d316-1c4b-4281-b951-d872f2087c98