GitLab

This may be causing this crash:
Note: Google Test filter = PrerenderBrowserTest.PrerenderUnload
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from PrerenderBrowserTest, where TypeParam = 
[ RUN      ] PrerenderBrowserTest.PrerenderUnload
[2464:2324:0302/211059:6709843:FATAL:profile_dependency_manager.cc(134)] Check failed: false. Attempted to access a Profile that was ShutDown(). This is most likely a heap smasher in progress. After ProfileKeyedService::Shutdown() completes, your service MUST NOT refer to depended Profile services again.


Move InitExtensions into ExtensionSystem.
Remove a few accessors (ExtensionDevToolsManager, ExtensionMessageService). The others have too many callers to fix in one go.

BUG=104095
TEST=Open and close an incognito window; should not crash.


Review URL: http://codereview.chromium.org/9369013

TBR=yoz@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9583036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124831 0039d316-1c4b-4281-b951-d872f2087c98

Mostly works, the only problem is that the first touch or gesture on switching "modes" gets lost because Windows doesn't start a touch of the "other" type when TouchRegisterWindow is called while there's a touch in progress.

TBR=cpu

Review URL: http://codereview.chromium.org/9549020

TBR=scottmg@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9572033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124830 0039d316-1c4b-4281-b951-d872f2087c98

Also shortens one bit of code while I'm here.

BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9581029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124826 0039d316-1c4b-4281-b951-d872f2087c98

BUG=114732
TEST='existing tests'


Review URL: http://codereview.chromium.org/9564047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124824 0039d316-1c4b-4281-b951-d872f2087c98

Add a DeleteKey() method to delete a key from the meta table.  This will be used in the TemplateURL refactoring changes.

Reorder function definitions to match declaration order.  Shorten a few bits.

BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9584031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124823 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124822 0039d316-1c4b-4281-b951-d872f2087c98

TBR=haraken@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9581035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124821 0039d316-1c4b-4281-b951-d872f2087c98

R=pkasting@chromium.org
TBR=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9588003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124820 0039d316-1c4b-4281-b951-d872f2087c98

BUG=24672
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9484003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124819 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jsbell
BUG=113159, 116438

Review URL: https://chromiumcodereview.appspot.com/9585035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124818 0039d316-1c4b-4281-b951-d872f2087c98

Move InitExtensions into ExtensionSystem.
Remove a few accessors (ExtensionDevToolsManager, ExtensionMessageService). The others have too many callers to fix in one go.

BUG=104095
TEST=Open and close an incognito window; should not crash.


Review URL: http://codereview.chromium.org/9369013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124817 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124816 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE
TEST=NONE

Review URL: https://chromiumcodereview.appspot.com/9585024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124815 0039d316-1c4b-4281-b951-d872f2087c98

BUG=115629

Review URL: http://codereview.chromium.org/9460010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124814 0039d316-1c4b-4281-b951-d872f2087c98

Mostly works, the only problem is that the first touch or gesture on switching "modes" gets lost because Windows doesn't start a touch of the "other" type when TouchRegisterWindow is called while there's a touch in progress.

TBR=cpu

Review URL: http://codereview.chromium.org/9549020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124813 0039d316-1c4b-4281-b951-d872f2087c98

Made the parentId argument for bookmarks.create() optional.
The default is the "Other Bookmarks" folder.

BUG=21410
TEST=Some of the bookmarks tests have been reported as flaky, so you will need
to change "DISABLED_Bookmarks" to "Bookmarks" in
chrome/browser/bookmarks/bookmark_extension_apitest.cc to run my test.
My test is called createNoParentId.


Review URL: http://codereview.chromium.org/9420041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124812 0039d316-1c4b-4281-b951-d872f2087c98

It is used to support the Android Bookmark Provider;
It caches the favicon id, visit time, created time,
bookmark information from thumbnail database, url
database and BookmarkModel.

The database is created in first access of AndroidProviderBackend,
and deleted after history backend shutdown, synced before
AndroidProviderBackend's Query, Insert, Update or Delete method
called.

BUG=
TEST=


Review URL: http://codereview.chromium.org/9549031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124811 0039d316-1c4b-4281-b951-d872f2087c98

BUG=114808


Review URL: http://codereview.chromium.org/9545010

TBR=sergeyu@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9585033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124809 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8598030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124808 0039d316-1c4b-4281-b951-d872f2087c98

Fixes compile errors and marks failing tests as FAILED to get
bots green.  Will tackle proper fixes to tests in follow-on CLs.

BUG=None
TEST=ShellTest.FAILS_OverlappingWindowModeBasics, CompactLayoutManagerTest.FAILS_TransitionTest, RootWindowEventFilterTest.FAILS_TransformActivate, ToplevelWindowEventFilterTest.FAILS_EscapeReverts
R=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9585028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124807 0039d316-1c4b-4281-b951-d872f2087c98

Only PanelManager adds/removes panels from panel strips.
Only exception is in tests.

BUG=None
TEST=Existing tests.


Review URL: http://codereview.chromium.org/9560002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124806 0039d316-1c4b-4281-b951-d872f2087c98

Current unit test use locally defined kCloseCodeNormalClosure as a close code.
Now, PPB_WebSocket provide API defined status codes. The test must use
PP_WEBSOCKETSTATUSCODE_NORMAL_CLOSURE instead of kCloseCodeNormalClosure.

BUG=87310
TEST=ui_tests --gtest_filter='PPAPI*Test.WebSocket*'


Review URL: http://codereview.chromium.org/9586015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124805 0039d316-1c4b-4281-b951-d872f2087c98

Previously, SSLInfo was given the cert chain as served by the server. It is
more useful and correct to provide higher layers the cert chain as
validated.

BUG=77757, 87303, 115312
TEST=net_unittests SSLClientSocketTest.VerifyReturnChainProperlyOrdered

Review URL: http://codereview.chromium.org/9442001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124804 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/9545008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124803 0039d316-1c4b-4281-b951-d872f2087c98

We support USB Bluetooth adapters being inserted and removed from our
older Chromebooks, so as well as showing the Bluetooth settings on
insertion we need a function to hide the settings pane again when the
adapter is pulled out.

BUG=chromium-os:27103
TEST=(with plumbing from later CL) removed adapter, verified the settings section vanished

Change-Id: I1e820e4f660787e4f74c28761114459fc29352c5


Review URL: http://codereview.chromium.org/9568054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124802 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124801 0039d316-1c4b-4281-b951-d872f2087c98

Only change: Silence genperf's success-related chatter.



Review URL: http://codereview.chromium.org/9584027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124800 0039d316-1c4b-4281-b951-d872f2087c98

This CL implements the auto-logout feature for Kiosk mode. The timeouts are pulled from the kiosk_mode_helper class.

This CL implements parts of the code for http://codereview.chromium.org/9265026/
Though this code is vastly refactored and reduced.

R=xiyuan@chromium.org
BUG=chromium-os:26045
TEST=Tested with the flag to ensure the feature works correctly.


Review URL: http://codereview.chromium.org/9568038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124799 0039d316-1c4b-4281-b951-d872f2087c98

BUG=114808


Review URL: http://codereview.chromium.org/9545010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124797 0039d316-1c4b-4281-b951-d872f2087c98

Minimized panels are not "minimized" from the OS point of view so they may receive focus when other windows are minimized or closed. This patch sets the flags on the minimized panels in such way that they are not activated by the OS but still appear in the Alt-Tab menu and on the taskbar.

BUG=102721
TEST=Manually verify that minimized panels do not open spontaneously when other windows are closed, but are accessible through the taskbar and Alt-Tab.


Review URL: http://codereview.chromium.org/9463022

TBR=aburago@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9593001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124795 0039d316-1c4b-4281-b951-d872f2087c98

can be enabled with command line flag --flow-control

R=willchan
TEST=network unittests
BUG=116167

Review URL: http://codereview.chromium.org/9516009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124794 0039d316-1c4b-4281-b951-d872f2087c98

Ensure pipelined requests are sent in the same order they're queued. Also, ensure HttpPipeliningCompatibilityClient closes the stream when it's done with a request.

BUG=110794
TEST=net_unittests and unit_tests


Review URL: http://codereview.chromium.org/9567025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124793 0039d316-1c4b-4281-b951-d872f2087c98

BUG=115845
TEST=none
R=ben@chromium.org


Review URL: http://codereview.chromium.org/9582025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124792 0039d316-1c4b-4281-b951-d872f2087c98

TEST=./net_unittests --gtest_filter=HostResolverImplTest.CanceledRequestsReleaseJobSlots

Review URL: https://chromiumcodereview.appspot.com/9584035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124791 0039d316-1c4b-4281-b951-d872f2087c98

Minimized panels are not "minimized" from the OS point of view so they may receive focus when other windows are minimized or closed. This patch sets the flags on the minimized panels in such way that they are not activated by the OS but still appear in the Alt-Tab menu and on the taskbar.

BUG=102721
TEST=Manually verify that minimized panels do not open spontaneously when other windows are closed, but are accessible through the taskbar and Alt-Tab.


Review URL: http://codereview.chromium.org/9463022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124790 0039d316-1c4b-4281-b951-d872f2087c98

BUG=116189


Review URL: http://codereview.chromium.org/9584022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124789 0039d316-1c4b-4281-b951-d872f2087c98

Changed <code> to @code and </code> to @endcode (for formatting issues. Removed .html (extensions not needed for DevSite) as per Andy.

Review URL: http://codereview.chromium.org/9421037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124788 0039d316-1c4b-4281-b951-d872f2087c98

This change attempts to reduce the load time of the file manager (especially on slow Alex devices) by trimming unnecessary work done in javascript and reducing layouts.

- Enable batch updating in cr.ui.Table (exactly how it's done in cr.ui.List).
- Add more 'on complete' callbacks to some of the FileManager infrastructure so we know when to stop batch UI updates.
- Use batch updates for some operations which profiling indicates causes non-trivial amounts of duplicated work.  In particular, in my testing this reduces the number of (sometimes expensive) List.redraw() calls on startup for the table from 6 down to 1, and for the roots list from 4 down to 2.

Measurements on alex are quite variable, but these changes result in about 70ms savings on startup (or about 17% of the time spent under 'v8.callChromeHiddenMethod' - i.e. JS callbacks through the extension system, which itself is about 1/3rd of total load time).

The majority of file manager load time is spent inside of v8, and there are many more opportunities like these to trim various code paths.  But it seems clear that major improvements are going to require more drastic approaches (eg. I'm experimenting with painting the initial UI after parsing/running a small fraction of the JS).

BUG=105181
TEST=


Review URL: http://codereview.chromium.org/9379023

TBR=rbyers@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9580035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124786 0039d316-1c4b-4281-b951-d872f2087c98

Also re-introduces a missing life check in case a request callback deletes the HostResolver.

R=eroman@chromium.org,cbentzel@chromium.org
BUG=115399
TEST=./net_unittest --gtest_filter=HostResolverImplTest.CanceledRequestsReleaseJobSlots


Review URL: http://codereview.chromium.org/9572018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124783 0039d316-1c4b-4281-b951-d872f2087c98

There were two problems.
1) We had started to write into profile/IndexedDB/IndexedDB/origin.leveldb/ (note the double IndexedDB).
2) We were writing into file__0.leveldb but checking for quota in __0.leveldb.  Now we always use __0.leveldb.

BUG=104748
TEST=


Review URL: http://codereview.chromium.org/9567030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124782 0039d316-1c4b-4281-b951-d872f2087c98