GitLab

In working on importing a newer version of SQLite, I found that I could
not find a copy of the previous version.  This makes it harder to figure
out if we have any mods which need to be tracked or unwound.

This import should be a non-event, since most of the files are identical
to the files in third_party/sqlite/src/ , so git will just add a reference.

BUG=340757

Review URL: https://codereview.chromium.org/826543003

Cr-Commit-Position: refs/heads/master@{#311378}

Also, removing special case where certain metrics where summed instead of averaged since they are now handled in the dashboard by averaging, no longer making them special cases.

BUG=447588

Review URL: https://codereview.chromium.org/847273002

Cr-Commit-Position: refs/heads/master@{#311377}

This forces WeakPtrs to be invalidated before other members' destructors run.
See the bug or the documentation of WeakPtrFactory for more information. I'm
in the process of trying to turn on a clang check for this (see the bug).

BUG=303818
R=asargent@chromium.org

Review URL: https://codereview.chromium.org/846153005

Cr-Commit-Position: refs/heads/master@{#311376}

Compile of app_list_unittests on toolkit-views enabled Mac regressed in
r311143 because it accessed aura::Window and there is no Aura on Mac
yet.

The MouseHoverToHighlight passes on Mac - it just needs to initialize
the event generator differently.

TapGestureToHighlight is disabled on Mac, since there are no touch
events on desktop Mac.

BUG=441573, 445520, 365977

Review URL: https://codereview.chromium.org/840373003

Cr-Commit-Position: refs/heads/master@{#311375}

This regressed in r311208.

AppListBackground constructor no longer takes two arguments.

BUG=365977

Review URL: https://codereview.chromium.org/789333004

Cr-Commit-Position: refs/heads/master@{#311374}

This forces WeakPtrs to be invalidated before other members' destructors run.
See the bug or the documentation of WeakPtrFactory for more information. I'm
in the process of trying to turn on a clang check for this (see the bug).

BUG=303818
R=stevenjb@chromium.org

Review URL: https://codereview.chromium.org/841103003

Cr-Commit-Position: refs/heads/master@{#311373}

This reduces duplciation and allows for hooks (e.g. tracing)
at the kernel proxy boundary.

R=binji

Review URL: https://codereview.chromium.org/757293005

Cr-Commit-Position: refs/heads/master@{#311372}

Recent changes to CDM_7 removed |destination_url| as it is no longer
used in the EME spec. However legacy applications using the prefixed
EME API depend on it, so adding it back in so that it is available
to those applications.

BUG=448242
TEST=existing EME tests pass + Play movies play

Review URL: https://codereview.chromium.org/813683005

Cr-Commit-Position: refs/heads/master@{#311371}

BUG=448596
TBR=ncbray@chromium.org
CC=sbc@chromium.org,rch@chromium.org,teravest@chromium.org

Review URL: https://codereview.chromium.org/851843002

Cr-Commit-Position: refs/heads/master@{#311370}

BrowsingDataAppCacheHelper no longer needs to be able to cancel its callback,
so remove the "CancelableCallback" member. The current code is also not
correct usage of CancelableCallback, because the callback can be deleted on a
different thread than where it was created. This was making a DCHECK fail when
trying to fix a problem in CancelableCallback (see
https://code.google.com/p/chromium/issues/detail?id=433583#c1).

BUG=433583
R=michaeln@chromium.org

Review URL: https://codereview.chromium.org/851553003

Cr-Commit-Position: refs/heads/master@{#311369}

When toolkit_views flips on Mac, the browser UI will still be Cocoa.

This audits the remaining TOOLKIT_VIEWS #defines under
chrome/browser/ui. Mostly constants designed for the views browser UI
that will introduce UI glitches while the Cocoa UI is still used on Mac.

For many of these the #elif defined(TOOLKIT_VIEWS) is redundant, but it
is kept as something to grep for when the browser UI eventually becomes
Views-based.

BUG=439882

Review URL: https://codereview.chromium.org/844333003

Cr-Commit-Position: refs/heads/master@{#311368}

The contents of this file seems to be all legacy
stuff.  These days all the build products end up in
the 'out' directory.

Review URL: https://codereview.chromium.org/835233004

Cr-Commit-Position: refs/heads/master@{#311367}

BUG=448439

Review URL: https://codereview.chromium.org/847043004

Cr-Commit-Position: refs/heads/master@{#311366}

BUG=417463

Review URL: https://codereview.chromium.org/848973002

Cr-Commit-Position: refs/heads/master@{#311365}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/2a7b861..0fda955

TBR=hayato@chromium.org,zmo@chromium.org

Review URL: https://codereview.chromium.org/853463005

Cr-Commit-Position: refs/heads/master@{#311364}

BUG=428729

Review URL: https://codereview.chromium.org/810193007

Cr-Commit-Position: refs/heads/master@{#311363}

This adds the UMA call to record when SSL warnings are caused by self-
signed certs.

It also updates the histogram name: SSLNonAttackCauses is no longer
an appropriate name because a self-signed cert very well might be an
attack.

BUG=392310
R=palmer@chromium.org

Review URL: https://codereview.chromium.org/808053007

Cr-Commit-Position: refs/heads/master@{#311362}

BUG=412384

Review URL: https://codereview.chromium.org/843113002

Cr-Commit-Position: refs/heads/master@{#311361}

BUG=
TEST=chromevox_tests (and manualy on Sheets format panel).

Review URL: https://codereview.chromium.org/841453005

Cr-Commit-Position: refs/heads/master@{#311360}

BUG=443392

Review URL: https://codereview.chromium.org/809713006

Cr-Commit-Position: refs/heads/master@{#311359}

The gin::Runner should be destroyed when the JS context is so that its
weak pointers are invalidated and any outstanding callbacks that
interact with the JS context can detect its destruction. Currently,
ScriptContext implements gin::Runner but is not immediately destroyed
when the JS context is. This CL moves this gin::Runner implementation
into a separate class which is destroyed when the ScriptContext is
invalidated.

Review URL: https://codereview.chromium.org/831423005

Cr-Commit-Position: refs/heads/master@{#311358}

A bug in onc_translator_onc_to_shill.cc is triggering a DCHECK when
a property is set in a previously non-existent dictionary.

This is a trivial fix to code that is subtle but clearly incorrect
by inspection.

BUG=none

Review URL: https://codereview.chromium.org/838043003

Cr-Commit-Position: refs/heads/master@{#311357}

ForkWithFlags is a wrapper around the clone syscall that uses the libc clone
wrapper, and thus updates the libc's pid cache if it has one (using sys_clone
directly does not update the pid cache, so getpid may return an incorrect
result in the child). This exposes the ability to set clone flags, which is
needed to use Linux namespaces.

BUG=312380

Review URL: https://codereview.chromium.org/840893003

Cr-Commit-Position: refs/heads/master@{#311356}

Fixing incorrect handling of out of range descriptors passed as newfd to dup2.

Fixing incorrect free descriptor management when using dup2 on a previously
allocated descriptor value.

Replacing a heap with a std::set, to allow descriptor deletion from the free
set in O(lg n).

Dropping impossible case where dup2ing a null handle.

TEST=Added two nacl_io_tests.
BUG=None
R=binji@chromium.org

Review URL: https://codereview.chromium.org/849743002

Cr-Commit-Position: refs/heads/master@{#311355}

BUG=417463

Review URL: https://codereview.chromium.org/848963002

Cr-Commit-Position: refs/heads/master@{#311354}

On ChromeOS the accelerometer needs to be read by both ash/ and content/

This change removes the ownership of AccelerometerReader from Shell, changing it into a Singleton.

TEST=Confirmed that a device with an accelerometer enters maximize mode.
BUG=342908

Review URL: https://codereview.chromium.org/822503003

Cr-Commit-Position: refs/heads/master@{#311353}

If a ui::TouchEvent is missing a radius on one axis, use the value from the other axis.

BUG=406004

Review URL: https://codereview.chromium.org/822803005

Cr-Commit-Position: refs/heads/master@{#311352}

BUG=

Review URL: https://codereview.chromium.org/852623002

Cr-Commit-Position: refs/heads/master@{#311351}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/199ba8e..bb928a0

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=djsollen@google.com

Review URL: https://codereview.chromium.org/808423003

Cr-Commit-Position: refs/heads/master@{#311350}

This forces WeakPtrs to be invalidated before other members' destructors run.
See the bug or the documentation of WeakPtrFactory for more information. I'm
in the process of trying to turn on a clang check for this (see the bug).

BUG=303818
R=morrita@chromium.org

Review URL: https://codereview.chromium.org/848533003

Cr-Commit-Position: refs/heads/master@{#311349}

Focus was not maintained because the elements in the row did not have focus when the menu was displayed. Change makes it so that the delete happens when the menu is no longer displayed. This allows the normal code path to run and maintain focus.

Updated unit test so that the appropriate event is tested.

BUG=431029

Review URL: https://codereview.chromium.org/751763003

Cr-Commit-Position: refs/heads/master@{#311348}

If the tab is instructed to print while the native side is not properly
initialized, it will now fail gracefully instead of crashing.

BUG=445467

Review URL: https://codereview.chromium.org/837773008

Cr-Commit-Position: refs/heads/master@{#311347}

R=qsr

Review URL: https://codereview.chromium.org/835223004

Cr-Commit-Position: refs/heads/master@{#311346}

"pushed_it" created early can point to expired entry.
DeleteExpiredPushedStreams will remove actual entry invalidating "pushed_it"
iterator. std::map::insert will crash when invalid iterator passed as hint.

Swap inserting new element and removing expired ones so iterator will stay
valid until late.

BUG=443490
R=bnc@chromium.org, rch@chromium.org

Review URL: https://codereview.chromium.org/813993002

Cr-Commit-Position: refs/heads/master@{#311345}

BUG=448521
TBR=enne@chromium.org

Review URL: https://codereview.chromium.org/851803002

Cr-Commit-Position: refs/heads/master@{#311344}

Multiple implementations of this functionality exist with slight modifications. This CL consolidates them.

Note: This is a reland of https://codereview.chromium.org/823143004/, which was reverted due to memory leaks, which are now fixed.

BUG=329911
TBR=phajdan.jr@chromium.org,thestig@chromium.org,stevenjb@chromium.org  # Reland.

Review URL: https://codereview.chromium.org/851703002

Cr-Commit-Position: refs/heads/master@{#311343}

Get rid of flakiness in android_dbg_tests_recipe bots.

BUG=448518
TEST=
TBR=dmazzoni@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/847263002

Cr-Commit-Position: refs/heads/master@{#311342}

This is the first CL to move the test template to //testing/test.gni

This CL is just creating an empty test.gni file. It is needed because
the test template is used in Blink, so we need to makes this change in
stages.

R=cjhopman@chromium.org

Review URL: https://codereview.chromium.org/850743003

Cr-Commit-Position: refs/heads/master@{#311341}

https://chromium.googlesource.com/angle/angle/+log/04184fb046..9e0478f62

BUG=447140

Review URL: https://codereview.chromium.org/847253002

Cr-Commit-Position: refs/heads/master@{#311340}

The active user is always Guest. This is dead code from way back when
the User Manager was displayed under a specific, regular profile.

BUG=NONE

Review URL: https://codereview.chromium.org/788993006

Cr-Commit-Position: refs/heads/master@{#311339}