GitLab

This reverts commit 5c5ce638.

Reason for revert: broke the build

Original change's description:
> Make histograms/pretty_print_test.py run on the bots.
> 
> This test was added via:
> https://chromium-review.googlesource.com/1244553
> 
> This is a follow-up CL to add it to metrics_python_tests so
> that it will run on the bots.
> 
> Renames Python files to avoid name collisions between
> different scripts, so that they can run together as part of
> metrics_python_tests. Also fixes up the rappor model test
> and adds it to the suite.
> 
> Bug: 714123
> Change-Id: I466584493f7090decdb8b21217347a905b3e6391
> Reviewed-on: https://chromium-review.googlesource.com/c/1255596
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#596921}

TBR=dpranke@chromium.org,asvitkine@chromium.org,holte@chromium.org

Change-Id: Iebebe68f9c4c4da11e6e79fc14b9853bea737e5c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 714123
Reviewed-on: https://chromium-review.googlesource.com/c/1263434Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596931}

Bug: 889233
Change-Id: I15614c6eef636f4e7b4dd0f204ee4155d3246cfa
Reviewed-on: https://chromium-review.googlesource.com/c/1262642Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596930}

https://chromium.googlesource.com/angle/angle.git/+log/49b0f6eb413b..14246813a110


git log 49b0f6eb413b..14246813a110 --date=short --no-merges --format='%ad %ae %s'
2018-10-04 jmadill@chromium.org Update sampler directly on Texture change.
2018-10-04 jmadill@chromium.org Update Textures immediately on program change.


Created with:
  gclient setdep -r src/third_party/angle@14246813a110

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=cwallez@chromium.org

Change-Id: I1663ed81840505e48af338b092d095e575b95f32
Reviewed-on: https://chromium-review.googlesource.com/c/1262981Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#596929}

This change substancially refactors chromeos::ProfileAuthData so that it
uses the CookieManager interface provided by the Network Service rather
than calling into net::CookieStore directly. Since the new interface can
be called from the UI thread this change breaks apart the work performed
by this class into tasks which can each complete on the necessary
thread.

The ProfileAuthDataTransferer class is made RefCountedDeleteOnSequence
so that the completion callback is run on the UI thread after all tasks
are complete and the object is destroyed.

Bug: 792678
Change-Id: I3378def190191235ae277902e855240b131a1961
Reviewed-on: https://chromium-review.googlesource.com/c/1263054
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596928}

This patch adds an idl for acquireDisplayLock and DisplayLockContext
with a schedule function. Also adds a naive implementation that just
runs the callback immediately, which makes the layout test pass.

The test should keep passing whenever we actually start implementing
the feature.

See the bug for description of the feature.

R=chrishtr@chromium.org

Bug: 882663
Change-Id: Ia8770e2ca3e6387eec3946c770d0f47cf57d23b4
Reviewed-on: https://chromium-review.googlesource.com/c/1258247
Commit-Queue: vmpstr <vmpstr@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596927}

BUG=892240

Change-Id: I500a4c0e2d3ee1192e203581d5c40fcfe8757683
Reviewed-on: https://chromium-review.googlesource.com/c/1262964Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596926}

This reverts commit 535e31ec.

Reason for revert: Broke code coverage builds: crbug.com/891320

Bug: 891320

Original change's description:
> viz: HitTest debug logging.
>
> Ctrl+Shift+H to trigger. Requires --enable-viz-hit-test-debug flag and logging level of 1 on hit_test_debug_key_event_observer.
>
> Adds observer to render_widget_host_impl to act on OnInputEventAck.
>
> Example: https://pastebin.com/pcxrZv6A
>
> R=​riajiang@chromium.org
>
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
> Change-Id: I1c9a0867debe5b4aa670a51f85fe24909073374c
> Reviewed-on: https://chromium-review.googlesource.com/1226099
> Commit-Queue: Alexander Shah <zandershah@google.com>
> Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
> Reviewed-by: Ria Jiang <riajiang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#595563}

TBR=sadrul@chromium.org,nzolghadr@chromium.org,riajiang@chromium.org,zandershah@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I51780234c0ee6ed9e4cdae71ef839cc5b4f633f7
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/c/1262926
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596925}

AnimationHost::mutator_host_client_ is null during its destruction.
So any code that is invoked during the destruction should not assume that
client is available.

This patch fixes ElementAnimation::ClearAffectsElementTypes() so that it
explicitly checks for client being null. This code is invoked during
destruction per following stacktrace:


cc::ElementAnimations::ClearAffectedElementTypes()
cc::AnimationHost::UnregisterKeyframeEffectForElement(cc::ElementId, cc::KeyframeEffect*)
cc::Animation::UnregisterKeyframeEffects()
cc::Animation::DetachElement()
cc::AnimationTimeline::ClearAnimations()
cc::AnimationHost::ClearMutators()
cc::AnimationHost::~AnimationHost()


Bug:892068

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ifb3d0888d30553493c0d35a20f5d20e0bfe74696
Reviewed-on: https://chromium-review.googlesource.com/c/1261376
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Ali Juma <ajuma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596924}

This change makes it so GpuChannelEstablishFactory is publically accessible,
and non-content code can use it to get access to GpuMemoryBufferManager and
to create context providers.

Cq-Include-Trybots: luci.chromium.try:linux_chromium_dbg_ng
Change-Id: Iba90a603a6326c61447acd21037b5e9b6573356c
Reviewed-on: https://chromium-review.googlesource.com/c/1262621Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596923}

https://pdfium.googlesource.com/pdfium.git/+log/d8ac668fad02..047347605c81


git log d8ac668fad02..047347605c81 --date=short --no-merges --format='%ad %ae %s'
2018-10-04 tsepez@chromium.org Remove CPDFSDK_DateTime entirely.
2018-10-04 tsepez@chromium.org CPDF_VariableText::m_nHorzScale is always 100
2018-10-04 tsepez@chromium.org CPDFSDK_AnnotHandlerMgr::Annot_OnCreate() is not called.


Created with:
  gclient setdep -r src/third_party/pdfium@047347605c81

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I45dc6ca3d734159ec9c3e01c98e950b6bf96b4ae
Reviewed-on: https://chromium-review.googlesource.com/c/1262980Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#596922}

This test was added via:
https://chromium-review.googlesource.com/1244553

This is a follow-up CL to add it to metrics_python_tests so
that it will run on the bots.

Renames Python files to avoid name collisions between
different scripts, so that they can run together as part of
metrics_python_tests. Also fixes up the rappor model test
and adds it to the suite.

Bug: 714123
Change-Id: I466584493f7090decdb8b21217347a905b3e6391
Reviewed-on: https://chromium-review.googlesource.com/c/1255596Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596921}

This reverts commit 60ed0f8d.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> [perf] Add browse:media:tumblr:2018 system health story
> 
> This also add a login helper for tumblr and updates credentials.json
> 
> Bug: 878390
> Change-Id: Iba56faf550cb638692899326b217347e04be9932
> Reviewed-on: https://chromium-review.googlesource.com/c/1256883
> Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
> Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#596763}

TBR=ulan@chromium.org,perezju@chromium.org,cbruni@chromium.org

Change-Id: Ie3500851b331cb8be91fd0f1f8a5de148e63ab70
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 878390,892425
Reviewed-on: https://chromium-review.googlesource.com/c/1263351Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596920}

Mixins can now apply to any key in a test. Previously they only applied
to swarming configuration values.

Also updates mixin docs, and uses the mixins to set args for the 'chromium'
master scripts.

Change-Id: I20396556464d9f268903afeda1231d83f2aba45a
Reviewed-on: https://chromium-review.googlesource.com/c/1258604
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596919}

Also fixed "Open in" unit test as the existing test was already passing a
corrupted PDF data to the UrlLoader. the reason was that the generated
pdf data had null characters, So when casting it to char* then converting
that to string it produced 8 letters Data stream.

Added unittest for the corrupted pdf case.

Bug: 892211
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I4fff1e22f617e6a0b2c08d9c6412e14265b8aab4
Reviewed-on: https://chromium-review.googlesource.com/c/1261926
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596918}

On LUCI this builder is on 'chromium.mac' master, so by default Buildbucket
looks for its migration status on (chromium.mac, WebKit Mac 10.13 (retina))
page, which doesn't exist (because there are no such Buildbot builder).

With this change, Buildbucket will look at correct Buildbot builder instead.

R=jchinlee@chromium.org, nodir@chromium.org
BUG=818301, 864817

Change-Id: Id821857a971e36d1da9b2437950efb39f2c27cb4
Reviewed-on: https://chromium-review.googlesource.com/c/1263343Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596917}

- Env owns WindowOcclusionTracker to make it a per-Env singleton;
- Expose the tracker API via Window::SetTrackOcclusionState, which
  later will be wired differently based on aura mode. For LOCAL
  aura, it calls tracker in local Env. For MUS aura, the code path
  will be go through WindowTree interface and use the tracker
  in WindowService Env;
- ScopedPauseOcclusionTracking -> ScopedPause since it is a nested
  class and WindowOcclusionTracker::ScopedPause is clear enough;

Bug: 867150
Change-Id: I73d6e0e0a31dae2e69307b35322fe6501289e889
Reviewed-on: https://chromium-review.googlesource.com/c/1259039
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596916}

Point chrome/browser/chromeos/policy/OWNERS to chromeos/policy/OWNERS.

Change-Id: Ifa77f18ad5faf81f7cc4cc4d81e04bbc16a57fab
Reviewed-on: https://chromium-review.googlesource.com/c/1263050Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596915}

This CL:
1) Moves SelectWordAroundCaret{Ack}() from RenderViewHost to
RenderFrameHost.
2) Moves SelectWordAroundCaret() from RenderView to FrameInputHandler,
the new place is more suitable for this function.
3) Migrates IPC to mojo, and does other IPC cleanup.

Bug: 716618, 545684
Change-Id: Ied823345dc7ff68ea6dd505eeb14ab5c6aca17d1
Reviewed-on: https://chromium-review.googlesource.com/c/821561Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596914}

https://skia.googlesource.com/skia.git/+log/ae16b74365f4..4302eb9a6e14


git log ae16b74365f4..4302eb9a6e14 --date=short --no-merges --format='%ad %ae %s'
2018-10-04 mtklein@google.com Revert "remove deprecated SkRect::MakeFromIRect()"
2018-10-04 mtklein@google.com remove SkColorSpaceTransferFn::invert()
2018-10-04 brianosman@google.com Restore proper name of the SkImage_Gpu2Cpu unit test
2018-10-04 halcanary@google.com SK_SUPPORT_LEGACY_DOCUMENT_FACTORY: clean up part 2/2


Created with:
  gclient setdep -r src/third_party/skia@4302eb9a6e14

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
TBR=mtklein@chromium.org

Change-Id: Ic7fefe114ea42e32f13a0fcda829842ed2706447
Reviewed-on: https://chromium-review.googlesource.com/c/1262976Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#596913}

Jumbo Build Fix: Fix windowsx.h Conflict with HwndMessageHandler::IsMaximized and HwndMessageHandler::IsMinimized

windowsx.h defines the following which break HwndMessageHandler:

BUG=
TBR=sky@chromium.org
Windows jumbo build break.

Change-Id: Icc2feeb8496ee80fa59f40b2f21850af1197fdd0
Reviewed-on: https://chromium-review.googlesource.com/c/1263115Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596912}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bf0d2438ae53..6a311a5b505c


Created with:
  gclient setdep -r src-internal@6a311a5b505c

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I7c10f64a31f773e80a8e62bf99be643b6f954999
Reviewed-on: https://chromium-review.googlesource.com/c/1262977Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#596911}

The V2 sandbox is now default for all but the network and GPU processes
on macOS. This CL deletes the feature flag. A new experiment will be
introduced for the GPU process.

Bug: 749839
Change-Id: Idb65a83f25f48db5aaf8d8d2400992640673d0e8
Reviewed-on: https://chromium-review.googlesource.com/c/1258214
Commit-Queue: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596910}

- Remove the last usage from FindPaintOffsetNeedingUpdate of
  TransformPaintPropertyNode::Clone() and operator==(), so we
  can remove them. This will make it easy to add move-only data
  in TransformPaintPropertyNode::State.

- Now FindPaintOffsetNeedingUpdateScope is also detecting unexpected
  change of PaintOffsetTranslation during UpdateForSelf(), and unexpected
  change of paint offset and PaintOffsetTranslation during
  UpdateForChildren(). Previously it detected unexpected change of
  paint offset during UpdateForObjectLocationAndSize() only.

- Now FindPropertyNeedingUpdateScope is also detecting unexpected
  change of FragmentClip. It no longer detects unexpected change of
  paint offset which is now detected by FindPaintOffsetNeedingUpdateScope.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Id78fa30f51445698d3f93e26c8b7852e3811bedb
Reviewed-on: https://chromium-review.googlesource.com/c/1260124
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596909}

2d translations (e.g. for paint offset translation, scroll translation)
are very common in our paint property trees. In many cases
GeometryMapper::SourceToDestinationProjection() deals with source and
destination transforms under a common subtree that contains 2d
translations only, and we expect that the result to be a 2d translation.

However, previously, in the case we used
 source_from_plane_root_or_screen * destination_to_plane_root_or_screen
which includes transforms and inverse of transforms of some common
ancestors of the input transforms, and contains accumulated floating
point errors when calculating the inverses and multiplications of the
common ancestors. The new test case in this CL shows the problem.

Now let GeometryMapperTransformCache cache the 2d translation root
of the transform node. In GeometryMapper::SourceToDestinationProjection(),
if the input transforms are under the same 2d translation root, we
can use the fast path to calculate the result which will be a 2d
translation.

Also reduce the size of the GeometryMapperTransformCache in common
cases by allocating plane root transform and screen transform only when
needed.

Bug: 891799
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I926b337469d0c8d79ee6a63f7c0e2f15781266d2
Reviewed-on: https://chromium-review.googlesource.com/c/1259663
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596908}

54e0bebf added a histogram to collect metrics on the results of
attestation prompts in webauthn. While there is still a sizable amount
of legacy U2F usage, it's useful to collect similar metrics there too.

This change causes U2F to also emit events for the existing histogram.
Since we don't want to do significant work on the U2F code at this
point, the granularity of the metrics in the U2F case is limited:
there's no direct link to the frame nor U2F logic in the C++ code so
timeouts aren't detected and abandonments are classified as negative
responses—same as explicit user interactions.

Change-Id: Ibb58dc084a0bb6599744d7112cf9975cd278c4e0
Reviewed-on: https://chromium-review.googlesource.com/c/1255154
Commit-Queue: Adam Langley <agl@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596907}

This is a step toward supporting chrome browser windows under
single-process and multi-process mash.

Break AXHostService into two parts. The core AXHostService manages
a map of AXRemoteHostDelegates. Each AXRemoteHostDelegate is-a
ui::AXHostDelegate and therefore can handle PerformAction requests
from accessibility extensions. AXHostService receives incoming
AXEvents from remote apps and routes them to the correct
AXRemoteHostDelegate, which forwards them to the extension.

Integration tests already exist in SpokenFeedbackTest.

Added unit tests.

Bug: 888147
Test: unit_tests, views_mus_unittests
Change-Id: If2ee438b310acba9437a251bd77e06bfb7d9a099
Reviewed-on: https://chromium-review.googlesource.com/c/1260205
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596906}

This reverts commit 7cff6f2f.

Reason for revert: NavigationPopupTest.testFaviconFetching started crashing after this landed in https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20CFI/3164

Original change's description:
> Refactor NavigationPopup to not expose the View type to clients.
> 
> This is a step towards removing ListPopupWindow and using a vanilla
> Popup to deal with styling issues.
> 
> BUG=800033
> 
> Change-Id: I79506cdd7c3e840e13e9ebbabce39948a9fa5936
> Reviewed-on: https://chromium-review.googlesource.com/c/1259480
> Commit-Queue: Ted Choc <tedchoc@chromium.org>
> Reviewed-by: Becky Zhou <huayinz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#596734}

TBR=tedchoc@chromium.org,huayinz@chromium.org

Change-Id: I6a7d3c914fcca88e64eea4158fbea9db224d762c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 800033
Reviewed-on: https://chromium-review.googlesource.com/c/1263344Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596905}

As requested by UI review.

Bug: 891379
Change-Id: I0f5d69300852a4a8cae191684ceddb2c5fbfaa15
Reviewed-on: https://chromium-review.googlesource.com/c/1262431Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596904}

This CL adds several UMAs to track time spend each stage of service
worker involved main resource loading. The purpose of these UMAs is
to make it easier to investigate performance bottleneck.

Design doc:
https://docs.google.com/document/d/16K2X5k6hUq7lZSee-KXR9FUeSTEEypDXCjYbu_CvkT0/edit?usp=sharing

Cq-Include-Trybots: luci.chromium.try:linux_mojo
Bug: 877972
Change-Id: Ibb2433cafb090e66b450236ef2f5f1f4baa918bf
Reviewed-on: https://chromium-review.googlesource.com/c/1256384Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596903}

When the presentation request is set, use its origin in the dialog
header. E.g. "Cast youtube.com" instead of "Cast".

If the user selects a non-tab source (desktop or local file), switch to
using just "Cast".

Bug: 851610
Change-Id: I7c672e458fa82af0182e1d9ed20a7f922e3ad814
Reviewed-on: https://chromium-review.googlesource.com/c/1259618
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596902}

This CL adds a 4dp vertical margin on either side of the list inside a
Dropdown window. This is needed for the Autofill refresh.

Bug: 874077
Change-Id: If37016cafe886417cd4a82e9b59f75dd8ccbba7d
Reviewed-on: https://chromium-review.googlesource.com/c/1262962
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596901}

https://webrtc.googlesource.com/src.git/+log/f638bbc181eb..264079a57aec


git log f638bbc181eb..264079a57aec --date=short --no-merges --format='%ad %ae %s'
2018-10-04 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 70554c25..c5c13a1e (596607:596716)


Created with:
  gclient setdep -r src/third_party/webrtc@264079a57aec

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Idab1cc9860710c239fd9be8515a4421b28d54d6e
Reviewed-on: https://chromium-review.googlesource.com/c/1262855Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#596900}

The Feed NTP attaches the SnapScrollHelper before scroll position
restoration, but legacy Zine attaches after. Thus, changing the current
logic for search box scrolling to handle scroll position restoration
well.

Bug: 889228
Change-Id: Ib2055b0e98b877ee3ced35356af2cf3b26743480
Reviewed-on: https://chromium-review.googlesource.com/c/1259609
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596899}

This CL adds a few new .h and .cc files for upcoming omnibox Pedals
prototype.  None of this code is used yet, but changes necessary
to ensure that one Pedal can be used are included so it compiles.

Change-Id: If3d03e1fd532fdace55bde941ab1d5597748a168
Reviewed-on: https://chromium-review.googlesource.com/c/1247223
Commit-Queue: Orin Jaworski <orinj@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596898}

If browser is not started, we don't have a profile to get the tracker
The Download completed message is used by in-product help/

BUG=842245

Change-Id: I2716dbc659e7e192198070ccd9e3d700a89f2810
Reviewed-on: https://chromium-review.googlesource.com/c/1263275Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596897}

Original CL:

- https://codereview.chromium.org/14769008

  Fix mmap region iteration while no regions are recorded.

  If no mmap regions are recorded, iteration failed since the RegionSet
  (std::set) object is not initialized.

  BUG=162208
  R=willchan@chromium.org

  Committed:
  https://src.chromium.org/viewvc/chrome?view=rev&revision=198878

BUG=724399,b:70905156

Change-Id: I9659e486e5be89e6c36bcdf83d794dee3295e91b
Reviewed-on: https://chromium-review.googlesource.com/c/1130807Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Gabriel Marin <gmx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596896}

We now test for existence of the path /dev/kvm at startup. This
directory only exists for board which can run VMs. As a side effect, this will address the attached bug.

Bug: 891554
Change-Id: Icd24f6da9f3490e54b9d86bbefa7a1350627d9c0
Reviewed-on: https://chromium-review.googlesource.com/c/1261840
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596895}

This reverts commit bebc3d33.

Reason for revert: Causes namespace issues with ontherecord download content ids.

Original change's description:
> Download shelf : Fix for incognito
> 
> Currently incognito downloads are showing up on the download shelf for
> normal profile.We need to initialize the DownloadManagerDelegate and
> DownloadShelfController for incognito.  Also we need to filter out the
> updates for the right profile in the controller since aggregator sends
> updates for all profiles.
> 
> Bug: 881499
> Change-Id: I309d1673e87de44b870d4efaca606390dd46345e
> Reviewed-on: https://chromium-review.googlesource.com/c/1257003
> Reviewed-by: Min Qin <qinmin@chromium.org>
> Reviewed-by: Rayan Kanso <rayankans@chromium.org>
> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#596735}

TBR=dtrainor@chromium.org,qinmin@chromium.org,shaktisahu@chromium.org,rayankans@chromium.org

Change-Id: I996da981cb9ccf586a1c6965e65c2a90b687b296
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 881499
Reviewed-on: https://chromium-review.googlesource.com/c/1263339Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596894}

When a user presses a mouse button over a PDF, the PDF receives all
mouse input until there is a corresponding MouseUp. This is currently
broken for OOPIFs because the browser process doesn't know when a PDF
is supposed to capture input and so it doesn't always route events to
the right process. This change causes renderers to signal the browser
process for mouse capture when a PDF is is clicked.

Bug: 864957
Change-Id: If17587d5ca475d9a8ac03a3bba301d4084e6d4e3
Reviewed-on: https://chromium-review.googlesource.com/c/1203883
Commit-Queue: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596893}

Change-Id: Ieb633af2954b9352f4650e3ba773369cbd530a32
Reviewed-on: https://chromium-review.googlesource.com/c/1260216Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596892}