- 10 Nov, 2018 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fbac34ca6a56..ed0182c12062 Created with: gclient setdep -r src-internal@ed0182c12062 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: If9585f6aeec07d96aaf19bbdba904f8dd1c6706b Reviewed-on: https://chromium-review.googlesource.com/c/1330769Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607103}
-
rajendrant authored
Client LoFi infobar will be shown when lofi response is received, and android omnibox UI will be shown at navigation commit. This CL changes the behavior to show the infobar UI as well at navigation commit, when NetworkService is enabled, since the response headers of subresources would not be received in the browser process. Bug: 893728 Change-Id: I66122590e80974449528635892b1c720efe04450 Reviewed-on: https://chromium-review.googlesource.com/c/1327556 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#607102}
-
Roger McFarlane authored
This is a two part change. (1) Explicitly add the form/field id and name attributes to the data passed across the renderer/browser boundary. The pre-existing name and id properties of each form/field were computed values that attempted to capture whichever of the id/name was available. These values need to be passed from the renderer/JS to the browser so they can be included in the randomized form metadata sent with uploads. This part of the change is mostly mechanical, but involves updating a significant number of unittests. (2) Integrate the RandomizedEncoder to enable Rich Metadata Uploads. This augments the vote information sent from the client with additional form and field metadata that has been randomized (differential privacy via randomized responses), preventing any given upload from revealing the metadata observed by the client, but reconstructible in aggregate if sufficient clients send the same underlying metadata. Bug: 896719 Change-Id: Id866bd358eccbebdf952063bf5f6dcb9b59ad194 Reviewed-on: https://chromium-review.googlesource.com/c/1279202Reviewed-by:Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#607101}
-
Nick Harper authored
Change-Id: Ic0fe9dd8a8a4f7fd785ba5bcf94ebd94d093217e Reviewed-on: https://chromium-review.googlesource.com/c/1328707Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#607100}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromiue.org Change-Id: Ibe4bc0cf846384b5093ce5c8fbba9339156078ef Reviewed-on: https://chromium-review.googlesource.com/c/1330796Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#607099}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/af0ede1e73a7..768c3afe1da0 git log af0ede1e73a7..768c3afe1da0 --date=short --no-merges --format='%ad %ae %s' 2018-11-10 iannucci@chromium.org [led] Roll to pick up new kitchen CLI flags and set CallUpdateBuild=false. Created with: gclient setdep -r src/third_party/depot_tools@768c3afe1da0 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I1e06de8d552da3bea9e1d621679986a4b7f52c2d Reviewed-on: https://chromium-review.googlesource.com/c/1330928Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607098}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/83560374fb95..fbac34ca6a56 Created with: gclient setdep -r src-internal@fbac34ca6a56 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I23d5bc89c435a6088eda6c8a99a23e843c98f6cc Reviewed-on: https://chromium-review.googlesource.com/c/1330930Reviewed-by:
-
Kenneth Russell authored
This code path was using the wrong blend mode when drawing the WebGL content to the intermediate cc::PaintImage which is then drawn to the 2D context. Added a pixel test for this which fails before the fix, and passes afterward. A WebGL conformance test has also been written which will be rolled in later, but it would not catch the bug unless the tests were run with SwiftShader - which they aren't currently on Chromium's waterfall. Bug: 894021 Change-Id: I77a0d4877641c545159bc43b11483b80ffc74c72 Reviewed-on: https://chromium-review.googlesource.com/c/1330890 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#607096}
-
John Budorick authored
This reverts commit e0c7bc0e. Reason for revert: crbug.com/903425 Original change's description: > Build internal android targets in telemetry_chrome_test. > > Requires crrev.com/i/709113 > > Bug: 817842 > Change-Id: If7556e8aa41631e12def309927656b4bcbcac330 > Reviewed-on: https://chromium-review.googlesource.com/c/1315992 > Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> > Reviewed-by: Ned Nguyen <nednguyen@google.com> > Commit-Queue: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606139} TBR=perezju@chromium.org,nednguyen@google.com,jbudorick@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 817842 Change-Id: I36d79be86060440535dd136e58427812d02db98d Reviewed-on: https://chromium-review.googlesource.com/c/1330843Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#607095}
-
Xianzhu Wang authored
The bug was exposed by removal of cache generation mechanism of paint controller. Before that, objects painted onto different paint controllers were always implicitly invalidated in one of the paint controllers due to cache generation mismatch. The bug exposed because we don't invalidate resizer in the main graphics layer on container resize if the resizer is composited. We should not paint composited resizer on the main graphics layer. Bug: 902697 Change-Id: Ia6eefe687d79a4a787528c3ccb391c57f649a911 Reviewed-on: https://chromium-review.googlesource.com/c/1329803 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#607094}
-
Ben Pastene authored
Bug: 903078 Change-Id: I30666c534644b6ccf4909456b50a47d510abff4a Reviewed-on: https://chromium-review.googlesource.com/c/1327147Reviewed-by:
Reid Kleckner <rnk@chromium.org> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#607093}
-
Jordy Greenblatt authored
I manually confirmed that it now shows the network state 'Connecting' and starts connecting when the cr-network-list-item corresponding to a tethering host is clicked. Bug: 903622 Change-Id: Ib7efe3001cd4283065f85327f8a6f56916d825f1 Reviewed-on: https://chromium-review.googlesource.com/c/1328144Reviewed-by:
Jordy Greenblatt <jordynass@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#607092}
-
Chromium WPT Sync authored
Using wpt-import in Chromium deef63c0. With Chromium commits locally applied on WPT: 270d4abd "ServiceWorker: Add new WPT tests to make sure to update a registration with different script type and identical script content." 9ff65400 "Add redirected cases to CSP/import tests in wpt/worklets" 687313c5 "Add action_sequence in testdriver" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: Idcffdcc64ea93b9f1a6528de29909667aaa7432d Reviewed-on: https://chromium-review.googlesource.com/c/1330831 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607091}
-
Andrew Comminos authored
When we have a single-line definite height row flexbox with a column flexbox as its child, we always relayout all children of the column flexbox during LayoutLineItems with a zero-sized height being set. This patch leverages the definite height of the row flexbox in order to avoid a relayout of the column flexbox children. Bug: 703512 Change-Id: I1f67efff3ebc67cdcce57dce2d2567e2abe13625 Reviewed-on: https://chromium-review.googlesource.com/c/1306404Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Andrew Comminos <acomminos@fb.com> Cr-Commit-Position: refs/heads/master@{#607090}
-
David Black authored
Previously AnswerCardContentsRegistry was used by AppList and Assistant to embed WebContents in Ash, although this would not work in Mash. Assistant used AnswerCardContentsRegistry in conjunction with WebContentsManager to embed Assistant cards. Now, we have migrated to Content Service which renders these classes no longer needed. AppList was transitioned in: https://chromium-review.googlesource.com/c/chromium/src/+/1269622 Assistant was transitioned in: https://chromium-review.googlesource.com/c/chromium/src/+/1313745 https://chromium-review.googlesource.com/c/chromium/src/+/1321861 Bug: b:78078693 Change-Id: I5b855b6ff24722524b600eb1032960210c0233f7 Reviewed-on: https://chromium-review.googlesource.com/c/1325430 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#607089}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/7adddc2268b1..f768692bdef0 git log 7adddc2268b1..f768692bdef0 --date=short --no-merges --format='%ad %ae %s' 2018-11-10 tsepez@chromium.org Enable more field property tests. 2018-11-09 thestig@chromium.org Fix JS event.value behavior. 2018-11-09 tsepez@chromium.org List annots in page annotation dict for JS field tests 2018-11-09 thestig@chromium.org Add CPDF_DocRenderDataTest. 2018-11-09 tsepez@chromium.org Add better tests for AFSimple_Calculate(). Created with: gclient setdep -r src/third_party/pdfium@f768692bdef0 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Idb3b239df8b74ad143fda91a02f9e838b099b3d9 Reviewed-on: https://chromium-review.googlesource.com/c/1330118Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8ecbd57f8e89..83560374fb95 Created with: gclient setdep -r src-internal@83560374fb95 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie9c10c2e2e81e1069c0d52240d329004e3ebeef5 Reviewed-on: https://chromium-review.googlesource.com/c/1330120Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2bb343c5e822..303a38c86077 git log 2bb343c5e822..303a38c86077 --date=short --no-merges --format='%ad %ae %s' 2018-11-09 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-11-09 reed@google.com Revert "rm legacy flags for hinting enum" 2018-11-09 jvanverth@google.com Verify YUVA channel information and add premultiplied alpha 2018-11-09 caryclark@skia.org fix bookmaker 2018-11-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 5d2dfa46c05c..50bf0429394d (1 commits) 2018-11-09 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@303a38c86077 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=allanmac@chromium.org Change-Id: I1b7fa5d77e8098d419ced8d604972d53fbd93a12 Reviewed-on: https://chromium-review.googlesource.com/c/1330111Reviewed-by:
-
Ben Pastene authored
Will go on chromium.android.fyi, and be a copy of the O WebView bot w/ the NetworkService feature. Going to try swarming it since the L WebView bot appears to be working on swarming. I can always undo that if it doesn't work. Bug: 880623 Change-Id: Ic57bce51c3c70325a2b4038976bb85552723fd0e Reviewed-on: https://chromium-review.googlesource.com/c/1327414Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ffec6a8edd68..7dbd8f071016 git log ffec6a8edd68..7dbd8f071016 --date=short --no-merges --format='%ad %ae %s' 2018-11-09 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@7dbd8f071016 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Iefa53c29d7aea2c277980ca6c05fe33dbd6f2d92 Reviewed-on: https://chromium-review.googlesource.com/c/1330767Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2b973a56..9d6971eb Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic6efee8344158737ea1a4a725f01e7ff9f412128 Reviewed-on: https://chromium-review.googlesource.com/c/1330832Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607083}
-
Ken Rockot authored
Changes Identity's instance ID field from a free-form string to a base::Token. Prior to this change, the default instance ID was the empty string. Now it's a zero-valued token. BindInterface attempts which do not specify an instance ID implicitly connect to the instance with a zero-valued instance ID. All usage of GUIDs where relevant to instance isolation (namely media CDM and various data decoder helpers) have been changed to Tokens. Bug: 895591 Change-Id: Id14c19402f0fd924a2f467bee40860293a5abe16 Reviewed-on: https://chromium-review.googlesource.com/c/1327526 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#607082}
-
Owen Min authored
profiles::OpenBrowserWindowForProfile uses IsSigninRequired flag as a hack to unblock all extensions during Profile unlocking process. Remove the hack and add a new parameter to unblock all extensions. IsSigninRequired needs to be set to false before open the browser window. If not, UserManager will be shown with selected Profile. Bug: 901430 Change-Id: I959dc21daa92f29bca7a279563015b168256762b Reviewed-on: https://chromium-review.googlesource.com/c/1327236 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#607081}
-
Khushal authored
Transfer cache is the OOPR equivalent of a shared image cache for all renderers. Make sure it uses the same budget. Also cleanup for transfer cache entry types which are not used anymore. R=ericrk@chromium.org Bug: 903775 Change-Id: I48741f1c8385eb64cf1a9f34f06a63673ee3d7c3 Reviewed-on: https://chromium-review.googlesource.com/c/1330763Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#607080}
-
James Hawkins authored
R=khorimoto@chromium.org Bug: 899324 Test: none Change-Id: I997296b1712ddebfe3ceacc69aa25e8b5fed4395 Reviewed-on: https://chromium-review.googlesource.com/c/1330835 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#607079}
-
Alexei Filippov authored
Place timing markers next to each other rather that make them overlap. BUG=901165 Change-Id: Iac9d544d6b5e5238767c3451aa9ace9f27126cc9 Reviewed-on: https://chromium-review.googlesource.com/c/1324378 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#607078}
-
Jon Kunkee authored
This commit is otherwise empty because the corresponding contributions are in other repos. Bug: 893460 Change-Id: I95ae29c6293e52da62573ae6f6e9a10f31fc48c9 Reviewed-on: https://chromium-review.googlesource.com/c/1330793Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#607077}
-
Sam McNally authored
DriveIntegrationService uses NetworkConnectionTracker to detect that it's offline and should defer retrying DriveFS mounting until that changes. This works well for no network at all, but doesn't handle isolated networks or captive portals. NetworkPortalDetector does handle these cases so use it instead for deciding whether to defer retries until online again and for detecting when it is online again. Bug: 902771 Change-Id: Ic3b84305b0fc8927b2b1ac64ee9c28a12b07a20a Reviewed-on: https://chromium-review.googlesource.com/c/1325574 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#607076}
-
Zhuoyu Qian authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: Ifd7489aeeef3f7249f9d0c7c56456c6d0bb3f445 Reviewed-on: https://chromium-review.googlesource.com/c/1328635Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#607075}
-
Martin Kreichgauer authored
This adds a UserVerificationRequirement enum field to CtapMakeCredentialRequest. The existing "effective" user verification bool is removed and the computation of the effective value (required vs discouraged) is moved into FidoDeviceAuthenticator, in parallel to how this is handled for GetAssertion requests. This change makes the full uv requirement available to the Windows authenticators, and at the same time fixes a bug for device authenticators where requests with uv="preferred" would result in CTAP device requests with uv=false even for authenticators with UV support. Also rename CtapMakeCredentialRequest::resident_key_supported() to resident_key_required(). Bug: 898718 Change-Id: I80ba3f052f871dce711c15ed8659812ad7cab10b Reviewed-on: https://chromium-review.googlesource.com/c/1324379 Commit-Queue: Martin Kreichgauer <martinkr@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#607074}
-
Steven Bennetts authored
This CL updates a couple of browser tests to use ChromeKeyboardControllerClient instead of direct calls into ui/keyboard to simplify DEPS exceptions. Bug: 876138 Change-Id: I7874cee278a3b9439efb4e4056390951eac6705c For keyboard specific changes to c/b/policy and c/b/ui/views tests: TBR=sky@chromium.org Change-Id: I7874cee278a3b9439efb4e4056390951eac6705c Reviewed-on: https://chromium-review.googlesource.com/c/1316248 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#607073}
-
John Budorick authored
This reverts commit 32758758. Reason for revert: causes compile failures on windows similar to the ones that appeared in the CQ runs, e.g. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win%20x64%20Builder/58688 Original change's description: > Remove menu_marker from MenuButton. > > This is always false except for in tests and menu_example.cc which is > not used. This helps simplify MenuButton for the Button cleanup task. > > Bug: 901183 > Change-Id: If5a3cf7b6ba1ce5618548d112df1c4404b2ae181 > Reviewed-on: https://chromium-review.googlesource.com/c/1324375 > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: Robert Flack <flackr@chromium.org> > Reviewed-by: Trent Apted <tapted@chromium.org> > Reviewed-by: Michael Wasserman <msw@chromium.org> > Commit-Queue: Charlene Yan <cyan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#607061} TBR=msw@chromium.org,flackr@chromium.org,oshima@chromium.org,tapted@chromium.org,cyan@chromium.org Change-Id: I9c311a3c8cea56c7670b2dace3e0410618151034 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 901183 Reviewed-on: https://chromium-review.googlesource.com/c/1330841Reviewed-by:
-
Ben Pastene authored
This reverts commit 4971af60. Reason for revert: "ImportError: No module named httplib2" on CQ bots https://luci-milo.appspot.com/p/chromium/builders/luci.chromium.ci/Headless%20Linux%20%28dbg%29/70541 Original change's description: > infra: remove no longer needed LUCI options. > > They became the default ones, no need to specify them. > > R=iannucci, vadimsh > > No-Try: True > Change-Id: Iebc66d8291fdebab72fcdb334e26befdc6d90bf3 > Reviewed-on: https://chromium-review.googlesource.com/c/1330288 > Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> > Reviewed-by: Robbie Iannucci <iannucci@chromium.org> > Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#607024} TBR=iannucci@chromium.org,vadimsh@chromium.org,tandrii@chromium.org Change-Id: Iee3d547f36dd6d583be555d6b35a3067ef592db4 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1330840Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#607071}
-
Sunny Sachanandani authored
LayerTreeHostContextTestLayersNotified was changed recently to attach root layer after first activation, but it does a static_cast on impl layers before the layers are propagated to impl tree. Bug: 903931 Change-Id: I824a5fe5f9915156090098f7c8b2306c32a9db23 Reviewed-on: https://chromium-review.googlesource.com/c/1330722 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#607070}
-
Andrew Comminos authored
Test that propagated definite heights of flexboxes avoid a reflow of wrapping text. With the definite height optimization, the benchmark runs twice as fast in my local testing. Bug: 703512 Change-Id: Ib5fbf14c90735504007883c874e71f7461fe1d11 Reviewed-on: https://chromium-review.googlesource.com/c/1330289Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#607069}
-
Sorin Jianu authored
The "required" attribute name in the update manifest is ignored by the update checker, and it can be removed to eliminate confusion and for simplicity reasons. This has been discovered when implementing the updater JSON protocol. Bug: 881076 Change-Id: Ie8ad8ad816c380375d85b6402f1270f21d7b3b20 Reviewed-on: https://chromium-review.googlesource.com/c/1330700Reviewed-by:
Minh Nguyen <mxnguyen@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#607068}
-
Christian Biesinger authored
R=ikilpatrick@chromium.org Change-Id: I8671ab92cb0c043dc9a3dc3509d92586ee78779c Reviewed-on: https://chromium-review.googlesource.com/c/1330829Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#607067}
-
Tarun Bansal authored
In incognito profiles, do not predict the next navigation, either at the time of load, or at the time of element click. Bug: 899406 Change-Id: Iccddf772ed8fc5de63233e427e7eab35d8a3f20c TBR: ryansturm@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1330702Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#607066}
-
Christian Biesinger authored
It needs to return at least border_scrollbar_padding_, or else this can lead to a DCHECK failure in ng_length_utils.cc Found by running ScrollbarsTest.AutosizeAlmostRemovableScrollbar with LayoutNG enabled. R=ikilpatrick@chromium.org, mstensho@chromium.org Change-Id: I9635ef98274bf573151756d19b3879fb6d33080a Reviewed-on: https://chromium-review.googlesource.com/c/1330348Reviewed-by:
-
Mason Freed authored
Change-Id: Icf9fd7a9ebd1f9753ef2e26d74bb91bd9598650f Reviewed-on: https://chromium-review.googlesource.com/c/1330697Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#607064}
-
