- 24 Sep, 2020 40 commits
-
-
Raymond Toy authored
This CL reverts all the recent changes to audio_buffer_source_node that was splitting up the code to make optimizations easier. We're now restoring the code back to the way it was in 86.0.4215.0, which was the last version before the offending 86.0.4232.0 was landed. While the change is somewhat large a lot of it is for undoing the experiments trying to figure out where the problem was coming from. Bug: 1116104 Change-Id: I5febac0cb9b1409f54e2f3a8d24cd58951308631 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427133Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#810311}
-
Caitlin Fischer authored
The IPH_NewTab feature no longer appears to be used in the code. Bug: 1126640 Change-Id: Ia74ecf49241aefd99cb4fd2b95f03cad2575ded3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427353 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#810310}
-
Mason Freed authored
Change-Id: Ib32c839baee0be8e5a9785a5df85774f61c337c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429374 Commit-Queue: Mason Freed <masonfreed@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#810309}
-
Eric Orth authored
The "DnsOverHttps" feature along with the "ShowUi" param is approved for launch and will soon be launched to 100% for win/mac/cros/android, so enable the feature/param by default for those platforms. There shouldn't be anything left with the feature enabled but the ShowUi param disabled, but I'm still switching the param on platform because I don't understand the UI code enough to be sure nothing in there will only check the param without the feature and not accidentally enable the UI. I'll figure that out and handle it later in a more thorough cleanup to fully delete the ShowUi param. Also note that it is traditional to delete the fieldtrial testing config entries when changing experiments to be enabled by default, but I'm leaving it in place here because it is covering testing of the "DisabledProviders" param that is not yet launching to a final state. Bug: 878582,1098039 Change-Id: I57bb6264047b7ed426bf57fca9f6301f71312ba2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429243 Commit-Queue: Eric Orth <ericorth@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Auto-Submit: Eric Orth <ericorth@chromium.org> Reviewed-by:
Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#810308}
-
Peter Wen authored
This makes it easier to manage and update android BUILD.gn files that are scattered throughout the codebase. Bug: None Change-Id: I6957ff13bc4bb9804ac6a8e4d3a290b18f2aef11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429843 Commit-Queue: Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#810307}
-
Moe Ahmadi authored
Change-Id: I802011805e0e2accfce7de6b49a9acb7db9559aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425012Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#810306}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/a09406249fa3..b94db86cf9b3 2020-09-24 sdefresne@chromium.org Explicitly filter assigments to sources variable If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1018739 Tbr: swiftshader-team+autoroll@google.com Change-Id: Ie0d9c9866e6df215e49cd592e66f63560936973d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428220Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810305}
-
Juanmi Huertas authored
Some type of the resources were deprecated but not marked as such. This CL marks them using the [[deprecated]] attribute. Bug: 1131514 Change-Id: Ia36acc7933d0fa0abee8138f07955837ff1568cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426249 Auto-Submit: Juanmi Huertas <juanmihd@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#810304}
-
Sujie Zhu authored
Surfacing server card nickname is already fully enabled in M84. Clean up all the usages. Will remove the Phase 1 histogram logging in a follow up CL. Bug: 1059087 Change-Id: I1394d5563e072f3a3cb8bdf0fee3fceda6c208ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422784 Commit-Queue: Sujie Zhu <sujiezhu@google.com> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Siyu An <siyua@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#810303}
-
Weilun Shi authored
Add a set of histogram name to folder name mapping to aggregate or split histograms in a semantically clearer way. Also update print_histograms_name to tolerate the case when the new histograms.xml file is not present in the previous version. Bug: 993193 Change-Id: Iad6fea2f3d8443f0a2518b3473fcece2a981d45d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427437 Commit-Queue: Weilun Shi <sweilun@chromium.org> Reviewed-by:
-
Sinan Sahin authored
Bug: 992019 Change-Id: Iab178d111664799f815843f84b9df94de83bb281 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429464Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#810301}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3d8fd27d9a8a..71ee049b6b17 2020-09-24 taylori@google.com Merge "perfetto-ui: Make metrics non-breaking in UI" 2020-09-24 hjd@google.com Merge changes I3ac1b577,I174ae837,I9d1f40a5 2020-09-24 taylori@google.com Merge "Load trace and discard old state" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: If7b85adbfc223724eddc91d10ba367aace68656f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428822Reviewed-by:
-
Alex Turner authored
Factors out the IdentifiableTokenBuilder construction and addition of the FontSelectionRequest's hash. Also factors out the logic for insertion of the typeface digest into the appropriate hash map (using the input key), including avoiding digest computation when the key is already present in the hash map. Finally, collapses repeated code during metric publishing into an additional for loop. These changes have no functional impact, but improve readability and reduce the risk that future changes might inadvertently miss a spot. Bug: 1126634 Change-Id: Ic825fb74fb177b8bee12c21b6458432bc3aafbc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402109 Commit-Queue: Alex Turner <alexmt@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#810299}
-
Wei Li authored
Use default argument true for creating a horizontal ScrollBarViews by default. Bug: 1108460 Change-Id: Ic19c4e34e6c06372d9004ccbb9d17cc72d31c9cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427525Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#810298}
-
minch authored
- Inkdrop ripple and highlight colors are based on the background color currently. And the color is WHITE in dark and BLACK in light mode. Removing the hard code, get the colors from AshColorProvider instead. - There is no need to set the inkdrop color on the underneath image's color now. Removing the |ink_drop_color_| related logic inside SystemMenuButton. Bug: 1107056 Change-Id: Id67a5b22845aae5df6fa85be775e892f7a958c5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426548Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#810297}
-
Andrew Grieve authored
Want to see if the signing block size is proportional to file sizes, or if it tends to fluctuate in size. Bug: 1130754 Change-Id: Idf2d8662418375a243750959ecdd9f162d513885 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426551 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#810296}
-
Hazem Ashmawy authored
Use MainActivity context to startActivity instead of calling the fragment#startActivity to avoid the exception thrown when the fragment is detached. Bug: 1130732 Test: Manually launch the app, click settings Test: run_webview_instrumentation_test_apk -f "*android_webview.devui*" Change-Id: Ib43df575edf34154b4297fac2bc1b8216250cdae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424151 Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#810295}
-
Simeon Anfinrud authored
When a new WebContents arrives, the current WindowAndroid's destroy() is invoked. To prevent this from happening multiple times on the same windowAndroid, create a new instance for each incoming WebContents. Bug: internal b/167950522 Test: Cast one app, then another Change-Id: I7c6d87f313d0215b1f35c767bce6a3ab192f63fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427216 Auto-Submit: Simeon Anfinrud <sanfin@chromium.org> Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Commit-Queue: Luke Halliwell (slow) <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#810294}
-
Eric Orth authored
Was previously an autoupgrade-only provider. Test: Manually confirmed UI change for multiple regions. Fixed: 1082456 Change-Id: Ie9241d6f468b7175fd3b10cfaf56f3a16cdfc183 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427352Reviewed-by:
-
Carlos IL authored
This feature launched as enabled by default on M81, and there are no plans to revert it. This CL cleans up the feature flag (and should cause no behavior changes). There is still cleanup left from the feature launch, notably removing the shield UI that is no longer used. That will be cleaned up in a follow up CL. Bug: 1078193 Change-Id: I34007e68e876c231e76dbcdedafe8de9a0d17121 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418810Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#810292}
-
Brian Sheedy authored
This reverts commit affe1977. Reason for revert: Causing flaky crashes on Mac, see https://bugs.chromium.org/p/chromium/issues/detail?id=1085222#c28. Original change's description: > Add ModuleCache API contract checks > > Adds checks to ensure early detection of API contract violations that > would lead to use-after-frees. > > Bug: 1127466 > Change-Id: Ic73b30f115f5206572a427ac44674ff6a9b9f249 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425523 > Commit-Queue: Mike Wittman <wittman@chromium.org> > Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org> > Cr-Commit-Position: refs/heads/master@{#809987} TBR=wittman@chromium.org,etiennep@chromium.org Change-Id: Iae2cd6197448b8f54e8ba6918979c1b6f43157b5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1127466, 1085222 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429867Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#810291}
-
Dominique Fauteux-Chapleau authored
This allows a screen reader to read the updated text of the dialog. Bug: 1131565 Change-Id: I73a2df8067ffc96148ebf5d50a9412cf34b67feb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424841 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#810290}
-
Alice Wang authored
This CL shows the identity disc when user is signed-in. The corresponding tests will be added in the subsequent CL after we add the new sign-in methods to AccountManagerFacade. Bug: 1131920 Change-Id: Ic5992cf9c0561206ceee3f9e68c53bda72661468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428929 Commit-Queue: Alice Wang <aliceywang@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#810289}
-
Patrick To authored
This change adds tests that validate scenarios where requesting XR compatibility should fail: - If the WebXR feature policy isn't allowed, a SecurityError is thrown - If there are no devices available, an InvalidStateError is thrown A runtime enabled feature is added for WebXR multi GPU that syncs with the corresponding Chromium feature flag. Bug: 1124024 Change-Id: Ia79b06ecffa936471a6fd80172717c7724245bf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416856Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Patrick To <patrto@microsoft.com> Cr-Commit-Position: refs/heads/master@{#810288}
-
Yuheng Huang authored
We switched to use chrome://favicon2 from base64 stream for favicon. But for OTR profile chrome://favicon2 is not available. This CL fixes favicon not showing up correctly in guest mode. Related CL: https://chromium-review.googlesource.com/c/chromium/src/+/2406932 Bug: 1099917 Change-Id: I5fdd1dda997d08024d6ce3aa6d6a569d38ac026e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424510 Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#810287}
-
Dan McArdle authored
In a prior CL [1], I added the CheckIdempotency() function, which tests that GURL canonicalization produces a fixed point the first time it's called. There was some confusion whether CheckIdempotency was duplicating logic that already existed in the fuzzer; the fuzzer already had a few lines to copy the GURL with a no-op call to ReplaceComponents and check that the spec string is unchanged. This "copy check" is subtly different than the idempotency check. In particular, it cannot catch the "file:///.//" -> "file:////" -> "file:///" bug because it never reaches DoParseFileURL. For context, the non-idempotency bug for "file:///.//" arises because * DoPartialPath drops "./", taking "file:///.//" to "file:////" * DoParseFileURL collapses "//" to "/", taking "file:////" to "file:///". [1]: http://crrev.com/c/2414615 Bug: 1128999 Change-Id: Ib35982f56cac3ced23d13def74f073a0245bdee3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424764Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#810286}
-
Tomasz Wiszkowski authored
This change introduces a TILE_NAVSUGGEST suggestion type for the most-visited suggestions. The TILE_NAVSUGGEST is built in a similar way to NAVSUGGEST and TILE_SUGGEST elements, where a list of tiles is held as a vector of elements arranged in the order these are scored. The TILE_NAVSUGGEST is currently meant specifically for zero-prefix most-visited URL suggestions and should be positioned below the QueryTiles. These elements are currently not meant to be cached as these URLs are used specifically when user is visiting a website (ie. not a ZPS on a NTP). The change does not create any logic wiring up TILE_NAVSUGGEST items; instead, it simply creates a new suggestion type and adds corresponding data to that object on both Native and Java sides. Change-Id: Ia4c5141143d6a49f963bcf66fecae9b84d3d4b5e Doc: http://doc/1IFsDKYhy_ARMOdT8jd1pMtk497xe03lb3hVnsaY-dOM Slides: http://slides/1c1SzJLzEsTjLmqIVLTomC8l9EgslBgYaBN6I7t8mbDI#slide=id.g8b3736bab3_0_0 Figma: https://www.figma.com/file/h8qjD0s9tezRzHdCMxIhYJ/On-Focus-Suggestions?node-id=290%3A309 Bug: 1106109 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422808 Commit-Queue: Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
-
Christian Biesinger authored
The problem with the test was that due to the way we calculate the intrinsic sizes of an inline flexbox, we end up sizing the flexbox to 20px wide and then "stretching" the flex item to that width. Instead, use a wrapping flex box where flex line sizing does not have that issue. R=ikilpatrick@chromium.org, mstensho@chromium.org Bug: 1117279 Change-Id: I719814fc5e4c570a100e131f4d903c09d4c05575 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429543 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
-
Christoph Schwering authored
The feature is disabled by default and is not subject to an active experiment. It's not publicly documented, so there's little chance web developers use is. Bug: 1007974, 869912 Change-Id: I7233fd8a21e583247868433b049996dfde843bb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410403Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#810283}
-
Reid Kleckner authored
This greatly reduces object file size during PGO phase 1 (20GB -> 9GB), and makes the linker use a lot less memory (160+GB -> 7.5GB private bytes). Bug: 1058040 Change-Id: I7dd433b46afab4b4c52b63d5698c75cad206f407 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427438Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#810282}
-
Satsuki Ueno authored
Fixes a bug where ipv6 addresses are not accepted for the remote-debugger-address option. Before this change, neither --remote-debugging-address=::1 nor --remote-debugging-address=[::1] are accepted. The reason is that the address was parsed expecting a bracketed address but then is later wrapped in brackets again, resulting in invalid addresses such as [[::1]]. This change updates parsing so that the non-bracketed ip literal is accepted. It also adds integ tests to verify the chromedriver/devtools interaction when ip literals are specified. Bug: 1112509 Change-Id: I82756add5f576f3303a84cd3edcc84956c65a75e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424035 Commit-Queue: Satsuki Ueno <satsukiu@google.com> Reviewed-by:
Shengfa Lin <shengfa@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#810281}
-
Stephen Roe authored
Fuchsia emulation now uses KVM so the long tests do not time out. Bug: 780317 Change-Id: I15d85e7e843781c0ae445bddba0900b6e38192f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427565Reviewed-by:
-
Mirko Bonadei authored
Speculative disable these tests since the failure seems similar to crbug.com/1069608 on ChromeOS. Bug: 1129807, 1128470 Change-Id: I33eb4db810b57ddb46f1c6982ced26b45f59fcb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429263Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#810279}
-
Xianzhu Wang authored
This reverts commit 99517448. Reason for revert: As this CL itself is incomplete and M87 branch is near, let's land this together with other CLs after M87 branch. Original change's description: > Prepare for segmented paint artifact > > This is the first of a series of CLs to improve performance and > flexibility of subsequence caching. The basic idea is to split a > previous monolithic PaintArtifact into segments which are the basic unit > of subsequence caching. A segment will be created when we start or end a > subsequence. It's either a leaf subsequence or the gap between two leaf > subsequences. When a subsequence can be cached, its segments will be > copied from the previous PaintArtifact with trivial cost. > > The mechanism will work for both CAP and pre-CAP. In pre-CAP we'll also > use one PaintController for each local frame tree, and we'll also create > segments at GraphicsLayer boundaries. In this way, the difference in > painting of CAP and pre-CAP will be greatly reduced. > > This CL prepares PaintArtifact and PaintChunkSubset for segmenting. > PaintChunkSubset supports iterating paint chunks in a PaintArtifact: > - for all paint chunks; > - for a subset of paint chunks, with a segment range, which will be for > pre-CAP GraphicsLayers; > - for a subset of paint chunks, with an array of paint chunk indices > which will be for CAP layerization algorithm, including CompositeSVG > for SVGs. > > Now we can also iterate the display items in a chunk with > PaintChunkIterator::DisplayItems(), so that a PaintChunkSubset (which > references the containing PaintArtifact) can represent all painted > result of a composited layer. > > Bug: 917911 > Change-Id: I5c894e105463e866ac38a17cdc9c5e43eca6a6e1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407298 > Reviewed-by: Stefan Zager <szager@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810007} TBR=szager@chromium.org,wangxianzhu@chromium.org,pdr@chromium.org Change-Id: I8384a99bbaba2c0a3b532d7e0f56287ed27ac9e0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 917911 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429864Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#810278}
-
James Cook authored
The ID prefix is shared between the Wayland client code in Lacros and the Wayland server code in ash, so share the constant. Bug: none Change-Id: If62550c447670e553a854ce1092cfd3d7d9aacff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427546Reviewed-by:
Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#810277}
-
Alexander Surkov authored
Bug: 1131921 Change-Id: I847df334df884624b2df8fa02b9dff2d80ca70fa AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427310Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Alexander Surkov <asurkov@igalia.com> Cr-Commit-Position: refs/heads/master@{#810276}
-
Mitsuru Oshima authored
This also fixes the blur on this new wallpaper. Plus, change AddRemoveDisplay to use the same display id for added display. Fixed: 1126186 Test: covered by unittest Change-Id: I2698d8f073f58edb18e29e84e7e16c4296ea48a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425431 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#810275}
-
Victor Hugo Vianna Silva authored
This CL modifies the behavior of the DecoupleSyncFromAndroidMasterSync feature. When the feature is enabled, Sync will only decouple from master sync and be re-enabled once the master toggle is first re-enabled. The fact that the decoupling happened is persisted using the APIs from crrev.com/c/2398524. We also do some non-related code brush up: - Shorten the implementation of some methods in AndroidSyncSettingsUtils. - Deprecate one test constructor of AndroidSyncSettings. - Add missing assertOnUiThread() to the methods to add/remove an observer in AndroidSyncSettings. - Restrict AndroidSyncSettingsTest#testAccountInitialization to the case where the feature is disabled, which should have been done in crrev.com/c/2366895. Bug: 1125622 Change-Id: Ia37a1075b159754337c3c7308d9b789b8008ec21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398504 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#810274}
-
Bruce Dawson authored
There is active work going on that may affect the reliability of the crashpad process so the histograms need to be extended beyond M85. Bug: 1119519 Change-Id: I6bab6600ce3a927fc2b9577216c172e086e00e56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417295 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Joshua Peraza <jperaza@chromium.org> Reviewed-by:
-
Collin Baker authored
These files are included in Android builds, but they shouldn't be. This adds checks and fixes the include errors. These checks are a step toward enabling gn check in chrome/browser. Bug: 949535 Change-Id: I9fb2a1bbbe04c5ba0fc68b53b795f5f3e43f3232 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426805 Auto-Submit: Collin Baker <collinbaker@chromium.org> Reviewed-by:
-
