GitLab

WebKit has been fixed in
https://src.chromium.org/viewvc/blink?revision=193998&view=revision

BUG=None
TEST=trybots
R=thestig@chromium.org
TBR=sergeyu@chromium.org,cpu@chromium.org

Review URL: https://codereview.chromium.org/1053123010

Cr-Commit-Position: refs/heads/master@{#327147}

BUG=473837

Review URL: https://codereview.chromium.org/1106183005

Cr-Commit-Position: refs/heads/master@{#327146}

R=brettw@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1110793002

Cr-Commit-Position: refs/heads/master@{#327145}

BUG=471928

Review URL: https://codereview.chromium.org/1099553003

Cr-Commit-Position: refs/heads/master@{#327144}

Delivering the FIRST_NONEMPTY_PAINT phase changing event to base/. This concludes the client-side “phased profiling” work.

I’m removing TODO items, and the DIFFS introduced by this should remind the reviewers that there are open questions that they wanted to re-raise, assuming the the CL doesn’t make it clear that the way it’s implemented is OK.

If there are still concerns, we should agree on one important thing before we resume the discussions: phase change delivery chain doesn’t go through metrics provider. It starts at the event source (FirstWebContentsProfiler), then goes to TrackingSynchronizer, then goes to base/. Once we agree on the design of this chain, it will make sense to go to more detailed discussions and open questions.
BUG=456354

Review URL: https://codereview.chromium.org/1021053003

Cr-Commit-Position: refs/heads/master@{#327143}

Revert of [media] Replace MessageLoopProxy usage with ThreadTaskRunnerHandle (patchset #3 id:40001 of https://codereview.chromium.org/1108773002/)

Reason for revert:
see https://code.google.com/p/chromium/issues/detail?id=481632

Original issue's description:
> Replace MessageLoopProxy usage with ThreadTaskRunnerHandle in src/media.
>
> MessageLoopProxy is deprecated.
> This basically does a search and replace:
>
> MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get().
>
> BUG=391045
>
> Committed: https://crrev.com/902e992a9b6447028bf8d4f3540892c425984b8f
> Cr-Commit-Position: refs/heads/master@{#327075}

TBR=anujk.sharma@samsung.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=391045

Review URL: https://codereview.chromium.org/1105163004

Cr-Commit-Position: refs/heads/master@{#327142}

ScopedFileDescriptor was initially introduced to facilitate the
management of a 'lifeline' FD used when asking permission_broker to
open a port in the device's firewall on CrOS.  It's actually a scoped
wrapper around DBus::FileDescriptor, not a platform file descriptor. I
would like to use it to facilitate some other similar functionality in
which I create a pipe and pass one end over DBus, so it seems like a
good idea to move ScopedFileDescriptor into the dbus library directly.

This reverts commit ee9dc849.

BUG=chromium:481340
TEST=FirewallHole unit tests still pass
TBR=stevenjb, reillyg, keybuk

Review URL: https://codereview.chromium.org/1108083003

Cr-Commit-Position: refs/heads/master@{#327141}

ANGLE can now create child windows and requires UI messages to be handled.
Because it is not possible to determine if ANGLE will use a child window
when creating surfaces, always use a UI message loop.

BUG=angleproject:961

Review URL: https://codereview.chromium.org/1097283005

Cr-Commit-Position: refs/heads/master@{#327140}

Update the native_viewport CommandLine usage pattern.
(codereview.chromium.org/1057603003 removed per-app args)

Re-enable window_manager_apptests with test and headless flags.
(our FYI waterfall: http://build.chromium.org/p/chromium.mojo/console)

BUG=480040
TEST=Tests pass on the waterfall.
R=sky@chromium.org
TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/1107133002

Cr-Commit-Position: refs/heads/master@{#327139}

The UI objects (specifically DataReductionProxySettings) already creates
a BooleanPrefMember for kDataReductionProxyEnabled and checks for changes
on it, then propagates this information to DataReductionProxyIOData via
DataReductionProxyIOData::SetProxyPrefs.

It also negates the need to pass a BooleanPrefMember to BypassStats when
ultimately all we care about is the boolean value.

BUG=472290

Review URL: https://codereview.chromium.org/1057473003

Cr-Commit-Position: refs/heads/master@{#327138}

CredentialManagerClientTest has crashed on Android since commit
d94a4430 was merged.

BUG=481415

Review URL: https://codereview.chromium.org/1103083002

Cr-Commit-Position: refs/heads/master@{#327137}

BUG=473837

Review URL: https://codereview.chromium.org/1106293003

Cr-Commit-Position: refs/heads/master@{#327136}

Previously this was a component which fails on the Windows component build because there are no exported symbols. In GYP this is a static library, which should generally be source_sets in GN.

TBR=keybuk@chromium.org

Review URL: https://codereview.chromium.org/1107103002

Cr-Commit-Position: refs/heads/master@{#327135}

Pull the implementation of TestToolbarActionsBarHelper into
BrowserActionTestUtil. The former is really only ever used
with the latter, and this allows:
- Tests to only worry about one test object.
- For one top-level fewer platform-specific test class.

TBR=sky@chromium.org (something wonky in our OWNERs check isn't counting Finnur/me as owners for toolbar actions stuff...)

Review URL: https://codereview.chromium.org/1104813005

Cr-Commit-Position: refs/heads/master@{#327134}

There are multiple possible login pages based on the Gaia server version
we hit in the E2E tests.

This change should not affect existing tests on the waterfall.

BUG=477157

Review URL: https://codereview.chromium.org/1102603003

Cr-Commit-Position: refs/heads/master@{#327133}

BUG=475653

Review URL: https://codereview.chromium.org/1110683002

Cr-Commit-Position: refs/heads/master@{#327132}

This uses the real settings object which contains the location of the
source root for resolving "//..." paths. The use-case is to allow
imports to be processed in the args file, which in turn allows one to assign
a set of build arguments by reference.

Review URL: https://codereview.chromium.org/1104313002

Cr-Commit-Position: refs/heads/master@{#327131}

I recently added the "transient" partial index to the
SQLitePersistentCookieStore. iOS 8.1 and older doesn't have access to SQLite
3.8+, so it can't use partial indices. Instead, use a full index on
SQLitePersistentCookieStore on iOS.

BUG=478346

Review URL: https://codereview.chromium.org/1098883005

Cr-Commit-Position: refs/heads/master@{#327130}

Because base/strings/string_split.h defines:
typedef std::vector<std::pair<std::string, std::string> > StringPairs;

BUG=412250

Review URL: https://codereview.chromium.org/1104693003

Cr-Commit-Position: refs/heads/master@{#327129}

This CL adds the new classes, changes to existing classes and tests for adding
the CPP API for LE advertisements. The design for this is available at
http://go/chrome-ble-advertising.

R=armansito@chromium.org, jamuraa@chromium.org
BUG=466375

Review URL: https://codereview.chromium.org/1054743003

Cr-Commit-Position: refs/heads/master@{#327128}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/385e26e..a6f7507

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=humper@google.com

Review URL: https://codereview.chromium.org/1105243002

Cr-Commit-Position: refs/heads/master@{#327127}

BUG=473837

Review URL: https://codereview.chromium.org/1107193002

Cr-Commit-Position: refs/heads/master@{#327126}

BUG=480738

Review URL: https://codereview.chromium.org/1082403004

Cr-Commit-Position: refs/heads/master@{#327125}

BUG=477721

Review URL: https://codereview.chromium.org/1056793009

Cr-Commit-Position: refs/heads/master@{#327124}

BUG=

Review URL: https://codereview.chromium.org/1111493002

Cr-Commit-Position: refs/heads/master@{#327123}

For now, this only happens in debug builds.

BUG=369661
TEST=NavigationControllerBrowserTest.NavigationTypeClassification_*
TEST=Every other test on the planet.

Review URL: https://codereview.chromium.org/1002803002

Cr-Commit-Position: refs/heads/master@{#327122}

Updated the documention for webview.back() and webview.forward() to reflect that they now have callbacks.

BUG=481594

Review URL: https://codereview.chromium.org/1111463002

Cr-Commit-Position: refs/heads/master@{#327121}

Directory now registers to be notified of catastrophic sync DB errors.
Upon notification, Directory triggers an unrecoverable sync error which
causes ProfileSyncService to delete the sync DB.

Add integration test that verifies the sync DB is deleted when DB
corruption is detected.

Remove unused member variable allow_failure_for_test_ from
DirectoryBackingStore.

Add MockUnrecoverableErrorHandler to assist in writing tests for
Directory.

BUG=470993

Review URL: https://codereview.chromium.org/1082893003

Cr-Commit-Position: refs/heads/master@{#327120}

For chrome://large-icon, if no large icon is found then we get the small
favicon to extract the dominant color for fallback background. If the
favicon is missing we're supposed to have a gray background. This behavior
was broken and this CL fixes it.

BUG=467712

Review URL: https://codereview.chromium.org/1108833002

Cr-Commit-Position: refs/heads/master@{#327119}

BUG=444049

Review URL: https://codereview.chromium.org/1060933003

Cr-Commit-Position: refs/heads/master@{#327118}

Adds an interface to ViewsDelegate to get a TaskRunner for a thread that
can be used for initialization tasks (implemented using the FILE thread),
and passes that TaskRunner to the ATK accessibility initialization code,
which currently does I/O on the main thread, causing a perf issue.

This change just adds the plumbing to get the TaskRunner there.
This will be followed up by this change that actually moves the initialization
to the other thread: https://codereview.chromium.org/1028553003/

BUG=468112

Review URL: https://codereview.chromium.org/1089003003

Cr-Commit-Position: refs/heads/master@{#327117}

Revert of Limit form-less Autofilling to pages that look like checkout pages. (patchset #7 id:120001 of https://codereview.chromium.org/1081803003/)

Reason for revert:
Caused compile error on Win x64 GN bot

Original issue's description:
> Limit form-less Autofilling to pages that look like checkout pages.
>
> This should hopefully stem the tide of false positives on non-checkout pages, while preserving desired behavior on Best Buy and Apple checkout.
>
> Fixing FormStructureBrowserTests: I went back and added <form>s that were present in the source pages but not in the local copies. I also added the original <title> tags, except for ones that did /not/ include any of the checkout keywords. For these, I added the checkout keywords to the title, so that the test still had some value (instead of passing trivially because the title was "Google Calendar" and not something like "Payment information").
>
> BUG=471090,477466
>
> Committed: https://crrev.com/aa3219ce27ef5471c19670fe5145b136925cbc89
> Cr-Commit-Position: refs/heads/master@{#327108}

TBR=thestig@chromium.org,brettw@chromium.org,estade@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=471090,477466

Review URL: https://codereview.chromium.org/1106313002

Cr-Commit-Position: refs/heads/master@{#327116}

Revert of Switch to STA mode for audio thread and WASAPI I/O streams. (patchset #9 id:200001 of https://codereview.chromium.org/1097553003/)

Reason for revert:
Does not seem to have helped anything, crashes are still present and UMA metrics are unchanged. If anything it may have caused issues like: http://crbug.com/480476 and http://crbug.com/481581

Original issue's description:
> Switch to STA mode for audio thread and WASAPI I/O streams.
>
> Using COM marshalling to share necessary worker thread pointers
> with the render and capture threads.
>
> BUG=422522
> TEST=all unit tests pass, audio input and output work.
>
> Committed: https://crrev.com/43f3b0d25752d924390a4d6fc868d6e9469edc4f
> Cr-Commit-Position: refs/heads/master@{#326360}

TBR=tommi@chromium.org,henrika@chromium.org,mcasas@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=422522

Review URL: https://codereview.chromium.org/1111503003

Cr-Commit-Position: refs/heads/master@{#327115}

- Use webview.addContentScripts to to inject js;
- Enable crendential passing tests;
- Make the test listen for authFlowChange event only when needed
  because it is fired on every auth page load now to correctly
  propagate the auth domain change;

BUG=467068

Review URL: https://codereview.chromium.org/1066573003

Cr-Commit-Position: refs/heads/master@{#327114}

It might be possible that animator is destroyed when desstruct CallbackAnimationObserver.
Use a scoped_refptr to make sure it wont happen.

BUG=478016

Review URL: https://codereview.chromium.org/1094863005

Cr-Commit-Position: refs/heads/master@{#327113}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/6554837..1e14c28

TBR=tkent@chromium.org,pdr@chromium.org

Review URL: https://codereview.chromium.org/1108063003

Cr-Commit-Position: refs/heads/master@{#327112}

The new implementation is activated when USE_GCD=1 at build time.

BUG=471928

Review URL: https://codereview.chromium.org/1094133003

Cr-Commit-Position: refs/heads/master@{#327111}

Add trace event inside each read notification for evdev.

BUG=none
TEST=chrome://tracing in link_freon

Review URL: https://codereview.chromium.org/1110693003

Cr-Commit-Position: refs/heads/master@{#327110}

Implemented CRUContextMenuController as a bridge backed up by
UIActionSheet on iOS7 and UIAlertController on iOS8.

BUG=410299,437781
TEST=
Context menu works on iPhone/iPad with iOS7/iOS8 for:
- web links and images
- bookmarks
- recently visited items on NTP

Review URL: https://codereview.chromium.org/1103743002

Cr-Commit-Position: refs/heads/master@{#327109}

This should hopefully stem the tide of false positives on non-checkout pages, while preserving desired behavior on Best Buy and Apple checkout.

Fixing FormStructureBrowserTests: I went back and added <form>s that were present in the source pages but not in the local copies. I also added the original <title> tags, except for ones that did /not/ include any of the checkout keywords. For these, I added the checkout keywords to the title, so that the test still had some value (instead of passing trivially because the title was "Google Calendar" and not something like "Payment information").

BUG=471090,477466

Review URL: https://codereview.chromium.org/1081803003

Cr-Commit-Position: refs/heads/master@{#327108}