- 13 Aug, 2018 1 commit
-
-
Khushal authored
This fixes 2 bugs which could result in using invalid textures from the image cache, if an image is originally uploaded at original size and mips are generated with a subsequent copy later. 1) When we generate mips the original texture is deleted, while if the DrawImage is ref-ed and there is an external ref on the SkImage backed by the original texture it could potentially be used after its deleted. 2) If skia fails to mip the texture for any reason, the "mipped" image returned is backed by the original texture which we would subsequently delete. R=ccameron@chromium.org, ericrk@chromium.org TBR=piman@chromium.org Bug: 870317 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iec925f35c7880db89f9b68a9cee5e0b76b8ce4d9 Reviewed-on: https://chromium-review.googlesource.com/1171960Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#582484}
-
- 12 Aug, 2018 19 commits
-
-
Kenneth Russell authored
conformance2/textures/misc/tex-mipmap-levels.html fails three times in a row when it fails. Mark it as Fail rather than Flaky. Bug: 870856 Tbr: ynovikov@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ib49cb54ee451b4f5f556a0b5899c12d9e88d80b3 Reviewed-on: https://chromium-review.googlesource.com/1171942Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#582483}
-
Jinsuk Kim authored
Removes a TODO by moving a test-only method in WebContentsImpl to test package. Change-Id: Ia143ee015b3a68b0ec946a85d042b30cbce07172 Reviewed-on: https://chromium-review.googlesource.com/1168953 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#582482}
-
Jinsuk Kim authored
Reduced the visibility of some methods to private. Change-Id: I696d5976e8d0f3823a61af445f7eb1c33b79fda3 Reviewed-on: https://chromium-review.googlesource.com/1170153Reviewed-by:
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/656d609a952a..f4cf64ec0669 git log 656d609a952a..f4cf64ec0669 --date=short --no-merges --format='%ad %ae %s' 2018-08-12 peah@webrtc.org AEC3: Enforcing nonlinear mode when transparent mode is active Created with: gclient setdep -r src/third_party/webrtc@f4cf64ec0669 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:873074 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib0004e39737a41814ac3b77b6143c6f9621c8f93 Reviewed-on: https://chromium-review.googlesource.com/1172103Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582480}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2ef04d1e. With Chromium commits locally applied on WPT: 7dad0f17 "Added new Sec-Metadata Web Platform Tests." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22604 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: I13dd0e4c95a393b7ad1a09eeffeed86870b9a3b0 Reviewed-on: https://chromium-review.googlesource.com/1172099 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#582479}
-
Kai Ninomiya authored
Due to a race condition between OnSignalAck and CheckResultsAvailable, getSyncParameter or clientWaitSync can report that a WebGLSync has passed before the readback results are actually available to getBufferSubData. This results in getBufferSubData falling back to the slower path sometimes. To remedy this, this change switches from using SignalQuery to a custom callback mechanism managed by the individual QueryTracker Query object. This callback is called immediately when the Query discovers that it has completed. Bug: 873424 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I2136e3ea4d55dc4b5c2392d24791b787500a30af Reviewed-on: https://chromium-review.googlesource.com/1171908Reviewed-by:
-
Robert Ma authored
TBR=foolip No-Try: True Bug: 870526 Change-Id: Id8d7d6c24425674d2a57abbf2b502781726bb0e3 Reviewed-on: https://chromium-review.googlesource.com/1172097Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#582477}
-
Thomas Tangl authored
When a custom passphrase is detected in the unified consent service, unified consent is revoked. Bug: 872221 Change-Id: I5c571e38a8752973f8b393f570c6a2e11b56183b Reviewed-on: https://chromium-review.googlesource.com/1170694 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#582476}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/02d174687cc9..f1a25c06cd15 git log 02d174687cc9..f1a25c06cd15 --date=short --no-merges --format='%ad %ae %s' 2018-08-12 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version Created with: gclient setdep -r src/third_party/skia@f1a25c06cd15 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@chromium.org Change-Id: I8aa51d07b884863b92b0a21c9427799aeac6a65f Reviewed-on: https://chromium-review.googlesource.com/1172102Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582475}
-
Alexander Alekseev authored
Bug: 852551 Change-Id: Ie7b3a95dee5ed135661f47f765e0fb37adb84273 Reviewed-on: https://chromium-review.googlesource.com/1171958Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#582474}
-
Alexander Alekseev authored
This Cl enables "Back" and "Forward" icons to follow the color style of the button. Bug: 852551 Change-Id: I75cec2058d7e330db5c7b5d226f47cd0f9f54571 Reviewed-on: https://chromium-review.googlesource.com/1171956Reviewed-by:
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I223c443b1baa87ef7f471ac9a63dcf532c968114 Reviewed-on: https://chromium-review.googlesource.com/1172091Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582472}
-
Xiaoqian Dai authored
Only the Edit printer dialog needs the scrollable behavior. Bug: 851903 Change-Id: I31ed7430b7caf1a6fcd878e732e3206868f40e79 Reviewed-on: https://chromium-review.googlesource.com/1168151Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#582471}
-
BUG=762641 TBR=alemate@chromium.org Change-Id: Ifeb4d9fca628409dbb436098f6e7aa4f8f03c10f Reviewed-on: https://chromium-review.googlesource.com/1172081Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582470}
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I395ce21322e74fe44a7a84974a61ca6000d58a90 Reviewed-on: https://chromium-review.googlesource.com/1172078 Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582469}
-
Peter Kasting authored
Bug: 870861 Change-Id: I8f5f47a2f87256ea3edf764ad5acedc287566d8b TBR: palmer Reviewed-on: https://chromium-review.googlesource.com/1172074Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#582468}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: Ifc3b27a5ffc4d212dae7de39c99f48d9d60908bd Reviewed-on: https://chromium-review.googlesource.com/1171992Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#582467}
-
Wez authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I6a13ee017776283e0ecad95a24d0e663699c3c3d Reviewed-on: https://chromium-review.googlesource.com/1171867 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f820a5ea1c5c..656d609a952a git log f820a5ea1c5c..656d609a952a --date=short --no-merges --format='%ad %ae %s' 2018-08-11 minyue@webrtc.org Add UTC time to init event in AEC debug dump. Created with: gclient setdep -r src/third_party/webrtc@656d609a952a The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: If4803f068b2c6b7ec68ac2c5daedecdadc67756f Reviewed-on: https://chromium-review.googlesource.com/1171718Reviewed-by:
-
- 11 Aug, 2018 20 commits
-
-
Christian Biesinger authored
This also required fixing the relayout when the scrollbar changes, which fixes css3/flexbox/scrollbars-auto.html (and avoids breaking two tests in external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/flexbox) Bug: 635619 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I790f0524b029a3c2340b6b9715c5b3529c75357f Reviewed-on: https://chromium-review.googlesource.com/1162657 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#582464}
-
David Black authored
AssistantOptInView visibility state is synced to the user's consent state as known by VoiceInteractionController. Note that it is possible for VoiceInteractionController to get out of sync (b/111882861). This CL also: - Animates footer entry on Assistant launch. - Animates transition of footer views when consent is granted/revoked. See bug for demo. Bug: b:111315696 Change-Id: I848c1301e13795711e8e1ff5916ac8e4020f4c0b Reviewed-on: https://chromium-review.googlesource.com/1171853Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#582463}
-
Xianzhu Wang authored
Object (DisplayItemClient) paint invalidation has not been very useful in layout tests (we care more about raster invalidations), and should be better tested with unit tests. Removing them from repaint layout test results can reduce rebaselines. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I6a01f025013734f788d199adc3fed4d02859b7d2 Reviewed-on: https://chromium-review.googlesource.com/1170037 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#582462}
-
David Black authored
This was previously created to send contextual HTML cards from AssistantManagerServiceImpl to AssistantScreenContextController. Now, thanks to changes in Libassistant, contextual cards will flow through our existing AssistantInteractionSubscriber.OnHtmlResponse pipeline. This interface is no longer necessary. Bug: b:112113187 Change-Id: Iccc11fdd92ce8144650038b487e735f28a3de98b Reviewed-on: https://chromium-review.googlesource.com/1171722 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Muyuan Li <muyuanli@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
James Robinson authored
Fuchsia cares about binary size, like iOS and Android. This configures the default build to -Oz instead of -O2. This reduces the size of text segment of the service_exe webrunner executable by about 13% when building for ARM64 release mode non-component: O2: text data bss dec hex filename 83509089 3370852 1109788a 87989729 53e9de1 out/fuchsia_arm64/exe.unstripped/service_exe text data bss dec hex filename 73707333 3398764 1110516 78216613 4a97da5 out/fuchsia_arm64/exe.unstripped/service_exe Oz: Change-Id: I09774eb71f690a483f3f6064cace265a7f7f80e6 Reviewed-on: https://chromium-review.googlesource.com/1171864Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
-
David Black authored
This parameter is needed to distinguish between user initiated requests and requests that we make ourselves. User generated requests initiate a conversation interaction that will return contextual cards. This may result from a suggestion chip press or Assistant stylus tool selection. Requests that do not originate from the user will not return contextual cards or start a conversation interaction. Instead, we will cache the screen context to send alongside subsequent voice/text queries for context. This portion is not yet wired up. Bug: b:112113187 Change-Id: I12cd531745d174738988808d7637c8529ddd80d0 Reviewed-on: https://chromium-review.googlesource.com/1170428 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
-
David Bokan authored
This is a reland of ace3f1f7 Original change's description: > [RootScroller] Allow main document horizontal overflow > > When implicitly promoting an element to be the root scroller, we first > check if the main document has any overflow. If it does, we err on the > side of not promoting since it is likely the main document's content is > important and meant to be scrollable. > > This heuristic turns out to be too restrictive. For example, this makes > it hard to build a root scrolling carousel. This CL loosens the > restriction to allow horizontal overflow. > > Bug: 838683 > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I6007f6faa8e2006799a9dca6240b68ff0de7f09a > Reviewed-on: https://chromium-review.googlesource.com/1165859 > Commit-Queue: David Bokan <bokan@chromium.org> > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581408} Bug: 838683 Change-Id: I886908a56db7a463c619135ed08712312ccacbfc Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel TBR: bokan, dtapuska Reviewed-on: https://chromium-review.googlesource.com/1171717 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Kevin Marshall authored
SandboxPolicyFuchsia is not thread affine but its ServiceDirectory is not. This CL schedules the ServiceDirectory's deletion on the same thread that was used for its construction. Change-Id: I98e950481e49106ba64c759cef2c903b5dcf5d3b Reviewed-on: https://chromium-review.googlesource.com/1171673Reviewed-by:
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I55fde6cc5f184386b780a060c5b6868b4e174735 Reviewed-on: https://chromium-review.googlesource.com/1172063 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
-
Bill Orr authored
A recent change accidentally modified the mapping of OpenVR contoller state to Gamepad buttons/axes. This change moves back to the original behavior. Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ifa821ef1610e04be42cd8a6c352d4dc93c006cfa Reviewed-on: https://chromium-review.googlesource.com/1171663 Commit-Queue: Bill Orr <billorr@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#582455}
-
Scott Violet authored
This makes Ash create an Env if passed SingleProcessMash. In addition this makes all window creation go through a factory that ensures the right env is supplied. See https://docs.google.com/document/d/11ha_KioDdXe4iZS2AML1foKnCJlNKm7Q1hFr6VW8dV4/edit for more details. This also adds the feature to ui/base. BUG=847992 TEST=covered by tests TBR=jamescook@chromium.org Change-Id: I446ba2dd7a05702cfca41a0e0d657d6606cc28e5 Reviewed-on: https://chromium-review.googlesource.com/1172054Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#582454}
-
Christopher Cameron authored
This is to limit the error spew in about:gpu (currently any useful messages are easily lost in warnings about these blank-resource uses). This function in SetVisible(false) to ensure that resources be dropped at tab switch. The current implementation immediately deletes the GL resource backing, even if it may be in use by the display. This results in flashed-black scrollbars and lots of GL errors. Change EvictAllUIResources to just evict the resources without deleting their backing. The resources are then destroyed when they are returned from the display (at OnUIResourceReleased). Bug: 864905, 870317 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I1e079e1790275d3194b565457971e65f7d265587 Reviewed-on: https://chromium-review.googlesource.com/1171832 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
-
Chris Harrelson authored
ShouldRespectOverflowClip conditions on paint_flags. However, AdjustForPaintProperties removes some of those flags (kPaintLayerPaintingOverflowContents in particular) when changing painting root. Before this patch, a non-composited clip (e.g. overflow:scroll) under a composited layer would not correctly apply a clip to the cull rect of the clip; now it does. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I04e4df8f1e0d987a3787ce430c80171f268884a4 Reviewed-on: https://chromium-review.googlesource.com/1171583 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#582452}
-
Peter Kasting authored
This reverts commit b6cde39f. Reason for revert: Caused flaky compile failures, e.g. https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20ChromeOS/54711 , https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/mac-rel/192 , https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-rel/1165 Original change's description: > Propagate update on RendererPreferences to ServiceWorkerFetchContextImpl > > Each FetchContexts needs to be notified it's update. This introduces a new Mojo > interface (mojom::RendererPreferenceWatcher) to observe changes in the > preferences. > > Bug: 853085 > Change-Id: I3985c0ee363e073099d1a3ac85bf210f5bbce537 > Reviewed-on: https://chromium-review.googlesource.com/1164151 > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: Makoto Shimazu <shimazu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#582445} TBR=avi@chromium.org,kinuko@chromium.org,shimazu@chromium.org Change-Id: Idda3a12439b55f00269ba3a3c0ea129a44c2fcf6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 853085 Reviewed-on: https://chromium-review.googlesource.com/1171716Reviewed-by:
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ea926a362b77..7ae70d8fb360 git log ea926a362b77..7ae70d8fb360 --date=short --no-merges --format='%ad %ae %s' 2018-08-11 jie.a.chen@intel.com ParallelCompile: Parallelize D3D linking Created with: gclient setdep -r src/third_party/angle@7ae70d8fb360 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: Iaab7a283e847ad95981074123daffcd3db07a34e Reviewed-on: https://chromium-review.googlesource.com/1171713Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582450}
-
Danil Chapovalov authored
undefine StrCat from StrCatW after including windows headers that redefine it Add preprocessor checks StrCat is not defined to something else. Add presubmit check headers that include shlwapi.h that redefines StrCat are wrapped Bug: chromium:856536, chromium:817738 Change-Id: Ief9303cbf6fa4f55f671861e49fb1fc747ed59aa Reviewed-on: https://chromium-review.googlesource.com/1117180Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Danil Chapovalov <danilchap@chromium.org> Cr-Commit-Position: refs/heads/master@{#582449}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5fb1b7e0ffe1..02d174687cc9 git log 5fb1b7e0ffe1..02d174687cc9 --date=short --no-merges --format='%ad %ae %s' 2018-08-11 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 ea926a362b77..7ae70d8fb360 (1 commits) Created with: gclient setdep -r src/third_party/skia@02d174687cc9 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=djsollen@chromium.org Change-Id: I9416d8cdad46cb1244ae903d8fa4e87fb3e0f7aa Reviewed-on: https://chromium-review.googlesource.com/1171714Reviewed-by:
-
Ella Ge authored
TextAutosizer::ComputeAutosizedFontSize are used in both font_builder and computed_style. The size passed in from font_builder is computedsize, which has zoom factor applied. But in ComputedStyle::SetTextAutosizingMultiplier, zoom factor doesn't. And also, kPleasantSize is hard-coded css pixel (without zoom factor), and it was used in calculation with computed_size(with zoom factor). The inconsistancy causes line height incorrect when multiplier applied(crbug/871124), and also text sometime lost scaling(crbug/871054) This CL correct the variable in ComputeAutosizedFontSize to computed_size, and pass in effective_zoom, so the sizes are computed in correct scale. Bug: 871054, 871124 Change-Id: Icf546795663b76af3cd03e4e42da96483eb83af7 Reviewed-on: https://chromium-review.googlesource.com/1169972Reviewed-by:
-
Trent Apted authored
Give it a js_unit_tests target, and lint the externs in gallery/js/BUILD.gn. Delete externs/gallery_event.js - it's currently unreferenced and unused. ribbon.js gets the definition of event.item from an assignment in gallery_data_model.js - not from this extern file. Bug: 867700 Change-Id: Iae49ca0af61768b37274db2314630cbde9b120ef Reviewed-on: https://chromium-review.googlesource.com/1170452Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#582446}
-
Makoto Shimazu authored
Each FetchContexts needs to be notified it's update. This introduces a new Mojo interface (mojom::RendererPreferenceWatcher) to observe changes in the preferences. Bug: 853085 Change-Id: I3985c0ee363e073099d1a3ac85bf210f5bbce537 Reviewed-on: https://chromium-review.googlesource.com/1164151Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#582445}
-
