- 15 Feb, 2019 40 commits
-
-
Scott Violet authored
It would seem neither of these are necessary any longer. BUG=none TEST=none Change-Id: Iec712982e85a80255d270c9818093085f0343841 Reviewed-on: https://chromium-review.googlesource.com/c/1474990 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#632804}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1b85323f10e7..34a2a76e2094 git log 1b85323f10e7..34a2a76e2094 --date=short --no-merges --format='%ad %ae %s' 2019-02-15 scroggo@google.com Remove assert that BGRA and RGBA are not opaque 2019-02-15 herb@google.com Revert of CL/192440 which would not reland cleanly. 2019-02-15 fmalita@chromium.org add mixer colorfilter 2019-02-15 csmartdalton@google.com Remove shader caps argument from GrGLSLTypeString 2019-02-15 robertphillips@google.com Stop using resourceProvider in GrRenderTargetContext's ctor Created with: gclient setdep -r src/third_party/skia@34a2a76e2094 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: I54f8a515e6da7c0d7aeeefd5e53cb621ca6cf799 Reviewed-on: https://chromium-review.googlesource.com/c/1475036Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632803}
-
Eric Karl authored
In certain cases, drivers hang when tearing down the Display. Finishing before teardown appears to address this, and should have minimal impact as we're during Display teardown so no frames are likely to be produced soon. We will hopefully replace this with a more targeted fix, but this should allow us to test some theories. Bug: 899705 Change-Id: Ie93ee00dcb975b704dccc51ba37a6267bb2d9719 Reviewed-on: https://chromium-review.googlesource.com/c/1468681 Auto-Submit: Eric Karl <ericrk@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#632802}
-
Becca Hughes authored
Add support for an "ambient" audio focus type. This is used when a media session can have its audio mixed with other sources; therefore it has no effect on other sessions when it gains focus. It can also be used when we want a session to appear in audio focus manager but without taking focus from other players (e.g. remote playback, paused). BUG=932315 Change-Id: I75318bc6ecc8fd561da4ad62764d0f44ee1ed178 Reviewed-on: https://chromium-review.googlesource.com/c/1474979Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#632801}
-
siyua authored
This DCHECK makes sure the email passed in CreateExplanationText() is not empty, but we later made change so that this function will be called when creating feedback dialog view where there is no user email address. So this DCHECK will always fail on an expected event. Bug: 897998 Change-Id: Id22300ba56fcc4de15f014a554d5c2d1e88df01d Reviewed-on: https://chromium-review.googlesource.com/c/1474805 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#632800}
-
Theresa authored
Start the trace after the early return to avoid a trace begin without end. NOTRY=true Bug: 932356 Change-Id: I07968ee22b41d9b0274ccfcaad6581173a10b020 Reviewed-on: https://chromium-review.googlesource.com/c/1474740Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#632799}
-
Yue Li authored
Bug: b/124240611 Test: Manual Test Change-Id: Idfd180d408a22f97330fb4f4deb60d0bc430cf80 Reviewed-on: https://chromium-review.googlesource.com/c/1471265Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#632798}
-
Alex Clarke authored
This is in preparation for the BrowserUIThreadScheduler where we hope to have only one location where it's set up. Bug: 863341, 872372 Change-Id: Ia7c07adc1d60280f2aed25f5226bfce80c6aba4b Reviewed-on: https://chromium-review.googlesource.com/c/1461393 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#632797}
-
Sergey Ulanov authored
This change reverts some parts of https://crrev.com/632311 . Modular still depends on ViewsV1, so it was broken by that change since it removed ViewsV1 support in web_runner. Bug: 899348 Change-Id: I10cd2c2c11b3b4d2ad2d3a0000ffee5c13e549e7 Reviewed-on: https://chromium-review.googlesource.com/c/1476063 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#632796}
-
Oksana Zhuravlova authored
Change-Id: I7d503196544f976ddaf1eeea4916b44a8989722b Reviewed-on: https://chromium-review.googlesource.com/c/1475830Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#632795}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2b14855de938..efc7e91fa764 git log 2b14855de938..efc7e91fa764 --date=short --no-merges --format='%ad %ae %s' 2019-02-15 iannucci@chromium.org [recipes] Manual roll. Created with: gclient setdep -r src/third_party/depot_tools@efc7e91fa764 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:914992 TBR=agable@chromium.org Change-Id: I145d4a1cb21987361fe8d6e1742ea471a4c9cf75 Reviewed-on: https://chromium-review.googlesource.com/c/1475893Reviewed-by:
-
manuk authored
This is a reland of 6e200e4f Original change's description: > [omnibox]: Initialize HistoryURLProvider earlier. > > This CL moves the HistoryURlProvider's initialization after the SearchProvider's > but before the ZeroSuggestProvider's and ClipboardURLProvider's. > > For threading reasons, CL 1384637 moved the HistoryURlProvider's initialization > last in the AutocompleteController's constructor. However, the zero suggest and > clipboard URL providers take a reference of the history URL provider when > initialized. To avoid setting these references to NULL, this CL moves the > history URL provider's initialization before the other two's but keeps > it after the search provider's for the reasons described in the other CL. > > Bug: 932257 > Change-Id: I1085ad89e13f29ea29264ce3fa1a2d33197f3b17 > Reviewed-on: https://chromium-review.googlesource.com/c/1474383 > Reviewed-by: Mark Pearson <mpearson@chromium.org> > Commit-Queue: manuk hovanesian <manukh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#632682} Bug: 932257 Change-Id: If1dd04d838bc78f8f323280b4023fea551a80b3a Reviewed-on: https://chromium-review.googlesource.com/c/1475249Reviewed-by:
manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#632793}
-
Hiroshige Hayashizaki authored
Will be used by [1] for V8 Code Cache for module scripts. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1237715 This doesn't change behavior. Bug: 841466 Change-Id: I15c4e6d4894ad5f41cc365dfb2c73b2d5fa3c40a Reviewed-on: https://chromium-review.googlesource.com/c/1475089Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#632792}
-
Erik Chen authored
This CL specifies the owners for the memlog flags, and indicates that they should never expire. Change-Id: I90a44edde7110355dde97dcfcbb6f9fd93246c03 Reviewed-on: https://chromium-review.googlesource.com/c/1473406 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#632791}
-
Min Chen authored
Bug: None Change-Id: I9635ede393d0390633b316030b2b0496d361d845 Reviewed-on: https://chromium-review.googlesource.com/c/1474993Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#632790}
-
Danyao Wang authored
This patch uses test_driver.bless() to automate manual tests that need a user activation to trigger .show(). The new automated tests pass on Chrome after this patch. Bug: 929773 Change-Id: Ic220c89db48c12a594ff9f77d091ff952b0c9abc Reviewed-on: https://chromium-review.googlesource.com/c/1474708Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#632789}
-
Oksana Zhuravlova authored
Change-Id: I26ca6eafa573be059dc6aceb63667f5d84b3e832 Reviewed-on: https://chromium-review.googlesource.com/c/1474625Reviewed-by:
-
Yutaka Hirano authored
The test was leaky when introduced, so it got DISABLED. Making Resource garbage collected solved the leak problem, but another change (probably https://crrev.com/aadbd2624c5003698624cf2e21fd6ae876e28629) broke the test silently. Bug: 340306 Change-Id: I5a5b2e619831fefd1ac9183fed9cff1293768e1c Reviewed-on: https://chromium-review.googlesource.com/c/1474884Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#632787}
-
Peter Collingbourne authored
Bug: 916828 Change-Id: I62582adf66fba07ebda6bda9980925ed515fb9dd Reviewed-on: https://chromium-review.googlesource.com/c/1475169Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#632786}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/e1f0d4e639f6..695b68d1009b git log e1f0d4e639f6..695b68d1009b --date=short --no-merges --format='%ad %ae %s' 2019-02-15 cwallez@chromium.org WebGPU error handling 3: CommandEncoder for validation tests Created with: gclient setdep -r src/third_party/dawn@695b68d1009b The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I918187ec7a89ffa7add8d086ce6302839b092103 Reviewed-on: https://chromium-review.googlesource.com/c/1475698Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5212cf739dd8..1f97ac96e633 git log 5212cf739dd8..1f97ac96e633 --date=short --no-merges --format='%ad %ae %s' 2019-02-15 simonhatch@chromium.org Pinpoint - Plumb bucket through to find_isolate_execution Created with: gclient setdep -r src/third_party/catapult@1f97ac96e633 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:931921 TBR=sullivan@chromium.org Change-Id: I541413b8548824f24b7b6b79f14c2c4607d4f676 Reviewed-on: https://chromium-review.googlesource.com/c/1475894Reviewed-by:
-
Evan Stade authored
Bug: none Change-Id: I9c8fcaa966474a059c1b1f910c18488265a9b772 Reviewed-on: https://chromium-review.googlesource.com/c/1474984 Commit-Queue: James Cook <jamescook@chromium.org> Auto-Submit: Evan Stade <estade@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#632783}
-
Patrick Monette authored
This will allows us to assess the performance impact that is has on Chrome. Bug: 928846 Change-Id: I0d4d41efab120c8be56548d2562008b47dff7534 Reviewed-on: https://chromium-review.googlesource.com/c/1452786 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#632782}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4bb6437ff800..7081b4fe0f79 git log 4bb6437ff800..7081b4fe0f79 --date=short --no-merges --format='%ad %ae %s' 2019-02-15 treehugger-gerrit@google.com Merge "Fix expectation in UnwindingTest." Created with: gclient setdep -r src/third_party/perfetto@7081b4fe0f79 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I2ce35dfdbbc3621c6d56913ae4a48db639672dcc Reviewed-on: https://chromium-review.googlesource.com/c/1475891Reviewed-by:
-
David Trainor authored
This adds real support for inline updates from Play. This hooks up the AppUpdateManager Play class to Chrome's InlineUpdateController and UpdateStateProvider. play core library that are required to support inline updates. Binary-Size: This cl brings in the minimal set of new classes from the Bug: 922714 Change-Id: I1ba932a97502472af956471d8d58c87645a966f7 Reviewed-on: https://chromium-review.googlesource.com/c/1468801 Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#632780}
-
Elly Fong-Jones authored
This change removes these flags: enable-media-controls-expand-gesture enable-modern-media-controls enable-overflow-icons-for-media-controls and adds TODOs to remove the backing features. Bug: None Change-Id: Ie442b114280c19d5fa89b64d79fa8c92ee7021a8 Reviewed-on: https://chromium-review.googlesource.com/c/1475799 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#632779}
-
Morten Stenshorne authored
We don't need to store the sizes on the legacy object at all, since we only need this during layout. Reduces the need for allocating (fairly big) LayoutBoxRareData objects. It also eliminates the need for storing OverrideAvailableInlineSize at all in LayoutBoxRareData, since it's only set from LayoutNG. Change-Id: I291713cac3c20d8fe81d656627eed7c8a830e9fd Reviewed-on: https://chromium-review.googlesource.com/c/1472711 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#632778}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/2bb0864b22e7..0eba65b14b60 git log 2bb0864b22e7..0eba65b14b60 --date=short --no-merges --format='%ad %ae %s' 2019-02-15 chrisforbes@google.com Support loads and stores of interface variables 2019-02-15 chrisforbes@google.com Add SpirvRoutine::getValue helper 2019-02-15 chrisforbes@google.com Implement some common forms of OpAccessChain 2019-02-15 chrisforbes@google.com Implement some common forms of OpStore 2019-02-15 chrisforbes@google.com Implement some common forms of OpLoad 2019-02-15 chrisforbes@google.com Templatize PopulateInterface & friends 2019-02-15 chrisforbes@google.com Split out decoration application helpers to avoid some iterator noise 2019-02-15 chrisforbes@google.com Fix handling of pointer sizes; we want them to be 1 2019-02-15 chrisforbes@google.com Add analysis pass support for OpLoad and OpAccessChain 2019-02-15 chrisforbes@google.com Handle more instructions in spirv analysis pass 2019-02-15 chrisforbes@google.com Remove more obsolete machinery from PixelProcessor 2019-02-15 chrisforbes@google.com Remove depthOverride pixel state bit 2019-02-15 chrisforbes@google.com Correctly determine whether we need to compute centroids 2019-02-15 chrisforbes@google.com Wire up FS input to the shader 2019-02-15 chrisforbes@google.com Remove VertexProcessor shader constants mechanism 2019-02-15 chrisforbes@google.com Wire VS interfaces onto spirv shader 2019-02-15 chrisforbes@google.com Set up VertexIndex builtin properly 2019-02-15 chrisforbes@google.com Do initial integration of spirv code generation with FS 2019-02-15 chrisforbes@google.com Remove various legacy parts of FS plumbing 2019-02-15 chrisforbes@google.com Rework setup, VS->FS structures, etc for Vulkan 2019-02-15 chrisforbes@google.com Start building up code generation Created with: gclient setdep -r src/third_party/swiftshader@0eba65b14b60 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/124388146,chromium:b/124388146,chromium:b/124388146,chromium:b/124388146,chromium:b/124388146,chromium:b/124388146,chromium:b/124388146,chromium:b/124388146,chromium:b/124388146,chromium:b/124388146,chromium:b/124177079,chromium:b/124177079,chromium:b/124177079,chromium:b/124177079,chromium:b/124177079,chromium:b/124177079,chromium:b/124177079,chromium:b/124177079,chromium:b/124177079,chromium:b/120799499,chromium:b/120799499 TBR=swiftshader-team+autoroll@chromium.org Change-Id: I6afcd6abcbdd291cdb106029eb4e31d4241b26ba Reviewed-on: https://chromium-review.googlesource.com/c/1475892Reviewed-by:
-
Adam Langley authored
This change adds request handlers for a future Settings UI to call into in order to drive set/change PIN and reset operations. Change-Id: I6df99d79807e4f87f20d4344a26eef7b896fd254 Reviewed-on: https://chromium-review.googlesource.com/c/1460412 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#632776}
-
Devlin Cronin authored
Fix a crash in revoking extension permissions where the permissions to be revoked didn't seem to be contained within the granted permissions. This was caused because the <all_urls> URLPattern retrieved from ExtensionPrefs (through calls to ExtensionPrefs::GetRuntimeGrantedPermissions) isn't properly scheme- restricted to avoid including chrome:-scheme patterns. As a result of crrev.com/e13eb218, URLPattern::Contains now properly checks schemes, resulting in this contains check failing and triggering a CHECK() failure. As a workaround, hackily adjust the runtime-granted permissions retrieved from ExtensionPrefs in ScriptablePermissionsModifier to properly omit the chrome:-scheme from <all_urls> patterns (adding back chrome://favicon separately). This logic mirrors that in ParseHelper in permissions_parser.cc, which adds the patterns to the extension permissions. This isn't a great solution, since ExtensionPrefs should really not be returning incorrect values for URLPatterns; however, it's the most targeted and easiest to merge. Since this is for a crash, go with this approach for now. A separate bug has been filed to fix ExtensionPrefs behavior. Add a regression test for the previously-crashing behavior. Bug: 930062 Change-Id: I0813c2bc2a462a0ced48f2e1a265c1efe7f2fdea Reviewed-on: https://chromium-review.googlesource.com/c/1471004 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#632775}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/7dc6b1b652fc..34fb6244cfec git log 7dc6b1b652fc..34fb6244cfec --date=short --no-merges --format='%ad %ae %s' 2019-02-15 thestig@chromium.org Add a test to show a case where patterns draw incorrectly. Created with: gclient setdep -r src/third_party/pdfium@34fb6244cfec The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I5e16bee4d92c430f214187b868a45c28c0d12f57 Reviewed-on: https://chromium-review.googlesource.com/c/1475890Reviewed-by:
-
Hiroshige Hayashizaki authored
Bug: None Change-Id: I9dd82cb5b43641dff6a5ee8a0f0788ba4a9165fa Reviewed-on: https://chromium-review.googlesource.com/c/1469373 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#632773}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/abcac71093c8..af2885953ccf Created with: gclient setdep -r src-internal@af2885953ccf The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Idc7159c1299dda3cfc4cda532e7f7074c6332026 Reviewed-on: https://chromium-review.googlesource.com/c/1474497Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632772}
-
Wenzhao Zang authored
There's a corner case that this message is shown, and the wallpaper picker refresh ignored this case. However, all the messages have consistent style in the new wallpaper picker spec, so we'll reuse the existing spec. Bug: 899872 Change-Id: I4d8834e2f569906943b31ba00a06cd1b7455e461 Reviewed-on: https://chromium-review.googlesource.com/c/1474775Reviewed-by:
May Lippert <maybelle@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#632771}
-
Jordan Taylor authored
web_tests/animations/animationworklet/animate-non-accelerated-property.html -> web_tests/external/wpt/animation-worklet/animate-non-accelerated-property.https.html web_tests/animations/animationworklet/cancel-non-accelerated-property.html -> web_tests/external/wpt/animation-worklet/cancel-non-accelerated-property.https.html Bug: 915352 Change-Id: I7ec16782489a9747920f6e93aa0fab749e25fbe8 Reviewed-on: https://chromium-review.googlesource.com/c/1474634 Commit-Queue: Jordan Taylor <jortaylo@microsoft.com> Reviewed-by:
Yi Gu <yigu@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#632770}
-
Jared Saul authored
Bug: 924021 Change-Id: If18e074621398ac7795523311c024821c7fb6ff1 Reviewed-on: https://chromium-review.googlesource.com/c/1468784Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
-
Aleks Totic authored
Reland of https://chromium-review.googlesource.com/c/chromium/src/+/1471384 Originals failed wpt import Bug: 907911 Change-Id: Ie97da9f68cf972d31303c7e3ee547e8a184bd52d Reviewed-on: https://chromium-review.googlesource.com/c/1474709Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#632768}
-
Ovidio Henriquez authored
This change updates the OWNERS files for directories that are part of the Blink>USB and IO>USB components to point to the OWNERS file found at //chrome/browser/usb/OWNERS. Change-Id: I014b5ab66c97e1a1ffbcfa2a217c07b57dcecc2c Reviewed-on: https://chromium-review.googlesource.com/c/1474510 Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#632767}
-
kylechar authored
TaskRunner::PostTask() takes a OnceCallback. Replace usage of base::Bind(), which produces a RepeatingCallback, with base::BindOnce() when the callback is created as a temporary inside of PostTask(). The following regex was used to find instances that could be replaced: (Post(?:Delayed)?Task)\((?:\n\s*)?FROM_HERE,(?:\n)?\s*base::Bind\( Also replace any usage of base::Passed(&var) with std::move(var) for variables passed to base::BindOnce(). base::Passed() isn't needed for move-only types with OnceCallbacks. This CL was uploaded by git cl split. R=zea@chromium.org Bug: 714018 Change-Id: I563c61da47057260e97bb3989d571f1edc2514e7 Reviewed-on: https://chromium-review.googlesource.com/c/1475646 Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:
Nicolas Zea <zea@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#632766}
-
Tommy C. Li authored
This experiment changes the generic vector icon for search to the same color as RESULTS_TEXT_URL (generally blue). It also changes the search terms presented in omnibox suggestions to that color. Bug: 931836 Change-Id: I7e42c901a984e8762e9c969a219be91008dae7e0 Reviewed-on: https://chromium-review.googlesource.com/c/1474090 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#632765}
-
