GitLab

Oilpan switched to non-eager tracing of objects recently. This removes
the now unused infra to track stack frame depth.

Bug: 933333
Change-Id: I8d75b6219cff838d20c8be5b71d62a85b005e339
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524491Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641665}

TBR=twellington@chromium.org

Change-Id: I0ef49a607322d7da41356d0b500debb41461d5b8
Bug: 942902
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527537Reviewed-by: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Auto-Submit: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641664}

libassistant only request audio focus with
output type STREAM_MEDIA at the end of ReleaseFocusForStream.

We would like to request audio focus when the internal media player is
playing.

In this CL:
- When the internal media player start audio playback with audio output
type STREAM_MEDIA, we explicitly acquire audio focus.
- When the internal media player stop audio playback with audio output
type STREAM_MEDIA, we explicitly abandon audio focus if necessary.

Bug: b:123718677
Test: Manual
Change-Id: Ia30e685d7ed2186145140c38ae8526db5284a7ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506554
Commit-Queue: Li Lin <llin@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641663}

Currently if a field is invalid, and we are using the client
validation feature, the field will not get autofilled.
According to the current validation logic, if country is empty,
all the address fields would be considered as invalid. This is not
good as we may have many valid profiles where the country is empty.
Therefore, we are going to have an exception here and have the
address fields autofilled, if the country is empty.

The suggestions would not change as the validation only changes
their order, and is not as aggressive.

Change-Id: I479dd9dd853032e309679c4bcaf2b117bb29d3f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524677
Commit-Queue: Parastoo Geranmayeh <parastoog@google.com>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641662}

This is a reland of 8c66199b.

Fixes use of uninitialized |num_pending_|.

Original change's description:
> This CL adds SQLitePersistentReportingAndNELStore which persists
> NEL policies to disk in a SQLite database. It will eventually also store
> Reporting clients and reports.
>
> The code is based on that of the SQLitePersistentCookieStore.
>
> It is not hooked up to anything yet (just unittests).
>
> Bug: 895821
> Change-Id: I99ea14ace6f9b7fecd6075b1be98647db80d2bcb
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504493
> Commit-Queue: Lily Chen <chlily@chromium.org>
> Reviewed-by: Maks Orlovich <morlovich@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#641361}

Bug: 942889, 895821
Change-Id: I679d6713a295715a3a08206f61c91cf58adcd0d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528474
Auto-Submit: Lily Chen <chlily@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Lily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641661}

Creates a new OmniboxPopupBaseViewController class. Renames existing
OmniboxPopupViewController class to OPLegacyVC.
Updates all current usage of OPVC to OPLegacyVC.

Bug: none
Test: none
Change-Id: I67338edce43431be0cd2b7dc9aabe91fcfc8c253
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1511356Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641660}

BUG=v8:8988

Change-Id: I0a0cc3b95814656de1a602cc31bca2fe726dae79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522193
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641659}

Added perfetto unittests to Linux, Mac, and Windows bots.
Removed tests from Android bots because they were failing.
Reland of https://crrev.com/c/1468261 with a few adjustments.

Bug: 931138
Change-Id: Ic4e844f0008e5a267ee28db627c3c4086e0fdfbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524528
Commit-Queue: Karen Qian <karenqian@google.com>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641658}

In focusless spat-nav mode, escape will blur a focused element so the
user can bo back to moving interest around. A common pattern is for the
page to move focus to an inner input element when clicked. Currently,
the implementation will blur the focused element on escape only if it's
also interested.

An alternative fix here would be to listen to focus changes and move
interest as well. That's a larger change and it's not clear it's
desirable. This CL simply removes the restriction that the focused
element must be interested; the escape key will blur any focused
element.

Bug: 942110
Change-Id: I0379bb3272b154f88a749453a41dbe9eadce4c0f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526484Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641657}

Bug: 929725
Change-Id: I91a2260c745a3d754f4b967cc354d3abc078434a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1459522
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641656}

This makes CrasAudioHandler::AudioObserver::OnOutputMuteChanged
match CrasAudioClient::Observer::OnOutputMuteChanged

Bug: 940810
Change-Id: If170df2f5c3cb451b4895d4052c39f42c25d8580
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522552
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641655}

Bug: 816629,861983
Change-Id: I2f6ce50bab8410679e8e5e7255349e087e62373d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1320207Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641654}

...instead of ProfileSyncServiceMock, which is an antipattern.

Bug: 910518
Change-Id: Iffd4da62dff2db9add9e930ef37e983c82525934
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528184Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641653}

I will use this hook to do some processing before the damage is sent that
may impact the damage regions.

BUG=627663
TEST=will be coming

Change-Id: Ic4466c2290c6b30404c92744ecc0b708aa2a8b29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519312
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641652}

...instead of ProfileSyncServiceMock, which is an antipattern.

Bug: 910518
Change-Id: Iec983a22725d3d766c40dbbf52953909134b7b18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528190
Auto-Submit: Marc Treib <treib@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641651}

R=proberge

Bug: 830892
Change-Id: I9def8b589ffbe1c037e81520fdb878b53df4b368
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525177
Commit-Queue: Joe Mason <joenotcharles@google.com>
Reviewed-by: proberge <proberge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641650}

Some code use ui/events/blink/did_overscroll_params.h and
ui/events/blink/web_input_event_traits.h so there needs to
be a dependency to "//ui/events/blink" which declares those headers.

Missing dependency found with a gn check --check-generated (new
feature just added to gn, see gn:57).

Exact errors:

ERROR at //out/Default/gen/content/common/input/input_handler.mojom.h:78:11: Include not allowed.
          ^--------------------------------------
It is not in any dependency of
  //content/common:mojo_bindings
The include file is in the target(s):
  //ui/events/blink:blink
which should somehow be reachable.
___________________
ERROR at //out/Default/gen/content/common/input/input_handler.mojom.h:79:11: Include not allowed.
          ^---------------------------------------
It is not in any dependency of
  //content/common:mojo_bindings
The include file is in the target(s):
  //ui/events/blink:blink
which should somehow be reachable.
___________________


Bug: 938893
Change-Id: I3c2001e5cfe4d7a5cd6334cb1162b15ca97a6a2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528185Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#641649}

There was an oversight in the old logic's "aggressive" correction path:
During device switch-over periods, when timestamps were unstable, the
resampler was being reconfigured for each and every call to Render().
This might have been part (or all?) of the cause of higher-than-expected
CPU usage seen on some machines.

The new logic in this change, instead, reconfigures the resampler in
coaser-grained steps. The code to accomplish this is also simpler. From
testing (on my three desktops, various scenarios), synchronization seems
to generally converge much more quickly and is generally more stable.

Bug: 936835, 931225
Change-Id: I01a029bdcc37e4c92ff84a22dfaac674712cac3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526798
Auto-Submit: Yuri Wiitala <miu@chromium.org>
Commit-Queue: Max Morin <maxmorin@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641648}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bb85d2ba05ff..28645ae1d8fb


Created with:
  gclient setdep -r src-internal@28645ae1d8fb

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=rogerta@chromium.org,yoichio@chromium.org,finnur@chromium.org,atotic@chromium.org,nicolaso@chromium.org

Change-Id: I1cb61d485cb95a8330986f0266140a58dcc87653
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528512Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#641647}

If the user has sync disabled by enterprise policy, the Manage sync
settings and the sync toggle need be hidden. And an error needs to
explain why sync is not available.

https://drive.google.com/open?id=1EgUvUXD9zXAHC85mzB0wx75f67yUEuhe

Bug: 937118
Change-Id: I91a2c50b053a920289a8bdbcb967001961da5c89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508262
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641646}

https://skia.googlesource.com/skia.git/+log/cfea834b8da6..252996c72d2c


git log cfea834b8da6..252996c72d2c --date=short --no-merges --format='%ad %ae %s'
2019-03-18 borenet@google.com [infra] Add some logging to go_deps asset creation
2019-03-18 brianosman@google.com Delay half-float vertex color determination until Op::finalize
2019-03-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader c2bb50b73101..00424c1bc233 (1 commits)
2019-03-18 yikong@google.com [Android] Do not build for Windows


Created with:
  gclient setdep -r src/third_party/skia@252996c72d2c

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:126457671
TBR=brianosman@chromium.org

Change-Id: I13a2caa2bb0ba3ddbf106c9bb0171afc3b287455
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528511Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#641645}

Change-Id: If35f720b23aad710989b98c005629fcd5ba9702b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526611Reviewed-by: Mike Klein <mtklein@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Mike Reed <reed@google.com>
Cr-Commit-Position: refs/heads/master@{#641644}

Bug: 939801
Change-Id: I3203025ea4b0edcd536f12d3faf4e6f6280993a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528530Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641643}

Bug: 942654
Change-Id: If7eda05fc8e3e197488ac4140634c2606e2bef26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525171Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641642}

Before this CL, there was a condition
"if (disabled_by_policy || !requested || first_setup_complete)"
which didn't make a lot of sense.
This CL breaks it apart by pulling out the disabled_by_policy and
!requested cases.
As one potential small behavior difference, these two cases will now have
priority over the "passphrase required" case. A passphrase should never
be required if Sync is disabled by policy or disabled by the user, so
this should make no practical difference.

Bug: 911153
Change-Id: I000192b4f17578cf1d1ff714e7f4e9ef4c752131
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528612Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641641}

While adding new goog-stats is banned and not allowed, this new metric
passed through our bots and review process, and has already reached M73
Stable. It's a bit late to remove it, so this CL updates our whitelist
to prevent the possibility of (flaky?) failures on
WebRtcBrowserTest.RunsAudioVideoWebRTCCallInTwoTabsGetStatsCallback.

Bug: 943123
Change-Id: If98991abf512f04b3f6083dc3706876ba3515bd3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528570Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641640}

A raw pointer to LauncherSearchProvider is passed to
launcher_search_provider::Service::OnQueryStarted and might be used
after LauncherSearchProvider is deleted while the query is being
processed.

Cancelling the currently running query from LauncherSearchProvider
destructor fixes the problem.

Bug: 921783
Test: manual, steps in bug
Change-Id: If624a2841c62197041ee2fb9b6e11e6f056afabc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526534
Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Auto-Submit: Vladislav Kaznacheev <kaznacheev@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641639}

CMA backend is expecting pipeline to keep the buffer alive until the
buffer is pushed successfully.

Bug: internal b/124943170
Test: Delay the call of OnPushBufferComplete and cast doesn't crash
Change-Id: Ib23b1742f426ec79897c288430422cc70a3f6986
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526696
Commit-Queue: Yuchen Liu <yucliu@chromium.org>
Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641638}

The minimum contribution of a grid item is the outer size resulting from
the minimum size if the computed preferred size behaves as auto, or the
min-content contribution otherwise.

If the preferred size is a percentage, it should be resolved with
respect to the grid area, which depends on the minimum contribution
of the item. Thus the percentage is cyclic and behaves as auto.

Before this change, Blink only checked whether the preferred size is
auto, not whether it behaves as auto. In fact this was according to
an older version of the spec, but it was changed in
https://github.com/w3c/csswg-drafts/issues/2367

Firefox already implemented this change in https://bugzil.la/1462854

BUG=931474
TEST=external/wpt/css/css-grid/grid-items/grid-item-percentage-sizes-001.html
TEST=external/wpt/css/css-grid/grid-items/grid-item-percentage-sizes-002.html

grid-item-percentage-sizes-003.html improves but still fails because of
http://crbug.com/942811

Change-Id: Iaf57a0237c68a5557ff9c7ee7b526975d51ac988
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526051Reviewed-by: Manuel Rego <rego@igalia.com>
Reviewed-by: Javier Fernandez <jfernandez@igalia.com>
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Cr-Commit-Position: refs/heads/master@{#641637}

Bug: 933109
Change-Id: I1e0b7548ac53c61f2e133989d7d9d747ac4850dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520497Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Lowell Manners <lowell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641636}

https://webrtc.googlesource.com/src.git/+log/6d83592367c2..7dbc0eb2efa4


git log 6d83592367c2..7dbc0eb2efa4 --date=short --no-merges --format='%ad %ae %s'
2019-03-18 srte@webrtc.org Makes loss based controller test more robust.


Created with:
  gclient setdep -r src/third_party/webrtc@7dbc0eb2efa4

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I3b573750cf63e863f2ceef7b0326d90373312da0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528283Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#641635}

Add per-target reminders that these targets are generated and
customizations should go into BuildConfigGenerator.groovy instead.

Bug: 913062
Change-Id: I1e6a927378de741efd79e7f248ce714cb1f55dd0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525310
Commit-Queue: Peter Wen <wnwen@chromium.org>
Commit-Queue: Sam Maier <smaier@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Reviewed-by: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641634}

Grid container baseline was wrongly computed when done in reference
to an orthogonal item.
The fix is a simple change in LayoutGrid::FirstLineBoxBaseline()
to use LogicalTopForChild() so it takes into account grid container
and item writing modes.

BUG=943003
TEST=external/wpt/css/css-grid/alignment/grid-container-baseline-001.html

Change-Id: I86301933ac9ec30f6fee138cd49981bb79a4484e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528183Reviewed-by: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Oriol Brufau <obrufau@igalia.com>
Commit-Queue: Manuel Rego <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#641633}

Currently, a bunch of places call QueryDetailedSyncStatus() (a fairly
low-level for-debugging method) to detect specifically whether the
Chrome client is too old and needs to be updated for Sync to work.
This CL adds a new SyncService API that exposes this bit specifically,
and updates sync_ui_util to use it.
As a follow-up, we can mark QueryDetailedSyncStatus as "ForDebugging".

Bug: 940437
Change-Id: I30a30a66366f4d3bb52e465bdfd4130003c943d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1523095
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641632}

This CL improves the VaapiJpegDecoder tests a bit:

- It adds more ASSERTs to check the sanity of the reported minimum and
maximum supported sizes.

- Simplifies calls to GenerateJpegImage().

- Uses reinterpret_cast for type agreement.

- Makes a couple of variables const.

Test: jpeg_decode_accelerator_unittest passes on grunt and samus.
Bug: 934560
Change-Id: I13dc691c769157ced12b7f438c6058596744a155
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526698
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641631}

There are a lot of pixel tests running on GLRenderer, but not on
SkiaRenderer. Parameterize tests, find out which ones pass with Skia,
and add TODOs to the rest.

Bug: 939442
Change-Id: I315449c89cf903c1418fb5c42bc78ba89d7b6296
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509454Reviewed-by: vmpstr <vmpstr@chromium.org>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641630}

In future this will prioritize it which helps startup occur slightly
quicker.

Bug: 863341
Change-Id: I1c8014bb8f74e6c84a82c11aa02b5dc53a66e7d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524273Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641629}

All tests pass, and crashes no longer happen. I believe
that code will not longer crash, but there might be
futher instances of incorrect positioning.

Fix #1
LayoutDescendantCandidates did not sweep newly discovered
candidates. This was done
manually once inside NGOutOfFlowLayoutPart::Run, and
sweep was not performed for LayoutDescendantCandidates
found in Legacy. Fix is to make LayoutDescendantCandidates
perform sweep instead.

Fix #2
fix #1 exposed a bug where duplicate fragments were generated
for a single layout object. This happened when NG was generating
fragments not inside ContainingBlock. Fix one instance of this
inside NGOutOfFlowLayoutPart::IsContainingBlockForDescendant
by making sure that OOF with inline containers are only positioned
inside its ContainingBlock()

Fix #3
NGOutOfFlowLayoutPart::LayoutDescendant offset adjustment.

Bug: 935805
Change-Id: I9f7ebbc7223f40fbbf6ba3739d9385bfd59e3641
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517093
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641628}

We used to stop targeting once we find a region with ask flag set since
we start asynchronous targeting from root-view anyway; however, this
breaks drag-n-drop with nested OOPIFs as drag-n-drop still expects
synchronous targeting result. This CL changes that behaviour in
VizHitTestDrawQuad by returning the deepest OOPIF that contains that
event location from HitTestQuery. Note that the case where we want to
drag-n-drop to divs on top of OOPIFs is still broken.

Bug: 804633
Test: HitTestQueryTest.NestedOOPIFs
Change-Id: I96e59804648ff690a8b0c8350c224d8094de7fbf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521483Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Ria Jiang <riajiang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641627}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/f413181b..9157bb60

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ibbf2220e8729c4f26d174931eaf1ccb511c093ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527871Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#641626}