- 29 Oct, 2019 40 commits
-
-
Alexander Timin authored
Disable bfcache for web authenticator, since on DidFinishNavigation it would cleanup all the authentication data. This would be a problem if we restore the document from back-forward cache, so disabling it. Bug: 1001087 Change-Id: I928a89568fc804c6953099560b0d0cc2916d7ada Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825220 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#710317}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c3dc1efee35a..2c887d9d2df6 Created with: gclient setdep -r src-internal@2c887d9d2df6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I24de4dbd8a4eebcd710bb3564f9064d0d92b7b1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886353Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710316}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/da052ca534fe..0877b946198e git log da052ca534fe..0877b946198e --date=short --no-merges --format='%ad %ae %s' 2019-10-29 taylori@google.com Merge "Revert "perfetto-ui: Add beta search tooltip"" Created with: gclient setdep -r src/third_party/perfetto@0877b946198e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ib315fe6a52e51827e0963d7c5954cb0fe2d0e373 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887050Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710315}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2fa0ef25..588b98f2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iebd22fcd49e7c97738ec06b6b454196260fc0550 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886372Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710314}
-
Jacobo Aragunde Pérez authored
Highlights: * There are some other changes to the code logic, derived from the usage of PendingRemote in function arguments instead of InterfacePtr. * Shorthands provided by the new Mojo types allowed to simplify some implementations. * Moved initialization of affected members to their declarations, where possible, to comply with coding guidelines. Bug: 955171 Change-Id: Iebdc315dfcfebc671e0c91c9cf4f9fdd9fdf7b24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847309Reviewed-by:
Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Jacobo Aragunde Pérez <jaragunde@igalia.com> Cr-Commit-Position: refs/heads/master@{#710313}
-
Sigurdur Asgeirsson authored
Bug: 1017874 Change-Id: I4c48c36574840b10b8a6ac0df4ce3e2643f13cd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881722 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#710312}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ba97ef24. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org: external/wpt/css/css-writing-modes NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: Ia3051a442d52bca5f1c39e4a42f63c763bc535df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886371Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710311}
-
Austin Eng authored
The WebGL working group decided there is enough WebGL 1 support for instancing that it would be simpler to only expose the instanced version of the extension. This also rolls WebGL 2701c13..69e333c which includes the spec and conformance test changes. Bug: chromium:890539 Change-Id: Ib4dccf56f488cedf8161268ac3467d27c9b371c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881712Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#710310}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/3e83dd9cb99c..918853e6112f git log 3e83dd9cb99c..918853e6112f --date=short --no-merges --format='%ad %ae %s' 2019-10-29 perezju@chromium.org [Telemetry] Stop collecting histograms in results object Created with: gclient setdep -r src/third_party/catapult@918853e6112f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=zhanliang@google.com Bug: chromium:973837 Change-Id: Ia2725ab643b1ef6aad228e6bf375e1717e16ad04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886758Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/9c71e4936bc2..05c47926ff71 git log 9c71e4936bc2..05c47926ff71 --date=short --no-merges --format='%ad %ae %s' 2019-10-29 srte@webrtc.org Removes OnPacketAdded callback from feedback adapter. Created with: gclient setdep -r src/third_party/webrtc@05c47926ff71 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I40693deb83acf59549c2042fb06cbc1525b72829 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886755Reviewed-by:
-
Piotr Pawliczek authored
This patch adds new entries to chrome://device-log with information about: - the length of a resultant list of print servers calculated from policies - results of querying each print servers (number of printers or error) - the length of a final list of server printers. BUG=chromium:1018552 TEST=tested on nautilus Change-Id: I73516f73e3608e87b59d2a6980fbb52367d45ea4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882650Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Luum Habtemariam <luum@chromium.org> Commit-Queue: Piotr Pawliczek <pawliczek@chromium.org> Auto-Submit: Piotr Pawliczek <pawliczek@chromium.org> Cr-Commit-Position: refs/heads/master@{#710307}
-
Aaron Krajeski authored
This reverts commit 4d99f02a. Reason for revert: Started causing an infra failure on the msan_linux bot https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests/20157 Original change's description: > DL: Speculative fix for a leak in display_lock_fuzzer. > > This replaces a leaky new with a local static variable for the display > lock fuzzer environment. > > This is a speculative fix for the referenced bug. > > R=schenney@chromium.org > > Bug: 1013486 > Change-Id: I717437eac8d3d6f3d81515e2822209a676047698 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873916 > Commit-Queue: vmpstr <vmpstr@chromium.org> > Reviewed-by: Stephen Chenney <schenney@chromium.org> > Cr-Commit-Position: refs/heads/master@{#709212} TBR=vmpstr@chromium.org,schenney@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1013486 Change-Id: I61dc9ddbc3997c7452e1aef4496b21d6a21c85d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884592Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#710306}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b254eda6882d..da052ca534fe git log b254eda6882d..da052ca534fe --date=short --no-merges --format='%ad %ae %s' 2019-10-29 treehugger-gerrit@google.com Merge "tools(install-build-deps): support Python 3" 2019-10-29 treehugger-gerrit@google.com Merge "Re-enable HeapprofdJavaCtsTest." Created with: gclient setdep -r src/third_party/perfetto@da052ca534fe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ib58af4e054b56c05d25abf86e0ea109410e142ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886754Reviewed-by:
-
Peter E Conn authored
Trusted Web Activities have been launched since Chrome 72 and Permission Auto-Enrolment has been launched since Chrome 75. Bug: 1017688 Change-Id: I98420357ee6fee95ef78df85a55f48f3f897695d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878199 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#710304}
-
Amr Aboelkher authored
- Add override desc for DeviceLoginScreenDefaultScreenMagnifierType policy, which is being overridden by DeviceLoginScreenScreenMagnifierType - Fix descriptions of the accessibility features in login screen Bug: 552439 Change-Id: I2341a495a98d363016e3c51061bdc4a7dfc1d6fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886612Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Cr-Commit-Position: refs/heads/master@{#710303}
-
Carlos Caballero authored
We will not restore the is_running_insecure_content_allowed_ to true if we navigate back and the page is in the BackForwardCache, so do not store it if we were to loose that state. Some background on why we sometimes need to disable bfcache: https://docs.google.com/document/d/1NjZeusdS1kyEkZyfLggndU1A6qVt0Y1sa-LRUxnMoK8 Bug: 1001087 Change-Id: Ib482f42c1c945ae9f3a1c163f24d885910a25334 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821786 Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
-
Tanmoy Mollik authored
[Signin][Andriod] SetFirstSetupComplete in OnDestroy and implement tests for https://crrev.com/c/1744487 There was some new logic introduced to start sync in andoird in this cl https://crrev.com/c/1744487. This cl is for testing the logic. Also the call to setFirstSetupComplete in SyncAndServicesPreferences has been moved from onBackPressed to onDestroy as that provides more consistency when the fragment is destroyed. Bug: 1009965, 951330 Change-Id: I8f095490c81e145e4722e5f592922d735d5b9a9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855986Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#710301}
-
Aaron Krajeski authored
It is totally possible that we now fallback to kBitmap for especially large canvases. We've been save from this check because Skia usually fails as well, so ResourceProvider is nil. A fuzzer found a situation where Skia doesn't *quite* fail, but we're still falling back to kBitmap. Bug: 1013933 Change-Id: I5aa2f4bb0a85cbe1013edaba43183f1e866b00c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884651Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
-
Aaron Krajeski authored
When we create a resource provider we replay the old transform if needed. For deferred canvases, this is handled when flushing the recording, so with the old logic we could do it twice. Bug: 1014537 Change-Id: I76d628df621bca5a15f2a0ce51d1a6e663593d5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869513 Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
-
Keishi Hattori authored
The iterator seems to break while iterating MutationObserverInterestGroup::observers_. To figure out if this is conservative GC related, this CL adds a GC forbidden scope. Bug: 1003733 Change-Id: I6511e1fef12771c5ed2d6891e547807151e89aa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883460Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#710298}
-
Kamila Hasanbega authored
This reverts commit eb349bc7. Reason for revert: This cl is likely causing this https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel/4085 deterministic failure. Original change's description: > Update third_party/devtools-frontend 70f122128c..8bb84e5801 > > https://chromium.googlesource.com/devtools/devtools-frontend/+log/70f122128c..8bb84e5801 > > TBR=aerotwist@chromium.org > > Change-Id: Id2370e489efc7024b916b328f7e8f46e9f314bec > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886410 > Reviewed-by: Yang Guo <yangguo@chromium.org> > Commit-Queue: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#710264} TBR=yangguo@chromium.org,aerotwist@chromium.org Change-Id: I6af7c5ef3d7142a8e1bf9eb39fb5ae55a00410f2 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886334Reviewed-by:
Kamila Hasanbega <hkamila@chromium.org> Commit-Queue: Kamila Hasanbega <hkamila@chromium.org> Cr-Commit-Position: refs/heads/master@{#710297}
-
Juan Antonio Navarro Perez authored
Makes the list more discoverable and easy to find. Also take the chance to rename chromium.perf -> chrome.perf waterfall. Bug: 958739 Change-Id: Icb64f5290abb2bb31575956889faba23adf6c944 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886853 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Auto-Submit: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#710296}
-
Marina Sakai authored
This CL replaces the old GetSymbol, which uses void* as a key, with the new GetSymbol, which uses an instance of SymbolKey created in CL1877490 as a key, for KeepAlive properties. Bug: 715418 Change-Id: I9ce1c1b70f9a82da29e126b78e271827c79eea5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880409 Commit-Queue: Marina Sakai <marinasakai@google.com> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#710295}
-
Eric Willigers authored
We persist both the app's preference and the user's preference for the display mode. The user's preference (open in Browser tab or in Standalone window) was already being stored and synced. This field is renamed as user_display_mode. We now additionally store the app's preference, as display_mode. Note it is only stored locally, not synced. Not yet implemented: recording app's preferred display mode in the extensions-based implementation of bookmark apps - crbug.com/1014346 TBR=dominickn@chromium.org Bug: 1014347, 1013968 Change-Id: Icab31053e40761194f62e961e3317acea655bca6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882197 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#710294}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/e0d8f948954f..3e83dd9cb99c git log e0d8f948954f..3e83dd9cb99c --date=short --no-merges --format='%ad %ae %s' 2019-10-29 perezju@chromium.org [Telemetry] Remove benchmark.MAX_NUM_VALUES Created with: gclient setdep -r src/third_party/catapult@3e83dd9cb99c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=zhanliang@google.com Bug: chromium:1001038 Change-Id: I886b1ba7f27b542550a3f0cb22cd1cb5a09dadaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886752Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/dca568a3575f..dc883a948e71 git log dca568a3575f..dc883a948e71 --date=short --no-merges --format='%ad %ae %s' 2019-10-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src ec12de913124..42f885238114 (3 commits) Created with: gclient setdep -r src/third_party/angle@dc883a948e71 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Bug: chromium:None Change-Id: I6446141ec36771dcda4b6fb6444a3c6aa6070417 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886753Reviewed-by:
-
Mikhail Khokhlov authored
This is to comply with the latest changes in the LUCI protocol. Bug: 1018248 Change-Id: I2c71dfc1a15fd456f77b9a39e54eb8de1207c7c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884290Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#710291}
-
David Roger authored
The GCMS was ignoring some cookie change notifications, specifically the ones receieved while the GCMS is busy. This was orinally done to fix a bug in the AccountReconcilor (see https://crbug.com/516070). However this was arguably the wrong place to fix it, and also it made the GCMS unreliable. Later, the AccountReconcilor was fixed (https://codereview.chromium.org/1267843003), and thus this is no longer necessary. This CL restores the previous behavior, and is essentially a revert of https://codereview.chromium.org/1264143003/ To completely avoid reconcilor loops, we will do the following: - rate-limit the reconcilor (bug 1008435) - add a new histogram that give the detailed status of a reconcilor run. The buckets could be something like: * no-op * failure (ideally including the failure reason) * success (logout) * success (multilogin) * success (MergeSession) * success (MergeSession + logout) Bug: 923873 Change-Id: Ib82cb511ea328793f80293450d140a74a1de6415 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831863Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#710290}
-
Miyoung Shin authored
This CL converts ProvisionFetcher{Ptr, Request} in media and content to the new Mojo type. Bug: 955171 Change-Id: If6bf828080e81389209404050145849f6249f7c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882265 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:Frank Liberato <liberato@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#710289}
-
Robert Liao authored
BUG=5027 Change-Id: I0046e489dbf25a4954321eb3c01ec36b15392345 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885632 Auto-Submit: Robert Liao <robliao@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
-
Kamila Hasanbega authored
This reverts commit 77add479. Reason for revert: This cl introduces consistent test failures https://ci.chromium.org/p/chromium/builders/ci/Linux%20TSan%20Tests/46230 Original change's description: > [omnibox] improve on device head suggest incognito flags. > > 1. Allows to enable on device head suggest in incognito w/o enabling it > in non incognito first. > 2. Removes request delay in incognito since there is no server > suggestion which we need to cope with. > > Bug: 925072 > Change-Id: I344ecc2c620cb95c3b5f7c929cac0d9287b3c05b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881978 > Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> > Reviewed-by: Tommy Li <tommycli@chromium.org> > Commit-Queue: Ce Chen <cch@chromium.org> > Cr-Commit-Position: refs/heads/master@{#710127} TBR=tommycli@chromium.org,jdonnelly@chromium.org,cch@chromium.org Change-Id: I7feaf59d4f0c16afb89e6048e622e4c5e294afd5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 925072 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886333Reviewed-by:
-
Vasilii Sukhanov authored
The experiment was launched with the threshold '3'. Bug: 552010 Change-Id: I6bf72aa48715a15c021c907c1a6fd3f0de80a26d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880042Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#710286}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a0b89dfb..2fa0ef25 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6284c0440d24c119460b16547e27914b92d02b5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886790Reviewed-by:
-
Jan Wilken Dörrie authored
This change prepares //chrome/browser/ui/webui and //chrome/browser/chromeos for the upcoming switch of base::Value::GetList() from ListStorage& to base::span<base::Value>. It does so by both directly using list APIs exposed on base::Value and making use of base::span where apporopriate. TBR=poromov@chromium.org Bug: 646113 Change-Id: If286e21b71d5abc371d8d6936bca6c4cb9cbb0d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874205 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#710284}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/01a21f71f427..9c71e4936bc2 git log 01a21f71f427..9c71e4936bc2 --date=short --no-merges --format='%ad %ae %s' 2019-10-29 sprang@webrtc.org Remove redundant BitrateProber::OnIncomingPacket() call Created with: gclient setdep -r src/third_party/webrtc@9c71e4936bc2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I4f1636367c90829f013354c663a11b98044ff0a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886751Reviewed-by:
-
Kamila authored
Change-Id: Ib3249e012753027b1d8ea8024df6cee0e589d3c8 TBR: afakhry@chromium.org BUG: 1019080, 1018498 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886672 Commit-Queue: Kamila Hasanbega <hkamila@chromium.org> Reviewed-by:
-
Juan Antonio Navarro Perez authored
Same crash in prediction_metrics_handler.cc as other infinite scroll stories. NOTRY=true TBR=crouleau@chromium.org Bug: 1017661 Change-Id: I902abdf15002e3dcbf93faba0c9c511861724230 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886852Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1874c334. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" af56e43c "Refactor fetch-error.https.html" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I64d18427f5d7316f0ca60c374c12c4e637aa6a16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886370Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5a19effaca7e..b254eda6882d git log 5a19effaca7e..b254eda6882d --date=short --no-merges --format='%ad %ae %s' 2019-10-29 primiano@google.com Merge "UI: fix include path in heap_profile_flamegraph/common.ts" Created with: gclient setdep -r src/third_party/perfetto@b254eda6882d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I23b5e5b9587611095b7196e21595012ab508908d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886750Reviewed-by:
-
Juan Antonio Navarro Perez authored
Make it slightly easier to write integration tests for results processor involving artifacts. Also fix a bug where creating multiple artifacts of the same type (e.g. many histogram artifacts for different test runs) would write all of them to the same file name, causing them to get overwritten. Bug: 981349 Change-Id: I7eaa8793d09fe0afc869dd8154df628d9ece7774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880034 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#710278}
-
