GitLab

This CL uses ScopedBlockingCall to mark blocking calls in /chrome/browser/background/background_mode_manager_mac.mm.

This CL was created by replacing calls to AssertBlockingAllowed()
with instantiations of ScopedBlockingCall(MAY_BLOCK).
I kindly ask the reviewer to make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.
  - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See
    BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().

This CL was uploaded by git cl split.

R=avi@chromium.org

Bug: 874080
Change-Id: Ic807c6eb4e22dc7ebdd34e2240e1fe6484e44174
Reviewed-on: https://chromium-review.googlesource.com/1191232Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593676}

https://skia.googlesource.com/skia.git/+log/4fb073ac7328..9461dcf1306a


git log 4fb073ac7328..9461dcf1306a --date=short --no-merges --format='%ad %ae %s'
2018-09-24 michaelludwig@google.com Revert "Implement an explicit binary search-based analytic gradient colorizer"
2018-09-24 fmalita@chromium.org [skottie] Initial property setters
2018-09-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms b9dc92669da2..82ea7fbce65f (1 commits)
2018-09-24 fmalita@chromium.org UBSAN: Divide-by-zero in SkRRect::setRectXY
2018-09-24 halcanary@google.com SkPDF: simplify SkPDFDevice::drawPaint.
2018-09-24 jvanverth@google.com Make sure ReflexHash grid count is reasonable
2018-09-24 michaelludwig@google.com Implement an explicit binary search-based analytic gradient colorizer


Created with:
  gclient setdep -r src/third_party/skia@9461dcf1306a

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel

BUG=chromium:796479,chromium:729727,chromium:696603,chromium:543625,chromium:414254,chromium:888233,chromium:796479,chromium:729727,chromium:696603,chromium:543625,chromium:414254
TBR=bsalomon@chromium.org

Change-Id: I5c06466571c0dbc74c36d61f4a9c7a6552f75eee
Reviewed-on: https://chromium-review.googlesource.com/1240836Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#593675}

This is the last CL to remove SkColorSpaceXform call sites from
third_party/blink. This change also does some refactoring in
ImageBitmap unit tests, etc.

TBR=fserb@chromium.org

Bug: 774520
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I8279f1687ef096ae9aa2179c74d5d6cf2364ce9b
Reviewed-on: https://chromium-review.googlesource.com/1237140Reviewed-by: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593674}

 - Errors are handled as part of _htmlPreview.
 - image/svg is already handled as an image as part of PreviewFactory.createPreview.
 - Text types are already handled as source as part of PreviewFactory.createPreview (and with better defaults like auto-formatting).

The only branch in which case this was still hit is Other resource type with non-encoded content, but it's best not to use that as heuristic since backend might encode text content as well and vice versa, so it's better not to show any preview in that case at all. Note that user can still check raw Response tab if they wish.

Change-Id: Icb76f2d54641a73aeef62d3e1c98c731ee894ab5
Reviewed-on: https://chromium-review.googlesource.com/1216303Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Ingvar Stepanyan <ingvar@cloudflare.com>
Cr-Commit-Position: refs/heads/master@{#593673}

This migrates content::PepperNetworkMonitorHost from
NetworkChangeNotifier to NetworkConnectionTracker, which works with the
network service enabled.

Bug: 887046
Change-Id: I6fcd03fa664689cc6bcc16ff80b86fdba75d695d
Reviewed-on: https://chromium-review.googlesource.com/1236560
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593672}

Refactoring of the internal input events blocker in
TabletModeController.

The input events should only be blocked if 1) we're currently in tablet
mode or 2) we're currently in laptop mode but the lid is flipped over,
i.e., we are in laptop mode because of an attached external mouse.

Bug: 887042
Change-Id: I8be03c684265d79ccc3499362a7154eb44c4dec0
Reviewed-on: https://chromium-review.googlesource.com/1237407
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593671}

- Screen reader will read the app name when the chip is focused.
- Navigate chips using tab.
- Toggle app to install / not install with space or enter key.
- Screen reader will read the title of recommend-apps and app-dowloading
screens.

Bug: 885219
Change-Id: I5ad9f79b33ae8a55fe4f5240692261e346461a22
Reviewed-on: https://chromium-review.googlesource.com/1234237Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Yue Cen <rsgingerrs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593670}

Bug: 838910
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Id40fa8876356c3ecdac81999f1701bb0ef420393
Reviewed-on: https://chromium-review.googlesource.com/1234842Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Doug Turner <dougt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593669}

Changes visibility of JavaPoet in android deps to
allow for code generation support in annotation processors.

Change-Id: Ic84705a85504fd8e3e541cb0a2be524df2164ef0
Reviewed-on: https://chromium-review.googlesource.com/1239360Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Aiden Benner <abenner@google.com>
Cr-Commit-Position: refs/heads/master@{#593668}

This change Clang formats ARC's power bridge.

Bug: None
Test: Compile.
Change-Id: I9658ce6c8405b3ec1b21986c162aa836fc09b774
Reviewed-on: https://chromium-review.googlesource.com/1239694Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593667}

This patch aligns the checkboxes to the first text line and adds a
separator between the geo/accept languages and the rest of the list.

Bug: 887678
Change-Id: Icf0f20a2f550541cd940d134b752d0d5deee6f11
Reviewed-on: https://chromium-review.googlesource.com/1237178Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593666}

Currently the policy uses a image element's naturalWidth/naturalHeight
as the image's size, but this is incorrect for cases:
  1. intrinsicSize attribute overrides naturalWidth/naturalHeight;
  2. srcset w descriptor sizes will determine
     naturalWidth/naturalHeight;

So, instead, we should be using the actual size of the Image object.

Bug: 888578
Change-Id: I2abc9854ffd8c0d942651085d510885a82884ad8
Reviewed-on: https://chromium-review.googlesource.com/1240497Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Luna Lu <loonybear@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593665}

This comment should have been removed with code review 1211963
because the bug fixed there was precisely the change of color
depending on popup state.

Bug: 879935
Change-Id: Ie4dd596a96050759d45bd542a75ab06e066c3797
Reviewed-on: https://chromium-review.googlesource.com/1240203Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Orin Jaworski <orinj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593664}

A FrameCoordinationUnit is never removed from a ProcessCoordinationUnit
through this mojo method. What happens instead is that when a frame is
deleted, the corresponding FrameCoordinationUnitImpl is destroyed. In
its destructor, the FrameCoordinationUnitImpl remove itself from its
parent ProcessCoordinationUnitImpl without going through mojo.

Bug: 885293
Change-Id: Ief70ddd0b979ca97fe822a9405899cf3bdfc8aba
Reviewed-on: https://chromium-review.googlesource.com/1234896Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593663}

Cleanup TrayBubbleView's MouseWatcher comments.
Remove a TimeDelta that was being used incorrectly.
(controls the callback delay, not a mouse sampling rate)

Remove no-op delegate function overrides (default is no-op).
Remove a call to the no-op BubbleDialogDelegateView::OnGestureEvent.

Bug: None
Test: No tray bubble (volume/brightness) auto-close regressions.
Change-Id: I1bf3775b22a147f2d42557ff4a71dba153c5bb6c
Reviewed-on: https://chromium-review.googlesource.com/1241195Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593662}

Bug: 853824
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I6e52260c7966a59434176c20867a11b5505a1cde
Reviewed-on: https://chromium-review.googlesource.com/1240740Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593661}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8bdc1b8a0433..aaf2cc09c687


git log 8bdc1b8a0433..aaf2cc09c687 --date=short --no-merges --format='%ad %ae %s'
2018-09-24 sergiyb@chromium.org Implement --no-autocc flag for Gerrit


Created with:
  gclient setdep -r src/third_party/depot_tools@aaf2cc09c687

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:878303
TBR=agable@chromium.org

Change-Id: Iab04c0d298d064f57c569aadd622ea5a338637be
Reviewed-on: https://chromium-review.googlesource.com/1240834Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#593660}

For incognito window's the in-memory DB is seeded (read only) by the DB
of the original profile. This is achieved via raw pointer to the seed
DB and the invariant that the incognito profile is always outlived by
its ancestor profile. Unfortunately, this overlooked that the ancestor
profile may destroy the DB and make a new one when asked to clear the
DB history. This caused the seed pointer to be invalid.

This CL changes the VideoDecodePerfHistory to never destroy the DB.
The DB is now a const unique_ptr, passed in during construction.

This CL also changes how clearing history works. Before, we used the
Destroy() API of the underlying ProtoDatabase to delete all entries.
This left the DB broken until re-initialized, which presents a risk
whenever that DB is seeding an incognito profile. Going forward,
clearing the DB is achieved by querying for all the keys and then
removing them. This removes the need for re-initialization and allows
the seeded in-memory DB to carry on safely unaware.

Test: Updated unit tests. Also manual e2e testing.
Bug: 881059
Change-Id: I014d76d9e04b16574fd7eea08775b1388740dd8d
Reviewed-on: https://chromium-review.googlesource.com/1220392Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Chrome Cunningham <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593659}

Rename the minimum/target SDK version and manifest package name
variables in the WebView manifest to be consistent with the ones in the
Chrome manifest. Use the old names as a default value so as not to break
downstream until this is updated.

Change-Id: If55711db4540fc164ddd0f6bddcf30abd3da99a5
Reviewed-on: https://chromium-review.googlesource.com/1241014Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593658}

This will execute the uninstall operation via the UI and the callback
will be invoked upon completion.

BUG=chromium:849438
TEST=tast run vm.CrostiniFiles

Change-Id: I854b0563cea082a325c3c52a00e2c357cb62a295
Reviewed-on: https://chromium-review.googlesource.com/1237387
Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593657}

LayerTreeHostTestWillBeginImplFrameHasDidFinishImplFrame has been
reported as flaky on and off for a while now.

TBR=lijeffrey@chromium.org

Bug: chromium:842038, chromium:845381
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ie71c4716777812d6ebec67833d98da340962b699
Reviewed-on: https://chromium-review.googlesource.com/1241193Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593656}

The feature that allowed specifying an element id before the event name
in the listeners object is no longer supported in Polymer 2.

For example:

  listeners: {
    'id.eventName': 'onEventName_',
  }

Bug: 885294
Change-Id: Ieb468d10ebdc3ba436fdc38b8858b6a1b237e93f
Reviewed-on: https://chromium-review.googlesource.com/1237400Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593655}

This change adds a page describing the manifest file structure and
focuses on the options field that replaced "magic" service_manager
capabilities.

Bug: 866967
Change-Id: I4fbf53b8e3f821cb67c3133b21c8521a7536e429
Reviewed-on: https://chromium-review.googlesource.com/1227229Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593654}

Bug: 886860
Change-Id: I8c18e4e66bfbe1cbc8d56153bde889423fcf4554
Reviewed-on: https://chromium-review.googlesource.com/1234960Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593653}

This migrates extensions::NetworkingPrivateServiceClient from
NetworkChangeNotifier to NetworkConnectionTracker, which works with the
network service enabled.

Bug: 887043
Change-Id: I189fc631c5b4050d2e4bffab627754157e9ec20a
Reviewed-on: https://chromium-review.googlesource.com/1237382
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593652}

This reverts commit 1922e955.

Reason for revert: Causing bug 887424

Original change's description:
> Reland "Under refresh, use the same menu options for Windows/Linux as under Mac"
>
> This is a reland of 9c5131ad
>
> Cannot reproduce the flake. Relanding for more information.
>
> Original change's description:
> > Under refresh, use the same menu options for Windows/Linux as under Mac
> >
> > Use the BubbleBorder for the menus since the drop-shadow under Windows
> > doesn't track the shape of the menu. We also have much more control over
> > the shape and depth of the drop-shadow.
> >
> > Bug: 837782
> > Change-Id: I91b9340251c2cd0b60e3b3f66d450a4791113007
> > Reviewed-on: https://chromium-review.googlesource.com/1159532
> > Commit-Queue: Allen Bauer <kylixrd@chromium.org>
> > Reviewed-by: Evan Stade <estade@chromium.org>
> > Reviewed-by: Michael Wasserman <msw@chromium.org>
> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#590731}
>
> TBR=ellyjones@chromium.org
> TBR=msw@chromium.org
> TBR=estade@chromium.org
>
> Bug: 837782
> Change-Id: I80a07fb2d716c9372d18a8d48df3e7e00ff286ab
> Reviewed-on: https://chromium-review.googlesource.com/1229173
> Commit-Queue: Allen Bauer <kylixrd@chromium.org>
> Reviewed-by: Allen Bauer <kylixrd@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#592156}

TBR=ellyjones@chromium.org,msw@chromium.org,estade@chromium.org,kylixrd@chromium.org
NOTRY=true
NOPRESUBMIT=true

Bug: 837782
Change-Id: Ie834df815bd1fb1d0f49d7ddc84adecf75ea351e
Reviewed-on: https://chromium-review.googlesource.com/1240733
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593651}

There is no longer a need for AnimationWorkletProxyClient to be split
across core/ and modules/.

This patch combines the abstract interface and its single concrete impl into
a single class.

Other changes:
 - remove unnecessary include in ChromClient

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Icc49dc26de20b1059cb8be0aaa72fb39b87e2730
Reviewed-on: https://chromium-review.googlesource.com/1237147Reviewed-by: Sandra Sun <sunyunjia@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593650}

This reverts commit c551571f.

Reason for revert: Need to revert a dependent CL (https://chromium-review.googlesource.com/c/chromium/src/+/1229173), so reverting this to prevent merge conflicts

Original change's description:
> [GTK] Fix menu background color regression
>
> Regressed after 9c5131ad.  This caused the menu
> background to always render white even though the text colors would still be
> styled using the system theme.  This caused illegible text when the menu
> background was supposed to be dark.
>
> R=​pkasting
> TBR=sky
>
> Change-Id: I39b836e0941cbfc033515fe3891ecd42d89d73a4
> Reviewed-on: https://chromium-review.googlesource.com/1237519
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Reviewed-by: Peter Kasting <pkasting@chromium.org>
> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#593039}

TBR=sky@chromium.org,pkasting@chromium.org,thomasanderson@chromium.org
NOTRY=true
NOPRESUBMIT=true

Change-Id: If1fa983c97f0942cea3fccad14372ed1f5922080
Reviewed-on: https://chromium-review.googlesource.com/1240713
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593649}

https://chromium.googlesource.com/catapult.git/+log/f19e5d119588..e06567b30fdd


git log f19e5d119588..e06567b30fdd --date=short --no-merges --format='%ad %ae %s'
2018-09-24 jbudorick@chromium.org Add vpython to pinpoint tasks.


Created with:
  gclient setdep -r src/third_party/catapult@e06567b30fdd

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:777865,chromium:878777
TBR=sullivan@chromium.org

Change-Id: I2d23dfdac206d7c569bfbce4d72f05eebded15fd
Reviewed-on: https://chromium-review.googlesource.com/1240510Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#593648}

An oversight in https://chromium-review.googlesource.com/1240121

TBR=jochen@chromium.org,estark@chromium.org

Bug: 888470
Change-Id: I006c76c4084bc78d3f3b3c248da28c6e13b9cef3
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1241173Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593647}

https://chromium.googlesource.com/angle/angle.git/+log/f668a4b5fb72..5272a543705e


git log f668a4b5fb72..5272a543705e --date=short --no-merges --format='%ad %ae %s'
2018-09-24 jmadill@chromium.org Vulkan: Skip BufferDataTest.RepeatedDrawDynamicBug on Win/Intel.


Created with:
  gclient setdep -r src/third_party/angle@5272a543705e

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=syoussefi@chromium.org

Change-Id: I82e96e5128ef25473349f1f3a6757345e3400118
Reviewed-on: https://chromium-review.googlesource.com/1240499Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#593646}

Bug: 874146
Change-Id: I2582d5d87c3e8839bdbe1e7939cd656eb76bc4ac
Reviewed-on: https://chromium-review.googlesource.com/1237520
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593645}

If there are more than 1 keep alive frames received before getting
the ack on request, the second will be thought as a continuation
fragment and fail with "Malformed Frame Continuation Fragment".

Change-Id: I69fb5c024f14fe19bfc60da2a2392b663bdcea66
Bug: 880053
Reviewed-on: https://chromium-review.googlesource.com/1237267
Commit-Queue: Yuankai Yu <yyk@google.com>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593644}

[Also adds a datareduction/OWNERS file as well for team self-approving such changes]

There is a different code path that the overflow menu uses that
ensures a negative savings value is not shown using Math.max.
This change applies the same technique to the code path used
to calculate the saving for the displayed graph range.

Bug: 861936
Change-Id: I7cb09da1e451271c364e9055bcbd4ae544059e87
Reviewed-on: https://chromium-review.googlesource.com/1235318
Commit-Queue: Doug Arnett <dougarnett@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593643}

Make the element reference proto consistent with what the backend
expects.

R=rouslan@chromium.org, szermatt@chromium.org

Bug: 806868
Change-Id: I2125add6b931d2ccce5fe2dc1986709a087237ee
Reviewed-on: https://chromium-review.googlesource.com/1240297Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Mathias Carlen <mcarlen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593642}

Normally the recommend-apps screen is only shown to first-time
Chromebook users. Adding this switch to skip the check so that testers
can reuse the same accounts for testing.

Bug: 835029
Change-Id: I61b1bef40e4b64f22f3890c64e24d3887a86b977
Reviewed-on: https://chromium-review.googlesource.com/1239249Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Yue Cen <rsgingerrs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593641}

TBR=fserb@chromium.org

Bug: 886670
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: If88bef42580f522accd6505076d75e3471a2e025
Reviewed-on: https://chromium-review.googlesource.com/1240519
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Reviewed-by: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593640}

Remove references to shadow stacks from the profiling documentation and
from the shutdown signal handler.
The only remaining references are in the old tcmalloc implementation, which
will eventually be removed.

BUG=724399,b:70905156

Change-Id: I2b1a854dc2eb081ec9bfb5401fc2c5ebd1860c4e
Reviewed-on: https://chromium-review.googlesource.com/1239442Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Alexander Potapenko <glider@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Gabriel Marin <gmx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593639}

This reverts commit 95797d79.

Reason for revert: will limit the workaround to AMD gpus only, so we could merge back to Beta affecting less machines.

Original change's description:
> Disable DirectComposition on everywhere except for Intel GPUs
> 
> We only need it if hardware overlays can be used.
> 
> BUG=800950
> TEST=bots
> R=​sunnyps@chromium.org
> 
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Change-Id: Id1a00799ee77f942183b55327ba21c7af65165b5
> Reviewed-on: https://chromium-review.googlesource.com/1232153
> Commit-Queue: Zhenyao Mo <zmo@chromium.org>
> Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#592267}

TBR=zmo@chromium.org,sunnyps@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 800950
Change-Id: I8bfe7d77c40a6754577719f853a3df4baf508d09
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1240509Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593638}

This CL uses ScopedBlockingCall to mark blocking calls in /chrome/browser/extensions/api/storage.

This CL was created by replacing calls to AssertBlockingAllowed()
with instantiations of ScopedBlockingCall(MAY_BLOCK).
I kindly ask the reviewer to make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.
  - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See
    BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().

This CL was uploaded by git cl split.

R=rdevlin.cronin@chromium.org

Bug: 874080
Change-Id: I4de4dd7b51419500492ecce093c5e82cd9fe6b35
Reviewed-on: https://chromium-review.googlesource.com/1191809Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593637}