- 23 May, 2018 40 commits
-
-
Yutaka Hirano authored
This is just a renaming change caused by a finch config settings change. Bug: 794073 Change-Id: I40f18880c76956a1e485ed96274e669723222d5f Reviewed-on: https://chromium-review.googlesource.com/1067526Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#560924}
-
S. Ganesh authored
* Service module and COM registration implementation. * Various entry points and build files. Design document: Design document link will be added to the linked bug soon. Bug: 833687 Change-Id: I195a42786e60b2565ba49ba4dd87e5ae4288af7f Reviewed-on: https://chromium-review.googlesource.com/1014723 Commit-Queue: S. Ganesh <ganesh@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#560923}
-
csharrison authored
This code used to bind a callback which did this implicity. Bug: 845104 Change-Id: I75db3232daaf6d20b5caa01361913663bf582d56 Reviewed-on: https://chromium-review.googlesource.com/1067358Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#560922}
-
John Z Wu authored
This will help with writing tests for CWVAutofillDataManager. Change-Id: Ib548b0a5df28ca74d3e43bc6f9d30cd192f44570 Reviewed-on: https://chromium-review.googlesource.com/1068024 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#560921}
-
Sandra Sun authored
After enabling smooth-scroll-for-find on Android, tapping "find" wouldn't scroll the text into view. To fix the regression, we would temporarily disable the smooth behavior, and re-enable it after we have solved the problem. Bug: 839795 Change-Id: I7733a269b5ee830df4352f10cdb9b036f4c779f2 Reviewed-on: https://chromium-review.googlesource.com/1069112Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Sandra Sun <sunyunjia@chromium.org> Cr-Commit-Position: refs/heads/master@{#560920}
-
Tetsui Ohkubo authored
In NotificationViewMD, the inline reply field will be shown when a configured button in a notification is clicked. The intended behavior is to focus on inline reply after the button is clicked, but RequestFocus was called before SetVisible(true), which is no-op. You can test the feature by enabling chrome://flags/#enable-experimental-web-platform-features then https://tests.peter.sh/notification-generator/ -> Actions -> "One action (type text)" -> Display the notification. TEST=NotificationViewMDTest.TestInlineReply BUG=845189 Change-Id: I1f5d80ad1ab20b7061621fdc6ab8745c7c4ecfea Reviewed-on: https://chromium-review.googlesource.com/1068529 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#560919}
-
Xiaocheng Hu authored
This patch adds an NG version of BidiAdjustment::AdjustForHitTest, and calls it at the end of NG hit testing (PositionForPoint), so that the output is also bidi-adjusted as its legacy counterpart. Bug: 811502 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I0415e9b89e518b88718670a0dc8f065df242e1fb Reviewed-on: https://chromium-review.googlesource.com/1064480 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#560918}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/12f7d6baa725..40e4ebef5551 $ git log 12f7d6baa..40e4ebef5 --date=short --no-merges --format='%ad %ae %s' 2018-05-22 dtu [pinpoint] Remove `auto_explore` in favor of `comparison_mode`. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ief80ee40ba36e05db4a62bfb9b7aadfd4d8f6513 Reviewed-on: https://chromium-review.googlesource.com/1069836Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#560917}
-
Nikunj Bhagat authored
Add FormSignature to DeveloperEngagement The FormSignature and FieldSignature added here is similar to the signature added to Autofill_SuggestionShown UKM. Bug: 842370 Change-Id: I2b0cc9a387f0fd28d7b7eab3c345a581af055400 Reviewed-on: https://chromium-review.googlesource.com/1067678Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Nik Bhagat <nikunjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#560916}
-
Ken Rockot authored
Reland of r560866, which was missing an include for Fuchsia in some configs. Adds mojo/public/cpp/platform to the public library. This includes a new PlatformHandle type, a thin C++ abstraction for platform-specific scoped handle values. This is a precursor to moving platform channel C++ types out of the EDK and into the public library, and ultimately introducing a public C++ invitation API to replace the EDK invitation API. TBR=jcivelli@chromium.org Bug: 844764 Change-Id: I86a04e27afd1c7ec7a3c1d419f10239d4b78c850 Reviewed-on: https://chromium-review.googlesource.com/1069839Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#560915}
-
Matt Reynolds authored
Before gamepad was partially servicified, gamepad struct definitions resided in WebKit. These definitions must be identical for all readers and writers to the shared memory buffer for consistency. Since pepper may not depend on WebKit, the structs were duplicated in the pepper gamepad client. Now these structs have been moved out of WebKit and can be shared with other components by depending on the target //device/gamepad/public/cpp:shared_with_blink. This CL removes the duplicate pepper definitions and switches all usages to the //device definitions. BUG=694998 Change-Id: I4cf596f5cff18f6dc8945a422a3cc9f70711c10c Reviewed-on: https://chromium-review.googlesource.com/1062600Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#560914}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=amineer@chromium.org Change-Id: I90298cf52d077cb75dd0167f318307940af7e3a8 Reviewed-on: https://chromium-review.googlesource.com/1069180Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#560913}
-
Sean Kau authored
Previous behavior was to accept the uri and CUPS would reject it when we try to use it. Received a report of this happening in TT. This will help to surface the root cause for users. Bug: 844521 Change-Id: I77a20232a7317ee40c7c3c0fa534d73d9aad2b4b Reviewed-on: https://chromium-review.googlesource.com/1066392 Commit-Queue: Sean Kau <skau@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#560912}
-
Malay Keshav authored
Currently users have the choice to change the ui scale on their internal displays via the display resolution slider in settings. Upon updating to a version of chrome that has display zoom enabled by default, the users will experience a sudden change in their logical resolutions on first boot. This is bad user experience. It may also lead to kiosk stations that were using ui scale to break. This patch prevents this by converting the ui scale to the corresponding display zoom scale and also ensures that the current zoom scale is present in the list of available zoom levels. NOTE - The display zoom scale set after this conversion may not be in the list of available zoom levels for that display. This means that if a users tries to change the zoom level(either from the settings page or via the keyboard shortcut), they may not be able to come back to this zoom level again. Bug: 839458 Change-Id: I4d5bd761506c6ec14dc92b3d3a120b87e02e2cb7 Component: Display Manager, display zoom, ui scale Reviewed-on: https://chromium-review.googlesource.com/1056192Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#560911}
-
Fergal Daly authored
Move all the of the methods that are purely building up the PendingInvalidationsMaps into a new PendingNodeInvalidations class. Fold RecursionData into StyleInvalidator and stop passing it as as a parameter for lots of methods. Snapshot 11 is a pure copy of style_invalidator.{cc,h} -> pending_node_invalidations.{cc,h} to make it easy to see the diffs when you use it as the base for diffing. There were a couple of places where I had to add {} on an if that was a pre-existing style violation but I was touching the code. Change-Id: I4e8858c286fd2adf9291a695452e6ad3a6549b6f Reviewed-on: https://chromium-review.googlesource.com/1061834 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#560910}
-
Mounir Lamouri authored
This CL removes ContentRendererClient::OverrideCreateAudioDevice because it breaks Web Audio tests that rely on rendering. Indeed, the fake audio path used for layout tests wouldn't notify the audio destination node that playback happened which means that calls to `resume()` would never be resolved as they are dependant on the audio context to start rendering. This code was added a 5 years ago and the CL does not explain why nor link to a bug: https://chromium.googlesource.com/chromium/src/+/f065ec59efdaa8e00940381a99b93ef7960ba0f5%5E%21/ Bug: None Change-Id: Ifc6854f97bdaf580b24cfc28460153b243188ac2 Reviewed-on: https://chromium-review.googlesource.com/1067100 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#560909}
-
csharrison authored
Bug: None Change-Id: I2dff91f3b397855cfbc6ef066158252423d5a946 Reviewed-on: https://chromium-review.googlesource.com/1066489Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#560908}
-
James Cook authored
It implements the "Show Taps" UI feature and is turned on via the flag --show-taps, so use a name with "taps" in it. Bug: 840380 Test: compiles, ash_unittests Change-Id: I84784115cb7ba26bfcac8c28db293df62b95ebf5 Reviewed-on: https://chromium-review.googlesource.com/1067851Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#560907}
-
Justin Cohen authored
Initial step in getting configs prepared for iOS12. Bug: 843244 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I6b4e788d56117ef4ec2f3bbb7b887a6374d7b28f Reviewed-on: https://chromium-review.googlesource.com/1069032Reviewed-by:
Shenghua Zhang <shenghuazhang@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#560906}
-
Derek Cheng authored
This patch introduces message formats for launching sessions on a Cast device and corresponding CastMessageHandler API. It also adds APIs for opening a virtual connection for a (sourceId,destId) pair, and forwarding an app message from Cast SDK client to the device. Also organized cast_message_utils to map message types to strings. Bug: 809249 Change-Id: I63d4f658e53579d6a761a8857508534ad993ebc4 Reviewed-on: https://chromium-review.googlesource.com/1060087 Commit-Queue: Derek Cheng <imcheng@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#560905}
-
Christopher Cameron authored
This state can be forwarded to the RenderWidgetHostViewCocoa instead of being queried using a synchronous callback. Bug: 821651 Change-Id: I163946352f2f3f5d7288134dd365504d4bd04912 Reviewed-on: https://chromium-review.googlesource.com/1064980Reviewed-by:
Sidney San Martín <sdy@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#560904}
-
Sidney San Martín authored
They served their purpose well. Change-Id: I8e93e25f8ab08ed2b2e3832f1f578a40561b2a22 Reviewed-on: https://chromium-review.googlesource.com/1067649 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#560903}
-
Alan Cutter authored
The origin string is displayed in the title bar when PWA windows are opened as a security precaution. This CL ensures it is also spoken by ChromeVox for accessibility. Bug: 839177 Change-Id: I622c45517ecddd2d85f680ae0fcae225e5be3ed9 Reviewed-on: https://chromium-review.googlesource.com/1068891 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#560902}
-
Bugs Nash authored
Make update_flaky_expectations.py script delete lines that do not fail in the specified way when they don't include any passing results. Currently expectations that do not fail in the specified way are removed only when they include a passing result, e.g. the expectation bug(test) fast/test.html [ Crash Pass ] will be removed if the results on the builders show only Passes and Timeouts because there is no Crash result. This patch changes the script to also delete the line if the builders show only Timeouts (and no Passes). This is in the spirit of the test's description "Scans the TestExpectations file and uses results from actual builder bots runs to remove tests that are marked as flaky but don't fail in the specified way." Bug: 730704 Change-Id: Ib70b5eb43fb58471ef28c346c9a0f7c334283a13 Reviewed-on: https://chromium-review.googlesource.com/1067525 Commit-Queue: Bugs Nash <bugsnash@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#560901}
-
David Trainor authored
In an attempt to make the UX more responsive, we had previously added code to update the notification update quickly in response to a user gesture. However if our persistence layers get out of sync, this can lead to a sticky notification that can't be removed/can start a foreground service in the background. This change makes the optimization still happen, but removes the check to disable state updating until the backend gets back to the front end. This way the front end's persistence layer will be updated even if the backend has no knowledge of the item and does not reply. BUG=845713 Change-Id: Idcfb6a4068cb3c09536464ed944d45f7a9530762 Reviewed-on: https://chromium-review.googlesource.com/1069771Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#560900}
-
Sergey Ulanov authored
Lack of namespace support in FIDL was breaking some libraries when using them in chromium due to name conflicts. fidlgen now supports namespaces. That change requires some updates in GN files because fidlgen now assumes a different location for generated headers (<namespace>/<name>/cpp/fidl.h instead of fuchsia/cpp/<name>.h). 1. Updated FIDL GN templates to support FIDL files with namespaces. 2. Updated existing FIDL deps in //base and //net. 3. Removed fuchsia/cpp from global include_rules. 4. Added SDK packages for Scenic in //third_party/fuchsia-sdk/BUILD.gn 5. Marked base::ServicesDirectory::GetDefault() static (was omitted initially by mistake). Bug: 831384 Change-Id: Iabae4887733b4a78e3de6781069cf029bdcc8c92 Reviewed-on: https://chromium-review.googlesource.com/1068203 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#560899}
-
Alexis Hetu authored
About a dozen tests were flaky on MacOS during the last 3 days after the switch to SwiftShader. These tests are now marked as flaky here, to avoid failures caused by these flaky tests for the time being, until they are fixed. Bug: chromium:726075 Change-Id: I54b1420cd11423ae3f738cf080cad2cd73b70c56 Reviewed-on: https://chromium-review.googlesource.com/1069266 Commit-Queue: Alexis Hétu <sugoi@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#560898}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/44d7d7d6..3792c386 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I1318b3d54065d04800a5e05162be70cd42d65ce1 Reviewed-on: https://chromium-review.googlesource.com/1067798Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#560897}
-
Erik Luo authored
Screenshot: https://imgur.com/a/lhjvp3U Bug: 827860 Change-Id: Ib42840136d4705bf90433e4ee308cf40417a610f Reviewed-on: https://chromium-review.googlesource.com/1068245Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#560896}
-
John Z Wu authored
This will allow us to be more DRY when creating and using test data. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I63841779af2b88e09a7e589faa13edc688b04835 Reviewed-on: https://chromium-review.googlesource.com/1067981 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#560895}
-
Devlin Cronin authored
The listeners that the extensions page adds for the developerPrivate API have expensive events associated with them. When the page isn't open, we should ensure that we are not listening for them. This CL adds a test to verify that. Bug: None Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ibba3692e2ccda2af2e29efab66873a2722d5a61b Reviewed-on: https://chromium-review.googlesource.com/1069311Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#560894}
-
danakj authored
As stated on the tin. R=piman@chromium.org Bug: 722935 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ia5f9da37b4f9bec72c49900019de3bbdd11e04f0 Reviewed-on: https://chromium-review.googlesource.com/1066510Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#560893}
-
Christopher Cameron authored
This was caused by a cast to RenderWidgetHostViewMac, which is inappropriate in some tests. Cast only to RenderWidgetHostViewBase instead. TBR=sdy Bug: 845688 Change-Id: Id08887aeba5f18209a9b570d7a36548bdf59faa7 Reviewed-on: https://chromium-review.googlesource.com/1069750Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Sidney San Martín <sdy@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#560892}
-
chromeos-commit-bot@chromium.org authored
BUG=762641 TBR=xiaoyinh@google.com Change-Id: I06761b98f30403cee94c0b77cf610db02600174e Reviewed-on: https://chromium-review.googlesource.com/1069849Reviewed-by:
ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#560891}
-
Kent Tamura authored
* name_style_converter.py: to_upper_camel_case() supports cases where the first token is a lowercased-acronym. Add 'DNS', 'XSS', and 'FE' to SPECIAL_TOKENS. * json5_generator.py, and make_runtime_features.py: Move 'tokenized_name' initialization from make_runtime_features.py to json5_generator.py because it is used in many places. * make_element_factory.py, make_element_type_helpers.py, make_internal_settings.py, make_settings.py, internal_settings_generated.cc.tmpl, internal_settings_generated.h.tmpl, internal_settings_generated.idl.tmpl, settings_macros.h.tmpl: Use 'tokenized_name.to_upper_camel_case()' instead of upper_first filter. * name_utilities.py: Remove upper_first() and ACRONYMS. Bug: 843927 Change-Id: Icb297c5cb820a7e98e09a69f63a27a8b89f7c836 Reviewed-on: https://chromium-review.googlesource.com/1068772Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#560890}
-
Siddhartha S authored
This reverts commit 9191004f. Reason for revert: The failure after the revert was a different failure. Sorry for the reland. Original change's description: > Reland "Use thresholds based on RAM size for OOM intervention" > > This reverts commit 50257b9e. > > Reason for revert: This was not the cause of failure, see > https://crbug.com/845763 > > Original change's description: > > Revert "Use thresholds based on RAM size for OOM intervention" > > > > This reverts commit 0c2124b3. > > > > Reason for revert: Speculatively reverting to see if it fixes webgl conformance test timeouts > > Bug: 845411 > > > > Original change's description: > > > Use thresholds based on RAM size for OOM intervention > > > > > > This CL does not change behavior of existing experiment on 512 devices. > > > 1. Remove low-end device checks while enabling intervention. This can be > > > filtered in Finch config. > > > 2. Set threshold based on percentage of RAM instead of absolute number. > > > 3. Disable intervention if device has more than 512MB RAM and threshold > > > was set to absolute number. > > > > > > BUG=843419 > > > > > > > > > Change-Id: Ib40a038d9d2f111a514b3f41ce7f32a3ea3a156d > > > Reviewed-on: https://chromium-review.googlesource.com/1066804 > > > Commit-Queue: Siddhartha S <ssid@chromium.org> > > > Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#560430} > > > > TBR=bashi@chromium.org,ssid@chromium.org > > > > Change-Id: I4b50e522dcc6c91542927a9e769e5eee24f486a5 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 843419 > > Reviewed-on: https://chromium-review.googlesource.com/1069567 > > Reviewed-by: enne <enne@chromium.org> > > Commit-Queue: enne <enne@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#560761} > > TBR=bashi@chromium.org,enne@chromium.org,ssid@chromium.org > > Change-Id: I4d0a08cd44772dc690ac1d93b1d92b4934ed0373 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 845411, 843419 > Reviewed-on: https://chromium-review.googlesource.com/1069888 > Reviewed-by: Siddhartha S <ssid@chromium.org> > Commit-Queue: Siddhartha S <ssid@chromium.org> > Cr-Commit-Position: refs/heads/master@{#560882} TBR=bashi@chromium.org,enne@chromium.org,ssid@chromium.org Change-Id: Ib8841dddaa2a167e674c997ec1577036df26e8cb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 845411, 843419 Reviewed-on: https://chromium-review.googlesource.com/1069876Reviewed-by:
Siddhartha S <ssid@chromium.org> Commit-Queue: Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#560889}
-
Yutaka Hirano authored
net::WebSocketChannel and various related classes use std::string to represent request headers. This CL changes them to HttpRequestHeaders. Bug: 721400 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Id730779b36f3a319a61b44516bd3e8389ebdfc23 Reviewed-on: https://chromium-review.googlesource.com/1065713Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#560888}
-
Xiyuan Xia authored
- Add IMERegistrarImpl and IMEDriverBridge to WindowService to provide IMERegistrar and IMEDriver mojo interface there; - Chrome always call IMEDriver::Register to register its IME with WindowService; Bug: 837710 Change-Id: I39e91dda3643707346f58914022ed8beab75c636 Reviewed-on: https://chromium-review.googlesource.com/1069672Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#560887}
-
John Z Wu authored
This improves the API to be more natural to use. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia6d4feabaf72a23b4550f9b7f7008314955a4d7f Reviewed-on: https://chromium-review.googlesource.com/1068117 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#560886}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/7f472cd8abe4..86688dea3b0d $ git log 7f472cd8a..86688dea3 --date=short --no-merges --format='%ad %ae %s' 2018-05-22 thestig Make friend RetainPtr<T> statements consistently public. 2018-05-22 thestig Fix nits in fxjs. 2018-05-22 thestig Simplify CPDF_ShadingPattern::Validate(). Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I448003d54d9cdf3c6861696a1ff2796b6adfb76d Reviewed-on: https://chromium-review.googlesource.com/1069785 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#560885}
-