- 22 Feb, 2020 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3654b68b32c3..855f2ed75a9c Created with: gclient setdep -r src-internal@855f2ed75a9c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I8255f118c08f3d56d5f0767a0e55be5262f103c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069379Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743806}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/c12493ff69e2..07e1a0a67aee git log c12493ff69e2..07e1a0a67aee --date=short --first-parent --format='%ad %ae %s' 2020-02-22 johnkslang@users.noreply.github.com Merge pull request #2090 from amdrexu/bugfix Created with: gclient setdep -r src/third_party/glslang/src@07e1a0a67aee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com,cwallez@google.com Change-Id: Ib118e804f34527371ec43963ae9f58c43ca49258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069381Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743805}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/96c6ec923081..3654b68b32c3 Created with: gclient setdep -r src-internal@3654b68b32c3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I28990dc03a0737b0d11df5e03b0160cccdd3a3a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069374Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743804}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1a85d581c934..ecd8762e1f86 git log 1a85d581c934..ecd8762e1f86 --date=short --first-parent --format='%ad %ae %s' 2020-02-22 kjlubick@google.com [canvaskit] Support children shaders into runtime shaders Created with: gclient setdep -r src/third_party/skia@ecd8762e1f86 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: I1fcb36e30a32860fbeb87464e0814e1e3ebcb381 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069372Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743803}
-
Liquan (Max) Gu authored
Before change: The PH UI crashes when users click the security icon. After change: The crash no longer happen. Change: * The CookieControlsBridge() call is moved after PageInfoControllerJni's init, so that the WebContents has initiated TabSpecificContentSettings. * Add a test for the crash path. Bug: 1053859 Change-Id: Ia30f35be32c76997ecf21418c9e8bb7e8247370e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062987Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#743802}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/adf008a9f500..93f917a48395 git log adf008a9f500..93f917a48395 --date=short --first-parent --format='%ad %ae %s' 2020-02-22 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@93f917a48395 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic59db69418f271fd11b284b56bf8882dbffc3e25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069369Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743801}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/92726d8bdba2..96c6ec923081 Created with: gclient setdep -r src-internal@96c6ec923081 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ib1f3ecf5f078ff29d9c845d7c31855a8b62bc3b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069361Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743800}
-
Kazuki Takise authored
We currently save snap fraction in CompleteDrag, but if the PIP window is flinged, the bounds of the PIP window is not the flinged bounds at this point as it just creates a bounds event and sends the client a bounds change request. So we need to pass the flinged bounds to SaveSnapFraction. Before introducing snap fraction, we used restore bounds and saved the flinged bounds properly, so this CL basically does the same thing with snap fraction. BUG=b:149875362 TEST=Manually confirmed flinging PIP and rotating the screen works. Change-Id: I7b109eaf7786aee5d3c70da167c27ff5c1a69e90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065510 Commit-Queue: Kazuki Takise <takise@chromium.org> Auto-Submit: Kazuki Takise <takise@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#743799}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I76ad8e78f7f8c514918fd64a2edd2aed702dbc8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069200Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743798}
-
chromium-autoroll authored
Roll airmont AFDO profile from 82-4044.5-1581936665-benchmark-82.0.4058.0-r1 to 82-4044.5-1581936665-benchmark-82.0.4065.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ic96b5ed2f1a1882690ff056a562df99c6a0502b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069131Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743797}
-
chromium-autoroll authored
Roll broadwell AFDO profile from 81-4025.0-1580122052-benchmark-81.0.4044.0-r1 to 82-4028.0-1581935713-benchmark-82.0.4065.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: If4656962938496bd7d7f3ef49392649a6307c596 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069130Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743796}
-
chromium-autoroll authored
Roll silvermont AFDO profile from 81-4028.0-1580121249-benchmark-81.0.4044.0-r1 to 82-4044.15-1581938780-benchmark-82.0.4065.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I56b4e16cbee197fd0b62fd123d307aee88a07d45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069128Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743795}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/90f726dbcf19..92726d8bdba2 Created with: gclient setdep -r src-internal@92726d8bdba2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I1cab53e643cacc7eea217de5b2e0f1d6c96dd319 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069244Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743794}
-
Anton Bikineev authored
Bug: 1029379 Change-Id: Ide991117023557000a40144741a1db3552b668df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066767 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#743793}
-
Xianzhu Wang authored
Previously by default we didn't dump non-drawable layers, causing the dumped layer information lacked hit testable layers. Dumping hit-testable layers will help us verify CompositeAfterPaint test results when we fix crbug.com/937573 (CAP hit-testing for blank backgrounds). Bug: 937573 Change-Id: I5adb1849606895aea7333481ac9a5fd863c218bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067555 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#743792}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7f19b54d3263..90f726dbcf19 Created with: gclient setdep -r src-internal@90f726dbcf19 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I054da062b2878c64a0a600cceca7cd95828fd078 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067756Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743791}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ie6fa4b9297a0d6426fb487c99b2f5808d62ee219 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069240Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743790}
-
Jiewei Qian authored
Prior to this CL, WebLaunchServiceImpl is behind a FileHandlingEnabled check on the document. However, at the time of this check, the actual document is not loaded (we get a blank document without origin trial tokens). So FileHandlingEnabled check always return false, unless we turn on runtime flags. This check cause the problem: when a PWA with File Handling origin trial is launched as a file handler, the app will not receive the launch files. This CL fixes the problem by always bind WebLaunchServiceImpl, this is okay because the DOM (JavaScript) side is still behind a origin trial check, we will not be exposing extra APIs to webpages. Fixed: 1053819 Bug: 1045297 Change-Id: I19966d26afe97dfd3115f142343c6eaacdfe0eab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063196 Commit-Queue: Jiewei Qian <qjw@chromium.org> Reviewed-by:
Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#743789}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/113e5df9..07cf1f5a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id69fd5bf75b1cfb0c087c58c4b81b1796ea7d23f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069164Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743788}
-
Chromium WPT Sync authored
Using wpt-import in Chromium fe1df04b. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" 76ee218c "Split html/.../query-encoding/ tests" 1ce9585a "Clear-Site-Data must uncontrol affected service worker clients" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools hbos@chromium.org, hta@chromium.org: external/wpt/webrtc NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I5f3cb8bb498e9cda27ff497752f0658291a01dd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069162Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743787}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/165da89015c7..adf008a9f500 git log 165da89015c7..adf008a9f500 --date=short --first-parent --format='%ad %ae %s' 2020-02-22 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@adf008a9f500 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6894313889454cdc161af8c8443745d6ecb18b7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067755Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743786}
-
Findit authored
This reverts commit eed7024d. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 743767 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZWVkNzAyNGRlMmQ5MDNkYzU0ZjAwMzgwYzMyMWQwMTA0YmU2NmUyNAw Sample Failed Build: https://ci.chromium.org/b/8887789665458415472 Sample Failed Step: browser_tests Sample Flaky Test: LoadingPredictorBrowserTestWithOptimizationGuide.UsesPredictionsFromOptimizationGuideIfAvailable Original change's description: > Add support for loading predictor to use hints from optimization guide > > Will add metrics in a subsequent CL. This shouldn't affect any current > metrics since the support is all behind a feature flag. > > Bug: 1050101 > Change-Id: If6f98dbae86bb5842803cdb3c1b052d99711e62f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067241 > Commit-Queue: Sophie Chang <sophiechang@chromium.org> > Reviewed-by: Ryan Sturm <ryansturm@chromium.org> > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#743767} Change-Id: Ie30a3a73e89bace0febe11c558d7be4c83501936 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1050101 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069258 Cr-Commit-Position: refs/heads/master@{#743785}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/eacec98a3499..a741abb98362 git log eacec98a3499..a741abb98362 --date=short --first-parent --format='%ad %ae %s' 2020-02-21 jmadill@chromium.org Vulkan: Rename CommandGraphResource to Resource. 2020-02-21 spang@chromium.org Reformat GN files Created with: gclient setdep -r src/third_party/angle@a741abb98362 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: I108cb534975d8c13a271bac30f30eeb074b04ab4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067747Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743784}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4ebfcd52ceee..7f19b54d3263 Created with: gclient setdep -r src-internal@7f19b54d3263 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I5e5f155e5b91702fcf6ef0489b67457e50bec17f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067751Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743783}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/88fd132a05e8..165da89015c7 git log 88fd132a05e8..165da89015c7 --date=short --first-parent --format='%ad %ae %s' 2020-02-22 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@165da89015c7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9a6119241875e909bae019e6d26661e55e199ab6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067752Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743782}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4db453d6..113e5df9 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic05aacb55288fde57a0baa716026ef0976a379bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069160Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743781}
-
Tom Anderson authored
This CL makes AutofillPopupFooterView respond to theme changes. Previously, the separator color was only initialized on creation, when the NativeTheme has not yet been set. R=pkasting Change-Id: I9bb8a511beca58e4d6f1d40a1f832bce922b6431 Bug: 914974 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063892 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#743780}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: I3b6e9988007429a5d708678312c89822348b005e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068311Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743779}
-
Xiaohan Wang authored
Use logging::SystemErrorCodeToString to pretty print failed HRESULTs. For example, for E_FAIL in Foo function, the message looks like: Foo: failed with "Unspecified error (0x80004005)" Change-Id: I28426b0447f8cdd0ea21768c93208cf637992a4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068921Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#743778}
-
Xiaohan Wang authored
This is a one-off namespace that's only used in mf_helpers.h. Remove it to be consistent with other media code. Change-Id: I08478a3bf644fbbf695b5fb0b6d6e92a5c4fb29f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068306 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#743777}
-
Xiaohan Wang authored
Instead, use media/base/win/mf_helpers.h. Change-Id: Ia3c018928e6c1aab0357ace07c87dcc8d30a2126 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068719 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#743776}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: If33551dc0da7dceed44d99b9ead7f2e353c507e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067753Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743775}
-
Kazuki Takise authored
This CL handles another edge case for the snap fraction logic. The issue is, at the end of drag-moving PIP, if the resting position is not along any of the edges of the movement area because, for example, the PIP window is snapped to some system UI (hotseat, system tray, etc). This CL ensures to forcefully adjust the PIP bounds to the movement area without considering other obstacles. BUG=b:149889040 TEST=Drag move the PIP window along some system UI and confirmed TEST=the PIP window didn't jump to the left screen edge. Change-Id: I67457d0708d79c6ce6c9a243eb11e3f90965468b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065695 Commit-Queue: Kazuki Takise <takise@chromium.org> Auto-Submit: Kazuki Takise <takise@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Cr-Commit-Position: refs/heads/master@{#743774}
-
Kazuki Takise authored
BUG=b:149889710 TEST=Manually confirmed swipe to dismiss works Change-Id: I62cbe45ca855a0a485fad4c1dedeb893865c92fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064232 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Cr-Commit-Position: refs/heads/master@{#743773}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0e6832de5af7..1a85d581c934 git log 0e6832de5af7..1a85d581c934 --date=short --first-parent --format='%ad %ae %s' 2020-02-22 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-02-22 nifong@google.com Expose 4x4 matrices on canvas in a way similar to SimpleMatrix, add example. Created with: gclient setdep -r src/third_party/skia@1a85d581c934 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: I5a5cef43b49c9ba216b3c4478a8f0fa3febb314e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067746Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743772}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c588f36ff15c..5ca404665a4c git log c588f36ff15c..5ca404665a4c --date=short --first-parent --format='%ad %ae %s' 2020-02-22 chriswailes@google.com Merge "Added additional metrics to android_startup" Created with: gclient setdep -r src/third_party/perfetto@5ca404665a4c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I962bc7b0b9474bacd57430c9863b58ecfac7c0b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068976Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743771}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/de47ef6c..4db453d6 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I17902f4b9b1e4b7968e2da64a63f78736d1906c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067979Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743770}
-
Sadrul Habib Chowdhury authored
We already have checks in place to prevent underflows. So remove the explicit check that was introduced to check other underflows, but it is tripping tests for valid sequences. So remove the DCHECK. We also report the length of the sequences in UMA, and according to the data, the lengths are: 50%ile: < 20 99%ile: < 500 99.5%ile: < 800 So underflows are not a concern at the moment. BUG=1052790 Change-Id: Ia87b3fae331b01c483468887894f16364938a624 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068894 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#743769}
-
Theresa Wellington authored
Set Android.MultiWindowMode.Active to expire never since this is a topline metric for monitoring multi-window mode usage on Chrome for Android. BUG=1052895 Change-Id: I8d83c27687f4a153e10b1fdc1a1f8a3b8a9c78a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064628Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#743768}
-
Sophie Chang authored
Will add metrics in a subsequent CL. This shouldn't affect any current metrics since the support is all behind a feature flag. Bug: 1050101 Change-Id: If6f98dbae86bb5842803cdb3c1b052d99711e62f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067241 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#743767}
-