- 13 Jul, 2017 40 commits
-
-
Mike Reed authored
Bug: Change-Id: I8cef060ee121c90f5ad405dd55a5ddb79676d9f2 Reviewed-on: https://chromium-review.googlesource.com/569990Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@chromium.org> Cr-Commit-Position: refs/heads/master@{#486424}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 142a048e. Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/310 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: glebl@chromium.org: external/wpt/css/CSS2/positioning hta@chromium.org: external/wpt/webrtc igrigorik@chromium.org, panicker@chromium.org: external/wpt/performance-timeline kojii@chromium.org: external/wpt/css/CSS2 TBR: qyearsley@chromium.org No-Export: true Change-Id: I652ded994e7de04204d163a5ee2ebd77bf25dc6c Reviewed-on: https://chromium-review.googlesource.com/569984 Commit-Queue: Blink W3C Test Autoroller <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#486423}
-
Bernhard Bauer authored
Without the invalidate() call, the view would only update 400ms later, when the progress indicator becomes visible. Bug: 741800 Change-Id: I949e423187b2b0e68eb807c44a8d3b78043ed016 Reviewed-on: https://chromium-review.googlesource.com/570037Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#486422}
-
kylechar authored
Remove the deprecated function that uses default InitParams. Add the params in the remaining callsites and set |single_process| correctly for tests. The only exception is in aura::Env::Init() where we don't know if it is a test. Bug: 620934,700142 Change-Id: I5e0d61578a423dd42eca38d21ccd1568b9ce5a8b Reviewed-on: https://chromium-review.googlesource.com/568361Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#486421}
-
Helen Yang authored
The CL [ios showcase] Integrated TextBadgeView with Showcase (patchset #4 id:80001 of https://codereview.chromium.org/2967113003/) broke ios_showcase_egtests suite for iPad. The revert can be found here: https://codereview.chromium.org/2978533002/. This CL is a reland of the first, and fixes the egtest issue by ensuring that EarlGrey only selects sufficiently visible elements. Bug: 740133 Change-Id: Ie30b78e85d965bd2ff48d27fef4eb7f824d56d98 Reviewed-on: https://chromium-review.googlesource.com/567129 Commit-Queue: Helen Yang <helenlyang@google.com> Reviewed-by:
Ed Chin <edchin@chromium.org> Reviewed-by:
Gregory Chatzinoff <gchatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#486420}
-
galinap authored
The thumbnail returned from a ThumbnailProvider may have one dimension larger than the requested thumbnail size. Therefore, the assertion in onThumbnailRetreived() should be using the smaller of the two sides to check that the condition is met, instead of using its height arbitrarily. Bug: 715477 Change-Id: I6e60c41dad1014508343f2338ad81140d577f08b Reviewed-on: https://chromium-review.googlesource.com/541323Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Nicolas Dossou-Gbété <dgn@chromium.org> Commit-Queue: Galia Peycheva <galinap@google.com> Cr-Commit-Position: refs/heads/master@{#486419}
-
Mike Dougherty authored
This reverts commit 944975a0. Reason for revert: These newly added tests are not passing in all configurations. For example: https://build.chromium.org/p/chromium.fyi/builders/EarlGreyiOS/builds/29628 Original change's description: > [Payment Request] Adds tests for accessibility on main pages of Payment Request > > The added HTML file and JS file have been downloaded from here: > > https://rsolomakhin.github.io/pr/multi/ > > And thus do not need to be thoroughly reviewed. The only changes made to these > files are as follows > 1) In the html file an "id" attribute is added to the "buy" button, the 2016 > copyright is changed to 2017, and the stylesheet and favicon links are removed. > 2) In the js file "requestPayerEmail," "requestPayerPhone," and "requestPayerName" > is added to options on line 106, the JSLint directives are removed from the top of > the file, and the long line on line 137 was changed into two lines. > > Bug: 734571 > Change-Id: Ib27f0e9398d3ce8922018138ad98e0e93aa6e15b > Reviewed-on: https://chromium-review.googlesource.com/567215 > Commit-Queue: Randall Raymond <rayraymond@google.com> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Reviewed-by: Louis Romero <lpromero@chromium.org> > Reviewed-by: mahmadi <mahmadi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#486391} TBR=eugenebut@chromium.org,lpromero@chromium.org,rayraymond@google.com,mahmadi@chromium.org Change-Id: Id007c92d6e9f72de546bec6672ca23aed1247904 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 734571 Reviewed-on: https://chromium-review.googlesource.com/570202Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#486418}
-
Anna Maria authored
[Local File Casting] Fixing issue where Cast File would be highlighted in menu even if file selection fails Bug: 721802 Change-Id: I39f9426667ec79b62010de1c93d9cbfbb4b50c91 Reviewed-on: https://chromium-review.googlesource.com/567246 Commit-Queue: Anna Maria <paezagon@chromium.org> Reviewed-by:
Jennifer Apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#486417}
-
Wez authored
This reverts commit 52118eee. Reason for revert: This prevents net_unittests from building, due to a dependency on these APIs in sql/connection.cc. We should consider stubbing them out to return sensible values, e.g. GetPosixPermissions returning ugo+rwx and SetPosixPermissions returning not-implemented error. Original change's description: > Remove unsupported perm, symlink calls for Fuchsia. > > Remove unsupported perm, symlink calls for Fuchsia. > Fuchsia's POSIX support does not extend to file permission bit or > symbolic links. This CL conditionally removes the relevant calls from > file_util and disables affected tests under Fuchsia builds. > > R: thakis@chromium.org > Bug: 706592 > Change-Id: Id6b68fd9a440f37debe50feb7ce3f457bbee3e4f > Reviewed-on: https://chromium-review.googlesource.com/562901 > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Kevin Marshall <kmarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#486236} TBR=thakis@chromium.org,kmarshall@chromium.org Change-Id: I1ce22ac0d60db6891c8264e269247deec0f29f32 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 706592 Reviewed-on: https://chromium-review.googlesource.com/570518Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#486416}
-
Emily Stark authored
This reverts commit f51e5d49. Reason for revert: This test fails on official builds because the field trial testing config doesn't apply. I will explicitly enable the Finch feature in the test and reland. Original change's description: > Add browser test and testing config for dynamic Expect-CT reporting > > This CL adds a browser test to check that the ChromeExpectCTReporter is properly > created and set up to receive reports, particularly for dynamic Expect-CT > violations. It also enables the dynamic Expect-CT feature on the waterfall. > > BUG=679012,642517 > > Change-Id: I3ea01207ea5852b9bd0bbb1d90799ee4555c854e > Reviewed-on: https://chromium-review.googlesource.com/566572 > Reviewed-by: Jesse Doherty <jwd@chromium.org> > Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> > Commit-Queue: Emily Stark <estark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#486158} TBR=jwd@chromium.org,meacer@chromium.org,estark@chromium.org Change-Id: I60d13cfa015707d535e0afb86cf10d74ecb35b79 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 679012, 642517 Reviewed-on: https://chromium-review.googlesource.com/570383Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#486415}
-
Nico Weber authored
This reverts commit 52118eee. Reason for revert: Breaks build: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.fyi%2FFuchsia%2F6583%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout Original change's description: > Remove unsupported perm, symlink calls for Fuchsia. > > Remove unsupported perm, symlink calls for Fuchsia. > Fuchsia's POSIX support does not extend to file permission bit or > symbolic links. This CL conditionally removes the relevant calls from > file_util and disables affected tests under Fuchsia builds. > > R: thakis@chromium.org > Bug: 706592 > Change-Id: Id6b68fd9a440f37debe50feb7ce3f457bbee3e4f > Reviewed-on: https://chromium-review.googlesource.com/562901 > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Kevin Marshall <kmarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#486236} TBR=thakis@chromium.org,kmarshall@chromium.org Change-Id: Icdd32651551e1a77adf9322fb531d4af69b56b38 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 706592 Reviewed-on: https://chromium-review.googlesource.com/570499Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#486414}
-
Geoff Lang authored
https://chromium.googlesource.com/angle/angle.git/+log/70c95fa..3ec7568 BUG=:angleproject:2101,740426 TBR=cwallez@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I302d09829846c705e5e337ff071098fc91bc96e5 Reviewed-on: https://chromium-review.googlesource.com/570379Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#486413}
-
Reza.Zakerinasab authored
This CL adds color settings to ImageData and ImageBitmap serialization code. Bug: 670703, 671356, 735976 Change-Id: I854723eb8fa563bdd8755a002f182092b3f903b3 Reviewed-on: https://chromium-review.googlesource.com/552822 Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#486412}
-
Mike Dougherty authored
Bug: 739359 Change-Id: I9c720471e7a4214fb30e93eefc8ae84503c7aa5b Reviewed-on: https://chromium-review.googlesource.com/559980Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#486411}
-
Aleks Totic authored
Bug: 635619 Change-Id: I57ce8f3a225d09fed054ffa102968c86d83c08f4 Reviewed-on: https://chromium-review.googlesource.com/568715 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#486410}
-
Mike Dougherty authored
Reland of https://chromium-review.googlesource.com/c/556394 which was reverted due to failure of the analyze step. The analyze step failed locally with the input file as described in #c0 of crbug.com/739469. After modifications to manage.py and gn_isolate_map.pyl, the analyze step passes successfully. The configuration also moved to screen_size_dependent_tests.json. Bug: 738092 Change-Id: I29b96e57ab193c2dd7045f91199a5f87f2621e2f Reviewed-on: https://chromium-review.googlesource.com/559945Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#486409}
-
Ian Vollick authored
Previously, we'd done our texture updates in UiElement::OnBeginFrame. This virtual function was also responsible for doing texture update throttling. It turns out that neither of these are good things to do. Throttling turns out to be unnecessary and OnBeginFrame is the wrong time in the frame lifecycle to update our textures as input processing has not yet happened. This CL introduces PrepareToDraw which happens just before rendering the elements and is the correct time to update textures to ensure we never draw a dirty element. Bug: None Change-Id: Ic099a9b64d656f584e7d12783338e6552d082d21 Reviewed-on: https://chromium-review.googlesource.com/569991Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#486408}
-
Miriam Gershenson authored
I'm not sure if this will fix the flake, since I can't repro locally, but it seems plausible. BUG=740207 Change-Id: Icd423f4221b460bedc31299ec8a69d002d3a9db1 Reviewed-on: https://chromium-review.googlesource.com/570358Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Miriam Gershenson <mgersh@chromium.org> Cr-Commit-Position: refs/heads/master@{#486407}
-
Alex Clarke authored
Bug: Change-Id: Ice4fb3a54005fa18568ae0be94cfa2b58750e775 Reviewed-on: https://chromium-review.googlesource.com/570166Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#486406}
-
Mounir Lamouri authored
This is also doing a couple of other cleanups. The main reason to do this is to simplify the implementation of the CTR for media controls. Bug: None Change-Id: I74670719ca576228a0bdca2ca28a809a6237bca4 Reviewed-on: https://chromium-review.googlesource.com/567157Reviewed-by:
Jennifer Apacible <apacible@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#486405}
-
Max Morin authored
Currently, the origin for the device request is looked up for every equest. However, we don't actually need it for the default device, so we defer looking up the origin to AudioOutputAuthorizationHandler. When using the default device, this removes hops the the UI thread completely. For nondefault devices, looking up the origin is consolidated with checking permissions, removing one thread hop. Note that this change changes the behaviour of the code when using AudioRendererHost, as it is currently using the origin passed over IPC. For ease of reviewing, I produced a diagram showing the flow of a call through AudioOutputAuthorizationHandler: https://docs.google.com/drawings/d/1S-eCMTqq4dzAXMVAkCrt4sJcc3rprphLQpFKNfsqGkE/edit BUG=425368 Change-Id: I4533e12e22b67e21a1e12f5c7036881b4d48fd9f Reviewed-on: https://chromium-review.googlesource.com/567006 Commit-Queue: Max Morin <maxmorin@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#486404}
-
Dan Zhang authored
There are no flags to be updated. Deprecate FLAGS_quic_reloadable_flag_quic_bbr_slow_recent_delivery in the disabled state. Merge internal change: 161298821 https://chromium-review.googlesource.com/c/567479/1 Deprecate FLAGS_quic_reloadable_flag_quic_bbr_ack_aggregation_bytes. Merge internal change: 161235354 https://chromium-review.googlesource.com/c/567335/1 Add explicit #include for waitable_event.h. Merge internal change: 161231994 https://chromium-review.googlesource.com/c/567330/1 Remove a redundant QUIC_FLAG_COUNT for FLAGS_quic_reloadable_flag_quic_enable_pcc. n/a (flag metadata) Merge internal change: 161228561 https://chromium-review.googlesource.com/c/567398/1 When enabled, adds up to 1.5x the previously measured ack aggregation in bytes to the CWND, but reduces that amount by 1/2 the bytes acked since the queue was drained. Protected by FLAGS_quic_reloadable_flag_quic_bbr_ack_aggregation_bytes3. Merge internal change: 161123535 https://chromium-review.googlesource.com/c/567268/1 deprecate FLAGS_quic_reloadable_flag_quic_bbr_fix_conservation2 Merge internal change: 161114930 https://chromium-review.googlesource.com/c/567321/2 Disable support for the packets-based QUIC congestion control algorithms now that they're basically unused. Protected by FLAGS_quic_reloadable_flag_disable_packets_based_cc Merge internal change: 161038619 https://chromium-review.googlesource.com/c/565441/1 Disable QUIC v36 as it's no longer being used. Protected by FLAGS_quic_reloadable_flag_quic_disable_version_36 Merge internal change: 160986423 https://chromium-review.googlesource.com/c/565640/1 Replace //net/quic/... uses of std::unordered_{map,set} with QuicUnordered{Map,Set}. No behavior change. Merge internal change: 160957726 https://chromium-review.googlesource.com/c/565639/2 Add QuicUnorderedMap and QuicUnorderedSet types to QUIC platform API. Add new type aliases QuicUnordered{Map,Set}. No behavior change. Merge internal change: 160942739 https://chromium-review.googlesource.com/c/565541/1 In QUIC, wrap pacing sender around PCC sender. Merge internal change: 160688357 https://chromium-review.googlesource.com/c/565301/1 Bug: Change-Id: I9caa01ee5cf8db011031320c0fedda0ae6955ca7 Reviewed-on: https://chromium-review.googlesource.com/568802Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Dan Zhang <danzh@chromium.org> Cr-Commit-Position: refs/heads/master@{#486403}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/dac0038997b8..6daeed6d7311 $ git log dac003899..6daeed6d7 --date=short --no-merges --format='%ad %ae %s' 2017-07-13 adithyas Remove Blink_ prefix from counters 2017-07-13 xunjieli [wpr-go] Use nil req.Body as appropriate for outgoing requests in http.Transport.RoundTrip() Created with: roll-dep src/third_party/catapult BUG=724543 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I5323b8aee971a46a37e81103ce6dfa76d41efa6e Reviewed-on: https://chromium-review.googlesource.com/570267 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#486402}
-
kylechar authored
On Mac there is a special task runner that runs when the main task runner is blocked on resize. The main task runner blocks until a CompositorFrame arrives, and we need HostFrameSinkManager and FrameSinkManagerImpl to continue processing messages during this time. The original CL http://crrev.com/c/563860 conflicted with http://crrev.com/c/562216 which moved the MessageLoop out of HostFrameSinkManagerTest. Get the TaskRunner from helper function instead of from MessageLoop directly. Bug: 657959 Change-Id: I9488d5ca38827e9ba72431c144f9a8ea69f7b66c TBR: piman@chromium.org,fsamuel@chromium.org Reviewed-on: https://chromium-review.googlesource.com/568999 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#486401}
-
Michael van Ouwerkerk authored
https://screenshot.googleplex.com/hPzcX8ian2N Bug: 739664 Change-Id: I03bd2aeff34c7f9172042524c1a2d3d60897cd25 Reviewed-on: https://chromium-review.googlesource.com/568030 Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#486400}
-
Peter K. Lee authored
Button titles coming in from XIB needs to have both Normal and Highlighted states set in code. Otherwise, the default non-translated strings in the XIB file is displayed during Highlighted state. Also done some refactoring to reduce verbosity. Bug: 741944 Change-Id: I4eb45deabd75d695f665565deb5ab6370097e0e1 Reviewed-on: https://chromium-review.googlesource.com/569339 Commit-Queue: Peter Lee <pkl@chromium.org> Reviewed-by:
Jean-François Geyelin <jif@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#486399}
-
Roman Sorokin authored
Chromad: Refresh the Kerberos ticket-granting-ticket for Active Directory enrolled devices on the lock screen Bug: 676337 Change-Id: I3ceebfcb25d961fa2d25c96d843028a54c6dec05 Reviewed-on: https://chromium-review.googlesource.com/516990 Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#486398}
-
zpeng authored
Revert of Deduplicate Monochrome locale .paks (patchset #4 id:180001 of https://codereview.chromium.org/2933343002/ ) Reason for revert: Chrome is now missing 5 locale strings. The reason is that these strings are believed to be in WebView locales because they're whitelisted, but since WebView uses multiple whitelists to pack its locale strings, these strings are actually not contained by WebView Original issue's description: > Deduplicate Monochrome locale .paks > > This CL removes WebView strings from Chrome locale .paks in Monochrome > using a generated resource whitelist. While WebView's locale resource > logic remains the same, Chrome in Monochrome now loads a secondary > locale pack file as a fallback when a string cannot be found in the > primary locale pack file. > > This CL reduces binary size by over 400KB. > > BUG=724110 > > Review-Url: https://codereview.chromium.org/2933343002 > Cr-Commit-Position: refs/heads/master@{#485635} > Committed: https://chromium.googlesource.com/chromium/src/+/08ba6b7c7e7edb3f7c8851eb7ddc1d2ea64497e6 TBR=agrieve@chromium.org,dpranke@chromium.org,thestig@chromium.org,sadrul@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=724110, 741798 Review-Url: https://codereview.chromium.org/2980773002 Cr-Commit-Position: refs/heads/master@{#486397}
-
chrisha authored
This defines the format in which whitelist/blacklist information will be distributed. BUG=690166 Review-Url: https://codereview.chromium.org/2965063003 Cr-Commit-Position: refs/heads/master@{#486396}
-
Ken MacKay authored
We reference AudioDecoderConfig from mojom files within chromecast code; those mojom files declare things in the chromecast.<etc>.mojom module, so the generated code is put within the chromecast:: namespace. Since there is a chromecast::media:: namespace, if we don't fully qualify 'media::AudioDecoderConfig', then files that include the generated mojom.h (that also include chromecast/media/ headers) will fail to build because the compiler tries to lookup AudioDecoderConfig in the chromecast: :media:: namespace and can't find it. Change-Id: I30cdb1e46e2d08976789a4383a84708ce645c61c Reviewed-on: https://chromium-review.googlesource.com/569490Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#486395}
-
Ramin Halavati authored
A typo is corrected in network traffic annotation of: rlz/lib/financial_ping.cc Bug: 656607 Change-Id: Ic707d088f0a4a30568ccd722e821105d2cfaf536 Reviewed-on: https://chromium-review.googlesource.com/565262Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#486394}
-
lanwei authored
We want to add a flag and implement updating hover effect when a layout is changed behind this flag. Bug=488886 Review-Url: https://codereview.chromium.org/2956023004 Cr-Commit-Position: refs/heads/master@{#486393}
-
vakh authored
Google CLs: http://cl/137190961, http://cl/137192202 BUG=543161 Review-Url: https://codereview.chromium.org/2450963002 Cr-Commit-Position: refs/heads/master@{#486392}
-
Randall Raymond authored
The added HTML file and JS file have been downloaded from here: https://rsolomakhin.github.io/pr/multi/ And thus do not need to be thoroughly reviewed. The only changes made to these files are as follows 1) In the html file an "id" attribute is added to the "buy" button, the 2016 copyright is changed to 2017, and the stylesheet and favicon links are removed. 2) In the js file "requestPayerEmail," "requestPayerPhone," and "requestPayerName" is added to options on line 106, the JSLint directives are removed from the top of the file, and the long line on line 137 was changed into two lines. Bug: 734571 Change-Id: Ib27f0e9398d3ce8922018138ad98e0e93aa6e15b Reviewed-on: https://chromium-review.googlesource.com/567215 Commit-Queue: Randall Raymond <rayraymond@google.com> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Louis Romero <lpromero@chromium.org> Reviewed-by:
mahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#486391}
-
gambard authored
Bug: 742349 Change-Id: I35c8b668a9fecdcc84d9e9fbd8e7cbb4057968b9 Reviewed-on: https://chromium-review.googlesource.com/570244Reviewed-by:
Jean-François Geyelin <jif@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#486390}
-
Michael Thiessen authored
Updating VR Support Level takes anywhere from 3-10ms on Pixel phones. In most cases we can skip this work. Bug: 741823 Change-Id: I8747fb19aea00444ceef1fb245f869b022a67e61 Reviewed-on: https://chromium-review.googlesource.com/568811Reviewed-by:
Biao She <bshe@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#486389}
-
Boris Sazonov authored
This CL adds a user action that is recorded whenever a dialog is shown in response to Google Play services recoverable error (usually this dialog requests an update). Bug: 739917 Change-Id: I5077a123080c59a054abe32cd232ab2ab490093a Reviewed-on: https://chromium-review.googlesource.com/568483Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#486388}
-
Quinten Yearsley authored
Change-Id: I4cdaa39a0832ad368d282967cc7375756a06238c Reviewed-on: https://chromium-review.googlesource.com/569065Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#486387}
-
Alexander Timin authored
R=eseckler@chromium.org BUG=615047 Change-Id: I27cca41d2ea79b07f34d48c1bc1091cfd6caa9d9 Reviewed-on: https://chromium-review.googlesource.com/570242Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#486386}
-
gambard authored
The fake omnibox displayed on the NTP is slightly missaligned with the real omnibox. This CL makes then aligned by increasing the height of the fake omnibox image by one pixel and moving the shadow below it by one pixel. The transparent pixels around the image have been removed. Bug: 742312 Change-Id: I99406a9d012a06f500b5f20675de0b75cd440a1a Reviewed-on: https://chromium-review.googlesource.com/569968Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#486385}
-